From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 14/21] drm/i915: Only apply one barrier after a breadcrumb interrupt is posted Date: Mon, 6 Jun 2016 16:34:27 +0100 Message-ID: <57559803.40208@linux.intel.com> References: <1464970133-29859-1-git-send-email-chris@chris-wilson.co.uk> <1464970133-29859-15-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id C43786E576 for ; Mon, 6 Jun 2016 15:34:28 +0000 (UTC) In-Reply-To: <1464970133-29859-15-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAzLzA2LzE2IDE3OjA4LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gSWYgd2UgZmxhZyB0aGUg c2Vxbm8gYXMgcG90ZW50aWFsbHkgc3RhbGUgdXBvbiByZWNlaXZpbmcgYW4gaW50ZXJydXB0LAo+ IHdlIGNhbiB1c2UgdGhhdCBpbmZvcm1hdGlvbiB0byByZWR1Y2UgdGhlIGZyZXF1ZW5jeSB0aGF0 IHdlIGFwcGx5IHRoZQo+IGhlYXZ5d2VpZ2h0IGNvaGVyZW50IHNlcW5vIHJlYWQgKGkuZS4gaWYg d2Ugd2FrZSB1cCBhIGNoYWluIG9mIHdhaXRlcnMpLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMg V2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oICAgICAgICAgIHwgMTUgKysrKysrKysrKysrKystCj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jICAgICAgICAgIHwgIDEgKwo+ICAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYyB8IDE2ICsrKysrKysrKystLS0tLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCAgfCAgMSArCj4gICA0IGZp bGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmgKPiBpbmRleCA0ZGRiOWZmMzE5Y2IuLmE3MWQwODE5OWQ1NyAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0zOTM1LDcgKzM5MzUsMjAgQEAgc3RhdGljIGlu bGluZSBib29sIF9faTkxNV9yZXF1ZXN0X2lycV9jb21wbGV0ZShzdHJ1Y3QgZHJtX2k5MTVfZ2Vt X3JlcXVlc3QgKnJlcSkKPiAgIAkgKiBidXQgaXQgaXMgZWFzaWVyIGFuZCBzYWZlciB0byBkbyBp dCBldmVyeSB0aW1lIHRoZSB3YWl0ZXIKPiAgIAkgKiBpcyB3b2tlbi4KPiAgIAkgKi8KPiAtCWlm IChlbmdpbmUtPmlycV9zZXFub19iYXJyaWVyKSB7Cj4gKwlpZiAoZW5naW5lLT5pcnFfc2Vxbm9f YmFycmllciAmJiBSRUFEX09OQ0UoZW5naW5lLT5pcnFfcG9zdGVkKSkgewo+ICsJCS8qIFRoZSBv cmRlcmluZyBvZiBpcnFfcG9zdGVkIHZlcnN1cyBhcHBseWluZyB0aGUgYmFycmllcgo+ICsJCSAq IGlzIGNydWNpYWwuIFRoZSBjbGVhcmluZyBvZiB0aGUgY3VycmVudCBpcnFfcG9zdGVkIG11c3QK PiArCQkgKiBiZSB2aXNpYmxlIGJlZm9yZSB3ZSBwZXJmb3JtIHRoZSBiYXJyaWVyIG9wZXJhdGlv biwKPiArCQkgKiBzdWNoIHRoYXQgaWYgYSBzdWJzZXF1ZW50IGludGVycnVwdCBhcnJpdmVzLCBp cnFfcG9zdGVkCj4gKwkJICogaXMgcmVhc3NlcnRlZCBhbmQgb3VyIHRhc2sgcmV3b2tlbiAod2hp Y2ggY2F1c2VzIHVzIHRvCj4gKwkJICogZG8gYW5vdGhlciBfX2k5MTVfcmVxdWVzdF9pcnFfY29t cGxldGUoKSBpbW1lZGlhdGVseQo+ICsJCSAqIGFuZCByZWFwcGx5IHRoZSBiYXJyaWVyKS4gQ29u dmVyc2VseSwgaWYgdGhlIGNsZWFyCj4gKwkJICogb2NjdXJzIGFmdGVyIHRoZSBiYXJyaWVyLCB0 aGVuIGFuIGludGVycnVwdCB0aGF0IGFycml2ZWQKPiArCQkgKiB3aGlsc3Qgd2Ugd2FpdGVkIG9u IHRoZSBiYXJyaWVyIHdvdWxkIG5vdCB0cmlnZ2VyIGEKPiArCQkgKiBiYXJyaWVyIG9uIHRoZSBu ZXh0IHBhc3MsIGFuZCB0aGUgcmVhZCBtYXkgbm90IHNlZSB0aGUKPiArCQkgKiBzZXFubyB1cGRh dGUuCj4gKwkJICovCj4gKwkJV1JJVEVfT05DRShlbmdpbmUtPmlycV9wb3N0ZWQsIGZhbHNlKTsK CldoeSBpcyB0aGlzIG5vdCBzbXBfc3RvcmVfbWIgPwoKPiAgIAkJZW5naW5lLT5pcnFfc2Vxbm9f YmFycmllcihlbmdpbmUpOwo+ICAgCQlpZiAoaTkxNV9nZW1fcmVxdWVzdF9jb21wbGV0ZWQocmVx KSkKPiAgIAkJCXJldHVybiB0cnVlOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+IGluZGV4IGMx NGViNTdiNTgwNy4uMTRiM2Q2NWJiNjA0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfaXJxLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4g QEAgLTk3Niw2ICs5NzYsNyBAQCBzdGF0aWMgdm9pZCBpcm9ubGFrZV9ycHNfY2hhbmdlX2lycV9o YW5kbGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPgo+ICAgc3RhdGljIHZv aWQgbm90aWZ5X3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgewo+ICsJ c21wX3N0b3JlX21iKGVuZ2luZS0+aXJxX3Bvc3RlZCwgdHJ1ZSk7Cj4gICAJaWYgKGludGVsX2Vu Z2luZV93YWtldXAoZW5naW5lKSkgewo+ICAgCQl0cmFjZV9pOTE1X2dlbV9yZXF1ZXN0X25vdGlm eShlbmdpbmUpOwo+ICAgCQllbmdpbmUtPnVzZXJfaW50ZXJydXB0cysrOwo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYwo+IGluZGV4IDQ0MzQ2ZGUzOTc5NC4uMGY1ZmUx MTRjMjA0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1 bWJzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jCj4g QEAgLTQzLDEyICs0MywxOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9icmVhZGNydW1ic19mYWtlX2ly cSh1bnNpZ25lZCBsb25nIGRhdGEpCj4KPiAgIHN0YXRpYyB2b2lkIGlycV9lbmFibGUoc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgewo+ICsJLyogRW5hYmxpbmcgdGhlIElSUSBt YXkgbWlzcyB0aGUgZ2VuZXJhdGlvbiBvZiB0aGUgaW50ZXJydXB0LCBidXQKPiArCSAqIHdlIHN0 aWxsIG5lZWQgdG8gZm9yY2UgdGhlIGJhcnJpZXIgYmVmb3JlIHJlYWRpbmcgdGhlIHNlcW5vLAo+ ICsJICoganVzdCBpbiBjYXNlLgo+ICsJICovCj4gKwllbmdpbmUtPmlycV9wb3N0ZWQgPSB0cnVl OwoKU2hvdWxkIGl0IGJlIHNtcF9zdG9yZV9tYiBoZXJlIGFzIHdlbGw/Cgo+ICAgCVdBUk5fT04o IWVuZ2luZS0+aXJxX2dldChlbmdpbmUpKTsKPiAgIH0KPgo+ICAgc3RhdGljIHZvaWQgaXJxX2Rp c2FibGUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgewo+ICAgCWVuZ2luZS0+ aXJxX3B1dChlbmdpbmUpOwo+ICsJZW5naW5lLT5pcnFfcG9zdGVkID0gZmFsc2U7Cj4gICB9Cj4K PiAgIHN0YXRpYyBib29sIF9faW50ZWxfYnJlYWRjcnVtYnNfZW5hYmxlX2lycShzdHJ1Y3QgaW50 ZWxfYnJlYWRjcnVtYnMgKmIpCj4gQEAgLTU2LDcgKzYyLDYgQEAgc3RhdGljIGJvb2wgX19pbnRl bF9icmVhZGNydW1ic19lbmFibGVfaXJxKHN0cnVjdCBpbnRlbF9icmVhZGNydW1icyAqYikKPiAg IAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUgPQo+ICAgCQljb250YWluZXJfb2YoYiwg c3RydWN0IGludGVsX2VuZ2luZV9jcywgYnJlYWRjcnVtYnMpOwo+ICAgCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICppOTE1ID0gZW5naW5lLT5pOTE1Owo+IC0JYm9vbCBpcnFfcG9zdGVkID0gZmFs c2U7Cj4KPiAgIAlhc3NlcnRfc3Bpbl9sb2NrZWQoJmItPmxvY2spOwo+ICAgCWlmIChiLT5ycG1f d2FrZWxvY2spCj4gQEAgLTcyLDEwICs3Nyw4IEBAIHN0YXRpYyBib29sIF9faW50ZWxfYnJlYWRj cnVtYnNfZW5hYmxlX2lycShzdHJ1Y3QgaW50ZWxfYnJlYWRjcnVtYnMgKmIpCj4KPiAgIAkvKiBO byBpbnRlcnJ1cHRzPyBLaWNrIHRoZSB3YWl0ZXIgZXZlcnkgamlmZmllISAqLwo+ICAgCWlmIChp bnRlbF9pcnFzX2VuYWJsZWQoaTkxNSkpIHsKPiAtCQlpZiAoIXRlc3RfYml0KGVuZ2luZS0+aWQs ICZpOTE1LT5ncHVfZXJyb3IudGVzdF9pcnFfcmluZ3MpKSB7Cj4gKwkJaWYgKCF0ZXN0X2JpdChl bmdpbmUtPmlkLCAmaTkxNS0+Z3B1X2Vycm9yLnRlc3RfaXJxX3JpbmdzKSkKPiAgIAkJCWlycV9l bmFibGUoZW5naW5lKTsKPiAtCQkJaXJxX3Bvc3RlZCA9IHRydWU7Cj4gLQkJfQo+ICAgCQliLT5p cnFfZW5hYmxlZCA9IHRydWU7Cj4gICAJfQo+Cj4gQEAgLTgzLDcgKzg2LDcgQEAgc3RhdGljIGJv b2wgX19pbnRlbF9icmVhZGNydW1ic19lbmFibGVfaXJxKHN0cnVjdCBpbnRlbF9icmVhZGNydW1i cyAqYikKPiAgIAkgICAgdGVzdF9iaXQoZW5naW5lLT5pZCwgJmk5MTUtPmdwdV9lcnJvci5taXNz ZWRfaXJxX3JpbmdzKSkKPiAgIAkJbW9kX3RpbWVyKCZiLT5mYWtlX2lycSwgamlmZmllcyArIDEp Owo+Cj4gLQlyZXR1cm4gaXJxX3Bvc3RlZDsKPiArCXJldHVybiBSRUFEX09OQ0UoZW5naW5lLT5p cnFfcG9zdGVkKTsKPiAgIH0KPgo+ICAgc3RhdGljIHZvaWQgX19pbnRlbF9icmVhZGNydW1ic19k aXNhYmxlX2lycShzdHJ1Y3QgaW50ZWxfYnJlYWRjcnVtYnMgKmIpCj4gQEAgLTE5Nyw3ICsyMDAs OCBAQCBib29sIGludGVsX2VuZ2luZV9hZGRfd2FpdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUsCj4gICAJCQkgKiBpbiBjYXNlIHRoZSBzZXFubyBwYXNzZWQuCj4gICAJCQkgKi8KPiAg IAkJCV9faW50ZWxfYnJlYWRjcnVtYnNfZW5hYmxlX2lycShiKTsKPiAtCQkJd2FrZV91cF9wcm9j ZXNzKHRvX3dhaXQobmV4dCktPnRhc2spOwo+ICsJCQlpZiAoUkVBRF9PTkNFKGVuZ2luZS0+aXJx X3Bvc3RlZCkpCgppZiAoX19pbnRlbF9icmVhZGNydW1ic19lbmFibGVfaXJxKGIpKSA/Cgo+ICsJ CQkJd2FrZV91cF9wcm9jZXNzKHRvX3dhaXQobmV4dCktPnRhc2spOwo+ICAgCQl9Cj4KPiAgIAkJ ZG8gewo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVy LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBpbmRleCBjYjU5 OWE1NDkzMWEuLjMyNGY4NWU4ZDU0MCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9yaW5nYnVmZmVyLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9y aW5nYnVmZmVyLmgKPiBAQCAtMTk3LDYgKzE5Nyw3IEBAIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg ewo+ICAgCXN0cnVjdCBpOTE1X2N0eF93b3JrYXJvdW5kcyB3YV9jdHg7Cj4KPiAgIAl1bnNpZ25l ZCBpcnFfcmVmY291bnQ7IC8qIHByb3RlY3RlZCBieSBkZXZfcHJpdi0+aXJxX2xvY2sgKi8KPiAr CWJvb2wJCWlycV9wb3N0ZWQ7Cj4gICAJdTMyCQlpcnFfZW5hYmxlX21hc2s7CS8qIGJpdG1hc2sg dG8gZW5hYmxlIHJpbmcgaW50ZXJydXB0ICovCj4gICAJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1 ZXN0ICp0cmFjZV9pcnFfcmVxOwo+ICAgCWJvb2wgX19tdXN0X2NoZWNrICgqaXJxX2dldCkoc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqcmluZyk7Cj4KClJlZ2FyZHMsCgpUdnJ0a28KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=