Re: [PATCH 3/3] drm/i915/guc: enable GuC loading & submission by default

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 07/06/16 09:14, Dave Gordon wrote:
> The recent patch
> . fce91f2 drm/i915/guc: add enable_guc_loading parameter
> enabled GuC loading and submission by default, but as issues

Not submission, just the loading.

> were found with warnings being issued during suspend-resume
> cycles, GuC loading was disabled by default, by patch
> . 2335986 drm/i915/guc: Disable automatic GuC firmware loading
>
> Those warnings have been resolved, so this patch re-enables GuC
> loading and submission by default.

Enabling submission by default was okayed by everyone now?

>
> Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_params.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 5e18cf9..573e787 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -54,8 +54,8 @@ struct i915_params i915 __read_mostly = {
>   	.verbose_state_checks = 1,
>   	.nuclear_pageflip = 0,
>   	.edp_vswing = 0,
> -	.enable_guc_loading = 0,
> -	.enable_guc_submission = 0,
> +	.enable_guc_loading = -1,
> +	.enable_guc_submission = -1,
>   	.guc_log_level = -1,
>   	.enable_dp_mst = true,
>   	.inject_load_failure = 0,
> @@ -202,12 +202,12 @@ struct i915_params i915 __read_mostly = {
>   module_param_named_unsafe(enable_guc_loading, i915.enable_guc_loading, int, 0400);
>   MODULE_PARM_DESC(enable_guc_loading,
>   		"Enable GuC firmware loading "
> -		"(-1=auto, 0=never [default], 1=if available, 2=required)");
> +		"(-1=auto [default], 0=never, 1=if available, 2=required)");
>
>   module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, int, 0400);
>   MODULE_PARM_DESC(enable_guc_submission,
>   		"Enable GuC submission "
> -		"(-1=auto, 0=never [default], 1=if available, 2=required)");
> +		"(-1=auto [default], 0=never, 1=if available, 2=required)");
>
>   module_param_named(guc_log_level, i915.guc_log_level, int, 0400);
>   MODULE_PARM_DESC(guc_log_level,
>

Patch itself is fine so:

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx