From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 2/3] drm/i915/guc: disable GuC submission earlier during GuC (re)load Date: Tue, 7 Jun 2016 11:13:32 +0100 Message-ID: <57569E4C.6060802@intel.com> References: <1465287291-2187-1-git-send-email-david.s.gordon@intel.com> <1465287291-2187-2-git-send-email-david.s.gordon@intel.com> <57569921.9060304@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id DD6EA6E70E for ; Tue, 7 Jun 2016 10:13:43 +0000 (UTC) In-Reply-To: <57569921.9060304@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDcvMDYvMTYgMTA6NTEsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMDcvMDYvMTYg MDk6MTQsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBXaGVuIHJlc2V0dGluZyBhbmQgcmVsb2FkaW5n IHRoZSBHdUMsIHRoZSBHdUMgc3VibWlzc2lvbiBtYW5hZ2VtZW50IGNvZGUKPj4gYWxzbyBuZWVk cyB0byBkZXN0cm95IGFuZCByZWNyZWF0ZSB0aGUgR3VDIGNsaWVudChzKS4gQ3VycmVudGx5IHRo aXMgaXMKPj4gZG9uZSBieSBhIHNlcGFyYXRlIGNhbGwgZnJvbSB0aGUgR3VDIGxvYWRlciwgYnV0 IHJlYWxseSwgaXQncyBqdXN0IGFuCj4+IGludGVybmFsIGRldGFpbCBvZiB0aGUgc3VibWlzc2lv biBjb2RlLiBTbyBoZXJlIHdlIHJlbW92ZSB0aGUgY2FsbCBmcm9tCj4+IHRoZSBsb2FkZXIgKHdo aWNoIGlzIHRvbyBsYXRlLCByZWFsbHksIGJlY2F1c2UgdGhlIEd1QyBoYXMgYWxyZWFkeSBiZWVu Cj4+IHJlbG9hZGVkIGF0IHRoaXMgcG9pbnQpIGFuZCBwdXQgaXQgaW50byBndWNfc3VibWlzc2lv bl9pbml0KCkgaW5zdGVhZC4KPj4gVGhpcyBtZWFucyB0aGF0IGFueSBwcmVleGlzdGluZyBjbGll bnQgaXMgZGVzdHJveWVkICpiZWZvcmUqIHRoZSBHdUMKPj4gKHJlKWxvYWQgYW5kIHRoZW4gcmVj cmVhdGVkIGFmdGVyLCBpZmYgdGhlIGZpcm13YXJlIHdhcyBzdWNjZXNzZnVsbHkKPj4gbG9hZGVk LiBJZiB0aGUgR3VDIHJlbG9hZCBmYWlscywgd2UgZG9uJ3QgcmVjcmVhdGUgdGhlIGNsaWVudCwg c28KPj4gZmFsbGJhY2sgdG8gZXhlY2xpc3RzIG1vZGUgKGlmIGFjdGl2ZSkgd29uJ3QgbGVhayB0 aGUgY2xpZW50IG9iamVjdAo+PiAocHJldmlvdXNseSwgdGhlIG5vdy11bnVzYWJsZSBjbGllbnQg d291bGQgaGF2ZSBiZWVuIGxlZnQgYWxsb2NhdGVkLAo+PiBhbmQgbGVha2VkIGlmIHRoZSBkcml2 ZXIgd2VyZSB1bmxvYWRlZCkuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZp ZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDE1ICsrKysrKysrKystLS0tLQo+PiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYyAgICB8ICAzIC0tLQo+PiAgIDIgZmlsZXMgY2hh bmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+PiBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+PiBpbmRleCBhYzcyNDUxLi4yZGIx MTgyIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNz aW9uLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5j Cj4+IEBAIC02NTcsNiArNjU3LDggQEAgc3RhdGljIHZvaWQgZ3VjX2NsaWVudF9mcmVlKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsCj4+ICAgICAgICAqLwo+Pgo+PiAgICAgICBpZiAoY2xpZW50LT5j bGllbnRfYmFzZSkgewo+PiArICAgICAgICB1aW50MTZfdCBkYl9pZCA9IGNsaWVudC0+ZG9vcmJl bGxfaWQ7Cj4+ICsKPj4gICAgICAgICAgIC8qCj4+ICAgICAgICAgICAgKiBJZiB3ZSBnb3QgYXMg ZmFyIGFzIHNldHRpbmcgdXAgYSBkb29yYmVsbCwgbWFrZSBzdXJlCj4+ICAgICAgICAgICAgKiB3 ZSBzaHV0IGl0IGRvd24gYmVmb3JlIHVubWFwcGluZyAmIGRlYWxsb2NhdGluZyB0aGUKPj4gQEAg LTY2NCwxMCArNjY2LDExIEBAIHN0YXRpYyB2b2lkIGd1Y19jbGllbnRfZnJlZShzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LAo+PiAgICAgICAgICAgICogR3VDIHRoYXQgd2UndmUgZmluaXNoZWQgd2l0 aCBpdCwgZmluYWxseSBkZWFsbG9jYXRlCj4+ICAgICAgICAgICAgKiBpdCBpbiBvdXIgYml0bWFw Cj4+ICAgICAgICAgICAgKi8KPj4gLSAgICAgICAgaWYgKGNsaWVudC0+ZG9vcmJlbGxfaWQgIT0g R1VDX0lOVkFMSURfRE9PUkJFTExfSUQpIHsKPj4gKyAgICAgICAgaWYgKGRiX2lkICE9IEdVQ19J TlZBTElEX0RPT1JCRUxMX0lEKSB7Cj4+ICAgICAgICAgICAgICAgZ3VjX2Rpc2FibGVfZG9vcmJl bGwoZ3VjLCBjbGllbnQpOwo+PiAtICAgICAgICAgICAgaG9zdDJndWNfcmVsZWFzZV9kb29yYmVs bChndWMsIGNsaWVudCk7Cj4+IC0gICAgICAgICAgICByZWxlYXNlX2Rvb3JiZWxsKGd1YywgY2xp ZW50LT5kb29yYmVsbF9pZCk7Cj4+ICsgICAgICAgICAgICBpZiAodGVzdF9iaXQoZGJfaWQsIGd1 Yy0+ZG9vcmJlbGxfYml0bWFwKSkKPj4gKyAgICAgICAgICAgICAgICBob3N0Mmd1Y19yZWxlYXNl X2Rvb3JiZWxsKGd1YywgY2xpZW50KTsKPj4gKyAgICAgICAgICAgIHJlbGVhc2VfZG9vcmJlbGwo Z3VjLCBkYl9pZCk7Cj4+ICAgICAgICAgICB9Cj4+Cj4+ICAgICAgICAgICBrdW5tYXAoa21hcF90 b19wYWdlKGNsaWVudC0+Y2xpZW50X2Jhc2UpKTsKPj4gQEAgLTkxMiw2ICs5MTUsMTAgQEAgaW50 IGk5MTVfZ3VjX3N1Ym1pc3Npb25faW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgICAg ICBjb25zdCBzaXplX3QgZ2Vtc2l6ZSA9IHJvdW5kX3VwKHBvb2xzaXplLCBQQUdFX1NJWkUpOwo+ PiAgICAgICBzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmZGV2X3ByaXYtPmd1YzsKPj4KPj4gKyAg ICAvKiBXaXBlIGJpdG1hcCAmIGRlbGV0ZSBjbGllbnQgaW4gY2FzZSBvZiByZWluaXRpYWxpc2F0 aW9uICovCj4+ICsgICAgYml0bWFwX2NsZWFyKGd1Yy0+ZG9vcmJlbGxfYml0bWFwLCAwLCBHVUNf TUFYX0RPT1JCRUxMUyk7Cj4+ICsgICAgaTkxNV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKGRldik7 Cj4+ICsKPj4gICAgICAgaWYgKCFpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbikKPj4gICAgICAg ICAgIHJldHVybiAwOyAvKiBub3QgZW5hYmxlZCAgKi8KPj4KPj4gQEAgLTkyMyw5ICs5MzAsNyBA QCBpbnQgaTkxNV9ndWNfc3VibWlzc2lvbl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+ ICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKPj4KPj4gICAgICAgaWRhX2luaXQoJmd1Yy0+Y3R4 X2lkcyk7Cj4+IC0KPj4gICAgICAgZ3VjX2NyZWF0ZV9sb2coZ3VjKTsKPj4gLQo+PiAgICAgICBn dWNfY3JlYXRlX2FkcyhndWMpOwo+Pgo+PiAgICAgICByZXR1cm4gMDsKPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+PiBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+PiBpbmRleCA0ZTM0YzJlLi40MWY3YzdkIDEw MDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4+IEBAIC00OTIs OSArNDkyLDYgQEAgaW50IGludGVsX2d1Y19zZXR1cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ PiAgICAgICAgICAgaW50ZWxfZ3VjX2Z3X3N0YXR1c19yZXByKGd1Y19mdy0+Z3VjX2Z3X2xvYWRf c3RhdHVzKSk7Cj4+Cj4+ICAgICAgIGlmIChpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbikgewo+ PiAtICAgICAgICAvKiBUaGUgZXhlY2J1Zl9jbGllbnQgd2lsbCBiZSByZWNyZWF0ZWQuIFJlbGVh c2UgaXQgZmlyc3QuICovCj4+IC0gICAgICAgIGk5MTVfZ3VjX3N1Ym1pc3Npb25fZGlzYWJsZShk ZXYpOwo+PiAtCj4+ICAgICAgICAgICBlcnIgPSBpOTE1X2d1Y19zdWJtaXNzaW9uX2VuYWJsZShk ZXYpOwo+PiAgICAgICAgICAgaWYgKGVycikKPj4gICAgICAgICAgICAgICBnb3RvIGZhaWw7Cj4K PiBUaGlzIGZpeGVzIHRoZSBlcnJvcnMgb24gc3VzcGVuZC9yZXN1bWU/IEl0IHdvdWxkIGJlIHVz ZWZ1bCBmb3IgdGhlCj4gY29tbWl0IG1lc3NhZ2UgdG8gZXhwbGFpbiB3aGF0IHdhcyBoYXBwZW5p bmcuCgpUaGUgZXJyb3IgbWVzc2FnZSBJJ3ZlIHNlZW4gd2FzIGFjdHVhbGx5IGEgdGltZW91dCBm cm9tIHRyeWluZyB0byB0YWxrIAp0byB0aGUgR3VDIGR1cmluZyBhIFREUiByZXNldC4gU28gdGhp cyBmaXhlcyBpdCBieSAqbm90KiB0YWxraW5nIHRvIHRoZSAKR3VDIGR1cmluZyBhIHJlc2V0IC0g ZXZlbiBpZiB0aGUgR3VDIHdlcmUgc3RpbGwgd29ya2luZywgdGhlcmUncyBub3QgCm11Y2ggcG9p bnQgaW4gdXBkYXRpbmcgaXQganVzdCBiZWZvcmUgdGhlIHJlbG9hZCwgd2hpY2ggd2lsbCByZXNl dCBhbGwgCml0cyBzdGF0ZSBhbnl3YXkuCgo+IEl0IGlzIGEgYml0IHN0cmFuZ2Ugc2luY2UgdGhl IGZpcnN0IGRpc2FibGUgbm93IGNvbWVzIGJlZm9yZSB0aGUgaW5pdCwKClRoZSBmaXJzdCBkaXNh YmxlIGlzIG5vdyAqaW5zaWRlKiBpOTE1X2d1Y19zdWJtaXNzaW9uX2luaXQoKS4KQnV0IGl0IGRv ZXMgY29tZSBiZWZvcmUgdGhlIGZpcnN0IGk5MTVfZ3VjX3N1Ym1pc3Npb25fZW5hYmxlKCkuCkl0 J3Mgbm90IGFuIGVycm9yIHRvIGRpc2FibGUgc29tZXRoaW5nIHRoYXQncyBub3QgKHlldCkgZW5h YmxlZCA6KQoKLkRhdmUuCgo+IGJ1dCBzaW5jZSB0aGUgZGlzYWJsZSBwYXRoIGFscmVhZHkgZG9l cyBoYW5kbGUgdGhhdCBjYXNlIEkgc3VwcG9zZSBpdCBpcwo+IE9LLgo+Cj4gQW55d2F5LAo+Cj4g UmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4K PiBSZWdhcmRzLAo+Cj4gVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK