From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 2/4] drm/i915/guc: move guc_ring_doorbell()
 nearer to callsite
Date: Wed, 8 Jun 2016 13:47:02 +0100
Message-ID: <575813C6.8060900@linux.intel.com>
References: <1465383329-14885-1-git-send-email-david.s.gordon@intel.com>
 <1465383329-14885-3-git-send-email-david.s.gordon@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTP id 6E2D06E9DD
 for <intel-gfx@lists.freedesktop.org>; Wed,  8 Jun 2016 12:47:04 +0000 (UTC)
In-Reply-To: <1465383329-14885-3-git-send-email-david.s.gordon@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDA4LzA2LzE2IDExOjU1LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBKdXN0IGNvZGUgbW92ZW1l
bnQsIG5vIGFjdHVhbCBjaGFuZ2UgdG8gdGhlIGZ1bmN0aW9uLiBUaGlzIGlzIGluCj4gcHJlcGFy
YXRpb24gZm9yIHRoZSBuZXh0IHBhdGNoLCB3aGljaCB3aWxsIHJlb3JnYW5pc2UgYWxsIHRoZSBv
dGhlcgo+IGRvb3JiZWxsIGNvZGUsIGJ1dCBkb2Vzbid0IGNoYW5nZSB0aGlzIGZ1bmN0aW9uLiBT
byBsZXQncyBzaHVmZmxlIGl0Cj4gZG93biBuZWFyIGl0cyBjYWxsZXIgcmF0aGVyIHRoYW4gbGVh
dmluZyBpdCBtaXhlZCBpbiB3aXRoIHRoZSBzZXR1cAo+IGNvZGUuIFVubGlrZSB0aGUgZG9vcmJl
bGwgbWFuYWdlbWVudCBjb2RlLCB0aGlzIGZ1bmN0aW9uIGlzIHNvbWV3aGF0Cj4gdGltZS1jcml0
aWNhbCwgc28gcHV0dGluZyBpdCBuZWFyIGl0cyBjYWxsZXIgbWF5IGV2ZW4geWllbGQgYSB0aW55
Cj4gcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRv
biA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwgMTEwICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0t
LS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNTUgaW5zZXJ0aW9ucygrKSwgNTUgZGVsZXRpb25zKC0p
Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lv
bi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gaW5kZXgg
MmRiMTE4Mi4uNzUxMDg0MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X2d1Y19zdWJtaXNzaW9uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19z
dWJtaXNzaW9uLmMKPiBAQCAtMTg1LDYxICsxODUsNiBAQCBzdGF0aWMgdm9pZCBndWNfaW5pdF9k
b29yYmVsbChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsCj4gICAJZG9vcmJlbGwtPmNvb2tpZSA9IDA7
Cj4gICB9Cj4KPiAtc3RhdGljIGludCBndWNfcmluZ19kb29yYmVsbChzdHJ1Y3QgaTkxNV9ndWNf
Y2xpZW50ICpnYykKPiAtewo+IC0Jc3RydWN0IGd1Y19wcm9jZXNzX2Rlc2MgKmRlc2M7Cj4gLQl1
bmlvbiBndWNfZG9vcmJlbGxfcXcgZGJfY21wLCBkYl9leGMsIGRiX3JldDsKPiAtCXVuaW9uIGd1
Y19kb29yYmVsbF9xdyAqZGI7Cj4gLQlpbnQgYXR0ZW1wdCA9IDIsIHJldCA9IC1FQUdBSU47Cj4g
LQo+IC0JZGVzYyA9IGdjLT5jbGllbnRfYmFzZSArIGdjLT5wcm9jX2Rlc2Nfb2Zmc2V0Owo+IC0K
PiAtCS8qIFVwZGF0ZSB0aGUgdGFpbCBzbyBpdCBpcyB2aXNpYmxlIHRvIEd1QyAqLwo+IC0JZGVz
Yy0+dGFpbCA9IGdjLT53cV90YWlsOwo+IC0KPiAtCS8qIGN1cnJlbnQgY29va2llICovCj4gLQlk
Yl9jbXAuZGJfc3RhdHVzID0gR1VDX0RPT1JCRUxMX0VOQUJMRUQ7Cj4gLQlkYl9jbXAuY29va2ll
ID0gZ2MtPmNvb2tpZTsKPiAtCj4gLQkvKiBjb29raWUgdG8gYmUgdXBkYXRlZCAqLwo+IC0JZGJf
ZXhjLmRiX3N0YXR1cyA9IEdVQ19ET09SQkVMTF9FTkFCTEVEOwo+IC0JZGJfZXhjLmNvb2tpZSA9
IGdjLT5jb29raWUgKyAxOwo+IC0JaWYgKGRiX2V4Yy5jb29raWUgPT0gMCkKPiAtCQlkYl9leGMu
Y29va2llID0gMTsKPiAtCj4gLQkvKiBwb2ludGVyIG9mIGN1cnJlbnQgZG9vcmJlbGwgY2FjaGVs
aW5lICovCj4gLQlkYiA9IGdjLT5jbGllbnRfYmFzZSArIGdjLT5kb29yYmVsbF9vZmZzZXQ7Cj4g
LQo+IC0Jd2hpbGUgKGF0dGVtcHQtLSkgewo+IC0JCS8qIGxldHMgcmluZyB0aGUgZG9vcmJlbGwg
Ki8KPiAtCQlkYl9yZXQudmFsdWVfcXcgPSBhdG9taWM2NF9jbXB4Y2hnKChhdG9taWM2NF90ICop
ZGIsCj4gLQkJCWRiX2NtcC52YWx1ZV9xdywgZGJfZXhjLnZhbHVlX3F3KTsKPiAtCj4gLQkJLyog
aWYgdGhlIGV4Y2hhbmdlIHdhcyBzdWNjZXNzZnVsbHkgZXhlY3V0ZWQgKi8KPiAtCQlpZiAoZGJf
cmV0LnZhbHVlX3F3ID09IGRiX2NtcC52YWx1ZV9xdykgewo+IC0JCQkvKiBkYiB3YXMgc3VjY2Vz
c2Z1bGx5IHJ1bmcgKi8KPiAtCQkJZ2MtPmNvb2tpZSA9IGRiX2V4Yy5jb29raWU7Cj4gLQkJCXJl
dCA9IDA7Cj4gLQkJCWJyZWFrOwo+IC0JCX0KPiAtCj4gLQkJLyogWFhYOiBkb29yYmVsbCB3YXMg
bG9zdCBhbmQgbmVlZCB0byBhY3F1aXJlIGl0IGFnYWluICovCj4gLQkJaWYgKGRiX3JldC5kYl9z
dGF0dXMgPT0gR1VDX0RPT1JCRUxMX0RJU0FCTEVEKQo+IC0JCQlicmVhazsKPiAtCj4gLQkJRFJN
X0VSUk9SKCJDb29raWUgbWlzbWF0Y2guIEV4cGVjdGVkICVkLCByZXR1cm5lZCAlZFxuIiwKPiAt
CQkJICBkYl9jbXAuY29va2llLCBkYl9yZXQuY29va2llKTsKPiAtCj4gLQkJLyogdXBkYXRlIHRo
ZSBjb29raWUgdG8gbmV3bHkgcmVhZCBjb29raWUgZnJvbSBHdUMgKi8KPiAtCQlkYl9jbXAuY29v
a2llID0gZGJfcmV0LmNvb2tpZTsKPiAtCQlkYl9leGMuY29va2llID0gZGJfcmV0LmNvb2tpZSAr
IDE7Cj4gLQkJaWYgKGRiX2V4Yy5jb29raWUgPT0gMCkKPiAtCQkJZGJfZXhjLmNvb2tpZSA9IDE7
Cj4gLQl9Cj4gLQo+IC0JcmV0dXJuIHJldDsKPiAtfQo+IC0KPiAgIHN0YXRpYyB2b2lkIGd1Y19k
aXNhYmxlX2Rvb3JiZWxsKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywKPiAgIAkJCQkgc3RydWN0IGk5
MTVfZ3VjX2NsaWVudCAqY2xpZW50KQo+ICAgewo+IEBAIC01NDMsNiArNDg4LDYxIEBAIHN0YXRp
YyB2b2lkIGd1Y19hZGRfd29ya3F1ZXVlX2l0ZW0oc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqZ2Ms
Cj4gICAJa3VubWFwX2F0b21pYyhiYXNlKTsKPiAgIH0KPgo+ICtzdGF0aWMgaW50IGd1Y19yaW5n
X2Rvb3JiZWxsKHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmdjKQo+ICt7Cj4gKwlzdHJ1Y3QgZ3Vj
X3Byb2Nlc3NfZGVzYyAqZGVzYzsKPiArCXVuaW9uIGd1Y19kb29yYmVsbF9xdyBkYl9jbXAsIGRi
X2V4YywgZGJfcmV0Owo+ICsJdW5pb24gZ3VjX2Rvb3JiZWxsX3F3ICpkYjsKPiArCWludCBhdHRl
bXB0ID0gMiwgcmV0ID0gLUVBR0FJTjsKPiArCj4gKwlkZXNjID0gZ2MtPmNsaWVudF9iYXNlICsg
Z2MtPnByb2NfZGVzY19vZmZzZXQ7Cj4gKwo+ICsJLyogVXBkYXRlIHRoZSB0YWlsIHNvIGl0IGlz
IHZpc2libGUgdG8gR3VDICovCj4gKwlkZXNjLT50YWlsID0gZ2MtPndxX3RhaWw7Cj4gKwo+ICsJ
LyogY3VycmVudCBjb29raWUgKi8KPiArCWRiX2NtcC5kYl9zdGF0dXMgPSBHVUNfRE9PUkJFTExf
RU5BQkxFRDsKPiArCWRiX2NtcC5jb29raWUgPSBnYy0+Y29va2llOwo+ICsKPiArCS8qIGNvb2tp
ZSB0byBiZSB1cGRhdGVkICovCj4gKwlkYl9leGMuZGJfc3RhdHVzID0gR1VDX0RPT1JCRUxMX0VO
QUJMRUQ7Cj4gKwlkYl9leGMuY29va2llID0gZ2MtPmNvb2tpZSArIDE7Cj4gKwlpZiAoZGJfZXhj
LmNvb2tpZSA9PSAwKQo+ICsJCWRiX2V4Yy5jb29raWUgPSAxOwo+ICsKPiArCS8qIHBvaW50ZXIg
b2YgY3VycmVudCBkb29yYmVsbCBjYWNoZWxpbmUgKi8KPiArCWRiID0gZ2MtPmNsaWVudF9iYXNl
ICsgZ2MtPmRvb3JiZWxsX29mZnNldDsKPiArCj4gKwl3aGlsZSAoYXR0ZW1wdC0tKSB7Cj4gKwkJ
LyogbGV0cyByaW5nIHRoZSBkb29yYmVsbCAqLwo+ICsJCWRiX3JldC52YWx1ZV9xdyA9IGF0b21p
YzY0X2NtcHhjaGcoKGF0b21pYzY0X3QgKilkYiwKPiArCQkJZGJfY21wLnZhbHVlX3F3LCBkYl9l
eGMudmFsdWVfcXcpOwo+ICsKPiArCQkvKiBpZiB0aGUgZXhjaGFuZ2Ugd2FzIHN1Y2Nlc3NmdWxs
eSBleGVjdXRlZCAqLwo+ICsJCWlmIChkYl9yZXQudmFsdWVfcXcgPT0gZGJfY21wLnZhbHVlX3F3
KSB7Cj4gKwkJCS8qIGRiIHdhcyBzdWNjZXNzZnVsbHkgcnVuZyAqLwo+ICsJCQlnYy0+Y29va2ll
ID0gZGJfZXhjLmNvb2tpZTsKPiArCQkJcmV0ID0gMDsKPiArCQkJYnJlYWs7Cj4gKwkJfQo+ICsK
PiArCQkvKiBYWFg6IGRvb3JiZWxsIHdhcyBsb3N0IGFuZCBuZWVkIHRvIGFjcXVpcmUgaXQgYWdh
aW4gKi8KPiArCQlpZiAoZGJfcmV0LmRiX3N0YXR1cyA9PSBHVUNfRE9PUkJFTExfRElTQUJMRUQp
Cj4gKwkJCWJyZWFrOwo+ICsKPiArCQlEUk1fRVJST1IoIkNvb2tpZSBtaXNtYXRjaC4gRXhwZWN0
ZWQgJWQsIHJldHVybmVkICVkXG4iLAo+ICsJCQkgIGRiX2NtcC5jb29raWUsIGRiX3JldC5jb29r
aWUpOwo+ICsKPiArCQkvKiB1cGRhdGUgdGhlIGNvb2tpZSB0byBuZXdseSByZWFkIGNvb2tpZSBm
cm9tIEd1QyAqLwo+ICsJCWRiX2NtcC5jb29raWUgPSBkYl9yZXQuY29va2llOwo+ICsJCWRiX2V4
Yy5jb29raWUgPSBkYl9yZXQuY29va2llICsgMTsKPiArCQlpZiAoZGJfZXhjLmNvb2tpZSA9PSAw
KQo+ICsJCQlkYl9leGMuY29va2llID0gMTsKPiArCX0KPiArCj4gKwlyZXR1cm4gcmV0Owo+ICt9
Cj4gKwo+ICAgLyoqCj4gICAgKiBpOTE1X2d1Y19zdWJtaXQoKSAtIFN1Ym1pdCBjb21tYW5kcyB0
aHJvdWdoIEd1Qwo+ICAgICogQHJxOgkJcmVxdWVzdCBhc3NvY2lhdGVkIHdpdGggdGhlIGNvbW1h
bmRzCj4KCkRpZmZzdGF0IGlzIGNvcnJlY3QsIGRpZCBub3QgcmVhZCB0aGUgaW5kaXZpZHVhbCBs
aW5lcy4gOikKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50
ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m
cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0
aW5mby9pbnRlbC1nZngK