From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 1/3] drm/i915/guc: fix GuC loading/submission check Date: Fri, 10 Jun 2016 16:45:43 +0100 Message-ID: <575AE0A7.5070306@intel.com> References: <1465287291-2187-1-git-send-email-david.s.gordon@intel.com> <575688D6.70600@linux.intel.com> <57594D41.7000000@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id B69066EDA6 for ; Fri, 10 Jun 2016 15:45:47 +0000 (UTC) In-Reply-To: <57594D41.7000000@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMDkvMDYvMTYgMTI6MDQsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMDcvMDYvMTYg MDk6NDEsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Pgo+PiBPbiAwNy8wNi8xNiAwOToxNCwgRGF2 ZSBHb3Jkb24gd3JvdGU6Cj4+PiBUaGUgbGFzdCBzdGFnZSBvZiB0aGUgR3VDIGxvYWRlciBhbHNv IHNhbml0aXNlcyB0aGUgR3VDIHN1Ym1pc3Npb24KPj4+IHNldHRpbmdzLCBzbyBzaG91bGQgYmUg Y2FsbGVkIHVuY29uZGl0aW9uYWxseSAoZXZlbiBvbiBwbGF0Zm9ybXMKPj4+IHdpdGhvdXQgYSBH dUMpIHRvIGVuc3VyZSBjb25zaXN0ZW50IHNldHRpbmdzOyBpbiBwYXJ0aWN1bGFyLCB0aGlzCj4+ PiBwcmV2ZW50cyBhbnkgYXR0ZW1wdCB0byB1c2UgR3VDIHN1Ym1pc3Npb24gb24gR3VDbGVzcyBw bGF0Zm9ybXMhCj4+Pgo+Pj4gQWxzbyBmaXggZXJyb3IgcGF0aCBoYW5kbGluZyBhbmQgY2xhcmlm eSBEUk1fSU5GTyBmYWxsYmFjayBtZXNzYWdlLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IERhdmUg R29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4+PiAtLS0KPj4+ICAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAgIHwgIDggKysrLS0tLS0KPj4+ICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jIHwgMTIgKysrKysrKystLS0tCj4+PiAg IDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPj4+Cj4+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+Pj4gYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+PiBpbmRleCAxYmZjMjYwLi5lYWU4ZDdhIDEw MDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+Pj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+Pj4gQEAgLTQ5MzAsMTEgKzQ5MzAsOSBA QCBpbnQgaTkxNV9nZW1faW5pdF9lbmdpbmVzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4+PiAg ICAgICBpbnRlbF9tb2NzX2luaXRfbDNjY190YWJsZShkZXYpOwo+Pj4KPj4+ICAgICAgIC8qIFdl IGNhbid0IGVuYWJsZSBjb250ZXh0cyB1bnRpbCBhbGwgZmlybXdhcmUgaXMgbG9hZGVkICovCj4+ PiAtICAgIGlmIChIQVNfR1VDKGRldikpIHsKPj4+IC0gICAgICAgIHJldCA9IGludGVsX2d1Y19z ZXR1cChkZXYpOwo+Pj4gLSAgICAgICAgaWYgKHJldCkKPj4+IC0gICAgICAgICAgICBnb3RvIG91 dDsKPj4+IC0gICAgfQo+Pj4gKyAgICByZXQgPSBpbnRlbF9ndWNfc2V0dXAoZGV2KTsKPj4+ICsg ICAgaWYgKHJldCkKPj4+ICsgICAgICAgIGdvdG8gb3V0Owo+Pj4KPj4+ICAgICAgIC8qCj4+PiAg ICAgICAgKiBJbmNyZW1lbnQgdGhlIG5leHQgc2Vxbm8gYnkgMHgxMDAgc28gd2UgaGF2ZSBhIHZp c2libGUgYnJlYWsKPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9n dWNfbG9hZGVyLmMKPj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5j Cj4+PiBpbmRleCBmMmI4OGM3Li40ZTM0YzJlIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9ndWNfbG9hZGVyLmMKPj4+IEBAIC00MjUsOSArNDI1LDEzIEBAIGludCBpbnRlbF9n dWNfc2V0dXAoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4+ICAgICAgIGlmICghaTkxNS5lbmFi bGVfZ3VjX2xvYWRpbmcpIHsKPj4+ICAgICAgICAgICBlcnIgPSAwOwo+Pj4gICAgICAgICAgIGdv dG8gZmFpbDsKPj4+IC0gICAgfSBlbHNlIGlmIChmd19wYXRoID09IE5VTEwgfHwgKmZ3X3BhdGgg PT0gJ1wwJykgewo+Pj4gLSAgICAgICAgaWYgKCpmd19wYXRoID09ICdcMCcpCj4+Cj4+IE9wcy4g SSBjYW4gb25seSBhc3N1bWUgSSBtZWFudCAhZndfcGF0aC4KPj4KPj4+IC0gICAgICAgICAgICBE Uk1fSU5GTygiTm8gR3VDIGZpcm13YXJlIGtub3duIGZvciB0aGlzIHBsYXRmb3JtXG4iKTsKPj4+ ICsgICAgfSBlbHNlIGlmIChmd19wYXRoID09IE5VTEwpIHsKPj4+ICsgICAgICAgIC8qIERldmlj ZSBpcyBrbm93biB0byBoYXZlIG5vIHVDb2RlIChlLmcuIG5vIEd1QykgKi8KPj4+ICsgICAgICAg IGVyciA9IC1FTlhJTzsKPj4+ICsgICAgICAgIGdvdG8gZmFpbDsKPj4+ICsgICAgfSBlbHNlIGlm ICgqZndfcGF0aCA9PSAnXDAnKSB7Cj4+PiArICAgICAgICAvKiBEZXZpY2UgaGFzIGEgR3VDIGJ1 dCB3ZSBkb24ndCBrbm93IHdoYXQgZi93IHRvIGxvYWQ/ICovCj4+PiArICAgICAgICBEUk1fSU5G TygiTm8gR3VDIGZpcm13YXJlIGtub3duIGZvciB0aGlzIHBsYXRmb3JtXG4iKTsKPj4+ICAgICAg ICAgICBlcnIgPSAtRU5PREVWOwo+Pj4gICAgICAgICAgIGdvdG8gZmFpbDsKPj4+ICAgICAgIH0K Pj4+IEBAIC01MzUsNyArNTM5LDcgQEAgaW50IGludGVsX2d1Y19zZXR1cChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2KQo+Pj4gICAgICAgICAgIGlmIChmd19wYXRoID09IE5VTEwpCj4+PiAgICAgICAg ICAgICAgIERSTV9JTkZPKCJHdUMgc3VibWlzc2lvbiB3aXRob3V0IGZpcm13YXJlIG5vdAo+Pj4g c3VwcG9ydGVkXG4iKTsKPj4+ICAgICAgICAgICBpZiAocmV0ID09IDApCj4+PiAtICAgICAgICAg ICAgRFJNX0lORk8oIkZhbGxpbmcgYmFjayB0byBleGVjbGlzdCBtb2RlXG4iKTsKPj4+ICsgICAg ICAgICAgICBEUk1fSU5GTygiRmFsbGluZyBiYWNrIGZyb20gR3VDIHN1Ym1pc3Npb24gdG8gZXhl Y2xpc3QKPj4+IG1vZGVcbiIpOwo+Pj4gICAgICAgICAgIGVsc2UKPj4+ICAgICAgICAgICAgICAg RFJNX0VSUk9SKCJHdUMgaW5pdCBmYWlsZWQ6ICVkXG4iLCByZXQpOwo+Pj4gICAgICAgfQo+Pj4K Pj4KPj4gUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5j b20+Cj4KPiBCYWggbm93IG9uIEJEVyB3ZSBnZXQgb24gYm9vdDoKPgo+IFtkcm06Z2VuOF9pbml0 X2NvbW1vbl9yaW5nXSBFeGVjbGlzdHMgZW5hYmxlZCBmb3IgcmVuZGVyIHJpbmcKPiBbZHJtOmdl bjhfaW5pdF9jb21tb25fcmluZ10gRXhlY2xpc3RzIGVuYWJsZWQgZm9yIGJsaXR0ZXIgcmluZwo+ IFtkcm06Z2VuOF9pbml0X2NvbW1vbl9yaW5nXSBFeGVjbGlzdHMgZW5hYmxlZCBmb3IgYnNkIHJp bmcKPiBbZHJtOmdlbjhfaW5pdF9jb21tb25fcmluZ10gRXhlY2xpc3RzIGVuYWJsZWQgZm9yIHZp ZGVvIGVuaGFuY2VtZW50IHJpbmcKPiBbZHJtOmludGVsX2d1Y19zZXR1cF0gR3VDIGZ3IHN0YXR1 czogcGF0aCAobnVsbCksIGZldGNoIE5PTkUsIGxvYWQgTk9ORQo+IFtkcm1dIEd1QyBmaXJtd2Fy ZSBsb2FkIHNraXBwZWQKPiBbZHJtXSBHdUMgc3VibWlzc2lvbiB3aXRob3V0IGZpcm13YXJlIG5v dCBzdXBwb3J0ZWQKPiBbZHJtXSBGYWxsaW5nIGJhY2sgZnJvbSBHdUMgc3VibWlzc2lvbiB0byBl eGVjbGlzdCBtb2RlCj4KPiBXaGljaCBpcyBhIGJpdCB1bnRpZHkuIDooCj4KPiBSZWdhcmRzLAo+ IFR2cnRrbwoKWW91IHNob3VsZG4ndCBnZXQgdGhlIHNlY29uZCBvciB0aGlyZCBbZHJtXSBtZXNz YWdlLCBpZiB5b3UgaGF2ZW4ndCAKb3ZlcnJpZGRlbiB0aGUgZGVmYXVsdCB2YWx1ZXMuIFRoZSBk ZWZhdWx0IGZvciBlbmFibGVfZ3VjX3N1Ym1pc3Npb24KaXMgKC0xKSB3aGljaCBnZXRzIG1hcHBl ZCB0byBIQVNfR1VDX1NDSEVEKCkgd2hpY2ggaXMgMCBvbiBCRFc7IHlvdSBvbmx5IApnZXQgdGhl IGV4dHJhIG1lc3NhZ2VzIGlmIHlvdSd2ZSBzZXQgaXQgdG8gYSBub24tZGVmYXVsdCB2YWx1ZS4K Ci5EYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK