From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 1/2] drm/i915/guc: prefer 'dev_priv' to
 'dev' for static functions
Date: Mon, 13 Jun 2016 10:13:47 +0100
Message-ID: <575E794B.5050401@linux.intel.com>
References: <1465579766-31595-1-git-send-email-david.s.gordon@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 052EC6E118
 for <intel-gfx@lists.freedesktop.org>; Mon, 13 Jun 2016 09:13:49 +0000 (UTC)
In-Reply-To: <1465579766-31595-1-git-send-email-david.s.gordon@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDEwLzA2LzE2IDE4OjI5LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBDb252ZXJ0IGFsbCBzdGF0
aWMgZnVuY3Rpb25zIGluIGk5MTVfZ3VjX3N1Ym1pc3Npb24uYyB0aGF0IGN1cnJlbnRseQo+IHRh
a2UgYSAnZGV2JyBwb2ludGVyIHRvIHRha2UgJ2Rldl9wcml2JyBpbnN0ZWFkICh0aGVyZSBhcmUg
dGhyZWUsCj4gZ3VjX2NsaWVudF9hbGxvYygpLCBndWNfY2xpZW50X2ZyZWUoKSwgYW5kIGdlbV9h
bGxvY2F0ZV9ndWNfb2JqKCkuCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQu
cy5nb3Jkb25AaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n
dWNfc3VibWlzc2lvbi5jIHwgMzkgKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4gICAx
IGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4KPiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gaW5kZXggMmRiMTE4Mi4u
MWJkMGZhYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJt
aXNzaW9uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9u
LmMKPiBAQCAtNTkxLDcgKzU5MSw3IEBAIGludCBpOTE1X2d1Y19zdWJtaXQoc3RydWN0IGRybV9p
OTE1X2dlbV9yZXF1ZXN0ICpycSkKPgo+ICAgLyoqCj4gICAgKiBnZW1fYWxsb2NhdGVfZ3VjX29i
aigpIC0gQWxsb2NhdGUgZ2VtIG9iamVjdCBmb3IgR3VDIHVzYWdlCj4gLSAqIEBkZXY6CWRybSBk
ZXZpY2UKPiArICogQGRldl9wcml2Oglkcml2ZXIgcHJpdmF0ZSBkYXRhIHN0cnVjdHVyZQo+ICAg
ICogQHNpemU6CXNpemUgb2Ygb2JqZWN0Cj4gICAgKgo+ICAgICogVGhpcyBpcyBhIHdyYXBwZXIg
dG8gY3JlYXRlIGEgZ2VtIG9iai4gSW4gb3JkZXIgdG8gdXNlIGl0IGluc2lkZSBHdUMsIHRoZQo+
IEBAIC02MDAsMTMgKzYwMCwxMiBAQCBpbnQgaTkxNV9ndWNfc3VibWl0KHN0cnVjdCBkcm1faTkx
NV9nZW1fcmVxdWVzdCAqcnEpCj4gICAgKgo+ICAgICogUmV0dXJuOglBIGRybV9pOTE1X2dlbV9v
YmplY3QgaWYgc3VjY2Vzc2Z1bCwgb3RoZXJ3aXNlIE5VTEwuCj4gICAgKi8KPiAtc3RhdGljIHN0
cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpnZW1fYWxsb2NhdGVfZ3VjX29iaihzdHJ1Y3QgZHJt
X2RldmljZSAqZGV2LAo+IC0JCQkJCQkJdTMyIHNpemUpCj4gK3N0YXRpYyBzdHJ1Y3QgZHJtX2k5
MTVfZ2VtX29iamVjdCAqCj4gK2dlbV9hbGxvY2F0ZV9ndWNfb2JqKHN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdiwgdTMyIHNpemUpCj4gICB7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICAgCXN0cnVjdCBkcm1faTkxNV9n
ZW1fb2JqZWN0ICpvYmo7Cj4KPiAtCW9iaiA9IGk5MTVfZ2VtX29iamVjdF9jcmVhdGUoZGV2LCBz
aXplKTsKPiArCW9iaiA9IGk5MTVfZ2VtX29iamVjdF9jcmVhdGUoZGV2X3ByaXYtPmRldiwgc2l6
ZSk7Cj4gICAJaWYgKElTX0VSUihvYmopKQo+ICAgCQlyZXR1cm4gTlVMTDsKPgo+IEBAIC02NDIs
MTAgKzY0MSwxMCBAQCBzdGF0aWMgdm9pZCBnZW1fcmVsZWFzZV9ndWNfb2JqKHN0cnVjdCBkcm1f
aTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gICAJZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2UoJm9i
ai0+YmFzZSk7Cj4gICB9Cj4KPiAtc3RhdGljIHZvaWQgZ3VjX2NsaWVudF9mcmVlKHN0cnVjdCBk
cm1fZGV2aWNlICpkZXYsCj4gLQkJCSAgICBzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQp
Cj4gK3N0YXRpYyB2b2lkCj4gK2d1Y19jbGllbnRfZnJlZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0
ZSAqZGV2X3ByaXYsCj4gKwkJc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50KQo+ICAgewo+
IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsK
PiAgIAlzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmZGV2X3ByaXYtPmd1YzsKPgo+ICAgCWlmICgh
Y2xpZW50KQo+IEBAIC02ODgsNyArNjg3LDcgQEAgc3RhdGljIHZvaWQgZ3VjX2NsaWVudF9mcmVl
KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4KPiAgIC8qKgo+ICAgICogZ3VjX2NsaWVudF9hbGxv
YygpIC0gQWxsb2NhdGUgYW4gaTkxNV9ndWNfY2xpZW50Cj4gLSAqIEBkZXY6CWRybSBkZXZpY2UK
PiArICogQGRldl9wcml2Oglkcml2ZXIgcHJpdmF0ZSBkYXRhIHN0cnVjdHVyZQo+ICAgICogQHBy
aW9yaXR5Oglmb3VyIGxldmVscyBwcmlvcml0eSBfQ1JJVElDQUwsIF9ISUdILCBfTk9STUFMIGFu
ZCBfTE9XCj4gICAgKiAJCVRoZSBrZXJuZWwgY2xpZW50IHRvIHJlcGxhY2UgRXhlY0xpc3Qgc3Vi
bWlzc2lvbiBpcyBjcmVhdGVkIHdpdGgKPiAgICAqIAkJTk9STUFMIHByaW9yaXR5LiBQcmlvcml0
eSBvZiBhIGNsaWVudCBmb3Igc2NoZWR1bGVyIGNhbiBiZSBISUdILAo+IEBAIC02OTgsMTIgKzY5
NywxMiBAQCBzdGF0aWMgdm9pZCBndWNfY2xpZW50X2ZyZWUoc3RydWN0IGRybV9kZXZpY2UgKmRl
diwKPiAgICAqCj4gICAgKiBSZXR1cm46CUFuIGk5MTVfZ3VjX2NsaWVudCBvYmplY3QgaWYgc3Vj
Y2VzcywgZWxzZSBOVUxMLgo+ICAgICovCj4gLXN0YXRpYyBzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50
ICpndWNfY2xpZW50X2FsbG9jKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gLQkJCQkJCXVpbnQz
Ml90IHByaW9yaXR5LAo+IC0JCQkJCQlzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4KQo+ICtz
dGF0aWMgc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqCj4gK2d1Y19jbGllbnRfYWxsb2Moc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCSB1aW50MzJfdCBwcmlvcml0eSwKPiAr
CQkgc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCkKPiAgIHsKPiAgIAlzdHJ1Y3QgaTkxNV9n
dWNfY2xpZW50ICpjbGllbnQ7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg
PSBkZXYtPmRldl9wcml2YXRlOwo+ICAgCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZkZXZfcHJp
di0+Z3VjOwo+ICAgCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmo7Cj4KPiBAQCAtNzI0
LDcgKzcyMyw3IEBAIHN0YXRpYyBzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpndWNfY2xpZW50X2Fs
bG9jKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gICAJfQo+Cj4gICAJLyogVGhlIGZpcnN0IHBh
Z2UgaXMgZG9vcmJlbGwvcHJvY19kZXNjLiBUd28gZm9sbG93ZWQgcGFnZXMgYXJlIHdxLiAqLwo+
IC0Jb2JqID0gZ2VtX2FsbG9jYXRlX2d1Y19vYmooZGV2LCBHVUNfREJfU0laRSArIEdVQ19XUV9T
SVpFKTsKPiArCW9iaiA9IGdlbV9hbGxvY2F0ZV9ndWNfb2JqKGRldl9wcml2LCBHVUNfREJfU0la
RSArIEdVQ19XUV9TSVpFKTsKPiAgIAlpZiAoIW9iaikKPiAgIAkJZ290byBlcnI7Cj4KPiBAQCAt
NzY4LDcgKzc2Nyw3IEBAIHN0YXRpYyBzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpndWNfY2xpZW50
X2FsbG9jKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gICBlcnI6Cj4gICAJRFJNX0VSUk9SKCJG
QUlMRUQgdG8gY3JlYXRlIHByaW9yaXR5ICV1IEd1QyBjbGllbnQhXG4iLCBwcmlvcml0eSk7Cj4K
PiAtCWd1Y19jbGllbnRfZnJlZShkZXYsIGNsaWVudCk7Cj4gKwlndWNfY2xpZW50X2ZyZWUoZGV2
X3ByaXYsIGNsaWVudCk7Cj4gICAJcmV0dXJuIE5VTEw7Cj4gICB9Cj4KPiBAQCAtNzkzLDcgKzc5
Miw3IEBAIHN0YXRpYyB2b2lkIGd1Y19jcmVhdGVfbG9nKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykK
Pgo+ICAgCW9iaiA9IGd1Yy0+bG9nX29iajsKPiAgIAlpZiAoIW9iaikgewo+IC0JCW9iaiA9IGdl
bV9hbGxvY2F0ZV9ndWNfb2JqKGRldl9wcml2LT5kZXYsIHNpemUpOwo+ICsJCW9iaiA9IGdlbV9h
bGxvY2F0ZV9ndWNfb2JqKGRldl9wcml2LCBzaXplKTsKPiAgIAkJaWYgKCFvYmopIHsKPiAgIAkJ
CS8qIGxvZ2dpbmcgd2lsbCBiZSBvZmYgKi8KPiAgIAkJCWk5MTUuZ3VjX2xvZ19sZXZlbCA9IC0x
Owo+IEBAIC04NTMsNyArODUyLDcgQEAgc3RhdGljIHZvaWQgZ3VjX2NyZWF0ZV9hZHMoc3RydWN0
IGludGVsX2d1YyAqZ3VjKQo+Cj4gICAJb2JqID0gZ3VjLT5hZHNfb2JqOwo+ICAgCWlmICghb2Jq
KSB7Cj4gLQkJb2JqID0gZ2VtX2FsbG9jYXRlX2d1Y19vYmooZGV2X3ByaXYtPmRldiwgUEFHRV9B
TElHTihzaXplKSk7Cj4gKwkJb2JqID0gZ2VtX2FsbG9jYXRlX2d1Y19vYmooZGV2X3ByaXYsIFBB
R0VfQUxJR04oc2l6ZSkpOwo+ICAgCQlpZiAoIW9iaikKPiAgIAkJCXJldHVybjsKPgo+IEBAIC05
MjUsNyArOTI0LDcgQEAgaW50IGk5MTVfZ3VjX3N1Ym1pc3Npb25faW5pdChzdHJ1Y3QgZHJtX2Rl
dmljZSAqZGV2KQo+ICAgCWlmIChndWMtPmN0eF9wb29sX29iaikKPiAgIAkJcmV0dXJuIDA7IC8q
IGFscmVhZHkgYWxsb2NhdGVkICovCj4KPiAtCWd1Yy0+Y3R4X3Bvb2xfb2JqID0gZ2VtX2FsbG9j
YXRlX2d1Y19vYmooZGV2X3ByaXYtPmRldiwgZ2Vtc2l6ZSk7Cj4gKwlndWMtPmN0eF9wb29sX29i
aiA9IGdlbV9hbGxvY2F0ZV9ndWNfb2JqKGRldl9wcml2LCBnZW1zaXplKTsKPiAgIAlpZiAoIWd1
Yy0+Y3R4X3Bvb2xfb2JqKQo+ICAgCQlyZXR1cm4gLUVOT01FTTsKPgo+IEBAIC05NDMsNyArOTQy
LDcgQEAgaW50IGk5MTVfZ3VjX3N1Ym1pc3Npb25fZW5hYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpk
ZXYpCj4gICAJc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50Owo+Cj4gICAJLyogY2xpZW50
IGZvciBleGVjYnVmIHN1Ym1pc3Npb24gKi8KPiAtCWNsaWVudCA9IGd1Y19jbGllbnRfYWxsb2Mo
ZGV2LAo+ICsJY2xpZW50ID0gZ3VjX2NsaWVudF9hbGxvYyhkZXZfcHJpdiwKPiAgIAkJCQkgIEdV
Q19DVFhfUFJJT1JJVFlfS01EX05PUk1BTCwKPiAgIAkJCQkgIGRldl9wcml2LT5rZXJuZWxfY29u
dGV4dCk7Cj4gICAJaWYgKCFjbGllbnQpIHsKPiBAQCAtOTYzLDcgKzk2Miw3IEBAIHZvaWQgaTkx
NV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAJc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgIAlz
dHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmZGV2X3ByaXYtPmd1YzsKPgo+IC0JZ3VjX2NsaWVudF9m
cmVlKGRldiwgZ3VjLT5leGVjYnVmX2NsaWVudCk7Cj4gKwlndWNfY2xpZW50X2ZyZWUoZGV2X3By
aXYsIGd1Yy0+ZXhlY2J1Zl9jbGllbnQpOwo+ICAgCWd1Yy0+ZXhlY2J1Zl9jbGllbnQgPSBOVUxM
Owo+ICAgfQo+Cj4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5A
aW50ZWwuY29tPgoKQW5kIHlvdSBjYW4ga2VlcCB0aGUgci1iIGlmIHlvdSByZW5hbWUgZ2VtX2Fs
bG9jYXRlX2d1Y19vYmogYXMgQ2hyaXMgaGFzIApzdWdnZXN0ZWQuCgpSZWdhcmRzLAoKVHZydGtv
Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm
eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp
c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=