From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 2/2] drm/i915/guc: prefer 'dev_priv' to
 'dev' for intra-module functions
Date: Mon, 13 Jun 2016 10:15:38 +0100
Message-ID: <575E79BA.9070101@linux.intel.com>
References: <1465579766-31595-1-git-send-email-david.s.gordon@intel.com>
 <1465579766-31595-2-git-send-email-david.s.gordon@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id AA6C36E40D
 for <intel-gfx@lists.freedesktop.org>; Mon, 13 Jun 2016 09:15:40 +0000 (UTC)
In-Reply-To: <1465579766-31595-2-git-send-email-david.s.gordon@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDEwLzA2LzE2IDE4OjI5LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBUaGVyZSBhcmUgZm91ciBu
b24tc3RhdGljIGZ1bmN0aW9ucyBpbiBpOTE1X2d1Y19zdWJtaXNzaW9uLmMgdGhhdCB0YWtlIGEK
PiAnZGV2JyBwYXJhbWV0ZXIuIEFsbCBhcmUgY2FsbGVkIG9ubHkgZnJvbSBHdUMgbG9hZGVyIGNv
ZGUsIGFuZCBjYW4gYmUKPiBlYXNpbHkgY29udmVydGVkIHRvIGFjY2VwdCAnZGV2X3ByaXYnIGlu
c3RlYWQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50
ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lv
bi5jIHwgMTQgKysrKystLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1
Yy5oICAgICAgICAgICB8ICA4ICsrKystLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9ndWNfbG9hZGVyLmMgICAgfCAxMiArKysrKystLS0tLS0KPiAgIDMgZmlsZXMgY2hhbmdlZCwg
MTUgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gaW5kZXggMWJkMGZhYy4uNjVlNjdmMCAxMDA2NDQK
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiArKysg
Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiBAQCAtOTA2LDkg
KzkwNiw4IEBAIHN0YXRpYyB2b2lkIGd1Y19jcmVhdGVfYWRzKHN0cnVjdCBpbnRlbF9ndWMgKmd1
YykKPiAgICAqIFNldCB1cCB0aGUgbWVtb3J5IHJlc291cmNlcyB0byBiZSBzaGFyZWQgd2l0aCB0
aGUgR3VDLiAgQXQgdGhpcyBwb2ludCwKPiAgICAqIHdlIHJlcXVpcmUganVzdCBvbmUgb2JqZWN0
IHRoYXQgY2FuIGJlIG1hcHBlZCB0aHJvdWdoIHRoZSBHR1RULgo+ICAgICovCj4gLWludCBpOTE1
X2d1Y19zdWJtaXNzaW9uX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAraW50IGk5MTVf
Z3VjX3N1Ym1pc3Npb25faW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g
ICB7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2
YXRlOwo+ICAgCWNvbnN0IHNpemVfdCBjdHhzaXplID0gc2l6ZW9mKHN0cnVjdCBndWNfY29udGV4
dF9kZXNjKTsKPiAgIAljb25zdCBzaXplX3QgcG9vbHNpemUgPSBHVUNfTUFYX0dQVV9DT05URVhU
UyAqIGN0eHNpemU7Cj4gICAJY29uc3Qgc2l6ZV90IGdlbXNpemUgPSByb3VuZF91cChwb29sc2l6
ZSwgUEFHRV9TSVpFKTsKPiBAQCAtOTE2LDcgKzkxNSw3IEBAIGludCBpOTE1X2d1Y19zdWJtaXNz
aW9uX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPgo+ICAgCS8qIFdpcGUgYml0bWFwICYg
ZGVsZXRlIGNsaWVudCBpbiBjYXNlIG9mIHJlaW5pdGlhbGlzYXRpb24gKi8KPiAgIAliaXRtYXBf
Y2xlYXIoZ3VjLT5kb29yYmVsbF9iaXRtYXAsIDAsIEdVQ19NQVhfRE9PUkJFTExTKTsKPiAtCWk5
MTVfZ3VjX3N1Ym1pc3Npb25fZGlzYWJsZShkZXYpOwo+ICsJaTkxNV9ndWNfc3VibWlzc2lvbl9k
aXNhYmxlKGRldl9wcml2KTsKPgo+ICAgCWlmICghaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24p
Cj4gICAJCXJldHVybiAwOyAvKiBub3QgZW5hYmxlZCAgKi8KPiBAQCAtOTM1LDkgKzkzNCw4IEBA
IGludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAg
IAlyZXR1cm4gMDsKPiAgIH0KPgo+IC1pbnQgaTkxNV9ndWNfc3VibWlzc2lvbl9lbmFibGUoc3Ry
dWN0IGRybV9kZXZpY2UgKmRldikKPiAraW50IGk5MTVfZ3VjX3N1Ym1pc3Npb25fZW5hYmxlKHN0
cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIHsKPiAtCXN0cnVjdCBkcm1faTkx
NV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gICAJc3RydWN0IGludGVs
X2d1YyAqZ3VjID0gJmRldl9wcml2LT5ndWM7Cj4gICAJc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAq
Y2xpZW50Owo+Cj4gQEAgLTk1NywxOCArOTU1LDE2IEBAIGludCBpOTE1X2d1Y19zdWJtaXNzaW9u
X2VuYWJsZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgCXJldHVybiAwOwo+ICAgfQo+Cj4g
LXZvaWQgaTkxNV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYp
Cj4gK3ZvaWQgaTkxNV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdikKPiAgIHsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp
diA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gICAJc3RydWN0IGludGVsX2d1YyAqZ3VjID0gJmRldl9w
cml2LT5ndWM7Cj4KPiAgIAlndWNfY2xpZW50X2ZyZWUoZGV2X3ByaXYsIGd1Yy0+ZXhlY2J1Zl9j
bGllbnQpOwo+ICAgCWd1Yy0+ZXhlY2J1Zl9jbGllbnQgPSBOVUxMOwo+ICAgfQo+Cj4gLXZvaWQg
aTkxNV9ndWNfc3VibWlzc2lvbl9maW5pKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gK3ZvaWQg
aTkxNV9ndWNfc3VibWlzc2lvbl9maW5pKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp
dikKPiAgIHsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2
X3ByaXZhdGU7Cj4gICAJc3RydWN0IGludGVsX2d1YyAqZ3VjID0gJmRldl9wcml2LT5ndWM7Cj4K
PiAgIAlnZW1fcmVsZWFzZV9ndWNfb2JqKGRldl9wcml2LT5ndWMuYWRzX29iaik7Cj4gZGlmZiAt
LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZ3VjLmgKPiBpbmRleCA0MTYwMWM3Li40ZGY4MGNjIDEwMDY0NAo+IC0tLSBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZ3VjLmgKPiBAQCAtMTU2LDExICsxNTYsMTEgQEAgZXh0ZXJuIGludCBpbnRl
bF9ndWNfc3VzcGVuZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgIGV4dGVybiBpbnQgaW50
ZWxfZ3VjX3Jlc3VtZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPgo+ICAgLyogaTkxNV9ndWNf
c3VibWlzc2lvbi5jICovCj4gLWludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2luaXQoc3RydWN0IGRy
bV9kZXZpY2UgKmRldik7Cj4gLWludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2VuYWJsZShzdHJ1Y3Qg
ZHJtX2RldmljZSAqZGV2KTsKPiAraW50IGk5MTVfZ3VjX3N1Ym1pc3Npb25faW5pdChzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICtpbnQgaTkxNV9ndWNfc3VibWlzc2lvbl9l
bmFibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgIGludCBpOTE1X2d1
Y193cV9jaGVja19zcGFjZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxKTsKPiAgIGlu
dCBpOTE1X2d1Y19zdWJtaXQoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSk7Cj4gLXZv
aWQgaTkxNV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+
IC12b2lkIGk5MTVfZ3VjX3N1Ym1pc3Npb25fZmluaShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsK
PiArdm9pZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZh
dGUgKmRldl9wcml2KTsKPiArdm9pZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2Zpbmkoc3RydWN0IGRy
bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPgo+ICAgI2VuZGlmCj4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+IGluZGV4IDQxZjdjN2QuLmQyOTEzN2YgMTAwNjQ0Cj4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4gQEAgLTQ1Myw3ICs0NTMsNyBA
QCBpbnQgaW50ZWxfZ3VjX3NldHVwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAJCWludGVs
X2d1Y19md19zdGF0dXNfcmVwcihndWNfZnctPmd1Y19md19mZXRjaF9zdGF0dXMpLAo+ICAgCQlp
bnRlbF9ndWNfZndfc3RhdHVzX3JlcHIoZ3VjX2Z3LT5ndWNfZndfbG9hZF9zdGF0dXMpKTsKPgo+
IC0JZXJyID0gaTkxNV9ndWNfc3VibWlzc2lvbl9pbml0KGRldik7Cj4gKwllcnIgPSBpOTE1X2d1
Y19zdWJtaXNzaW9uX2luaXQoZGV2X3ByaXYpOwo+ICAgCWlmIChlcnIpCj4gICAJCWdvdG8gZmFp
bDsKPgo+IEBAIC00OTIsNyArNDkyLDcgQEAgaW50IGludGVsX2d1Y19zZXR1cChzdHJ1Y3QgZHJt
X2RldmljZSAqZGV2KQo+ICAgCQlpbnRlbF9ndWNfZndfc3RhdHVzX3JlcHIoZ3VjX2Z3LT5ndWNf
ZndfbG9hZF9zdGF0dXMpKTsKPgo+ICAgCWlmIChpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbikg
ewo+IC0JCWVyciA9IGk5MTVfZ3VjX3N1Ym1pc3Npb25fZW5hYmxlKGRldik7Cj4gKwkJZXJyID0g
aTkxNV9ndWNfc3VibWlzc2lvbl9lbmFibGUoZGV2X3ByaXYpOwo+ICAgCQlpZiAoZXJyKQo+ICAg
CQkJZ290byBmYWlsOwo+ICAgCQlkaXJlY3RfaW50ZXJydXB0c190b19ndWMoZGV2X3ByaXYpOwo+
IEBAIC01MDUsOCArNTA1LDggQEAgaW50IGludGVsX2d1Y19zZXR1cChzdHJ1Y3QgZHJtX2Rldmlj
ZSAqZGV2KQo+ICAgCQlndWNfZnctPmd1Y19md19sb2FkX3N0YXR1cyA9IEdVQ19GSVJNV0FSRV9G
QUlMOwo+Cj4gICAJZGlyZWN0X2ludGVycnVwdHNfdG9faG9zdChkZXZfcHJpdik7Cj4gLQlpOTE1
X2d1Y19zdWJtaXNzaW9uX2Rpc2FibGUoZGV2KTsKPiAtCWk5MTVfZ3VjX3N1Ym1pc3Npb25fZmlu
aShkZXYpOwo+ICsJaTkxNV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKGRldl9wcml2KTsKPiArCWk5
MTVfZ3VjX3N1Ym1pc3Npb25fZmluaShkZXZfcHJpdik7Cj4KPiAgIAkvKgo+ICAgCSAqIFdlJ3Zl
IGZhaWxlZCB0byBsb2FkIHRoZSBmaXJtd2FyZSA6KAo+IEBAIC03MzEsOCArNzMxLDggQEAgdm9p
ZCBpbnRlbF9ndWNfZmluaShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+Cj4gICAJbXV0ZXhfbG9j
aygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICAgCWRpcmVjdF9pbnRlcnJ1cHRzX3RvX2hvc3QoZGV2
X3ByaXYpOwo+IC0JaTkxNV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKGRldik7Cj4gLQlpOTE1X2d1
Y19zdWJtaXNzaW9uX2ZpbmkoZGV2KTsKPiArCWk5MTVfZ3VjX3N1Ym1pc3Npb25fZGlzYWJsZShk
ZXZfcHJpdik7Cj4gKwlpOTE1X2d1Y19zdWJtaXNzaW9uX2ZpbmkoZGV2X3ByaXYpOwo+Cj4gICAJ
aWYgKGd1Y19mdy0+Z3VjX2Z3X29iaikKPiAgIAkJZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2Uo
Jmd1Y19mdy0+Z3VjX2Z3X29iai0+YmFzZSk7Cj4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxp
biA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs
aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz
a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK