From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 6/6] drm/i915/guc: (re)initialise doorbell h/w when enabling GuC submission Date: Mon, 13 Jun 2016 11:22:11 +0100 Message-ID: <575E8953.9090800@linux.intel.com> References: <1465577461-35616-1-git-send-email-david.s.gordon@intel.com> <1465577461-35616-7-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AE626E4DD for ; Mon, 13 Jun 2016 10:22:13 +0000 (UTC) In-Reply-To: <1465577461-35616-7-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEwLzA2LzE2IDE3OjUxLCBEYXZlIEdvcmRvbiB3cm90ZToKPiBEdXJpbmcgYSBoaWJlcm5h dGUvcmVzdW1lIGN5Y2xlLCB0aGUgd2hvbGUgc3lzdGVtIGlzIHJlc2V0LCBpbmNsdWRpbmcKPiB0 aGUgR3VDIGFuZCB0aGUgZG9vcmJlbGwgaGFyZHdhcmUuIFRoZW4gdGhlIHN5c3RlbSBpcyBib290 ZWQgdXAsIGRyaXZlcnMKPiBhcmUgbG9hZGVkLCBldGMgLS0gdGhlIEd1QyBmaXJtd2FyZSBtYXkg YmUgbG9hZGVkIGFuZCBzZXQgcnVubmluZyBhdAo+IHRoaXMgcG9pbnQuIEJ1dCB0aGVuLCB0aGUg Ym9vdGVkIGtlcm5lbCBpcyByZXBsYWNlZCBieSB0aGUgaGliZXJuYXRlZAo+IGltYWdlLCBhbmQg dGhpcyByZXN1bWVkIGtlcm5lbCB3aWxsIGFsc28gdHJ5IHRvIHJlbG9hZCB0aGUgR3VDIGZpcm13 YXJlCj4gKHdoaWNoIHdpbGwgZmFpbCkuIFRvIHJlY292ZXIsIHdlIHJlc2V0IHRoZSBHdUMgYW5k IHRyeSBhZ2FpbiAod2hpY2gKPiBzaG91bGQgd29yaykuIEJ1dCB0aGlzIEd1QyByZXNldCBkb2Vz bid0IGFsc28gcmVzZXQgdGhlIGRvb3JiZWxsCj4gaGFyZHdhcmUsIHNvIGl0IGNhbiBiZSBsZWZ0 IGluIGEgc3RhdGUgaW5jb25zaXN0ZW50IHdpdGggdGhhdCBhc3N1bWVkCj4gYnkgdGhlIGRyaXZl ciBhbmQvb3IgdGhlIG5ld2x5LWxvYWRlZCBHdUMgZmlybXdhcmUuCj4KPiBJdCB3b3VsZCBiZSBi ZXR0ZXIgaWYgdGhlIEd1QyByZXNldCBhbHNvIGNsZWFyZWQgYWxsIGRvb3JiZWxsIHN0YXRlLAo+ IGJ1dCB0aGF0J3Mgbm90IGhvdyB0aGUgaGFyZHdhcmUgY3VycmVudGx5IHdvcmtzOyBhbHNvLCB0 aGUgZHJpdmVyIGNhbm5vdAo+IGRpcmVjdGx5IHJlcHJvZ3JhbSB0aGUgZG9vcmJlbGwgaGFyZHdh cmUgKG9ubHkgdGhlIEd1QyBjYW4gZG8gdGhhdCkuCj4KPiBTbyB0aGlzIHBhdGNoIGN5Y2xlcyB0 aHJvdWdoIGFsbCBkb29yYmVsbHMsIGFzc2lnbmluZyBhbmQgcmVsZWFzaW5nIGVhY2gKPiBpbiB0 dXJuLCBzbyB0aGF0IGFsbCB0aGUgZG9vcmJlbGwgaGFyZHdhcmUgaXMgbGVmdCBpbiBhIGNvbnNp c3RlbnQKPiBzdGF0ZSwgbm8gbWF0dGVyIGhvdyBpdCB3YXMgcHJvZ3JhbW1lZCBieSB0aGUgcHJl dmlvdXNseS1ydW5uaW5nIGtlcm5lbAo+IGFuZC9vciBHdUMgZmlybXdhcmUuCj4KPiB2MjogZG9u J3QgdXNlIGttYXBfYXRvbWljKCkgbm93IHRoYXQgY2xpZW50IHBhZ2UgMCBpcyBrZXB0IG1hcHBl ZC4KPgo+IFNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5j b20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMg fCA0NCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0 MyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gaW5kZXggMTgzM2JmZC4uMTIwZDJlOCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiBAQCAtNjk0LDYgKzY5 NCw0OCBAQCBzdGF0aWMgdm9pZCBndWNfY2xpZW50X2ZyZWUoc3RydWN0IGRybV9kZXZpY2UgKmRl diwKPiAgIAlrZnJlZShjbGllbnQpOwo+ICAgfQo+Cj4gKy8qCj4gKyAqIEJvcnJvdyB0aGUgZmly c3QgY2xpZW50IHRvIHNldCB1cCAmIHRlYXIgZG93biBldmVyeSBkb29yYmVsbAo+ICsgKiBpbiB0 dXJuLCB0byBlbnN1cmUgdGhhdCBhbGwgZG9vcmJlbGwgaC93IGlzIChyZSlpbml0aWFsaXNlZC4K PiArICovCj4gK3N0YXRpYyB2b2lkIGd1Y19pbml0X2Rvb3JiZWxsX2h3KHN0cnVjdCBpbnRlbF9n dWMgKmd1YykKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3Vj X3RvX2k5MTUoZ3VjKTsKPiArCXN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCA9IGd1Yy0+ ZXhlY2J1Zl9jbGllbnQ7Cj4gKwl1aW50MTZfdCBkYl9pZCwgaTsKPiArCWludCBlcnI7Cj4gKwo+ ICsJZGJfaWQgPSBjbGllbnQtPmRvb3JiZWxsX2lkOwo+ICsKPiArCWZvciAoaSA9IDA7IGkgPCBH VUNfTUFYX0RPT1JCRUxMUzsgKytpKSB7Cj4gKwkJaTkxNV9yZWdfdCBkcmJyZWcgPSBHRU44X0RS QlJFR0woaSk7Cj4gKwkJdTMyIHZhbHVlID0gSTkxNV9SRUFEKGRyYnJlZyk7Cj4gKwo+ICsJCWVy ciA9IGd1Y191cGRhdGVfZG9vcmJlbGxfaWQoZ3VjLCBjbGllbnQsIGkpOwo+ICsKPiArCQkvKiBS ZXBvcnQgdXBkYXRlIGZhaWx1cmUgb3IgdW5leHBlY3RlZGx5IGFjdGl2ZSBkb29yYmVsbCAqLwo+ ICsJCWlmIChlcnIgfHwgKGkgIT0gZGJfaWQgJiYgKHZhbHVlICYgR1VDX0RPT1JCRUxMX0VOQUJM RUQpKSkKPiArCQkJRFJNX0RFQlVHX0RSSVZFUigiRG9vcmJlbGwgJWQgKHJlZyAweCV4KSB3YXMg MHgleCwgZXJyICVkXG4iLAo+ICsJCQkJCSAgaSwgZHJicmVnLnJlZywgdmFsdWUsIGVycik7Cj4g Kwl9Cj4gKwo+ICsJLyogUmVzdG9yZSB0byBvcmlnaW5hbCB2YWx1ZSAqLwo+ICsJZXJyID0gZ3Vj X3VwZGF0ZV9kb29yYmVsbF9pZChndWMsIGNsaWVudCwgZGJfaWQpOwo+ICsJaWYgKGVycikKPiAr CQlEUk1fRVJST1IoIkZhaWxlZCB0byByZXN0b3JlIGRvb3JiZWxsIHRvICVkLCBlcnIgJWRcbiIs Cj4gKwkJCWRiX2lkLCBlcnIpOwo+ICsKPiArCWZvciAoaSA9IDA7IGkgPCBHVUNfTUFYX0RPT1JC RUxMUzsgKytpKSB7Cj4gKwkJaTkxNV9yZWdfdCBkcmJyZWcgPSBHRU44X0RSQlJFR0woaSk7Cj4g KwkJdTMyIHZhbHVlID0gSTkxNV9SRUFEKGRyYnJlZyk7Cj4gKwo+ICsJCWlmIChpICE9IGRiX2lk ICYmICh2YWx1ZSAmIEdVQ19ET09SQkVMTF9FTkFCTEVEKSkKPiArCQkJRFJNX0RFQlVHX0RSSVZF UigiRG9vcmJlbGwgJWQgKHJlZyAweCV4KSBmaW5hbGx5IDB4JXhcbiIsCj4gKwkJCQkJICBpLCBk cmJyZWcucmVnLCB2YWx1ZSk7Cj4gKwo+ICsJfQo+ICt9Cj4gKwo+ICAgLyoqCj4gICAgKiBndWNf Y2xpZW50X2FsbG9jKCkgLSBBbGxvY2F0ZSBhbiBpOTE1X2d1Y19jbGllbnQKPiAgICAqIEBkZXY6 CWRybSBkZXZpY2UKPiBAQCAtOTU5LDggKzEwMDEsOCBAQCBpbnQgaTkxNV9ndWNfc3VibWlzc2lv bl9lbmFibGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgIAl9Cj4KPiAgIAlndWMtPmV4ZWNi dWZfY2xpZW50ID0gY2xpZW50Owo+IC0KPiAgIAlob3N0Mmd1Y19zYW1wbGVfZm9yY2V3YWtlKGd1 YywgY2xpZW50KTsKPiArCWd1Y19pbml0X2Rvb3JiZWxsX2h3KGd1Yyk7Cj4KPiAgIAlyZXR1cm4g MDsKPiAgIH0KPgoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBp bnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK