From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH v2 5/6] drm/i915/guc: refactor doorbell
	management code
Date: Mon, 13 Jun 2016 16:59:25 +0100
Message-ID: <575ED85D.7050509@intel.com>
References: <1465577461-35616-1-git-send-email-david.s.gordon@intel.com>
 <1465577461-35616-6-git-send-email-david.s.gordon@intel.com>
 <575E8162.2010302@linux.intel.com> <575E8A13.4000902@intel.com>
 <575E909A.5010807@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 425036E49C
 for <intel-gfx@lists.freedesktop.org>; Mon, 13 Jun 2016 15:59:28 +0000 (UTC)
In-Reply-To: <575E909A.5010807@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMTMvMDYvMTYgMTE6NTMsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMTMvMDYvMTYg
MTE6MjUsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBPbiAxMy8wNi8xNiAxMDo0OCwgVHZydGtvIFVy
c3VsaW4gd3JvdGU6Cj4+Pgo+Pj4gT24gMTAvMDYvMTYgMTc6NTEsIERhdmUgR29yZG9uIHdyb3Rl
Ogo+Pj4+IFRoaXMgcGF0Y2ggcmVmYWN0b3JzIHRoZSBkcml2ZXIncyBoYW5kbGluZyBhbmQgdHJh
Y2tpbmcgb2YKPj4+PiBkb29yYmVsbHMsIGluCj4+Pj4gcHJlcGFyYXRpb24gZm9yIGEgbGF0ZXIg
b25lIHdoaWNoIHdpbGwgcmVzb2x2ZSBhIHN1c3BlbmQtcmVzdW1lIGlzc3VlLgo+Pj4+Cj4+Pj4g
VGhlcmUgYXJlIHRocmVlIHJlc291cmNlcyB0byBiZSBtYW5hZ2VkOgo+Pj4+IDEuIENhY2hlbGlu
ZXM6IGEgc2luZ2xlIGxpbmUgd2l0aGluIHRoZSBjbGllbnQtb2JqZWN0J3MgcGFnZSAwCj4+Pj4g
ICAgIGlzIHNub29wZWQgYnkgZG9vcmJlbGwgaGFyZHdhcmUgZm9yIHdyaXRlcyBmcm9tIHRoZSBo
b3N0Lgo+Pj4+IDIuIERvb3JiZWxsIHJlZ2lzdGVyczogZWFjaCBkZWZpbmVzIG9uZSBjYWNoZWxp
bmUgdG8gYmUgc25vb3BlZC4KPj4+PiAzLiBCaXRtYXA6IHRyYWNrcyB3aGljaCBkb29yYmVsbCBy
ZWdpc3RlcnMgYXJlIGluIHVzZS4KPj4+Pgo+Pj4+IFRoZSBkb29yYmVsbCBzZXR1cC90ZWFyZG93
biBwcm90b2NvbCBzdGFydHMgd2l0aDoKPj4+PiAxLiBQaWNrIGEgY2FjaGVsaW5lOiBzZWxlY3Rf
ZG9vcmJlbGxfY2FjaGVsaW5lKCkKPj4+PiAyLiBGaW5kIGFuIGF2YWlsYWJsZSBkb29yYmVsbCBy
ZWdpc3RlcjogYXNzaWduX2Rvb3JiZWxsKCkKPj4+PiAoVGhlc2UgdmFsdWVzIGFyZSBwYXNzZWQg
dG8gdGhlIEd1QyB2aWEgdGhlIHNoYXJlZCBjb250ZXh0Cj4+Pj4gZGVzY3JpcHRvcjsgdGhpcyBw
YXJ0IG9mIHRoZSBzZXF1ZW5jZSByZW1haW5zIHVuY2hhbmdlZCkuCj4+Pj4KPj4+PiAzLiBVcGRh
dGUgdGhlIGJpdG1hcCB0byByZWZsZWN0IHJlZ2lzdGVycy1pbi11c2UKPj4+PiA0LiBQcmVwYXJl
IHRoZSBjYWNoZWxpbmUgZm9yIHVzZSBieSBzZXR0aW5nIGl0cyBzdGF0dXMgdG8gRU5BQkxFRAo+
Pj4+IDUuIEFzayB0aGUgR3VDIHRvIHByb2dyYW0gdGhlIGRvb3JiZWxsIHRvIHNub29wIHRoZSBj
YWNoZWxpbmUKPj4+Pgo+Pj4+IGFuZCBvZiBjb3Vyc2UgdGVhcmRvd24gaXMgdmVyeSBzaW1pbGFy
Ogo+Pj4+IDYuIFNldCB0aGUgY2FjaGVsaW5lIHRvIERJU0FCTEVECj4+Pj4gNy4gQXNrIHRoZSBH
dUMgdG8gcmVwcm9ncmFtIHRoZSBkb29yYmVsbCB0byBzdG9wIHNub29waW5nCj4+Pj4gOC4gUmVj
b3JkIHRoYXQgdGhlIGRvb3JiZWxsIGlzIG5vdCBpbiB1c2UuCj4+Pj4KPj4+PiBPcGVyYXRpb25z
IDYtOCAoZ3VjX2Rpc2FibGVfZG9vcmJlbGwoKSwgaG9zdDJndWNfcmVsZWFzZV9kb29yYmVsbCgp
LAo+Pj4+IGFuZAo+Pj4+IHJlbGVhc2VfZG9vcmJlbGwoKSkgd2VyZSBjYWxsZWQgaW4gc2VxdWVu
Y2UgZnJvbSBndWNfY2xpZW50X2ZyZWUoKSwgYnV0Cj4+Pj4gYXJlIG5vdyBtb3ZlZCBpbnRvIHRo
ZSB0ZWFyZG93biBwaGFzZSBvZiB0aGUgY29tbW9uIGZ1bmN0aW9uLgo+Pj4+Cj4+Pj4gU3RlcHMg
NC01IChndWNfaW5pdF9kb29yYmVsbCgpIGFuZCBob3N0Mmd1Y19hbGxvY2F0ZV9kb29yYmVsbCgp
KSB3ZXJlCj4+Pj4gc2ltaWxhcmx5IGRvbmUgYXMgc2VxdWVudGlhbCBzdGVwcyBpbiBndWNfY2xp
ZW50X2FsbG9jKCksIGJ1dCBzaW5jZSBpdAo+Pj4+IHR1cm5zIG91dCB0aGF0IHdlIGRvbid0IG5l
ZWQgdG8gYmUgYWJsZSB0byBkbyB0aGVtIHNlcGFyYXRlbHkgdGhleSdyZQo+Pj4+IG5vdyBjb2xs
ZWN0ZWQgaW50byB0aGUgc2V0dXAgcGhhc2Ugb2YgdGhlIGNvbW1vbiBmdW5jdGlvbi4KPj4+Pgo+
Pj4+IFRoZSBvbmx5IG5ldyBjb2RlIChhbmQgbmV3IGNhcGFiaWxpdHkpIGlzIHRoZSBibG9jayB0
YWdnZWQKPj4+PiAgICAgIC8qIFVwZGF0ZSB0aGUgR3VDJ3MgaWRlYSBvZiB0aGUgZG9vcmJlbGwg
SUQgKi8KPj4+PiBpLmUuIHdlIGNhbiBub3cgKmNoYW5nZSogdGhlIGRvb3JiZWxsIHJlZ2lzdGVy
IHVzZWQgYnkgYW4gZXhpc3RpbmcKPj4+PiBjbGllbnQsIHdoZXJlYXMgcHJldmlvdXNseSBpdCB3
YXMgc2V0IG9uY2UgZm9yIHRoZSBlbnRpcmUgbGlmZXRpbWUKPj4+PiBvZiB0aGUgY2xpZW50LiBX
ZSB3aWxsIHVzZSB0aGlzIG5ldyBmZWF0dXJlIGluIHRoZSBuZXh0IHBhdGNoLgo+Pj4+Cj4+Pj4g
djI6IFRyaXZpYWwgaW5kZXBlbmRlbnQgZml4ZXMgcHVzaGVkIGFoZWFkIGFzIHNlcGFyYXRlIHBh
dGNoZXMuCj4+Pj4gICAgICBNVUNIIGxvbmdlciBjb21taXQgbWVzc2FnZSA6KSBbVHZydGtvIFVy
c3VsaW5dCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jk
b25AaW50ZWwuY29tPgo+Pj4+IC0tLQo+Pj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n
dWNfc3VibWlzc2lvbi5jIHwgOTQKPj4+PiArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0K
Pj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCA1MyBpbnNlcnRpb25zKCspLCA0MSBkZWxldGlvbnMoLSkK
Pj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJt
aXNzaW9uLmMKPj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24u
Ywo+Pj4+IGluZGV4IDQ1YjMzZjguLjE4MzNiZmQgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+Pj4gQEAgLTE3NCwzMSArMTc0LDU5IEBA
IHN0YXRpYyBpbnQgaG9zdDJndWNfc2FtcGxlX2ZvcmNld2FrZShzdHJ1Y3QKPj4+PiBpbnRlbF9n
dWMgKmd1YywKPj4+PiAgICAqIGNsaWVudCBvYmplY3Qgd2hpY2ggY29udGFpbnMgdGhlIHBhZ2Ug
YmVpbmcgdXNlZCBmb3IgdGhlIGRvb3JiZWxsCj4+Pj4gICAgKi8KPj4+Pgo+Pj4+IC1zdGF0aWMg
dm9pZCBndWNfaW5pdF9kb29yYmVsbChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsCj4+Pj4gLSAgICAg
ICAgICAgICAgICAgIHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCkKPj4+PiArc3RhdGlj
IGludCBndWNfdXBkYXRlX2Rvb3JiZWxsX2lkKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywKPj4+PiAr
ICAgICAgICAgICAgICAgICAgc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50LAo+Pj4+ICsg
ICAgICAgICAgICAgICAgICB1MTYgbmV3X2lkKQo+Pj4+ICAgewo+Pj4+ICsgICAgc3RydWN0IHNn
X3RhYmxlICpzZyA9IGd1Yy0+Y3R4X3Bvb2xfb2JqLT5wYWdlczsKPj4+PiArICAgIHZvaWQgKmRv
b3JiZWxsX2JpdG1hcCA9IGd1Yy0+ZG9vcmJlbGxfYml0bWFwOwo+Pj4+ICAgICAgIHN0cnVjdCBn
dWNfZG9vcmJlbGxfaW5mbyAqZG9vcmJlbGw7Cj4+Pj4gKyAgICBzdHJ1Y3QgZ3VjX2NvbnRleHRf
ZGVzYyBkZXNjOwo+Pj4+ICsgICAgc2l6ZV90IGxlbjsKPj4+Pgo+Pj4+ICAgICAgIGRvb3JiZWxs
ID0gY2xpZW50LT5jbGllbnRfYmFzZSArIGNsaWVudC0+ZG9vcmJlbGxfb2Zmc2V0Owo+Pj4+Cj4+
Pj4gLSAgICBkb29yYmVsbC0+ZGJfc3RhdHVzID0gR1VDX0RPT1JCRUxMX0VOQUJMRUQ7Cj4+Pj4g
KyAgICBpZiAoY2xpZW50LT5kb29yYmVsbF9pZCAhPSBHVUNfSU5WQUxJRF9ET09SQkVMTF9JRCAm
Jgo+Pj4+ICsgICAgICAgIHRlc3RfYml0KGNsaWVudC0+ZG9vcmJlbGxfaWQsIGRvb3JiZWxsX2Jp
dG1hcCkpIHsKPj4+PiArICAgICAgICAvKiBEZWFjdGl2YXRlIHRoZSBvbGQgZG9vcmJlbGwgKi8K
Pj4+PiArICAgICAgICBkb29yYmVsbC0+ZGJfc3RhdHVzID0gR1VDX0RPT1JCRUxMX0RJU0FCTEVE
Owo+Pj4+ICsgICAgICAgICh2b2lkKWhvc3QyZ3VjX3JlbGVhc2VfZG9vcmJlbGwoZ3VjLCBjbGll
bnQpOwo+Pj4+ICsgICAgICAgIF9fY2xlYXJfYml0KGNsaWVudC0+ZG9vcmJlbGxfaWQsIGRvb3Ji
ZWxsX2JpdG1hcCk7Cj4+Pj4gKyAgICB9Cj4+Pj4gKwo+Pj4+ICsgICAgLyogVXBkYXRlIHRoZSBH
dUMncyBpZGVhIG9mIHRoZSBkb29yYmVsbCBJRCAqLwo+Pj4+ICsgICAgbGVuID0gc2dfcGNvcHlf
dG9fYnVmZmVyKHNnLT5zZ2wsIHNnLT5uZW50cywgJmRlc2MsIHNpemVvZihkZXNjKSwKPj4+PiAr
ICAgICAgICAgICAgICAgICBzaXplb2YoZGVzYykgKiBjbGllbnQtPmN0eF9pbmRleCk7Cj4+Pj4g
KyAgICBpZiAobGVuICE9IHNpemVvZihkZXNjKSkKPj4+PiArICAgICAgICByZXR1cm4gLUVGQVVM
VDsKPj4+PiArICAgIGRlc2MuZGJfaWQgPSBuZXdfaWQ7Cj4+Pj4gKyAgICBsZW4gPSBzZ19wY29w
eV9mcm9tX2J1ZmZlcihzZy0+c2dsLCBzZy0+bmVudHMsICZkZXNjLAo+Pj4+IHNpemVvZihkZXNj
KSwKPj4+PiArICAgICAgICAgICAgICAgICBzaXplb2YoZGVzYykgKiBjbGllbnQtPmN0eF9pbmRl
eCk7Cj4+Pj4gKyAgICBpZiAobGVuICE9IHNpemVvZihkZXNjKSkKPj4+PiArICAgICAgICByZXR1
cm4gLUVGQVVMVDsKPj4+PiArCj4+Pj4gKyAgICBjbGllbnQtPmRvb3JiZWxsX2lkID0gbmV3X2lk
Owo+Pj4+ICsgICAgaWYgKG5ld19pZCA9PSBHVUNfSU5WQUxJRF9ET09SQkVMTF9JRCkKPj4+PiAr
ICAgICAgICByZXR1cm4gMDsKPj4+PiArCj4+Pj4gKyAgICAvKiBBY3RpdmF0ZSB0aGUgbmV3IGRv
b3JiZWxsICovCj4+Pj4gKyAgICBfX3NldF9iaXQobmV3X2lkLCBkb29yYmVsbF9iaXRtYXApOwo+
Pj4KPj4+IElzIHRoaXMgdGhlIHNhbWUgYml0IGFzIGluIGFzc2lnbl9kb29yYmVsbCBzbyByZWR1
bmRhbnQ/Cj4+Cj4+IEl0IGlzIHRoZSBzYW1lIGJpdCwgYW5kIHllcywgaXQgd2lsbCBiZSByZWR1
bmRhbnQgZHVyaW5nIHRoZSBpbml0aWFsCj4+IHNldHVwLCBidXQgd2hlbiB3ZSBjb21lIHRvICpy
ZSphc3NpZ24gdGhlIGFzc29jaWF0aW9uIGJldHdlZW4gYSBjbGllbnQKPj4gYW5kIGEgZG9vcmJl
bGwgKGluIHRoZSBuZXh0IHBhdGNoKSB0aGVuIGl0IHdvbid0IGJlLgo+Pgo+PiBXZSBjb3VsZCBh
bHNvIGNob29zZSB0byBoYXZlIGFzc2lnbl9kb29yYmVsbCgpIE5PVCB1cGRhdGUgdGhlIG1hcCwg
c28KPj4gdGhlbiB0aGlzIHdvdWxkIGJlIHRoZSBvbmx5IHBsYWNlIHdoZXJlIHRoZSBiaXRtYXAg
Z2V0cyB1cGRhdGVkLiBJJ2QKPj4gaGF2ZSB0byByZW5hbWUgaXQgdGhvdWdoLCBhcyBpdCB3b3Vs
ZCBubyBsb25nZXIgYmUgYXNzaWduaW5nIGFueXRoaW5nIQo+Cj4gTWF5YmUgcGlja19kb29yYmVs
bCBvciBmaW5kX2ZyZWVfZG9vcmJlbGw/IEl0IHdvdWxkIGJlIGEgbGl0dGxlIGJpdAo+IGNsZWFy
ZXIgYW5kIHNhZmVyIChlYXJseSByZXR1cm5zIGFib3ZlIGNvdWxkIGxlYXZlIHRoZSBiaXRtYXAg
c2V0KSB3aXRoCj4gYSBzaW5nbGUgYml0bWFwIHVwZGF0ZSBsb2NhdGlvbiBzbyBJIHRoaW5rIGl0
IHdvdWxkIGJlIHdvcnRoIGl0Lgo+Cj4gUmVnYXJkcywKPiBUdnJ0a28KClJvZ2VyIHdpbGNvLCBi
dXQgaXQgbG9va3Mgc2ltcGxlciBpZiBJIG1ha2UgaXQgYSBmb2xsb3d1cCBbNy82XT8KT3RoZXJ3
aXNlIChpZiBJIG1peCBpdCBpbnRvIHRoaXMgcmV3b3JrKSBnaXQgc2NyYW1ibGVzIHRoZSBkaWZm
CmFyb3VuZCBzbyBpdHMgbGVzcyBlYXN5IHRvIHNlZSBob3cgdGhlIGNvZGUgd2FzIHJlb3JnYW5p
c2VkLgoKVXBkYXRlIHBhdGNoIHdpbGwgZm9sbG93IHNvb24gLi4uCgouRGF2ZS4KX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg
bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl
c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==