From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH v2 5/6] drm/i915/guc: refactor doorbell
	management code
Date: Mon, 13 Jun 2016 17:04:31 +0100
Message-ID: <575ED98F.2070202@linux.intel.com>
References: <1465577461-35616-1-git-send-email-david.s.gordon@intel.com>
 <1465577461-35616-6-git-send-email-david.s.gordon@intel.com>
 <575E8162.2010302@linux.intel.com> <575E8A13.4000902@intel.com>
 <575E909A.5010807@linux.intel.com> <575ED85D.7050509@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTP id BA3AB6E649
 for <intel-gfx@lists.freedesktop.org>; Mon, 13 Jun 2016 16:05:11 +0000 (UTC)
In-Reply-To: <575ED85D.7050509@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDEzLzA2LzE2IDE2OjU5LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBPbiAxMy8wNi8xNiAxMTo1
MywgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IE9uIDEzLzA2LzE2IDExOjI1LCBEYXZlIEdv
cmRvbiB3cm90ZToKPj4+IE9uIDEzLzA2LzE2IDEwOjQ4LCBUdnJ0a28gVXJzdWxpbiB3cm90ZToK
Pj4+Pgo+Pj4+IE9uIDEwLzA2LzE2IDE3OjUxLCBEYXZlIEdvcmRvbiB3cm90ZToKPj4+Pj4gVGhp
cyBwYXRjaCByZWZhY3RvcnMgdGhlIGRyaXZlcidzIGhhbmRsaW5nIGFuZCB0cmFja2luZyBvZgo+
Pj4+PiBkb29yYmVsbHMsIGluCj4+Pj4+IHByZXBhcmF0aW9uIGZvciBhIGxhdGVyIG9uZSB3aGlj
aCB3aWxsIHJlc29sdmUgYSBzdXNwZW5kLXJlc3VtZSBpc3N1ZS4KPj4+Pj4KPj4+Pj4gVGhlcmUg
YXJlIHRocmVlIHJlc291cmNlcyB0byBiZSBtYW5hZ2VkOgo+Pj4+PiAxLiBDYWNoZWxpbmVzOiBh
IHNpbmdsZSBsaW5lIHdpdGhpbiB0aGUgY2xpZW50LW9iamVjdCdzIHBhZ2UgMAo+Pj4+PiAgICAg
aXMgc25vb3BlZCBieSBkb29yYmVsbCBoYXJkd2FyZSBmb3Igd3JpdGVzIGZyb20gdGhlIGhvc3Qu
Cj4+Pj4+IDIuIERvb3JiZWxsIHJlZ2lzdGVyczogZWFjaCBkZWZpbmVzIG9uZSBjYWNoZWxpbmUg
dG8gYmUgc25vb3BlZC4KPj4+Pj4gMy4gQml0bWFwOiB0cmFja3Mgd2hpY2ggZG9vcmJlbGwgcmVn
aXN0ZXJzIGFyZSBpbiB1c2UuCj4+Pj4+Cj4+Pj4+IFRoZSBkb29yYmVsbCBzZXR1cC90ZWFyZG93
biBwcm90b2NvbCBzdGFydHMgd2l0aDoKPj4+Pj4gMS4gUGljayBhIGNhY2hlbGluZTogc2VsZWN0
X2Rvb3JiZWxsX2NhY2hlbGluZSgpCj4+Pj4+IDIuIEZpbmQgYW4gYXZhaWxhYmxlIGRvb3JiZWxs
IHJlZ2lzdGVyOiBhc3NpZ25fZG9vcmJlbGwoKQo+Pj4+PiAoVGhlc2UgdmFsdWVzIGFyZSBwYXNz
ZWQgdG8gdGhlIEd1QyB2aWEgdGhlIHNoYXJlZCBjb250ZXh0Cj4+Pj4+IGRlc2NyaXB0b3I7IHRo
aXMgcGFydCBvZiB0aGUgc2VxdWVuY2UgcmVtYWlucyB1bmNoYW5nZWQpLgo+Pj4+Pgo+Pj4+PiAz
LiBVcGRhdGUgdGhlIGJpdG1hcCB0byByZWZsZWN0IHJlZ2lzdGVycy1pbi11c2UKPj4+Pj4gNC4g
UHJlcGFyZSB0aGUgY2FjaGVsaW5lIGZvciB1c2UgYnkgc2V0dGluZyBpdHMgc3RhdHVzIHRvIEVO
QUJMRUQKPj4+Pj4gNS4gQXNrIHRoZSBHdUMgdG8gcHJvZ3JhbSB0aGUgZG9vcmJlbGwgdG8gc25v
b3AgdGhlIGNhY2hlbGluZQo+Pj4+Pgo+Pj4+PiBhbmQgb2YgY291cnNlIHRlYXJkb3duIGlzIHZl
cnkgc2ltaWxhcjoKPj4+Pj4gNi4gU2V0IHRoZSBjYWNoZWxpbmUgdG8gRElTQUJMRUQKPj4+Pj4g
Ny4gQXNrIHRoZSBHdUMgdG8gcmVwcm9ncmFtIHRoZSBkb29yYmVsbCB0byBzdG9wIHNub29waW5n
Cj4+Pj4+IDguIFJlY29yZCB0aGF0IHRoZSBkb29yYmVsbCBpcyBub3QgaW4gdXNlLgo+Pj4+Pgo+
Pj4+PiBPcGVyYXRpb25zIDYtOCAoZ3VjX2Rpc2FibGVfZG9vcmJlbGwoKSwgaG9zdDJndWNfcmVs
ZWFzZV9kb29yYmVsbCgpLAo+Pj4+PiBhbmQKPj4+Pj4gcmVsZWFzZV9kb29yYmVsbCgpKSB3ZXJl
IGNhbGxlZCBpbiBzZXF1ZW5jZSBmcm9tIGd1Y19jbGllbnRfZnJlZSgpLAo+Pj4+PiBidXQKPj4+
Pj4gYXJlIG5vdyBtb3ZlZCBpbnRvIHRoZSB0ZWFyZG93biBwaGFzZSBvZiB0aGUgY29tbW9uIGZ1
bmN0aW9uLgo+Pj4+Pgo+Pj4+PiBTdGVwcyA0LTUgKGd1Y19pbml0X2Rvb3JiZWxsKCkgYW5kIGhv
c3QyZ3VjX2FsbG9jYXRlX2Rvb3JiZWxsKCkpIHdlcmUKPj4+Pj4gc2ltaWxhcmx5IGRvbmUgYXMg
c2VxdWVudGlhbCBzdGVwcyBpbiBndWNfY2xpZW50X2FsbG9jKCksIGJ1dCBzaW5jZSBpdAo+Pj4+
PiB0dXJucyBvdXQgdGhhdCB3ZSBkb24ndCBuZWVkIHRvIGJlIGFibGUgdG8gZG8gdGhlbSBzZXBh
cmF0ZWx5IHRoZXkncmUKPj4+Pj4gbm93IGNvbGxlY3RlZCBpbnRvIHRoZSBzZXR1cCBwaGFzZSBv
ZiB0aGUgY29tbW9uIGZ1bmN0aW9uLgo+Pj4+Pgo+Pj4+PiBUaGUgb25seSBuZXcgY29kZSAoYW5k
IG5ldyBjYXBhYmlsaXR5KSBpcyB0aGUgYmxvY2sgdGFnZ2VkCj4+Pj4+ICAgICAgLyogVXBkYXRl
IHRoZSBHdUMncyBpZGVhIG9mIHRoZSBkb29yYmVsbCBJRCAqLwo+Pj4+PiBpLmUuIHdlIGNhbiBu
b3cgKmNoYW5nZSogdGhlIGRvb3JiZWxsIHJlZ2lzdGVyIHVzZWQgYnkgYW4gZXhpc3RpbmcKPj4+
Pj4gY2xpZW50LCB3aGVyZWFzIHByZXZpb3VzbHkgaXQgd2FzIHNldCBvbmNlIGZvciB0aGUgZW50
aXJlIGxpZmV0aW1lCj4+Pj4+IG9mIHRoZSBjbGllbnQuIFdlIHdpbGwgdXNlIHRoaXMgbmV3IGZl
YXR1cmUgaW4gdGhlIG5leHQgcGF0Y2guCj4+Pj4+Cj4+Pj4+IHYyOiBUcml2aWFsIGluZGVwZW5k
ZW50IGZpeGVzIHB1c2hlZCBhaGVhZCBhcyBzZXBhcmF0ZSBwYXRjaGVzLgo+Pj4+PiAgICAgIE1V
Q0ggbG9uZ2VyIGNvbW1pdCBtZXNzYWdlIDopIFtUdnJ0a28gVXJzdWxpbl0KPj4+Pj4KPj4+Pj4g
U2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPj4+
Pj4gLS0tCj4+Pj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5j
IHwgOTQKPj4+Pj4gKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4+Pj4+ICAgMSBmaWxl
IGNoYW5nZWQsIDUzIGluc2VydGlvbnMoKyksIDQxIGRlbGV0aW9ucygtKQo+Pj4+Pgo+Pj4+PiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+
Pj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+Pj4+IGlu
ZGV4IDQ1YjMzZjguLjE4MzNiZmQgMTAwNjQ0Cj4+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4+Pj4gQEAgLTE3NCwzMSArMTc0LDU5IEBAIHN0YXRp
YyBpbnQgaG9zdDJndWNfc2FtcGxlX2ZvcmNld2FrZShzdHJ1Y3QKPj4+Pj4gaW50ZWxfZ3VjICpn
dWMsCj4+Pj4+ICAgICogY2xpZW50IG9iamVjdCB3aGljaCBjb250YWlucyB0aGUgcGFnZSBiZWlu
ZyB1c2VkIGZvciB0aGUgZG9vcmJlbGwKPj4+Pj4gICAgKi8KPj4+Pj4KPj4+Pj4gLXN0YXRpYyB2
b2lkIGd1Y19pbml0X2Rvb3JiZWxsKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywKPj4+Pj4gLSAgICAg
ICAgICAgICAgICAgIHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCkKPj4+Pj4gK3N0YXRp
YyBpbnQgZ3VjX3VwZGF0ZV9kb29yYmVsbF9pZChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsCj4+Pj4+
ICsgICAgICAgICAgICAgICAgICBzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQsCj4+Pj4+
ICsgICAgICAgICAgICAgICAgICB1MTYgbmV3X2lkKQo+Pj4+PiAgIHsKPj4+Pj4gKyAgICBzdHJ1
Y3Qgc2dfdGFibGUgKnNnID0gZ3VjLT5jdHhfcG9vbF9vYmotPnBhZ2VzOwo+Pj4+PiArICAgIHZv
aWQgKmRvb3JiZWxsX2JpdG1hcCA9IGd1Yy0+ZG9vcmJlbGxfYml0bWFwOwo+Pj4+PiAgICAgICBz
dHJ1Y3QgZ3VjX2Rvb3JiZWxsX2luZm8gKmRvb3JiZWxsOwo+Pj4+PiArICAgIHN0cnVjdCBndWNf
Y29udGV4dF9kZXNjIGRlc2M7Cj4+Pj4+ICsgICAgc2l6ZV90IGxlbjsKPj4+Pj4KPj4+Pj4gICAg
ICAgZG9vcmJlbGwgPSBjbGllbnQtPmNsaWVudF9iYXNlICsgY2xpZW50LT5kb29yYmVsbF9vZmZz
ZXQ7Cj4+Pj4+Cj4+Pj4+IC0gICAgZG9vcmJlbGwtPmRiX3N0YXR1cyA9IEdVQ19ET09SQkVMTF9F
TkFCTEVEOwo+Pj4+PiArICAgIGlmIChjbGllbnQtPmRvb3JiZWxsX2lkICE9IEdVQ19JTlZBTElE
X0RPT1JCRUxMX0lEICYmCj4+Pj4+ICsgICAgICAgIHRlc3RfYml0KGNsaWVudC0+ZG9vcmJlbGxf
aWQsIGRvb3JiZWxsX2JpdG1hcCkpIHsKPj4+Pj4gKyAgICAgICAgLyogRGVhY3RpdmF0ZSB0aGUg
b2xkIGRvb3JiZWxsICovCj4+Pj4+ICsgICAgICAgIGRvb3JiZWxsLT5kYl9zdGF0dXMgPSBHVUNf
RE9PUkJFTExfRElTQUJMRUQ7Cj4+Pj4+ICsgICAgICAgICh2b2lkKWhvc3QyZ3VjX3JlbGVhc2Vf
ZG9vcmJlbGwoZ3VjLCBjbGllbnQpOwo+Pj4+PiArICAgICAgICBfX2NsZWFyX2JpdChjbGllbnQt
PmRvb3JiZWxsX2lkLCBkb29yYmVsbF9iaXRtYXApOwo+Pj4+PiArICAgIH0KPj4+Pj4gKwo+Pj4+
PiArICAgIC8qIFVwZGF0ZSB0aGUgR3VDJ3MgaWRlYSBvZiB0aGUgZG9vcmJlbGwgSUQgKi8KPj4+
Pj4gKyAgICBsZW4gPSBzZ19wY29weV90b19idWZmZXIoc2ctPnNnbCwgc2ctPm5lbnRzLCAmZGVz
Yywgc2l6ZW9mKGRlc2MpLAo+Pj4+PiArICAgICAgICAgICAgICAgICBzaXplb2YoZGVzYykgKiBj
bGllbnQtPmN0eF9pbmRleCk7Cj4+Pj4+ICsgICAgaWYgKGxlbiAhPSBzaXplb2YoZGVzYykpCj4+
Pj4+ICsgICAgICAgIHJldHVybiAtRUZBVUxUOwo+Pj4+PiArICAgIGRlc2MuZGJfaWQgPSBuZXdf
aWQ7Cj4+Pj4+ICsgICAgbGVuID0gc2dfcGNvcHlfZnJvbV9idWZmZXIoc2ctPnNnbCwgc2ctPm5l
bnRzLCAmZGVzYywKPj4+Pj4gc2l6ZW9mKGRlc2MpLAo+Pj4+PiArICAgICAgICAgICAgICAgICBz
aXplb2YoZGVzYykgKiBjbGllbnQtPmN0eF9pbmRleCk7Cj4+Pj4+ICsgICAgaWYgKGxlbiAhPSBz
aXplb2YoZGVzYykpCj4+Pj4+ICsgICAgICAgIHJldHVybiAtRUZBVUxUOwo+Pj4+PiArCj4+Pj4+
ICsgICAgY2xpZW50LT5kb29yYmVsbF9pZCA9IG5ld19pZDsKPj4+Pj4gKyAgICBpZiAobmV3X2lk
ID09IEdVQ19JTlZBTElEX0RPT1JCRUxMX0lEKQo+Pj4+PiArICAgICAgICByZXR1cm4gMDsKPj4+
Pj4gKwo+Pj4+PiArICAgIC8qIEFjdGl2YXRlIHRoZSBuZXcgZG9vcmJlbGwgKi8KPj4+Pj4gKyAg
ICBfX3NldF9iaXQobmV3X2lkLCBkb29yYmVsbF9iaXRtYXApOwo+Pj4+Cj4+Pj4gSXMgdGhpcyB0
aGUgc2FtZSBiaXQgYXMgaW4gYXNzaWduX2Rvb3JiZWxsIHNvIHJlZHVuZGFudD8KPj4+Cj4+PiBJ
dCBpcyB0aGUgc2FtZSBiaXQsIGFuZCB5ZXMsIGl0IHdpbGwgYmUgcmVkdW5kYW50IGR1cmluZyB0
aGUgaW5pdGlhbAo+Pj4gc2V0dXAsIGJ1dCB3aGVuIHdlIGNvbWUgdG8gKnJlKmFzc2lnbiB0aGUg
YXNzb2NpYXRpb24gYmV0d2VlbiBhIGNsaWVudAo+Pj4gYW5kIGEgZG9vcmJlbGwgKGluIHRoZSBu
ZXh0IHBhdGNoKSB0aGVuIGl0IHdvbid0IGJlLgo+Pj4KPj4+IFdlIGNvdWxkIGFsc28gY2hvb3Nl
IHRvIGhhdmUgYXNzaWduX2Rvb3JiZWxsKCkgTk9UIHVwZGF0ZSB0aGUgbWFwLCBzbwo+Pj4gdGhl
biB0aGlzIHdvdWxkIGJlIHRoZSBvbmx5IHBsYWNlIHdoZXJlIHRoZSBiaXRtYXAgZ2V0cyB1cGRh
dGVkLiBJJ2QKPj4+IGhhdmUgdG8gcmVuYW1lIGl0IHRob3VnaCwgYXMgaXQgd291bGQgbm8gbG9u
Z2VyIGJlIGFzc2lnbmluZyBhbnl0aGluZyEKPj4KPj4gTWF5YmUgcGlja19kb29yYmVsbCBvciBm
aW5kX2ZyZWVfZG9vcmJlbGw/IEl0IHdvdWxkIGJlIGEgbGl0dGxlIGJpdAo+PiBjbGVhcmVyIGFu
ZCBzYWZlciAoZWFybHkgcmV0dXJucyBhYm92ZSBjb3VsZCBsZWF2ZSB0aGUgYml0bWFwIHNldCkg
d2l0aAo+PiBhIHNpbmdsZSBiaXRtYXAgdXBkYXRlIGxvY2F0aW9uIHNvIEkgdGhpbmsgaXQgd291
bGQgYmUgd29ydGggaXQuCj4+Cj4+IFJlZ2FyZHMsCj4+IFR2cnRrbwo+Cj4gUm9nZXIgd2lsY28s
IGJ1dCBpdCBsb29rcyBzaW1wbGVyIGlmIEkgbWFrZSBpdCBhIGZvbGxvd3VwIFs3LzZdPwo+IE90
aGVyd2lzZSAoaWYgSSBtaXggaXQgaW50byB0aGlzIHJld29yaykgZ2l0IHNjcmFtYmxlcyB0aGUg
ZGlmZgo+IGFyb3VuZCBzbyBpdHMgbGVzcyBlYXN5IHRvIHNlZSBob3cgdGhlIGNvZGUgd2FzIHJl
b3JnYW5pc2VkLgo+Cj4gVXBkYXRlIHBhdGNoIHdpbGwgZm9sbG93IHNvb24gLi4uCgpZZXMgZmlu
ZSwgaGF2ZSBpdCBvdXRzaWRlIHRoaXMgc2VyaWVzIGZvciBzaW1wbGljaXR5LiBTbyBmb3IgdGhp
cyBwYXRjaDoKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50
ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz
LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp
c3RpbmZvL2ludGVsLWdmeAo=