From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3 6/7] drm/i915/guc: replace assign_doorbell() with select_doorbell_register() Date: Tue, 14 Jun 2016 13:23:19 +0100 Message-ID: <575FF737.8000008@linux.intel.com> References: <1465837054-16245-1-git-send-email-david.s.gordon@intel.com> <1465837054-16245-7-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id E8064897C5 for ; Tue, 14 Jun 2016 12:23:20 +0000 (UTC) In-Reply-To: <1465837054-16245-7-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEzLzA2LzE2IDE3OjU3LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBUaGlzIHZlcnNpb24gZG9l c24ndCB1cGRhdGUgdGhlIGRvb3JiZWxsIGJpdG1hcCwgYXMgdGhhdCB3aWxsCj4gYmUgZG9uZSB3 aGVuIHRoZSBzZWxlY3RlZCBkb29yYmVsbCBpcyBhc3NvY2lhdGVkIHdpdGggYSBjbGllbnQuCj4K PiBUaGUgY2FsbCBpcyBub3cgc2xpZ2h0bHkgZWFybGllciwganVzdCBvbiB0aGUgZ2VuZXJhbCBw cmluY2lwbGUKPiB0aGF0IHBvdGVudGlhbGx5LWZhaWxpbmcgb3BlcmF0aW9ucyBzaG91bGQgYmUg ZG9uZSBhcyBlYXJseSBhcwo+IHBvc3NpYmxlLCB0byBlbGltaW5hdGUgbGF0ZSBmYWlsdXJlcyBh bmQgc2ltcGxpZnkgcmVjb3ZlcnkuCj4KPiBTdWdnZXN0ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0 dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRh dmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1 bGluQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1 Ym1pc3Npb24uYyB8IDYyICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxl IGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IGluZGV4IDYyYmY0YmQuLmEyNTI1 MDUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lv bi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4g QEAgLTIzMiw2ICsyMzIsMzIgQEAgc3RhdGljIHZvaWQgZ3VjX2Rpc2FibGVfZG9vcmJlbGwoc3Ry dWN0IGludGVsX2d1YyAqZ3VjLAo+ICAgCS8qIFhYWDogd2FpdCBmb3Igd29ya3F1ZXVlIHRvIGRy YWluICovCj4gICB9Cj4KPiArc3RhdGljIHVpbnQxNl90Cj4gK3NlbGVjdF9kb29yYmVsbF9yZWdp c3RlcihzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIHVpbnQzMl90IHByaW9yaXR5KQo+ICt7Cj4gKwkv Kgo+ICsJICogVGhlIGJpdG1hcCB0cmFja3Mgd2hpY2ggZG9vcmJlbGwgcmVnaXN0ZXJzIGFyZSBj dXJyZW50bHkgaW4gdXNlLgo+ICsJICogSXQgaXMgc3BsaXQgaW50byB0d28gaGFsdmVzOyB0aGUg Zmlyc3QgaGFsZiBpcyB1c2VkIGZvciBub3JtYWwKPiArCSAqIHByaW9yaXR5IGNvbnRleHRzLCB0 aGUgc2Vjb25kIGhhbGYgZm9yIGhpZ2gtcHJpb3JpdHkgb25lcy4KPiArCSAqIE5vdGUgdGhhdCBs b2dpY2FsbHkgaGlnaGVyIHByaW9yaXRpZXMgYXJlIG51bWVyaWNhbGx5IGxlc3MgdGhhbgo+ICsJ ICogbm9ybWFsIG9uZXMsIHNvIHRoZSB0ZXN0IGJlbG93IG1lYW5zICJpcyBpdCBoaWdoLXByaW9y aXR5PyIKPiArCSAqLwo+ICsJY29uc3QgYm9vbCBoaV9wcmkgPSAocHJpb3JpdHkgPD0gR1VDX0NU WF9QUklPUklUWV9ISUdIKTsKPiArCWNvbnN0IHVpbnQxNl90IGhhbGYgPSBHVUNfTUFYX0RPT1JC RUxMUyAvIDI7Cj4gKwljb25zdCB1aW50MTZfdCBzdGFydCA9IGhpX3ByaSA/IGhhbGYgOiAwOwo+ ICsJY29uc3QgdWludDE2X3QgZW5kID0gc3RhcnQgKyBoYWxmOwo+ICsJdWludDE2X3QgaWQ7Cj4g Kwo+ICsJaWQgPSBmaW5kX25leHRfemVyb19iaXQoZ3VjLT5kb29yYmVsbF9iaXRtYXAsIGVuZCwg c3RhcnQpOwo+ICsJaWYgKGlkID09IGVuZCkKPiArCQlpZCA9IEdVQ19JTlZBTElEX0RPT1JCRUxM X0lEOwo+ICsKPiArCURSTV9ERUJVR19EUklWRVIoImFzc2lnbmVkICVzIHByaW9yaXR5IGRvb3Ji ZWxsIGlkIDB4JXhcbiIsCj4gKwkJCWhpX3ByaSA/ICJoaWdoIiA6ICJub3JtYWwiLCBpZCk7Cj4g Kwo+ICsJcmV0dXJuIGlkOwo+ICt9Cj4gKwo+ICAgLyoKPiAgICAqIFNlbGVjdCwgYXNzaWduIGFu ZCByZWxhc2UgZG9vcmJlbGwgY2FjaGVsaW5lcwo+ICAgICoKPiBAQCAtMjU2LDMyICsyODIsNiBA QCBzdGF0aWMgdWludDMyX3Qgc2VsZWN0X2Rvb3JiZWxsX2NhY2hlbGluZShzdHJ1Y3QgaW50ZWxf Z3VjICpndWMpCj4gICAJcmV0dXJuIG9mZnNldDsKPiAgIH0KPgo+IC1zdGF0aWMgdWludDE2X3Qg YXNzaWduX2Rvb3JiZWxsKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgdWludDMyX3QgcHJpb3JpdHkp Cj4gLXsKPiAtCS8qCj4gLQkgKiBUaGUgYml0bWFwIGlzIHNwbGl0IGludG8gdHdvIGhhbHZlczsg dGhlIGZpcnN0IGhhbGYgaXMgdXNlZCBmb3IKPiAtCSAqIG5vcm1hbCBwcmlvcml0eSBjb250ZXh0 cywgdGhlIHNlY29uZCBoYWxmIGZvciBoaWdoLXByaW9yaXR5IG9uZXMuCj4gLQkgKiBOb3RlIHRo YXQgbG9naWNhbGx5IGhpZ2hlciBwcmlvcml0aWVzIGFyZSBudW1lcmljYWxseSBsZXNzIHRoYW4K PiAtCSAqIG5vcm1hbCBvbmVzLCBzbyB0aGUgdGVzdCBiZWxvdyBtZWFucyAiaXMgaXQgaGlnaC1w cmlvcml0eT8iCj4gLQkgKi8KPiAtCWNvbnN0IGJvb2wgaGlfcHJpID0gKHByaW9yaXR5IDw9IEdV Q19DVFhfUFJJT1JJVFlfSElHSCk7Cj4gLQljb25zdCB1aW50MTZfdCBoYWxmID0gR1VDX01BWF9E T09SQkVMTFMgLyAyOwo+IC0JY29uc3QgdWludDE2X3Qgc3RhcnQgPSBoaV9wcmkgPyBoYWxmIDog MDsKPiAtCWNvbnN0IHVpbnQxNl90IGVuZCA9IHN0YXJ0ICsgaGFsZjsKPiAtCXVpbnQxNl90IGlk Owo+IC0KPiAtCWlkID0gZmluZF9uZXh0X3plcm9fYml0KGd1Yy0+ZG9vcmJlbGxfYml0bWFwLCBl bmQsIHN0YXJ0KTsKPiAtCWlmIChpZCA9PSBlbmQpCj4gLQkJaWQgPSBHVUNfSU5WQUxJRF9ET09S QkVMTF9JRDsKPiAtCWVsc2UKPiAtCQlfX3NldF9iaXQoaWQsIGd1Yy0+ZG9vcmJlbGxfYml0bWFw KTsKPiAtCj4gLQlEUk1fREVCVUdfRFJJVkVSKCJhc3NpZ25lZCAlcyBwcmlvcml0eSBkb29yYmVs bCBpZCAweCV4XG4iLAo+IC0JCQloaV9wcmkgPyAiaGlnaCIgOiAibm9ybWFsIiwgaWQpOwo+IC0K PiAtCXJldHVybiBpZDsKPiAtfQo+IC0KPiAgIC8qCj4gICAgKiBJbml0aWFsaXNlIHRoZSBwcm9j ZXNzIGRlc2NyaXB0b3Igc2hhcmVkIHdpdGggdGhlIEd1QyBmaXJtd2FyZS4KPiAgICAqLwo+IEBA IC03NDIsNiArNzQyLDExIEBAIHN0YXRpYyB2b2lkIGdlbV9yZWxlYXNlX2d1Y19vYmooc3RydWN0 IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPiAgIAljbGllbnQtPndxX29mZnNldCA9IEdVQ19E Ql9TSVpFOwo+ICAgCWNsaWVudC0+d3Ffc2l6ZSA9IEdVQ19XUV9TSVpFOwo+Cj4gKwlkYl9pZCA9 IHNlbGVjdF9kb29yYmVsbF9yZWdpc3RlcihndWMsIGNsaWVudC0+cHJpb3JpdHkpOwo+ICsJaWYg KGRiX2lkID09IEdVQ19JTlZBTElEX0RPT1JCRUxMX0lEKQo+ICsJCS8qIFhYWDogZXZpY3QgYSBk b29yYmVsbCBpbnN0ZWFkPyAqLwo+ICsJCWdvdG8gZXJyOwo+ICsKPiAgIAljbGllbnQtPmRvb3Ji ZWxsX29mZnNldCA9IHNlbGVjdF9kb29yYmVsbF9jYWNoZWxpbmUoZ3VjKTsKPgo+ICAgCS8qCj4g QEAgLTc1NCwxMSArNzU5LDYgQEAgc3RhdGljIHZvaWQgZ2VtX3JlbGVhc2VfZ3VjX29iaihzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICAgCWVsc2UKPiAgIAkJY2xpZW50LT5wcm9j X2Rlc2Nfb2Zmc2V0ID0gKEdVQ19EQl9TSVpFIC8gMik7Cj4KPiAtCWRiX2lkID0gYXNzaWduX2Rv b3JiZWxsKGd1YywgY2xpZW50LT5wcmlvcml0eSk7Cj4gLQlpZiAoZGJfaWQgPT0gR1VDX0lOVkFM SURfRE9PUkJFTExfSUQpCj4gLQkJLyogWFhYOiBldmljdCBhIGRvb3JiZWxsIGluc3RlYWQgKi8K PiAtCQlnb3RvIGVycjsKPiAtCj4gICAJZ3VjX2luaXRfcHJvY19kZXNjKGd1YywgY2xpZW50KTsK PiAgIAlndWNfaW5pdF9jdHhfZGVzYyhndWMsIGNsaWVudCk7Cj4gICAJaWYgKGd1Y19pbml0X2Rv b3JiZWxsKGd1YywgY2xpZW50LCBkYl9pZCkpCj4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxp biA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK