From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ramalingam C Subject: Re: [PATCH v2 2/4] drm/i915: Read Vprime thrice incase of mismatch Date: Mon, 2 Apr 2018 14:46:33 +0530 Message-ID: <57633bbe-7687-7049-bd95-c3a7b7915e18@intel.com> References: <1522332548-15370-1-git-send-email-ramalingam.c@intel.com> <1522332548-15370-3-git-send-email-ramalingam.c@intel.com> <20180329143846.GD41885@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180329143846.GD41885@art_vandelay> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org CgpPbiBUaHVyc2RheSAyOSBNYXJjaCAyMDE4IDA4OjA4IFBNLCBTZWFuIFBhdWwgd3JvdGU6Cj4g T24gVGh1LCBNYXIgMjksIDIwMTggYXQgMDc6Mzk6MDZQTSArMDUzMCwgUmFtYWxpbmdhbSBDIHdy b3RlOgo+PiBJbiBjYXNlIG9mIFYgcHJpbWUgbWlzbWF0Y2gsIERQIEhEQ1Agc3BlYyBtYW5kYXRl cyB0aGUgcmUtcmVhZCBvZgo+PiBWcHJpbWUgYXRsZWFzdCB0d2ljZS4KPj4KPj4gVGhpcyBwYXRj aCBuZWVkZWQgZm9yIERQIEhEQ1AxLjQgQ1RTIFRlc3Q6IDFCLTA1Lgo+Pgo+PiB2MjoKPj4gICAg TW92ZWQgdGhlIFYnIHZhbGlkYXRpb24gaW50byBhIGZ1bmN0aW9uIGZvciByZXRyeS4gW1NlYW4g UGF1bF0KPj4KPj4gU2lnbmVkLW9mZi1ieTogUmFtYWxpbmdhbSBDIDxyYW1hbGluZ2FtLmNAaW50 ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZGNwLmMgfCAx MTMgKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPj4gICAxIGZpbGUgY2hh bmdlZCwgNzAgaW5zZXJ0aW9ucygrKSwgNDMgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZGNwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9oZGNwLmMKPj4gaW5kZXggOTZiOTAyNWRjNzU5Li5mNzdkOTU2YjJiMTggMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hkY3AuYwo+PiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZGNwLmMKPj4gQEAgLTE0Miw1MyArMTQyLDE3IEBAIGJv b2wgaW50ZWxfaGRjcF9pc19rc3ZfdmFsaWQodTggKmtzdikKPj4gICAJcmV0dXJuIHRydWU7Cj4+ ICAgfQo+PiAgIAo+PiAtLyogSW1wbGVtZW50cyBQYXJ0IDIgb2YgdGhlIEhEQ1AgYXV0aG9yaXph dGlvbiBwcm9jZWR1cmUgKi8KPj4gLXN0YXRpYwo+PiAtaW50IGludGVsX2hkY3BfYXV0aF9kb3du c3RyZWFtKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LAo+PiAtCQkJ ICAgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9oZGNwX3NoaW0gKnNoaW0pCj4+ICtzdGF0aWMgaW5s aW5lCj4gV2h5IGlubGluZT8KSXRzIGEgbWlzdGFrZS4gV2lsbCBjb3JyZWN0IGl0LiB0aGFua3MK Pgo+PiAraW50IGludGVsX2hkY3BfdmFsaWRhdGVfdl9wcmltZShzdHJ1Y3QgaW50ZWxfZGlnaXRh bF9wb3J0ICppbnRlbF9kaWdfcG9ydCwKPj4gKwkJCQljb25zdCBzdHJ1Y3QgaW50ZWxfaGRjcF9z aGltICpzaGltLAo+PiArCQkJCXU4ICprc3ZfZmlmbywgdTggbnVtX2Rvd25zdHJlYW0sIHU4ICpi c3RhdHVzKQo+PiAgIHsKPj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2Owo+ PiAgIAl1MzIgdnByaW1lLCBzaGFfdGV4dCwgc2hhX2xlZnRvdmVycywgcmVwX2N0bDsKPj4gLQl1 OCBic3RhdHVzWzJdLCBudW1fZG93bnN0cmVhbSwgKmtzdl9maWZvOwo+PiAgIAlpbnQgcmV0LCBp LCBqLCBzaGFfaWR4Owo+PiAgIAo+PiAgIAlkZXZfcHJpdiA9IGludGVsX2RpZ19wb3J0LT5iYXNl LmJhc2UuZGV2LT5kZXZfcHJpdmF0ZTsKPj4gICAKPj4gLQlyZXQgPSBpbnRlbF9oZGNwX3BvbGxf a3N2X2ZpZm8oaW50ZWxfZGlnX3BvcnQsIHNoaW0pOwo+PiAtCWlmIChyZXQpIHsKPj4gLQkJRFJN X0VSUk9SKCJLU1YgbGlzdCBmYWlsZWQgdG8gYmVjb21lIHJlYWR5ICglZClcbiIsIHJldCk7Cj4+ IC0JCXJldHVybiByZXQ7Cj4+IC0JfQo+PiAtCj4+IC0JcmV0ID0gc2hpbS0+cmVhZF9ic3RhdHVz KGludGVsX2RpZ19wb3J0LCBic3RhdHVzKTsKPj4gLQlpZiAocmV0KQo+PiAtCQlyZXR1cm4gcmV0 Owo+PiAtCj4+IC0JaWYgKERSTV9IRENQX01BWF9ERVZJQ0VfRVhDRUVERUQoYnN0YXR1c1swXSkg fHwKPj4gLQkgICAgRFJNX0hEQ1BfTUFYX0NBU0NBREVfRVhDRUVERUQoYnN0YXR1c1sxXSkpIHsK Pj4gLQkJRFJNX0VSUk9SKCJNYXggVG9wb2xvZ3kgTGltaXQgRXhjZWVkZWRcbiIpOwo+PiAtCQly ZXR1cm4gLUVQRVJNOwo+PiAtCX0KPj4gLQo+PiAtCS8qCj4+IC0JICogV2hlbiByZXBlYXRlciBy ZXBvcnRzIDAgZGV2aWNlIGNvdW50LCBIRENQMS40IHNwZWMgYWxsb3dzIGRpc2FibGluZwo+PiAt CSAqIHRoZSBIRENQIGVuY3J5cHRpb24uIFRoYXQgaW1wbGllcyB0aGF0IHJlcGVhdGVyIGNhbid0 IGhhdmUgaXRzIG93bgo+PiAtCSAqIGRpc3BsYXkuIEFzIHRoZXJlIGlzIG5vIGNvbnN1bXB0aW9u IG9mIGVuY3J5cHRlZCBjb250ZW50IGluIHRoZQo+PiAtCSAqIHJlcGVhdGVyIHdpdGggMCBkb3du c3RyZWFtIGRldmljZXMsIHdlIGFyZSBmYWlsaW5nIHRoZQo+PiAtCSAqIGF1dGhlbnRpY2F0aW9u Lgo+PiAtCSAqLwo+PiAtCW51bV9kb3duc3RyZWFtID0gRFJNX0hEQ1BfTlVNX0RPV05TVFJFQU0o YnN0YXR1c1swXSk7Cj4+IC0JaWYgKG51bV9kb3duc3RyZWFtID09IDApCj4+IC0JCXJldHVybiAt RUlOVkFMOwo+PiAtCj4+IC0Ja3N2X2ZpZm8gPSBremFsbG9jKG51bV9kb3duc3RyZWFtICogRFJN X0hEQ1BfS1NWX0xFTiwgR0ZQX0tFUk5FTCk7Cj4+IC0JaWYgKCFrc3ZfZmlmbykKPj4gLQkJcmV0 dXJuIC1FTk9NRU07Cj4+IC0KPj4gLQlyZXQgPSBzaGltLT5yZWFkX2tzdl9maWZvKGludGVsX2Rp Z19wb3J0LCBudW1fZG93bnN0cmVhbSwga3N2X2ZpZm8pOwo+PiAtCWlmIChyZXQpCj4+IC0JCXJl dHVybiByZXQ7Cj4+IC0KPj4gICAJLyogUHJvY2VzcyBWJyB2YWx1ZXMgZnJvbSB0aGUgcmVjZWl2 ZXIgKi8KPj4gICAJZm9yIChpID0gMDsgaSA8IERSTV9IRENQX1ZfUFJJTUVfTlVNX1BBUlRTOyBp KyspIHsKPj4gICAJCXJldCA9IHNoaW0tPnJlYWRfdl9wcmltZV9wYXJ0KGludGVsX2RpZ19wb3J0 LCBpLCAmdnByaW1lKTsKPj4gQEAgLTM1Myw3ICszMTcsNyBAQCBpbnQgaW50ZWxfaGRjcF9hdXRo X2Rvd25zdHJlYW0oc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsCj4+ ICAgCQkJcmV0dXJuIHJldDsKPj4gICAJCXNoYV9pZHggKz0gc2l6ZW9mKHNoYV90ZXh0KTsKPj4g ICAJfSBlbHNlIHsKPj4gLQkJRFJNX0VSUk9SKCJJbnZhbGlkIG51bWJlciBvZiBsZWZ0b3ZlcnMg JWRcbiIsIHNoYV9sZWZ0b3ZlcnMpOwo+PiArCQlEUk1fREVCVUcoIkludmFsaWQgbnVtYmVyIG9m IGxlZnRvdmVycyAlZFxuIiwgc2hhX2xlZnRvdmVycyk7Cj4+ICAgCQlyZXR1cm4gLUVJTlZBTDsK Pj4gICAJfQo+PiAgIAo+PiBAQCAtMzgxLDE0ICszNDUsNzcgQEAgaW50IGludGVsX2hkY3BfYXV0 aF9kb3duc3RyZWFtKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LAo+ PiAgIAlpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIEhEQ1BfUkVQX0NUTCwK Pj4gICAJCQkJICAgIEhEQ1BfU0hBMV9DT01QTEVURSwKPj4gICAJCQkJICAgIEhEQ1BfU0hBMV9D T01QTEVURSwgMSkpIHsKPj4gLQkJRFJNX0VSUk9SKCJUaW1lZCBvdXQgd2FpdGluZyBmb3IgU0hB MSBjb21wbGV0ZVxuIik7Cj4+ICsJCURSTV9ERUJVRygiVGltZWQgb3V0IHdhaXRpbmcgZm9yIFNI QTEgY29tcGxldGVcbiIpOwo+PiAgIAkJcmV0dXJuIC1FVElNRURPVVQ7Cj4+ICAgCX0KPj4gICAJ aWYgKCEoSTkxNV9SRUFEKEhEQ1BfUkVQX0NUTCkgJiBIRENQX1NIQTFfVl9NQVRDSCkpIHsKPj4g LQkJRFJNX0VSUk9SKCJTSEEtMSBtaXNtYXRjaCwgSERDUCBmYWlsZWRcbiIpOwo+PiArCQlEUk1f REVCVUcoIlNIQS0xIG1pc21hdGNoLCBIRENQIGZhaWxlZFxuIik7Cj4gSSB0aGluayB0aGUgREVC VUcgc2hvdWxkIGJlIERFQlVHX0tNUywgY29uc2lzdGVudCB3aXRoIHRoZSByZXN0IG9mIHRoZSBm aWxlPwpXaWxsIG1ha2UgaXQgdW5pZm9ybQoKLS1SYW0KPgo+PiAgIAkJcmV0dXJuIC1FTlhJTzsK Pj4gICAJfQo+PiAgIAo+PiArCXJldHVybiAwOwo+PiArfQo+PiArCj4+ICsvKiBJbXBsZW1lbnRz IFBhcnQgMiBvZiB0aGUgSERDUCBhdXRob3JpemF0aW9uIHByb2NlZHVyZSAqLwo+PiArc3RhdGlj Cj4+ICtpbnQgaW50ZWxfaGRjcF9hdXRoX2Rvd25zdHJlYW0oc3RydWN0IGludGVsX2RpZ2l0YWxf cG9ydCAqaW50ZWxfZGlnX3BvcnQsCj4+ICsJCQkgICAgICAgY29uc3Qgc3RydWN0IGludGVsX2hk Y3Bfc2hpbSAqc2hpbSkKPj4gK3sKPj4gKwl1OCBic3RhdHVzWzJdLCBudW1fZG93bnN0cmVhbSwg Kmtzdl9maWZvOwo+PiArCWludCByZXQsIGksIHRyaWVzID0gMzsKPj4gKwo+PiArCXJldCA9IGlu dGVsX2hkY3BfcG9sbF9rc3ZfZmlmbyhpbnRlbF9kaWdfcG9ydCwgc2hpbSk7Cj4+ICsJaWYgKHJl dCkgewo+PiArCQlEUk1fRVJST1IoIktTViBsaXN0IGZhaWxlZCB0byBiZWNvbWUgcmVhZHkgKCVk KVxuIiwgcmV0KTsKPj4gKwkJcmV0dXJuIHJldDsKPj4gKwl9Cj4+ICsKPj4gKwlyZXQgPSBzaGlt LT5yZWFkX2JzdGF0dXMoaW50ZWxfZGlnX3BvcnQsIGJzdGF0dXMpOwo+PiArCWlmIChyZXQpCj4+ ICsJCXJldHVybiByZXQ7Cj4+ICsKPj4gKwlpZiAoRFJNX0hEQ1BfTUFYX0RFVklDRV9FWENFRURF RChic3RhdHVzWzBdKSB8fAo+PiArCSAgICBEUk1fSERDUF9NQVhfQ0FTQ0FERV9FWENFRURFRChi c3RhdHVzWzFdKSkgewo+PiArCQlEUk1fRVJST1IoIk1heCBUb3BvbG9neSBMaW1pdCBFeGNlZWRl ZFxuIik7Cj4+ICsJCXJldHVybiAtRVBFUk07Cj4+ICsJfQo+PiArCj4+ICsJLyoKPj4gKwkgKiBX aGVuIHJlcGVhdGVyIHJlcG9ydHMgMCBkZXZpY2UgY291bnQsIEhEQ1AxLjQgc3BlYyBhbGxvd3Mg ZGlzYWJsaW5nCj4+ICsJICogdGhlIEhEQ1AgZW5jcnlwdGlvbi4gVGhhdCBpbXBsaWVzIHRoYXQg cmVwZWF0ZXIgY2FuJ3QgaGF2ZSBpdHMgb3duCj4+ICsJICogZGlzcGxheS4gQXMgdGhlcmUgaXMg bm8gY29uc3VtcHRpb24gb2YgZW5jcnlwdGVkIGNvbnRlbnQgaW4gdGhlCj4+ICsJICogcmVwZWF0 ZXIgd2l0aCAwIGRvd25zdHJlYW0gZGV2aWNlcywgd2UgYXJlIGZhaWxpbmcgdGhlCj4+ICsJICog YXV0aGVudGljYXRpb24uCj4+ICsJICovCj4+ICsJbnVtX2Rvd25zdHJlYW0gPSBEUk1fSERDUF9O VU1fRE9XTlNUUkVBTShic3RhdHVzWzBdKTsKPj4gKwlpZiAobnVtX2Rvd25zdHJlYW0gPT0gMCkK Pj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4+ICsKPj4gKwlrc3ZfZmlmbyA9IGt6YWxsb2MobnVtX2Rv d25zdHJlYW0gKiBEUk1fSERDUF9LU1ZfTEVOLCBHRlBfS0VSTkVMKTsKPj4gKwlpZiAoIWtzdl9m aWZvKQo+PiArCQlyZXR1cm4gLUVOT01FTTsKPj4gKwo+PiArCXJldCA9IHNoaW0tPnJlYWRfa3N2 X2ZpZm8oaW50ZWxfZGlnX3BvcnQsIG51bV9kb3duc3RyZWFtLCBrc3ZfZmlmbyk7Cj4+ICsJaWYg KHJldCkKPj4gKwkJcmV0dXJuIHJldDsKPj4gKwo+PiArCS8qCj4+ICsJICogV2hlbiBWIHByaW1l IG1pc21hdGNoZXMsIERQIFNwZWMgbWFuZGF0ZXMgcmUtcmVhZCBvZgo+PiArCSAqIFYgcHJpbWUg YXRsZWFzdCB0d2ljZS4KPj4gKwkgKi8KPj4gKwlmb3IgKGkgPSAwOyBpIDwgdHJpZXM7IGkrKykg ewo+PiArCQlyZXQgPSBpbnRlbF9oZGNwX3ZhbGlkYXRlX3ZfcHJpbWUoaW50ZWxfZGlnX3BvcnQs IHNoaW0sCj4+ICsJCQkJCQkgIGtzdl9maWZvLCBudW1fZG93bnN0cmVhbSwKPj4gKwkJCQkJCSAg YnN0YXR1cyk7Cj4+ICsJCWlmICghcmV0KQo+PiArCQkJYnJlYWs7Cj4+ICsJfQo+PiArCj4+ICsJ aWYgKGkgPT0gdHJpZXMpIHsKPj4gKwkJRFJNX0VSUk9SKCJWIFByaW1lIHZhbGlkYXRpb24gZmFp bGVkLiglZClcbiIsIHJldCk7Cj4+ICsJCXJldHVybiByZXQ7Cj4+ICsJfQo+PiArCj4+ICAgCURS TV9ERUJVR19LTVMoIkhEQ1AgaXMgZW5hYmxlZCAoJWQgZG93bnN0cmVhbSBkZXZpY2VzKVxuIiwK Pj4gICAJCSAgICAgIG51bV9kb3duc3RyZWFtKTsKPj4gICAJcmV0dXJuIDA7Cj4+IC0tIAo+PiAy LjcuNAo+PgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==