From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915: Small compaction of the engine init code Date: Thu, 23 Jun 2016 11:26:27 +0100 Message-ID: <576BB953.1050006@linux.intel.com> References: <576ABAED.4020303@linux.intel.com> <1466613348-29394-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20160622165959.GF22318@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id F291D6E8FA for ; Thu, 23 Jun 2016 10:26:28 +0000 (UTC) In-Reply-To: <20160622165959.GF22318@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIyLzA2LzE2IDE3OjU5LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gV2VkLCBKdW4gMjIs IDIwMTYgYXQgMDU6MzU6NDhQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IEZyb206 IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IEVmZmVjdGl2 ZWx5IHJlbW92ZXMgb25lIGxheWVyIG9mIGluZGlyZWN0aW9uIGJldHdlZW4gdGhlIG1hc2sgb2YK Pj4gcG9zc2libGUgZW5naW5lcyBhbmQgdGhlIGVuZ2luZSBjb25zdHJ1Y3RvcnMuIEluc3RlYWQg b2Ygc3BlbGxpbmcKPj4gb3V0IGluIGNvZGUgdGhlIG1hcHBpbmcgb2YgSEFTXzxlbmdpbmU+IHRv IGNvbnN0cnVjdG9ycywgbWFrZXMKPj4gbW9yZSB1c2Ugb2YgdGhlIHJlY2VudGx5IGFkZGVkIGRh dGEgZHJpdmVuIGFwcHJvYWNoIGJ5IHB1dHRpbmcKPj4gZW5naW5lIGNvbnN0cnVjdG9yIHZmdW5j cyBpbnRvIHRoZSB0YWJsZSBhcyB3ZWxsLgo+Pgo+PiBFZmZlY3QgaXMgZmV3ZXIgbGluZXMgb2Yg c291cmNlIGFuZCBzbWFsbGVyIGJpbmFyeS4KPj4KPj4gQXQgdGhlIHNhbWUgdGltZSBzaW1wbGlm eSB0aGUgZXJyb3IgaGFuZGxpbmcgc2luY2UgZW5naW5lCj4+IGRlc3RydWN0b3JzIGNhbiBydW4g b24gdW5pdGlhbGl6ZWQgZW5naW5lcyBhbnl3YXkuCj4+Cj4+IFNpbWlsYXIgYXBwcm9hY2ggY291 bGQgYmUgZG9uZSBmb3IgbGVnYWN5IHN1Ym1pc3Npb24gaXMgd2FudGVkLgo+Pgo+PiB2MjogUmVt b3ZlZCB1Z2x5IEJVSUxEX0JVR19PTnMgaW4gZmF2b3VyIG9mIG5ld2x5IGludHJvZHVjZWQKPj4g ICAgICBFTkdJTkVfTUFTSyBhbmQgSEFTX0VOR0lORSBtYWNyb3MuCj4+ICAgICAgQWxzbyByZW1v dmVkIHRoZSBmb3J3YXJkIGRlY2xhcmF0aW9ucyBieSBzaHVmZmxpbmcgZnVuY3Rpb25zCj4+ICAg ICAgYXJvdW5kLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVy c3VsaW5AaW50ZWwuY29tPgo+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24u Y28udWs+Cj4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv LnVrPgo+Cj4+ICAgaW50IGludGVsX2xvZ2ljYWxfcmluZ3NfaW5pdChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KQo+PiAgIHsKPj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g ZGV2LT5kZXZfcHJpdmF0ZTsKPj4gKwlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4+ ICsJdW5zaWduZWQgaW50IGk7Cj4+ICAgCWludCByZXQ7Cj4+Cj4+IC0JcmV0ID0gbG9naWNhbF9y ZW5kZXJfcmluZ19pbml0KGRldik7Cj4+IC0JaWYgKHJldCkKPj4gLQkJcmV0dXJuIHJldDsKPj4g LQo+PiAtCWlmIChIQVNfQlNEKGRldikpIHsKPj4gLQkJcmV0ID0gbG9naWNhbF9ic2RfcmluZ19p bml0KGRldik7Cj4+IC0JCWlmIChyZXQpCj4+IC0JCQlnb3RvIGNsZWFudXBfcmVuZGVyX3Jpbmc7 Cj4+IC0JfQo+PiAtCj4+IC0JaWYgKEhBU19CTFQoZGV2KSkgewo+PiAtCQlyZXQgPSBsb2dpY2Fs X2JsdF9yaW5nX2luaXQoZGV2KTsKPj4gLQkJaWYgKHJldCkKPj4gLQkJCWdvdG8gY2xlYW51cF9i c2RfcmluZzsKPj4gLQl9Cj4+IC0KPj4gLQlpZiAoSEFTX1ZFQk9YKGRldikpIHsKPj4gLQkJcmV0 ID0gbG9naWNhbF92ZWJveF9yaW5nX2luaXQoZGV2KTsKPj4gLQkJaWYgKHJldCkKPj4gLQkJCWdv dG8gY2xlYW51cF9ibHRfcmluZzsKPj4gLQl9Cj4+IC0KPj4gLQlpZiAoSEFTX0JTRDIoZGV2KSkg ewo+PiAtCQlyZXQgPSBsb2dpY2FsX2JzZDJfcmluZ19pbml0KGRldik7Cj4+IC0JCWlmIChyZXQp Cj4+IC0JCQlnb3RvIGNsZWFudXBfdmVib3hfcmluZzsKPj4gKwlmb3IgKGkgPSAwOyBpIDwgSTkx NV9OVU1fRU5HSU5FUzsgaSsrKSB7Cj4KPiBPbmUgbW9yZSB0aGluZyB0byBjb25zaWRlciBpcyB0 aGF0IGxvZ2ljYWxfcmluZ3NbXSBoYXMgYW4gdW5zcGVjaWZpZWQKPiBzaXplLiBFaXRoZXIgd2Ug c2V0IE5VTV9FTkdJTkVTIHRoZXJlIG9yIHVzZSBBUlJBWV9TSVpFIGhlcmUsIGVpdGhlciB3YXkK PiB3ZSByaXNrIG5vdCBpbml0aWFsaXNpbmcgYWxsIGVuZ2luZXMgd2UgZXhwZWN0Lgo+Cj4gSSB0 aGluayB3ZSBuZWVkOgo+IHVuc2lnbmVkIG1hc2sgPSAwOwo+Cj4+ICsJCWlmIChIQVNfRU5HSU5F KGRldl9wcml2LCBpKSkgewo+PiArCQkJZW5naW5lID0gbG9naWNhbF9yaW5nX3NldHVwKGRldl9w cml2LCBpKTsKPj4gKwkJCXJldCA9IGxvZ2ljYWxfcmluZ3NbaV0uaW5pdChlbmdpbmUpOwo+PiAr CQkJaWYgKHJldCkKPj4gKwkJCQlnb3RvIGNsZWFudXA7Cj4gCQkJbWFzayB8PSBpbnRlbF9lbmdp bmVfZmxhZyhlbmdpbmUpOwo+PiArCQl9Cj4+ICAgCX0KPgo+IGlmIChXQVJOX09OKG1hc2sgIT0g ZGV2X3ByaXYtPmluZm8ucmluZ3NfbWFzaykpCj4gCW1rd3JpdGVfaW50ZWxfaW5mbyhkZXZfcHJp diktPnJpbmdzX21hc2sgPSBtYXNrOwo+Cj4gVG8gY2F0Y2ggYW55IGZ1dHVyZSBmb3Jnb3R0ZW4g YWRkaXRpb25zIHdpdGhvdXQgZXhwbG9kaW5nLgoKSG0sIGlmIGxvZ2ljYWxfcmluZ3MgZG9lcyBu b3QgY29udGFpbiBhbGwgcmVxdWlyZWQgZW5naW5lcyBpdCBjYW4gZWl0aGVyIApjcmFzaCBvciwg aWYgc29tZWhvdyBpdCBtYWdpY2FsbHkgbWFuYWdlcyB0byBpbml0aWFsaXplIGl0IGZyb20gcmFu ZG9tIApkYXRhLCBzdGlsbCBwYXNzIHlvdXIgdGVzdC4KClBlcmhhcHMgd2UganVzdCBuZWVkOgoK QlVJTERfQlVHX09OKEFSUkFZX1NJWkUobG9naWNhbF9yaW5ncykgPT0gSTkxNV9OVU1fRU5HSU5F UykKCj8KCldoYXQgaXMgdGhpcyBta3dyaXRlX2ludGVsX2luZm8gdGhpbmc/IFRoZXJlIGlzIGEg ZmFjaWxpdHkgbm93YWRheXMgdG8gCndyaXRlIHRvIHRoZSByb2RhdGEgc2VjdGlvbj8gOikKClJl Z2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==