From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 18/25] drm/i915: Only apply one barrier after a breadcrumb interrupt is posted Date: Mon, 27 Jun 2016 11:35:51 +0100 Message-ID: <57710187.306@linux.intel.com> References: <1466849588-17558-1-git-send-email-chris@chris-wilson.co.uk> <1466849588-17558-19-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id BAF1A6E267 for ; Mon, 27 Jun 2016 10:35:53 +0000 (UTC) In-Reply-To: <1466849588-17558-19-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI1LzA2LzE2IDExOjEzLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gSWYgd2UgZmxhZyB0aGUg c2Vxbm8gYXMgcG90ZW50aWFsbHkgc3RhbGUgdXBvbiByZWNlaXZpbmcgYW4gaW50ZXJydXB0LAo+ IHdlIGNhbiB1c2UgdGhhdCBpbmZvcm1hdGlvbiB0byByZWR1Y2UgdGhlIGZyZXF1ZW5jeSB0aGF0 IHdlIGFwcGx5IHRoZQo+IGhlYXZ5d2VpZ2h0IGNvaGVyZW50IHNlcW5vIHJlYWQgKGkuZS4gaWYg d2Ugd2FrZSB1cCBhIGNoYWluIG9mIHdhaXRlcnMpLgo+Cj4gdjI6IFVzZSBjbXB4Y2hnIHRvIHJl cGxhY2UgUkVBRF9PTkNFL1dSSVRFX09OQ0UgZm9yIG1vcmUgZXhwbGljaXQKPiBjb250cm9sIG9m IHRoZSBvcmRlcmluZyB3cnQgdG8gaW50ZXJydXB0IGdlbmVyYXRpb24gYW5kIGludGVycnVwdAo+ IGNoZWNraW5nIGluIHRoZSBib3R0b20taGFsZi4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuaCAgICAgICAgICB8IDE1ICsrKysrKysrKysrKysrLQo+ICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyAgICAgICAgICB8ICAxICsKPiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMgfCAxNiArKysrKysrKysrLS0tLS0tCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggIHwgIDEgKwo+ICAgNCBmaWxl cyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2Rydi5oCj4gaW5kZXggOWEzODkwZjk1ZmIxLi5kMDliOTZkMTkzYTUgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMzk5NCw3ICszOTk0LDIwIEBAIHN0YXRpYyBpbmxp bmUgYm9vbCBfX2k5MTVfcmVxdWVzdF9pcnFfY29tcGxldGUoc3RydWN0IGRybV9pOTE1X2dlbV9y ZXF1ZXN0ICpyZXEpCj4gICAJICogYnV0IGl0IGlzIGVhc2llciBhbmQgc2FmZXIgdG8gZG8gaXQg ZXZlcnkgdGltZSB0aGUgd2FpdGVyCj4gICAJICogaXMgd29rZW4uCj4gICAJICovCj4gLQlpZiAo ZW5naW5lLT5pcnFfc2Vxbm9fYmFycmllcikgewo+ICsJaWYgKGVuZ2luZS0+aXJxX3NlcW5vX2Jh cnJpZXIgJiYKPiArCSAgICBjbXB4Y2hnX3JlbGF4ZWQoJmVuZ2luZS0+aXJxX3Bvc3RlZCwgMSwg MCkpIHsKPiArCQkvKiBUaGUgb3JkZXJpbmcgb2YgaXJxX3Bvc3RlZCB2ZXJzdXMgYXBwbHlpbmcg dGhlIGJhcnJpZXIKPiArCQkgKiBpcyBjcnVjaWFsLiBUaGUgY2xlYXJpbmcgb2YgdGhlIGN1cnJl bnQgaXJxX3Bvc3RlZCBtdXN0Cj4gKwkJICogYmUgdmlzaWJsZSBiZWZvcmUgd2UgcGVyZm9ybSB0 aGUgYmFycmllciBvcGVyYXRpb24sCj4gKwkJICogc3VjaCB0aGF0IGlmIGEgc3Vic2VxdWVudCBp bnRlcnJ1cHQgYXJyaXZlcywgaXJxX3Bvc3RlZAo+ICsJCSAqIGlzIHJlYXNzZXJ0ZWQgYW5kIG91 ciB0YXNrIHJld29rZW4gKHdoaWNoIGNhdXNlcyB1cyB0bwo+ICsJCSAqIGRvIGFub3RoZXIgX19p OTE1X3JlcXVlc3RfaXJxX2NvbXBsZXRlKCkgaW1tZWRpYXRlbHkKPiArCQkgKiBhbmQgcmVhcHBs eSB0aGUgYmFycmllcikuIENvbnZlcnNlbHksIGlmIHRoZSBjbGVhcgo+ICsJCSAqIG9jY3VycyBh ZnRlciB0aGUgYmFycmllciwgdGhlbiBhbiBpbnRlcnJ1cHQgdGhhdCBhcnJpdmVkCj4gKwkJICog d2hpbHN0IHdlIHdhaXRlZCBvbiB0aGUgYmFycmllciB3b3VsZCBub3QgdHJpZ2dlciBhCj4gKwkJ ICogYmFycmllciBvbiB0aGUgbmV4dCBwYXNzLCBhbmQgdGhlIHJlYWQgbWF5IG5vdCBzZWUgdGhl Cj4gKwkJICogc2Vxbm8gdXBkYXRlLgo+ICsJCSAqLwo+ICAgCQllbmdpbmUtPmlycV9zZXFub19i YXJyaWVyKGVuZ2luZSk7Cj4gICAJCWlmIChpOTE1X2dlbV9yZXF1ZXN0X2NvbXBsZXRlZChyZXEp KQo+ICAgCQkJcmV0dXJuIHRydWU7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gaW5kZXggYmU3 ZjBiOWIyN2UwLi43NzI0YmFlMjdiY2YgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9pcnEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBA QCAtOTc2LDYgKzk3Niw3IEBAIHN0YXRpYyB2b2lkIGlyb25sYWtlX3Jwc19jaGFuZ2VfaXJxX2hh bmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+Cj4gICBzdGF0aWMgdm9p ZCBub3RpZnlfcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICB7Cj4gKwlz bXBfc3RvcmVfbWIoZW5naW5lLT5pcnFfcG9zdGVkLCB0cnVlKTsKPiAgIAlpZiAoaW50ZWxfZW5n aW5lX3dha2V1cChlbmdpbmUpKSB7Cj4gICAJCXRyYWNlX2k5MTVfZ2VtX3JlcXVlc3Rfbm90aWZ5 KGVuZ2luZSk7Cj4gICAJCWVuZ2luZS0+dXNlcl9pbnRlcnJ1cHRzKys7Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jCj4gaW5kZXggY2I1ZTg1MTkyNjY5Li44NGMyYTQ0 OWRkMGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVt YnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMKPiBA QCAtNDMsMTIgKzQzLDE4IEBAIHN0YXRpYyB2b2lkIGludGVsX2JyZWFkY3J1bWJzX2Zha2VfaXJx KHVuc2lnbmVkIGxvbmcgZGF0YSkKPgo+ICAgc3RhdGljIHZvaWQgaXJxX2VuYWJsZShzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICB7Cj4gKwkvKiBFbmFibGluZyB0aGUgSVJRIG1h eSBtaXNzIHRoZSBnZW5lcmF0aW9uIG9mIHRoZSBpbnRlcnJ1cHQsIGJ1dAo+ICsJICogd2Ugc3Rp bGwgbmVlZCB0byBmb3JjZSB0aGUgYmFycmllciBiZWZvcmUgcmVhZGluZyB0aGUgc2Vxbm8sCj4g KwkgKiBqdXN0IGluIGNhc2UuCj4gKwkgKi8KPiArCWVuZ2luZS0+aXJxX3Bvc3RlZCA9IHRydWU7 Cj4gICAJV0FSTl9PTighZW5naW5lLT5pcnFfZ2V0KGVuZ2luZSkpOwo+ICAgfQo+Cj4gICBzdGF0 aWMgdm9pZCBpcnFfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICB7 Cj4gICAJZW5naW5lLT5pcnFfcHV0KGVuZ2luZSk7Cj4gKwllbmdpbmUtPmlycV9wb3N0ZWQgPSBm YWxzZTsKPiAgIH0KPgo+ICAgc3RhdGljIGJvb2wgX19pbnRlbF9icmVhZGNydW1ic19lbmFibGVf aXJxKHN0cnVjdCBpbnRlbF9icmVhZGNydW1icyAqYikKPiBAQCAtNTYsNyArNjIsNiBAQCBzdGF0 aWMgYm9vbCBfX2ludGVsX2JyZWFkY3J1bWJzX2VuYWJsZV9pcnEoc3RydWN0IGludGVsX2JyZWFk Y3J1bWJzICpiKQo+ICAgCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSA9Cj4gICAJCWNv bnRhaW5lcl9vZihiLCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzLCBicmVhZGNydW1icyk7Cj4gICAJ c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPSBlbmdpbmUtPmk5MTU7Cj4gLQlib29sIGly cV9wb3N0ZWQgPSBmYWxzZTsKPgo+ICAgCWFzc2VydF9zcGluX2xvY2tlZCgmYi0+bG9jayk7Cj4g ICAJaWYgKGItPnJwbV93YWtlbG9jaykKPiBAQCAtNzIsMTAgKzc3LDggQEAgc3RhdGljIGJvb2wg X19pbnRlbF9icmVhZGNydW1ic19lbmFibGVfaXJxKHN0cnVjdCBpbnRlbF9icmVhZGNydW1icyAq YikKPgo+ICAgCS8qIE5vIGludGVycnVwdHM/IEtpY2sgdGhlIHdhaXRlciBldmVyeSBqaWZmaWUh ICovCj4gICAJaWYgKGludGVsX2lycXNfZW5hYmxlZChpOTE1KSkgewo+IC0JCWlmICghdGVzdF9i aXQoZW5naW5lLT5pZCwgJmk5MTUtPmdwdV9lcnJvci50ZXN0X2lycV9yaW5ncykpIHsKPiArCQlp ZiAoIXRlc3RfYml0KGVuZ2luZS0+aWQsICZpOTE1LT5ncHVfZXJyb3IudGVzdF9pcnFfcmluZ3Mp KQo+ICAgCQkJaXJxX2VuYWJsZShlbmdpbmUpOwo+IC0JCQlpcnFfcG9zdGVkID0gdHJ1ZTsKPiAt CQl9Cj4gICAJCWItPmlycV9lbmFibGVkID0gdHJ1ZTsKPiAgIAl9Cj4KPiBAQCAtODMsNyArODYs NyBAQCBzdGF0aWMgYm9vbCBfX2ludGVsX2JyZWFkY3J1bWJzX2VuYWJsZV9pcnEoc3RydWN0IGlu dGVsX2JyZWFkY3J1bWJzICpiKQo+ICAgCSAgICB0ZXN0X2JpdChlbmdpbmUtPmlkLCAmaTkxNS0+ Z3B1X2Vycm9yLm1pc3NlZF9pcnFfcmluZ3MpKQo+ICAgCQltb2RfdGltZXIoJmItPmZha2VfaXJx LCBqaWZmaWVzICsgMSk7Cj4KPiAtCXJldHVybiBpcnFfcG9zdGVkOwo+ICsJcmV0dXJuIGVuZ2lu ZS0+aXJxX3Bvc3RlZDsKPiAgIH0KPgo+ICAgc3RhdGljIHZvaWQgX19pbnRlbF9icmVhZGNydW1i c19kaXNhYmxlX2lycShzdHJ1Y3QgaW50ZWxfYnJlYWRjcnVtYnMgKmIpCj4gQEAgLTIwNSw3ICsy MDgsOCBAQCBzdGF0aWMgYm9vbCBfX2ludGVsX2VuZ2luZV9hZGRfd2FpdChzdHJ1Y3QgaW50ZWxf ZW5naW5lX2NzICplbmdpbmUsCj4gICAJCQkgKiBpbiBjYXNlIHRoZSBzZXFubyBwYXNzZWQuCj4g ICAJCQkgKi8KPiAgIAkJCV9faW50ZWxfYnJlYWRjcnVtYnNfZW5hYmxlX2lycShiKTsKPiAtCQkJ d2FrZV91cF9wcm9jZXNzKHRvX3dhaXQobmV4dCktPnRzayk7Cj4gKwkJCWlmIChSRUFEX09OQ0Uo ZW5naW5lLT5pcnFfcG9zdGVkKSkKPiArCQkJCXdha2VfdXBfcHJvY2Vzcyh0b193YWl0KG5leHQp LT50c2spOwo+ICAgCQl9Cj4KPiAgIAkJZG8gewo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9y aW5nYnVmZmVyLmgKPiBpbmRleCA3ZTUzZTRkNjZiNmMuLjRkNmMyYjc3M2E2NCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBAQCAtMTk3LDYgKzE5Nyw3IEBA IHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mgewo+ICAgCXN0cnVjdCBpOTE1X2N0eF93b3JrYXJvdW5k cyB3YV9jdHg7Cj4KPiAgIAl1bnNpZ25lZCBpcnFfcmVmY291bnQ7IC8qIHByb3RlY3RlZCBieSBk ZXZfcHJpdi0+aXJxX2xvY2sgKi8KPiArCWJvb2wJCWlycV9wb3N0ZWQ7Cj4gICAJdTMyCQlpcnFf ZW5hYmxlX21hc2s7CS8qIGJpdG1hc2sgdG8gZW5hYmxlIHJpbmcgaW50ZXJydXB0ICovCj4gICAJ c3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICp0cmFjZV9pcnFfcmVxOwo+ICAgCWJvb2wgX19t dXN0X2NoZWNrICgqaXJxX2dldCkoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZyk7Cj4KCkFG QUlSIHRoaXMgbG9va2VkIE9LIHRvIG1lIGxhc3QgdGltZSByb3VuZCBhcGFydCBmcm9tIHRoZSBh IGxpdHRsZSBiaXQgCm9mIHVuY2xhcml0eSBpbiBfX2k5MTVfcmVxdWVzdF9pcnFfY29tcGxldGUg d2hpY2ggeW91IHJlc29sdmVkIHdpdGggY21weGNoZy4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJz dWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==