public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Robert Foss <robert.foss@collabora.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	daniel.vetter@ffwll.ch, daniel.stone@collabora.com,
	marius.c.vlad@intel.com, tomeu.vizoso@collabora.com,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PACTH i-g-t v1] lib/drmtest: Change DRIVER_INTEL check to avoid running GEM on non-Intel
Date: Tue, 28 Jun 2016 05:46:27 -0400	[thread overview]
Message-ID: <57724773.2090206@collabora.com> (raw)
In-Reply-To: <20160628090618.GH25424@nuc-i3427.alporthouse.com>

Thanks Chris!

On 2016-06-28 05:06 AM, Chris Wilson wrote:
> On Mon, Jun 27, 2016 at 01:53:13PM -0400, robert.foss@collabora.com wrote:
>> From: Robert Foss <robert.foss@collabora.com>
>>
>> Avoid running gem_quiescent_gpu() on non-Intel hardware.
>>
>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>> ---
>>   lib/drmtest.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/drmtest.c b/lib/drmtest.c
>> index 632fec4..6427657 100644
>> --- a/lib/drmtest.c
>> +++ b/lib/drmtest.c
>> @@ -338,7 +338,7 @@ int drm_open_driver(int chipset)
>>   	if (__sync_fetch_and_add(&open_count, 1))
>>   		return fd;
>>
>> -	if(chipset & DRIVER_INTEL){
>> +	if(chipset == DRIVER_INTEL){
>
> That doesn't work. You need an is_i915_device()
> Took the liberty of making that change and pushing with your credit.
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2016-06-28  9:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 17:53 [PACTH i-g-t v1] lib/drmtest: Change DRIVER_INTEL check to avoid running GEM on non-Intel robert.foss
2016-06-28  9:06 ` Chris Wilson
2016-06-28  9:46   ` Robert Foss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57724773.2090206@collabora.com \
    --to=robert.foss@collabora.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.stone@collabora.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=marius.c.vlad@intel.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox