From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH 2/6] drm/i915/huc: Unified css_header struct
 for GuC and HuC
Date: Tue, 28 Jun 2016 15:32:51 +0100
Message-ID: <57728A93.70607@intel.com>
References: <1466532685-5101-1-git-send-email-peter.antoine@intel.com>
 <1466532685-5101-3-git-send-email-peter.antoine@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 2181A6E5B2
 for <intel-gfx@lists.freedesktop.org>; Tue, 28 Jun 2016 14:33:06 +0000 (UTC)
In-Reply-To: <1466532685-5101-3-git-send-email-peter.antoine@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Peter Antoine <peter.antoine@intel.com>, intel-gfx@lists.freedesktop.org
Cc: sean.v.kelley@intel.com, lawrence.t.li@intel.com, rodrigo.vivi@intel.com
List-Id: intel-gfx@lists.freedesktop.org

T24gMjEvMDYvMTYgMTk6MTEsIFBldGVyIEFudG9pbmUgd3JvdGU6Cj4gRnJvbTogQWxleCBEYWkg
PHl1LmRhaUBpbnRlbC5jb20+Cj4KPiBIdUMgZmlybXdhcmUgY3NzIGhlYWRlciBoYXMgYWxtb3N0
IGV4YWN0bHkgc2FtZSBkZWZpbml0aW9uIGFzIEd1Qwo+IGZpcm13YXJlIGV4Y2VwdCBmb3IgdGhl
IHN3X3ZlcnNpb24uIEFsc28sIGFkZCBhIG5ldyBtZW1iZXIgZndfdHlwZQo+IGludG8gaW50ZWxf
dWNfZncgdG8gaW5kaWNhdGUgd2hhdCBraW5kIG9mIGZ3IGl0IGlzLiBTbywgdGhlIGxvYWRlcgo+
IHdpbGwgcHVsbCByaWdodCBzd192ZXJzaW9uIGZyb20gaGVhZGVyLgo+Cj4gU2lnbmVkLW9mZi1i
eTogQWxleCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUGV0ZXIgQW50
b2luZSA8cGV0ZXIuYW50b2luZUBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9ndWMuaCAgICAgICAgfCAgNCArKysrCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9ndWNfZndpZi5oICAgfCAxNiArKysrKysrKysrLS0tCj4gICBkcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMgfCA0MiArKysrKysrKysrKysrKysrKysrKystLS0t
LS0tLS0tLS0KPiAgIDMgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRp
b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgg
Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+IGluZGV4IDgzNjQyMGIuLjBiNGVk
ODggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPiArKysg
Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+IEBAIC05Nyw2ICs5Nyw5IEBAIGVu
dW0gaW50ZWxfdWNfZndfc3RhdHVzIHsKPiAgIAlVQ19GSVJNV0FSRV9TVUNDRVNTCj4gICB9Owo+
Cj4gKyNkZWZpbmUgVUNfRldfVFlQRV9HVUMJCTAKPiArI2RlZmluZSBVQ19GV19UWVBFX0hVQwkJ
MQo+ICsKPiAgIC8qCj4gICAgKiBUaGlzIHN0cnVjdHVyZSBlbmNhcHN1bGF0ZXMgYWxsIHRoZSBk
YXRhIG5lZWRlZCBkdXJpbmcgdGhlIHByb2Nlc3MKPiAgICAqIG9mIGZldGNoaW5nLCBjYWNoaW5n
LCBhbmQgbG9hZGluZyB0aGUgZmlybXdhcmUgaW1hZ2UgaW50byB0aGUgR3VDLgo+IEBAIC0xMTQs
NiArMTE3LDcgQEAgc3RydWN0IGludGVsX3VjX2Z3IHsKPiAgIAl1aW50MTZfdCBtYWpvcl92ZXJf
Zm91bmQ7Cj4gICAJdWludDE2X3QgbWlub3JfdmVyX2ZvdW5kOwo+Cj4gKwl1aW50MzJfdCBmd190
eXBlOwo+ICAgCXVpbnQzMl90IGhlYWRlcl9zaXplOwo+ICAgCXVpbnQzMl90IGhlYWRlcl9vZmZz
ZXQ7Cj4gICAJdWludDMyX3QgcnNhX3NpemU7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2d1Y19md2lmLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNf
ZndpZi5oCj4gaW5kZXggOTQ0Nzg2ZC4uYTY5ZWUzNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9ndWNfZndpZi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZ3VjX2Z3aWYuaAo+IEBAIC0xNTQsNyArMTU0LDcgQEAKPiAgICAqIFRoZSBHdUMgZmly
bXdhcmUgbGF5b3V0IGxvb2tzIGxpa2UgdGhpczoKPiAgICAqCj4gICAgKiAgICAgKy0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rCj4gLSAqICAgICB8ICAgICAgICBndWNfY3NzX2hlYWRl
ciAgICAgICAgIHwKPiArICogICAgIHwgICAgICAgICB1Y19jc3NfaGVhZGVyICAgICAgICAgfAo+
ICAgICogICAgIHwgY29udGFpbnMgbWFqb3IvbWlub3IgdmVyc2lvbiAgfAo+ICAgICogICAgICst
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKwo+ICAgICogICAgIHwgICAgICAgICAgICAg
dUNvZGUgICAgICAgICAgICAgfAo+IEBAIC0xODAsOSArMTgwLDE2IEBACj4gICAgKiAzLiBMZW5n
dGggaW5mbyBvZiBlYWNoIGNvbXBvbmVudCBjYW4gYmUgZm91bmQgaW4gaGVhZGVyLCBpbiBkd29y
ZHMuCj4gICAgKiA0LiBNb2R1bHVzIGFuZCBleHBvbmVudCBrZXkgYXJlIG5vdCByZXF1aXJlZCBi
eSBkcml2ZXIuIFRoZXkgbWF5IG5vdCBhcHBlYXIKPiAgICAqIGluIGZ3LiBTbyBkcml2ZXIgd2ls
bCBsb2FkIGEgdHJ1bmNhdGVkIGZpcm13YXJlIGluIHRoaXMgY2FzZS4KPiArICoKPiArICogSHVD
IGZpcm13YXJlIGxheW91dCBpcyBzYW1lIGFzIEd1QyBmaXJtd2FyZS4KPiArICoKPiArICogSHVD
IGZpcm13YXJlIGNzcyBoZWFkZXIgaXMgZGlmZmVyZW50LiBIb3dldmVyLCB0aGUgb25seSBkaWZm
ZXJlbmNlIGlzIHdoZXJlCj4gKyAqIHRoZSB2ZXJzaW9uIGluZm9ybWF0aW9uIGlzIHNhdmVkLiBU
aGUgdWNfY3NzX2hlYWRlciBpcyB1bmlmaWVkIHRvIHN1cHBvcnQKPiArICogYm90aC4gRHJpdmVy
IHNob3VsZCBnZXQgSHVDIHZlcnNpb24gZnJvbSB1Y19jc3NfaGVhZGVyLmh1Y19zd192ZXJzaW9u
LCB3aGlsZQo+ICsgKiB1Y19jc3NfaGVhZGVyLmd1Y19zd192ZXJzaW9uIGZvciBHdUMuCj4gICAg
Ki8KPgo+IC1zdHJ1Y3QgZ3VjX2Nzc19oZWFkZXIgewo+ICtzdHJ1Y3QgdWNfY3NzX2hlYWRlciB7
CgpUaGlzIG5hbWUgY2hhbmdlIGNvdWxkIGhhdmUgYmVlbiBwYXJ0IG9mIHRoZSBwcmV2aW91cyBn
bG9iYWwgCnNlYXJjaC1hbmQtcmVwbGFjZS4KCj4gICAJdWludDMyX3QgbW9kdWxlX3R5cGU7Cj4g
ICAJLyogaGVhZGVyX3NpemUgaW5jbHVkZXMgYWxsIG5vbi11Q29kZSBiaXRzLCBpbmNsdWRpbmcg
Y3NzX2hlYWRlciwgcnNhCj4gICAJICoga2V5LCBtb2R1bHVzIGtleSBhbmQgZXhwb25lbnQgZGF0
YS4gKi8KPiBAQCAtMjEzLDcgKzIyMCwxMCBAQCBzdHJ1Y3QgZ3VjX2Nzc19oZWFkZXIgewo+Cj4g
ICAJY2hhciB1c2VybmFtZVs4XTsKPiAgIAljaGFyIGJ1aWxkbnVtYmVyWzEyXTsKPiAtCXVpbnQz
Ml90IGRldmljZV9pZDsKPiArCXVuaW9uIHsKPiArCQl1aW50MzJfdCBkZXZpY2VfaWQ7Cj4gKwkJ
dWludDMyX3QgaHVjX3N3X3ZlcnNpb247Cj4gKwl9Owo+ICAgCXVpbnQzMl90IGd1Y19zd192ZXJz
aW9uOwo+ICAgCXVpbnQzMl90IHByb2RfcHJlcHJvZF9mdzsKPiAgIAl1aW50MzJfdCByZXNlcnZl
ZFsxMl07CgpUaGlzIGNhbid0IHJlYWxseSBiZSByaWdodDsgdGhlIEh1QyBmL3cgaGVhZGVyIGRv
ZXNuJ3QgY29udGFpbiBhIApndWNfc3dfdmVyc2lvbiEgU28gdGhlIHVuaW9uIG11c3QgYmUgbW9y
ZSBsaWtlOgoKCXVuaW9uIHsKCQlzdHJ1Y3QgewoJCQl1aW50MzJfdCBkZXZpY2VfaWQ7CgkJCXVp
bnQzMl90IGd1Y19zd192ZXJzaW9uOwoJCQl1aW50MzJfdCBwcm9kX3ByZXByb2RfZnc7CgkJfSBn
dWNfZGF0YTsKCQlzdHJ1Y3QgewoJCQl1aW50MzJfdCBodWNfc3dfdmVyc2lvbjsKCQkJdWludDMy
X3QgcHJvZF9wcmVwcm9kX2Z3OwoJCQl1aW50MzJfdCBkdW1teTsKCQl9IGh1Y19kYXRhOwoJfTsK
ICAgIAl1aW50MzJfdCByZXNlcnZlZFsxMl07CgouLi4gb3Igc29tZXRoaW5nIC0gSSBkb24ndCBr
bm93IHdoYXQgdGhlIGFjdHVhbCBsYXlvdXQgaXMgaGVyZS4KCk90aGVyd2lzZSBnZW5lcmFsbHkg
T0suCgouRGF2ZS4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1
Y19sb2FkZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+IGlu
ZGV4IGZmMDU0ZjUuLjcwNTc1YmQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZ3VjX2xvYWRlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3Vj
X2xvYWRlci5jCj4gQEAgLTU3NCw3ICs1NzQsNyBAQCB2b2lkIGludGVsX3VjX2Z3X2ZldGNoKHN0
cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBpbnRlbF91Y19mdyAqdWNfZncpCj4gICB7Cj4g
ICAJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iajsKPiAgIAljb25zdCBzdHJ1Y3QgZmly
bXdhcmUgKmZ3Owo+IC0Jc3RydWN0IGd1Y19jc3NfaGVhZGVyICpjc3M7Cj4gKwlzdHJ1Y3QgdWNf
Y3NzX2hlYWRlciAqY3NzOwo+ICAgCXNpemVfdCBzaXplOwo+ICAgCWludCBlcnI7Cj4KPiBAQCAt
NTkxLDE5ICs1OTEsMTkgQEAgdm9pZCBpbnRlbF91Y19md19mZXRjaChzdHJ1Y3QgZHJtX2Rldmlj
ZSAqZGV2LCBzdHJ1Y3QgaW50ZWxfdWNfZncgKnVjX2Z3KQo+ICAgCQl1Y19mdy0+dWNfZndfcGF0
aCwgZncpOwo+Cj4gICAJLyogQ2hlY2sgdGhlIHNpemUgb2YgdGhlIGJsb2IgYmVmb3JlIGV4YW1p
bmluZyBidWZmZXIgY29udGVudHMgKi8KPiAtCWlmIChmdy0+c2l6ZSA8IHNpemVvZihzdHJ1Y3Qg
Z3VjX2Nzc19oZWFkZXIpKSB7Cj4gKwlpZiAoZnctPnNpemUgPCBzaXplb2Yoc3RydWN0IHVjX2Nz
c19oZWFkZXIpKSB7Cj4gICAJCURSTV9FUlJPUigiRmlybXdhcmUgaGVhZGVyIGlzIG1pc3Npbmdc
biIpOwo+ICAgCQlnb3RvIGZhaWw7Cj4gICAJfQo+Cj4gLQljc3MgPSAoc3RydWN0IGd1Y19jc3Nf
aGVhZGVyICopZnctPmRhdGE7Cj4gKwljc3MgPSAoc3RydWN0IHVjX2Nzc19oZWFkZXIgKilmdy0+
ZGF0YTsKPgo+ICAgCS8qIEZpcm13YXJlIGJpdHMgYWx3YXlzIHN0YXJ0IGZyb20gaGVhZGVyICov
Cj4gICAJdWNfZnctPmhlYWRlcl9vZmZzZXQgPSAwOwo+ICAgCXVjX2Z3LT5oZWFkZXJfc2l6ZSA9
IChjc3MtPmhlYWRlcl9zaXplX2R3IC0gY3NzLT5tb2R1bHVzX3NpemVfZHcgLQo+ICAgCQljc3Mt
PmtleV9zaXplX2R3IC0gY3NzLT5leHBvbmVudF9zaXplX2R3KSAqIHNpemVvZih1MzIpOwo+Cj4g
LQlpZiAodWNfZnctPmhlYWRlcl9zaXplICE9IHNpemVvZihzdHJ1Y3QgZ3VjX2Nzc19oZWFkZXIp
KSB7Cj4gKwlpZiAodWNfZnctPmhlYWRlcl9zaXplICE9IHNpemVvZihzdHJ1Y3QgdWNfY3NzX2hl
YWRlcikpIHsKPiAgIAkJRFJNX0VSUk9SKCJDU1MgaGVhZGVyIGRlZmluaXRpb24gbWlzbWF0Y2hc
biIpOwo+ICAgCQlnb3RvIGZhaWw7Cj4gICAJfQo+IEBAIC02MjcsMjMgKzYyNywzNSBAQCB2b2lk
IGludGVsX3VjX2Z3X2ZldGNoKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBpbnRlbF91
Y19mdyAqdWNfZncpCj4gICAJCWdvdG8gZmFpbDsKPiAgIAl9Cj4KPiAtCS8qIEhlYWRlciBhbmQg
dUNvZGUgd2lsbCBiZSBsb2FkZWQgdG8gV09QQ00uIFNpemUgb2YgdGhlIHR3by4gKi8KPiAtCXNp
emUgPSB1Y19mdy0+aGVhZGVyX3NpemUgKyB1Y19mdy0+dWNvZGVfc2l6ZTsKPiAtCj4gLQkvKiBU
b3AgMzJrIG9mIFdPUENNIGlzIHJlc2VydmVkICg4SyBzdGFjayArIDI0ayBSQzYgY29udGV4dCku
ICovCj4gLQlpZiAoc2l6ZSA+IGd1Y193b3BjbV9zaXplKGRldi0+ZGV2X3ByaXZhdGUpKSB7Cj4g
LQkJRFJNX0VSUk9SKCJGaXJtd2FyZSBpcyB0b28gbGFyZ2UgdG8gZml0IGluIFdPUENNXG4iKTsK
PiAtCQlnb3RvIGZhaWw7Cj4gLQl9Cj4gLQo+ICAgCS8qCj4gICAJICogVGhlIHVDIGZpcm13YXJl
IGltYWdlIGhhcyB0aGUgdmVyc2lvbiBudW1iZXIgZW1iZWRkZWQgYXQgYSB3ZWxsLWtub3duCj4g
ICAJICogb2Zmc2V0IHdpdGhpbiB0aGUgZmlybXdhcmUgYmxvYjsgbm90ZSB0aGF0IG1ham9yIC8g
bWlub3IgdmVyc2lvbiBhcmUKPiAgIAkgKiBUV08gYnl0ZXMgZWFjaCAoaS5lLiB1MTYpLCBhbHRo
b3VnaCBhbGwgcG9pbnRlcnMgYW5kIG9mZnNldHMgYXJlIGRlZmluZWQKPiAgIAkgKiBpbiB0ZXJt
cyBvZiBieXRlcyAodTgpLgo+ICAgCSAqLwo+IC0JdWNfZnctPm1ham9yX3Zlcl9mb3VuZCA9IGNz
cy0+Z3VjX3N3X3ZlcnNpb24gPj4gMTY7Cj4gLQl1Y19mdy0+bWlub3JfdmVyX2ZvdW5kID0gY3Nz
LT5ndWNfc3dfdmVyc2lvbiAmIDB4RkZGRjsKPiArCXN3aXRjaCAodWNfZnctPmZ3X3R5cGUpIHsK
PiArCWNhc2UgVUNfRldfVFlQRV9HVUM6Cj4gKwkJLyogSGVhZGVyIGFuZCB1Q29kZSB3aWxsIGJl
IGxvYWRlZCB0byBXT1BDTS4gU2l6ZSBvZiB0aGUgdHdvLiAqLwo+ICsJCXNpemUgPSB1Y19mdy0+
aGVhZGVyX3NpemUgKyB1Y19mdy0+dWNvZGVfc2l6ZTsKPiArCj4gKwkJLyogVG9wIDMyayBvZiBX
T1BDTSBpcyByZXNlcnZlZCAoOEsgc3RhY2sgKyAyNGsgUkM2IGNvbnRleHQpLiAqLwo+ICsJCWlm
IChzaXplID4gZ3VjX3dvcGNtX3NpemUoZGV2LT5kZXZfcHJpdmF0ZSkpIHsKPiArCQkJRFJNX0VS
Uk9SKCJGaXJtd2FyZSBpcyB0b28gbGFyZ2UgdG8gZml0IGluIFdPUENNXG4iKTsKPiArCQkJZ290
byBmYWlsOwo+ICsJCX0KPiArCj4gKwkJdWNfZnctPm1ham9yX3Zlcl9mb3VuZCA9IGNzcy0+Z3Vj
X3N3X3ZlcnNpb24gPj4gMTY7Cj4gKwkJdWNfZnctPm1pbm9yX3Zlcl9mb3VuZCA9IGNzcy0+Z3Vj
X3N3X3ZlcnNpb24gJiAweEZGRkY7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIFVDX0ZXX1RZUEVfSFVD
Ogo+ICsJCXVjX2Z3LT5tYWpvcl92ZXJfZm91bmQgPSBjc3MtPmh1Y19zd192ZXJzaW9uID4+IDE2
Owo+ICsJCXVjX2Z3LT5taW5vcl92ZXJfZm91bmQgPSBjc3MtPmh1Y19zd192ZXJzaW9uICYgMHhG
RkZGOwo+ICsJCWJyZWFrOwo+ICsJZGVmYXVsdDoKPiArCQlEUk1fRVJST1IoIlVua25vd24gZmly
bXdhcmUgdHlwZSAlZFxuIiwgdWNfZnctPmZ3X3R5cGUpOwo+ICsJCWVyciA9IC1FTk9FWEVDOwo+
ICsJCWdvdG8gZmFpbDsKPiArCX0KPgo+ICAgCWlmICh1Y19mdy0+bWFqb3JfdmVyX2ZvdW5kICE9
IHVjX2Z3LT5tYWpvcl92ZXJfd2FudGVkIHx8Cj4gICAJICAgIHVjX2Z3LT5taW5vcl92ZXJfZm91
bmQgPCB1Y19mdy0+bWlub3JfdmVyX3dhbnRlZCkgewo+CgpfX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm
eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp
bG1hbi9saXN0aW5mby9pbnRlbC1nZngK