From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 6/6] drm/i915/huc: Add BXT HuC Loading Support Date: Tue, 28 Jun 2016 16:20:43 +0100 Message-ID: <577295CB.1090403@intel.com> References: <1466532685-5101-1-git-send-email-peter.antoine@intel.com> <1466532685-5101-7-git-send-email-peter.antoine@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id F40336E5C7 for ; Tue, 28 Jun 2016 15:24:59 +0000 (UTC) In-Reply-To: <1466532685-5101-7-git-send-email-peter.antoine@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Peter Antoine , intel-gfx@lists.freedesktop.org Cc: sean.v.kelley@intel.com, lawrence.t.li@intel.com, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gMjEvMDYvMTYgMTk6MTEsIFBldGVyIEFudG9pbmUgd3JvdGU6Cj4gVGhpcyBwYXRjaCBhZGRz IHRoZSBIdUMgTG9hZGluZyBmb3IgdGhlIEJYVC4KPiBWZXJzaW9uIDEueCBvZiB0aGUgSHVDIGZp cm13YXJlLgo+Cj4gU2lnbmVkLW9mZi1ieTogUGV0ZXIgQW50b2luZSA8cGV0ZXIuYW50b2luZUBp bnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAg ICAgfCAxMyArKystLS0tLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNf bG9hZGVyLmMgfCAyOSArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfaHVjX2xvYWRlci5jIHwgIDcgKysrKysrKwo+ICAgMyBmaWxlcyBj aGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW0uYwo+IGluZGV4IDU0OWRkM2YuLjZhYmQ1ZTUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtLmMKPiBAQCAtNTE0MywxNiArNTE0Myw5IEBAIGk5MTVfZ2VtX2luaXRfaHcoc3RydWN0 IGRybV9kZXZpY2UgKmRldikKPiAgIAlpbnRlbF9tb2NzX2luaXRfbDNjY190YWJsZShkZXYpOwo+ Cj4gICAJLyogV2UgY2FuJ3QgZW5hYmxlIGNvbnRleHRzIHVudGlsIGFsbCBmaXJtd2FyZSBpcyBs b2FkZWQgKi8KPiAtCWlmIChIQVNfR1VDKGRldikpIHsKPiAtCQkvKiBpbml0IFdPUENNICovCj4g LQkJSTkxNV9XUklURShHVUNfV09QQ01fU0laRSwgZ3VjX3dvcGNtX3NpemUoZGV2KSk7Cj4gLQkJ STkxNV9XUklURShETUFfR1VDX1dPUENNX09GRlNFVCwgR1VDX1dPUENNX09GRlNFVF9WQUxVRSk7 Cj4gLQo+IC0JCWludGVsX2h1Y19sb2FkKGRldik7Cj4gLQkJcmV0ID0gaW50ZWxfZ3VjX3NldHVw KGRldik7Cj4gLQkJaWYgKHJldCkKPiAtCQkJZ290byBvdXQ7Cj4gLQl9Cj4gKwlyZXQgPSBpbnRl bF9ndWNfc2V0dXAoZGV2KTsKPiArCWlmIChyZXQpCj4gKwkJZ290byBvdXQ7CgpUaGlzIHJldmVy dHMgb25lIG9mIHRoZSBlYXJsaWVyIGNoYW5nZXMgdGhhdCBJIG9iamVjdGVkIHRvIQpQbGVhc2Ug c3F1YXNoIHRoZW0gdG9nZXRoZXIgc28gaXQgaXNuJ3QgY2hhbmdlZCBhbmQgdGhlbiBjaGFuZ2Vk IGJhY2suCgo+ICAgCS8qCj4gICAJICogSW5jcmVtZW50IHRoZSBuZXh0IHNlcW5vIGJ5IDB4MTAw IHNvIHdlIGhhdmUgYSB2aXNpYmxlIGJyZWFrCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1 Y19sb2FkZXIuYwo+IGluZGV4IGU4NzZhMjNmLi4yODliNWI2IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+IEBAIC04Miw2ICs4MiwxNyBAQCBjb25zdCBjaGFy ICppbnRlbF91Y19md19zdGF0dXNfcmVwcihlbnVtIGludGVsX3VjX2Z3X3N0YXR1cyBzdGF0dXMp Cj4gICAJfQo+ICAgfTsKPgo+ICt1MzIgZ3VjX3dvcGNtX3NpemUoc3RydWN0IGRybV9kZXZpY2Ug KmRldikKPiArewo+ICsJdTMyIHdvcGNtX3NpemUgPSBHVUNfV09QQ01fVE9QOwo+ICsKPiArCS8q IE9uIEJYVCwgdGhlIHRvcCBvZiBXT1BDTSBpcyByZXNlcnZlZCBmb3IgUkM2IGNvbnRleHQgKi8K PiArCWlmIChJU19CUk9YVE9OKGRldikpCj4gKwkJd29wY21fc2l6ZSAtPSBCWFRfR1VDX1dPUENN X1JDNl9SRVNFUlZFRDsKPiArCj4gKwlyZXR1cm4gd29wY21fc2l6ZTsKPiArfQo+ICsKPiAgIHN0 YXRpYyB2b2lkIGRpcmVjdF9pbnRlcnJ1cHRzX3RvX2hvc3Qoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ICAgewo+ICAgCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZTsK PiBAQCAtMjk2LDE3ICszMDcsNiBAQCBzdGF0aWMgaW50IGd1Y191Y29kZV94ZmVyX2RtYShzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJcmV0dXJuIHJldDsKPiAgIH0KPgo+ IC11MzIgZ3VjX3dvcGNtX3NpemUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAtewo+IC0JdTMy IHdvcGNtX3NpemUgPSBHVUNfV09QQ01fVE9QOwo+IC0KPiAtCS8qIE9uIEJYVCwgdGhlIHRvcCBv ZiBXT1BDTSBpcyByZXNlcnZlZCBmb3IgUkM2IGNvbnRleHQgKi8KPiAtCWlmIChJU19CUk9YVE9O KGRldikpCj4gLQkJd29wY21fc2l6ZSAtPSBCWFRfR1VDX1dPUENNX1JDNl9SRVNFUlZFRDsKPiAt Cj4gLQlyZXR1cm4gd29wY21fc2l6ZTsKPiAtfQo+IC0KClRoaXMgaXMganVzdCBiZWluZyBtb3Zl ZCBhcm91bmQ/IERvZXMgaXQgbmVlZCB0byBiZT8KCj4gICAvKgo+ICAgICogTG9hZCB0aGUgR3VD IGZpcm13YXJlIGJsb2IgaW50byB0aGUgTWludXRlSUEuCj4gICAgKi8KPiBAQCAtMzMzLDYgKzMz MywxMCBAQCBzdGF0aWMgaW50IGd1Y191Y29kZV94ZmVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPgo+ICAgCWludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0KGRldl9wcml2LCBG T1JDRVdBS0VfQUxMKTsKPgo+ICsJLyogaW5pdCBXT1BDTSAqLwo+ICsJSTkxNV9XUklURShHVUNf V09QQ01fU0laRSwgZ3VjX3dvcGNtX3NpemUoZGV2KSk7Cj4gKwlJOTE1X1dSSVRFKERNQV9HVUNf V09QQ01fT0ZGU0VULCBHVUNfV09QQ01fT0ZGU0VUX1ZBTFVFKTsKPiArCgpJcyB0aGlzIGJlaW5n IG1vdmVkIGFyb3VuZCAoYWdhaW4/KQpJIHRoaW5rIHdlIHNob3VsZCBlbmQgdXAgd2l0aCBHVUNf V09QQ01fU0laRSBiZWluZyBzZXQganVzdCBvbmNlLgoKPiAgIAkvKiBFbmFibGUgTUlBIGNhY2hp bmcuIEd1QyBjbG9jayBnYXRpbmcgaXMgZGlzYWJsZWQuICovCj4gICAJSTkxNV9XUklURShHVUNf U0hJTV9DT05UUk9MLCBHVUNfU0hJTV9DT05UUk9MX1ZBTFVFKTsKPgo+IEBAIC00ODMsNiArNDg3 LDcgQEAgaW50IGludGVsX2d1Y19zZXR1cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgCQkJ Z290byBmYWlsOwo+ICAgCQl9Cj4KPiArCQlpbnRlbF9odWNfbG9hZChkZXYpOwo+ICAgCQllcnIg PSBndWNfdWNvZGVfeGZlcihkZXZfcHJpdik7Cj4gICAJCWlmICghZXJyKQo+ICAgCQkJYnJlYWs7 Cj4gQEAgLTYzOCw3ICs2NDMsNyBAQCB2b2lkIGludGVsX3VjX2Z3X2ZldGNoKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsIHN0cnVjdCBpbnRlbF91Y19mdyAqdWNfZncpCj4gICAJCXNpemUgPSB1Y19m dy0+aGVhZGVyX3NpemUgKyB1Y19mdy0+dWNvZGVfc2l6ZTsKPgo+ICAgCQkvKiBUb3AgMzJrIG9m IFdPUENNIGlzIHJlc2VydmVkICg4SyBzdGFjayArIDI0ayBSQzYgY29udGV4dCkuICovCj4gLQkJ aWYgKHNpemUgPiBndWNfd29wY21fc2l6ZShkZXYtPmRldl9wcml2YXRlKSkgewo+ICsJCWlmIChz aXplID4gZ3VjX3dvcGNtX3NpemUoZGV2KSkgewo+ICAgCQkJRFJNX0VSUk9SKCJGaXJtd2FyZSBp cyB0b28gbGFyZ2UgdG8gZml0IGluIFdPUENNXG4iKTsKPiAgIAkJCWdvdG8gZmFpbDsKPiAgIAkJ fQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9odWNfbG9hZGVyLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9odWNfbG9hZGVyLmMKPiBpbmRleCA3MjA1ZTll Li43YTQzZDRlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2h1Y19s b2FkZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2h1Y19sb2FkZXIuYwo+ IEBAIC00OSw2ICs0OSw5IEBACj4gICAjZGVmaW5lIEk5MTVfU0tMX0hVQ19VQ09ERSAiaTkxNS9z a2xfaHVjX3ZlcjEuYmluIgo+ICAgTU9EVUxFX0ZJUk1XQVJFKEk5MTVfU0tMX0hVQ19VQ09ERSk7 Cj4KPiArI2RlZmluZSBJOTE1X0JYVF9IVUNfVUNPREUgImk5MTUvYnh0X2h1Y192ZXIxLmJpbiIK PiArTU9EVUxFX0ZJUk1XQVJFKEk5MTVfQlhUX0hVQ19VQ09ERSk7Cj4gKwo+ICAgLyoqCj4gICAg KiBpbnRlbF9odWNfbG9hZF91Y29kZSgpIC0gRE1BJ3MgdGhlIGZpcm13YXJlCj4gICAgKiBAZGV2 OiB0aGUgZHJtIGRldmljZQo+IEBAIC0xNTcsNiArMTYwLDEwIEBAIHZvaWQgaW50ZWxfaHVjX2lu aXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgIAkJZndfcGF0aCA9IEk5MTVfU0tMX0hVQ19V Q09ERTsKPiAgIAkJaHVjX2Z3LT5tYWpvcl92ZXJfd2FudGVkID0gMTsKPiAgIAkJaHVjX2Z3LT5t aW5vcl92ZXJfd2FudGVkID0gNTsKPiArCX0gZWxzZSBpZiAoSVNfQlJPWFRPTihkZXYpKSB7Cj4g KwkJZndfcGF0aCA9IEk5MTVfQlhUX0hVQ19VQ09ERTsKPiArCQlodWNfZnctPm1ham9yX3Zlcl93 YW50ZWQgPSAxOwo+ICsJCWh1Y19mdy0+bWlub3JfdmVyX3dhbnRlZCA9IDA7Cj4gICAJfQo+Cj4g ICAJaWYgKGZ3X3BhdGggPT0gTlVMTCkKCk92ZXJhbGw6IEkgdGhpbmsgdGhlIGdlbmVyYWwgZnVu Y3Rpb25hbGl0eSBpcyBPSywgYnV0IHRoZXJlIGFyZSBhIGZldyAKc3BlY2lmaWMgcG9pbnRzIHRo YXQgbmVlZCB0byBiZSBmaXhlZCAodW5sZXNzIHRoZXkgYWxyZWFkeSBhcmUsIGJ5IGEgCmxhdGVy IHBhdGNoKS4gSW4gYWRkaXRpb24sIHRoZSBzZXJpZXMgbmVlZCB0byBiZSByZW9yZ2FuaXNlZCBz byB0aGF0IHdlIApkb24ndCBoYXZlIHRoZSBzYW1lIGxpbmVzIG9mIGNvZGUgcmVwZWF0ZWRseSBz aHVmZmxlZCBmcm9tIG9uZSBwbGFjZSB0byAKYW5vdGhlciwgb3IgYSBjaGFuZ2UgbWFkZSBhbmQg dGhlbiByZXZlcnRlZC4KCi5EYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK