From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: tidy up request alloc Date: Thu, 30 Jun 2016 09:50:20 +0100 Message-ID: <5774DD4C.6030702@linux.intel.com> References: <1467250532-23644-1-git-send-email-hong.liu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 637AD6E83D for ; Thu, 30 Jun 2016 08:50:22 +0000 (UTC) In-Reply-To: <1467250532-23644-1-git-send-email-hong.liu@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hong Liu , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDMwLzA2LzE2IDAyOjM1LCBIb25nIExpdSB3cm90ZToKPiBSZXR1cm4gdGhlIGFsbG9jYXRl ZCByZXF1ZXN0IHBvaW50ZXIgZGlyZWN0bHkgdG8gcmVtb3ZlCj4gdGhlIGRvdWJsZSBwb2ludGVy IHBhcmFtZXRlci4KPgo+IFNpZ25lZC1vZmYtYnk6IEhvbmcgTGl1IDxob25nLmxpdUBpbnRlbC5j b20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgMjUgKysrKysr Ky0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwg MTggZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCAxZDk4Nzgy Li45ODgxNDU1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTI5ODgsMzIgKzI5 ODgsMjYgQEAgdm9pZCBpOTE1X2dlbV9yZXF1ZXN0X2ZyZWUoc3RydWN0IGtyZWYgKnJlcV9yZWYp Cj4gICAJa21lbV9jYWNoZV9mcmVlKHJlcS0+aTkxNS0+cmVxdWVzdHMsIHJlcSk7Cj4gICB9Cj4K PiAtc3RhdGljIGlubGluZSBpbnQKPiArc3RhdGljIGlubGluZSBzdHJ1Y3QgZHJtX2k5MTVfZ2Vt X3JlcXVlc3QgKgo+ICAgX19pOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKmVuZ2luZSwKPiAtCQkJIHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsCj4gLQkJ CSBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKipyZXFfb3V0KQo+ICsJCQkgc3RydWN0IGk5 MTVfZ2VtX2NvbnRleHQgKmN0eCkKPiAgIHsKPiAgIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSBlbmdpbmUtPmk5MTU7Cj4gICAJdW5zaWduZWQgcmVzZXRfY291bnRlciA9IGk5 MTVfcmVzZXRfY291bnRlcigmZGV2X3ByaXYtPmdwdV9lcnJvcik7Cj4gICAJc3RydWN0IGRybV9p OTE1X2dlbV9yZXF1ZXN0ICpyZXE7Cj4gICAJaW50IHJldDsKPgo+IC0JaWYgKCFyZXFfb3V0KQo+ IC0JCXJldHVybiAtRUlOVkFMOwo+IC0KPiAtCSpyZXFfb3V0ID0gTlVMTDsKPiAtCj4gICAJLyog QUJJOiBCZWZvcmUgdXNlcnNwYWNlIGFjY2Vzc2VzIHRoZSBHUFUgKGUuZy4gZXhlY2J1ZmZlciks IHJlcG9ydAo+ICAgCSAqIEVJTyBpZiB0aGUgR1BVIGlzIGFscmVhZHkgd2VkZ2VkLCBvciBFQUdB SU4gdG8gZHJvcCB0aGUgc3RydWN0X211dGV4Cj4gICAJICogYW5kIHJlc3RhcnQuCj4gICAJICov Cj4gICAJcmV0ID0gaTkxNV9nZW1fY2hlY2tfd2VkZ2UocmVzZXRfY291bnRlciwgZGV2X3ByaXYt Pm1tLmludGVycnVwdGlibGUpOwo+ICAgCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiArCQly ZXR1cm4gRVJSX1BUUihyZXQpOwo+Cj4gICAJcmVxID0ga21lbV9jYWNoZV96YWxsb2MoZGV2X3By aXYtPnJlcXVlc3RzLCBHRlBfS0VSTkVMKTsKPiAgIAlpZiAocmVxID09IE5VTEwpCj4gLQkJcmV0 dXJuIC1FTk9NRU07Cj4gKwkJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4KPiAgIAlyZXQgPSBp OTE1X2dlbV9nZXRfc2Vxbm8oZW5naW5lLT5pOTE1LCAmcmVxLT5zZXFubyk7Cj4gICAJaWYgKHJl dCkKPiBAQCAtMzA0MSwxNCArMzAzNSwxMyBAQCBfX2k5MTVfZ2VtX3JlcXVlc3RfYWxsb2Moc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAgCWlmIChyZXQpCj4gICAJCWdvdG8gZXJy X2N0eDsKPgo+IC0JKnJlcV9vdXQgPSByZXE7Cj4gLQlyZXR1cm4gMDsKPiArCXJldHVybiByZXE7 Cj4KPiAgIGVycl9jdHg6Cj4gICAJaTkxNV9nZW1fY29udGV4dF91bnJlZmVyZW5jZShjdHgpOwo+ ICAgZXJyOgo+ICAgCWttZW1fY2FjaGVfZnJlZShkZXZfcHJpdi0+cmVxdWVzdHMsIHJlcSk7Cj4g LQlyZXR1cm4gcmV0Owo+ICsJcmV0dXJuIEVSUl9QVFIocmV0KTsKPiAgIH0KPgo+ICAgLyoqCj4g QEAgLTMwNjcsMTMgKzMwNjAsOSBAQCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKgo+ICAg aTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4g ICAJCSAgICAgICBzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4KQo+ICAgewo+IC0Jc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXE7Cj4gLQlpbnQgZXJyOwo+IC0KPiAgIAlpZiAoY3R4 ID09IE5VTEwpCj4gICAJCWN0eCA9IGVuZ2luZS0+aTkxNS0+a2VybmVsX2NvbnRleHQ7Cj4gLQll cnIgPSBfX2k5MTVfZ2VtX3JlcXVlc3RfYWxsb2MoZW5naW5lLCBjdHgsICZyZXEpOwo+IC0JcmV0 dXJuIGVyciA/IEVSUl9QVFIoZXJyKSA6IHJlcTsKPiArCXJldHVybiBfX2k5MTVfZ2VtX3JlcXVl c3RfYWxsb2MoZW5naW5lLCBjdHgpOwo+ICAgfQo+Cj4gICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3Jl cXVlc3QgKgo+CgpMb29rcyBnb29kIHRvIG1lLiBBbmQgaGF2ZSB0aGlzIGZlZWxpbmcgSSd2ZSBz ZWVuIHRoaXMgc29tZXdoZXJlIGJlZm9yZS4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==