From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: tidy up request alloc Date: Thu, 30 Jun 2016 13:49:14 +0100 Message-ID: <5775154A.9070005@linux.intel.com> References: <1467250532-23644-1-git-send-email-hong.liu@intel.com> <5774DD4C.6030702@linux.intel.com> <20160630102241.GY28577@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id EF3A16E41C for ; Thu, 30 Jun 2016 12:49:15 +0000 (UTC) In-Reply-To: <20160630102241.GY28577@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Hong Liu , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDMwLzA2LzE2IDExOjIyLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gVGh1LCBKdW4gMzAs IDIwMTYgYXQgMDk6NTA6MjBBTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IE9u IDMwLzA2LzE2IDAyOjM1LCBIb25nIExpdSB3cm90ZToKPj4+IFJldHVybiB0aGUgYWxsb2NhdGVk IHJlcXVlc3QgcG9pbnRlciBkaXJlY3RseSB0byByZW1vdmUKPj4+IHRoZSBkb3VibGUgcG9pbnRl ciBwYXJhbWV0ZXIuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogSG9uZyBMaXUgPGhvbmcubGl1QGlu dGVsLmNvbT4KPj4+IC0tLQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwg MjUgKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+Pj4gICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNl cnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMK Pj4+IGluZGV4IDFkOTg3ODIuLjk4ODE0NTUgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jCj4+PiBAQCAtMjk4OCwzMiArMjk4OCwyNiBAQCB2b2lkIGk5MTVfZ2VtX3JlcXVlc3RfZnJl ZShzdHJ1Y3Qga3JlZiAqcmVxX3JlZikKPj4+ICAgCWttZW1fY2FjaGVfZnJlZShyZXEtPmk5MTUt PnJlcXVlc3RzLCByZXEpOwo+Pj4gICB9Cj4+Pgo+Pj4gLXN0YXRpYyBpbmxpbmUgaW50Cj4+PiAr c3RhdGljIGlubGluZSBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKgo+Pj4gICBfX2k5MTVf Z2VtX3JlcXVlc3RfYWxsb2Moc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+Pj4gLQkJ CSBzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4LAo+Pj4gLQkJCSBzdHJ1Y3QgZHJtX2k5MTVf Z2VtX3JlcXVlc3QgKipyZXFfb3V0KQo+Pj4gKwkJCSBzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAq Y3R4KQo+Pj4gICB7Cj4+PiAgIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBl bmdpbmUtPmk5MTU7Cj4+PiAgIAl1bnNpZ25lZCByZXNldF9jb3VudGVyID0gaTkxNV9yZXNldF9j b3VudGVyKCZkZXZfcHJpdi0+Z3B1X2Vycm9yKTsKPj4+ICAgCXN0cnVjdCBkcm1faTkxNV9nZW1f cmVxdWVzdCAqcmVxOwo+Pj4gICAJaW50IHJldDsKPj4+Cj4+PiAtCWlmICghcmVxX291dCkKPj4+ IC0JCXJldHVybiAtRUlOVkFMOwo+Pj4gLQo+Pj4gLQkqcmVxX291dCA9IE5VTEw7Cj4+PiAtCj4+ PiAgIAkvKiBBQkk6IEJlZm9yZSB1c2Vyc3BhY2UgYWNjZXNzZXMgdGhlIEdQVSAoZS5nLiBleGVj YnVmZmVyKSwgcmVwb3J0Cj4+PiAgIAkgKiBFSU8gaWYgdGhlIEdQVSBpcyBhbHJlYWR5IHdlZGdl ZCwgb3IgRUFHQUlOIHRvIGRyb3AgdGhlIHN0cnVjdF9tdXRleAo+Pj4gICAJICogYW5kIHJlc3Rh cnQuCj4+PiAgIAkgKi8KPj4+ICAgCXJldCA9IGk5MTVfZ2VtX2NoZWNrX3dlZGdlKHJlc2V0X2Nv dW50ZXIsIGRldl9wcml2LT5tbS5pbnRlcnJ1cHRpYmxlKTsKPj4+ICAgCWlmIChyZXQpCj4+PiAt CQlyZXR1cm4gcmV0Owo+Pj4gKwkJcmV0dXJuIEVSUl9QVFIocmV0KTsKPj4+Cj4+PiAgIAlyZXEg PSBrbWVtX2NhY2hlX3phbGxvYyhkZXZfcHJpdi0+cmVxdWVzdHMsIEdGUF9LRVJORUwpOwo+Pj4g ICAJaWYgKHJlcSA9PSBOVUxMKQo+Pj4gLQkJcmV0dXJuIC1FTk9NRU07Cj4+PiArCQlyZXR1cm4g RVJSX1BUUigtRU5PTUVNKTsKPj4+Cj4+PiAgIAlyZXQgPSBpOTE1X2dlbV9nZXRfc2Vxbm8oZW5n aW5lLT5pOTE1LCAmcmVxLT5zZXFubyk7Cj4+PiAgIAlpZiAocmV0KQo+Pj4gQEAgLTMwNDEsMTQg KzMwMzUsMTMgQEAgX19pOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRlbF9lbmdpbmVf Y3MgKmVuZ2luZSwKPj4+ICAgCWlmIChyZXQpCj4+PiAgIAkJZ290byBlcnJfY3R4Owo+Pj4KPj4+ IC0JKnJlcV9vdXQgPSByZXE7Cj4+PiAtCXJldHVybiAwOwo+Pj4gKwlyZXR1cm4gcmVxOwo+Pj4K Pj4+ICAgZXJyX2N0eDoKPj4+ICAgCWk5MTVfZ2VtX2NvbnRleHRfdW5yZWZlcmVuY2UoY3R4KTsK Pj4+ICAgZXJyOgo+Pj4gICAJa21lbV9jYWNoZV9mcmVlKGRldl9wcml2LT5yZXF1ZXN0cywgcmVx KTsKPj4+IC0JcmV0dXJuIHJldDsKPj4+ICsJcmV0dXJuIEVSUl9QVFIocmV0KTsKPj4+ICAgfQo+ Pj4KPj4+ICAgLyoqCj4+PiBAQCAtMzA2NywxMyArMzA2MCw5IEBAIHN0cnVjdCBkcm1faTkxNV9n ZW1fcmVxdWVzdCAqCj4+PiAgIGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2Moc3RydWN0IGludGVsX2Vu Z2luZV9jcyAqZW5naW5lLAo+Pj4gICAJCSAgICAgICBzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAq Y3R4KQo+Pj4gICB7Cj4+PiAtCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxOwo+Pj4g LQlpbnQgZXJyOwo+Pj4gLQo+Pj4gICAJaWYgKGN0eCA9PSBOVUxMKQo+Pj4gICAJCWN0eCA9IGVu Z2luZS0+aTkxNS0+a2VybmVsX2NvbnRleHQ7Cj4+PiAtCWVyciA9IF9faTkxNV9nZW1fcmVxdWVz dF9hbGxvYyhlbmdpbmUsIGN0eCwgJnJlcSk7Cj4+PiAtCXJldHVybiBlcnIgPyBFUlJfUFRSKGVy cikgOiByZXE7Cj4+PiArCXJldHVybiBfX2k5MTVfZ2VtX3JlcXVlc3RfYWxsb2MoZW5naW5lLCBj dHgpOwo+Pj4gICB9Cj4+Pgo+Pj4gICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKgo+Pj4K Pj4KPj4gTG9va3MgZ29vZCB0byBtZS4gQW5kIGhhdmUgdGhpcyBmZWVsaW5nIEkndmUgc2VlbiB0 aGlzIHNvbWV3aGVyZSBiZWZvcmUuCj4KPiBTZXZlcmFsIHRpbWVzLiBUaGlzIGlzIG5vdCB0aGUg ZnVsbCB0aWR5LCBub3IgZG9lcyBpdCByZWFsaXNlIHRoZQo+IHJhbWlmYWN0aW9ucyBvZiByZXF1 ZXN0IGFsbG9jIHRocm91Z2ggdGhlIHN0YWNrLgoKSG0gSSBjYW4ndCBzcG90IHRoYXQgaXQgaXMg ZG9pbmcgYW55dGhpbmcgd3Jvbmcgb3IgbWFraW5nIGFueXRoaW5nIAp3b3JzZS4gWW91IGRvbid0 IHdhbnQgdG8gbGV0IHRoZSBzbWFsbCBjbGVhbnVwIGluPwoKUmVnYXJkcywKClR2cnRrbwoKCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK