From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 2/4] drm/i915: Convert sandybridge_pcode_*()
 to use intel_wait_for_register()
Date: Thu, 30 Jun 2016 14:04:43 +0100
Message-ID: <577518EB.1000005@linux.intel.com>
References: <1467286215-8357-1-git-send-email-chris@chris-wilson.co.uk>
 <1467286215-8357-2-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id 7B4C06E87B
 for <intel-gfx@lists.freedesktop.org>; Thu, 30 Jun 2016 13:05:19 +0000 (UTC)
In-Reply-To: <1467286215-8357-2-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDMwLzA2LzE2IDEyOjMwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gV2Ugd2FudCB0byByZXBs
YWNlIHRoZSBpbmxpbmUgd2FpdF9mb3IoKSB3aXRoIGFuIG91dC1vZi1saW5lIGh5YnJpZAo+IGJ1
c3kvc2xlZXAgd2FpdF9mb3IoKSBpbiB0aGUgaG9wZXMgb2Ygc3BlZWRpbmcgdXAgdGhlIGNvbW11
bmljYXRpb24gd2l0Cj4gdGhlIFBDb2RlIHVuaXQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBX
aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlr
YS5rdW9wcGFsYUBpbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs
YUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBp
bnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIHwgNDMg
KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFu
Z2VkLCAyOCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfcG0uYwo+IGluZGV4IGQ3ZjhiYTg5ZDJhNS4uZjg0YmYyNTNkMDRhIDEwMDY0NAo+IC0tLSBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9wbS5jCj4gQEAgLTc2MjMsNDYgKzc2MjMsNTkgQEAgaW50IHNhbmR5YnJpZGdl
X3Bjb2RlX3JlYWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgbWJveCwg
dTMyICp2YWwKPiAgIHsKPiAgIAlXQVJOX09OKCFtdXRleF9pc19sb2NrZWQoJmRldl9wcml2LT5y
cHMuaHdfbG9jaykpOwo+Cj4gLQlpZiAoSTkxNV9SRUFEKEdFTjZfUENPREVfTUFJTEJPWCkgJiBH
RU42X1BDT0RFX1JFQURZKSB7Cj4gKwkvKiBHRU42X1BDT0RFXyogYXJlIG91dHNpZGUgb2YgdGhl
IGZvcmNld2FrZSBkb21haW4sIHdlIGNhbgo+ICsJICogdXNlIHRlIGZ3IEk5MTVfUkVBRCB2YXJp
YW50cyB0byByZWR1Y2UgdGhlIGFtb3VudCBvZiB3b3JrCj4gKwkgKiByZXF1aXJlZCB3aGVuIHJl
YWRpbmcvd3JpdGluZy4KPiArCSAqLwo+ICsKPiArCWlmIChJOTE1X1JFQURfRlcoR0VONl9QQ09E
RV9NQUlMQk9YKSAmIEdFTjZfUENPREVfUkVBRFkpIHsKPiAgIAkJRFJNX0RFQlVHX0RSSVZFUigi
d2FybmluZzogcGNvZGUgKHJlYWQpIG1haWxib3ggYWNjZXNzIGZhaWxlZFxuIik7Cj4gICAJCXJl
dHVybiAtRUFHQUlOOwo+ICAgCX0KPgo+IC0JSTkxNV9XUklURShHRU42X1BDT0RFX0RBVEEsICp2
YWwpOwo+IC0JSTkxNV9XUklURShHRU42X1BDT0RFX0RBVEExLCAwKTsKPiAtCUk5MTVfV1JJVEUo
R0VONl9QQ09ERV9NQUlMQk9YLCBHRU42X1BDT0RFX1JFQURZIHwgbWJveCk7Cj4gKwlJOTE1X1dS
SVRFX0ZXKEdFTjZfUENPREVfREFUQSwgKnZhbCk7Cj4gKwlJOTE1X1dSSVRFX0ZXKEdFTjZfUENP
REVfREFUQTEsIDApOwo+ICsJSTkxNV9XUklURV9GVyhHRU42X1BDT0RFX01BSUxCT1gsIEdFTjZf
UENPREVfUkVBRFkgfCBtYm94KTsKPgo+IC0JaWYgKHdhaXRfZm9yKChJOTE1X1JFQUQoR0VONl9Q
Q09ERV9NQUlMQk9YKSAmIEdFTjZfUENPREVfUkVBRFkpID09IDAsCj4gLQkJICAgICA1MDApKSB7
Cj4gKwlpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsCj4gKwkJCQkgICAgR0VO
Nl9QQ09ERV9NQUlMQk9YLCBHRU42X1BDT0RFX1JFQURZLCAwLAo+ICsJCQkJICAgIDUwMCkpIHsK
CldoeSBub3QgdGhlIF9mdyB2ZXJzaW9uPwoKQWN0dWFsbHkgYnJpbmdzIG1lIHRvIHRoZSBwb2lu
dCBJIGdsYW5jZWQgb3ZlciBpbiB0aGUgcHJldmlvdXMgcGF0Y2ggLSAKd2h5IHdvdWxkIGludGVs
X3dhaXRfZm9yX3JlZ2lzdGVyX2Z3IGJlIG5vdCBzdWl0YWJsZSBmb3IgbG9uZyB3YWl0cz8gSXQg
Cmxvb2tzIGxpa2UgYSBjb25jZXJuIGZvciB0aGUgY2FsbGluZyBjb2RlIGdyYWJiaW5nIHRoZSBm
dyBvdXRzaWRlIGl0IGZvciAKYSBsb25nIHBlcmlvZCBhbmQgbm90IGZvciB0aGUgZnVuY3Rpb24g
aXRzZWxmLiBUaGlzIGNhbGwgc2l0ZSBiZWluZyBhIApjYXNlIGluIHBvaW50IGZvciB0aGF0LgoK
PiAgIAkJRFJNX0VSUk9SKCJ0aW1lb3V0IHdhaXRpbmcgZm9yIHBjb2RlIHJlYWQgKCVkKSB0byBm
aW5pc2hcbiIsIG1ib3gpOwo+ICAgCQlyZXR1cm4gLUVUSU1FRE9VVDsKPiAgIAl9Cj4KPiAtCSp2
YWwgPSBJOTE1X1JFQUQoR0VONl9QQ09ERV9EQVRBKTsKPiAtCUk5MTVfV1JJVEUoR0VONl9QQ09E
RV9EQVRBLCAwKTsKPiArCSp2YWwgPSBJOTE1X1JFQURfRlcoR0VONl9QQ09ERV9EQVRBKTsKPiAr
CUk5MTVfV1JJVEVfRlcoR0VONl9QQ09ERV9EQVRBLCAwKTsKPgo+ICAgCXJldHVybiAwOwo+ICAg
fQo+Cj4gLWludCBzYW5keWJyaWRnZV9wY29kZV93cml0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0
ZSAqZGV2X3ByaXYsIHUzMiBtYm94LCB1MzIgdmFsKQo+ICtpbnQgc2FuZHlicmlkZ2VfcGNvZGVf
d3JpdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkgICAgICAgdTMy
IG1ib3gsIHUzMiB2YWwpCj4gICB7Cj4gICAJV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZkZXZf
cHJpdi0+cnBzLmh3X2xvY2spKTsKPgo+IC0JaWYgKEk5MTVfUkVBRChHRU42X1BDT0RFX01BSUxC
T1gpICYgR0VONl9QQ09ERV9SRUFEWSkgewo+ICsJLyogR0VONl9QQ09ERV8qIGFyZSBvdXRzaWRl
IG9mIHRoZSBmb3JjZXdha2UgZG9tYWluLCB3ZSBjYW4KPiArCSAqIHVzZSB0ZSBmdyBJOTE1X1JF
QUQgdmFyaWFudHMgdG8gcmVkdWNlIHRoZSBhbW91bnQgb2Ygd29yawo+ICsJICogcmVxdWlyZWQg
d2hlbiByZWFkaW5nL3dyaXRpbmcuCj4gKwkgKi8KPiArCj4gKwlpZiAoSTkxNV9SRUFEX0ZXKEdF
TjZfUENPREVfTUFJTEJPWCkgJiBHRU42X1BDT0RFX1JFQURZKSB7Cj4gICAJCURSTV9ERUJVR19E
UklWRVIoIndhcm5pbmc6IHBjb2RlICh3cml0ZSkgbWFpbGJveCBhY2Nlc3MgZmFpbGVkXG4iKTsK
PiAgIAkJcmV0dXJuIC1FQUdBSU47Cj4gICAJfQo+Cj4gLQlJOTE1X1dSSVRFKEdFTjZfUENPREVf
REFUQSwgdmFsKTsKPiAtCUk5MTVfV1JJVEUoR0VONl9QQ09ERV9NQUlMQk9YLCBHRU42X1BDT0RF
X1JFQURZIHwgbWJveCk7Cj4gKwlJOTE1X1dSSVRFX0ZXKEdFTjZfUENPREVfREFUQSwgdmFsKTsK
PiArCUk5MTVfV1JJVEVfRlcoR0VONl9QQ09ERV9NQUlMQk9YLCBHRU42X1BDT0RFX1JFQURZIHwg
bWJveCk7Cj4KPiAtCWlmICh3YWl0X2ZvcigoSTkxNV9SRUFEKEdFTjZfUENPREVfTUFJTEJPWCkg
JiBHRU42X1BDT0RFX1JFQURZKSA9PSAwLAo+IC0JCSAgICAgNTAwKSkgewo+ICsJaWYgKGludGVs
X3dhaXRfZm9yX3JlZ2lzdGVyX2Z3KGRldl9wcml2LAo+ICsJCQkJICAgICAgIEdFTjZfUENPREVf
TUFJTEJPWCwgR0VONl9QQ09ERV9SRUFEWSwgMCwKPiArCQkJCSAgICAgICA1MDApKSB7CgpIZXJl
IHlvdSB1c2UgdGhlIF9mdyB2YXJpYW50LgoKPiAgIAkJRFJNX0VSUk9SKCJ0aW1lb3V0IHdhaXRp
bmcgZm9yIHBjb2RlIHdyaXRlICglZCkgdG8gZmluaXNoXG4iLCBtYm94KTsKPiAgIAkJcmV0dXJu
IC1FVElNRURPVVQ7Cj4gICAJfQo+Cj4gLQlJOTE1X1dSSVRFKEdFTjZfUENPREVfREFUQSwgMCk7
Cj4gKwlJOTE1X1dSSVRFX0ZXKEdFTjZfUENPREVfREFUQSwgMCk7Cj4KPiAgIAlyZXR1cm4gMDsK
PiAgIH0KPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m
cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0
aW5mby9pbnRlbC1nZngK