From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915: Convert wait_for(I915_READ(reg)) to intel_wait_for_register()
Date: Thu, 30 Jun 2016 14:42:32 +0100 [thread overview]
Message-ID: <577521C8.3090503@linux.intel.com> (raw)
In-Reply-To: <20160630133445.GA28577@nuc-i3427.alporthouse.com>
On 30/06/16 14:34, Chris Wilson wrote:
> On Thu, Jun 30, 2016 at 02:27:55PM +0100, Tvrtko Ursulin wrote:
>> On 30/06/16 12:30, Chris Wilson wrote:
>>> By using the out-of-line intel_wait_for_register() not only do we can
>>> efficiency from using the hybrid wait_for() contained within, but we
>>> avoid code bloat from the numerous inlined loops:
>>>
>>> text data bss dec hex filename
>>> 1078551 4557 416 1083524 108884 drivers/gpu/drm/i915/i915.ko
>>> 1070775 4557 416 1075748 106a24 drivers/gpu/drm/i915/i915.ko
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
>> Read it all and did not spot any errors.
>>
>> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> I think I will split this patch into per-file changes just to help
> bisection, just in case. I just wanted to share how big an impact this
> is. (There are still more we can do mostly for vlv sidebands.)
Certainly would not harm, although for bisection it is mostly already
naturally split by platforms and features.
> Mind if I keep your r-b tag on splitting?
Don't mind. Certainly prefer that to re-reading it! :D
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-06-30 13:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 11:30 [PATCH 1/4] drm/i915: Use a hybrid scheme for fast register waits Chris Wilson
2016-06-30 11:30 ` [PATCH 2/4] drm/i915: Convert sandybridge_pcode_*() to use intel_wait_for_register() Chris Wilson
2016-06-30 13:04 ` Tvrtko Ursulin
2016-06-30 13:19 ` Chris Wilson
2016-06-30 13:39 ` Tvrtko Ursulin
2016-06-30 19:21 ` Matt Turner
2016-06-30 11:30 ` [PATCH 3/4] drm/i915: Convert wait_for(I915_READ(reg)) to intel_wait_for_register() Chris Wilson
2016-06-30 13:27 ` Tvrtko Ursulin
2016-06-30 13:34 ` Chris Wilson
2016-06-30 13:42 ` Tvrtko Ursulin [this message]
2016-06-30 11:30 ` [PATCH 4/4] drm/i915: Perform Sandybridge BSD tail write under the forcewake Chris Wilson
2016-06-30 13:32 ` Tvrtko Ursulin
2016-06-30 12:05 ` ✗ Ro.CI.BAT: warning for series starting with [1/4] drm/i915: Use a hybrid scheme for fast register waits Patchwork
2016-06-30 12:58 ` [PATCH 1/4] " Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577521C8.3090503@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox