From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/2] drm/i915/ringbuffer: Move all generic engine->dispatch_batchbuffer together Date: Fri, 1 Jul 2016 09:40:28 +0100 Message-ID: <57762C7C.4080201@linux.intel.com> References: <1467361093-20209-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 072D16E9AD for ; Fri, 1 Jul 2016 08:40:30 +0000 (UTC) In-Reply-To: <1467361093-20209-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAxLzA3LzE2IDA5OjE4LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gQ29uc29saWRhdGUgdGhl IGJsb2NrIG9mIGRlZmF1bHQgdmZ1bmNzIGZvciBkaXNwYXRjaGluZyB0aGUgYmF0Y2hidWZmZXIu Cj4gSnVzdCBhIG1pbm9yIHR3ZWFrIG9uIHRvcCBvZiBUdnJ0a28ncyBncmVhdCBqb2Igb2YgdGlk eWluZyB1cCB0aGUgdmZ1bmMKPiBpbml0aWFsaXNhdGlvbi4KPgo+IFNpZ25lZC1vZmYtYnk6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxp biA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgMjcgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4g ICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gaW5kZXggNGQ2MWVhOTIzMTU0 Li5jYWViZTgxMmQxMGYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cmluZ2J1ZmZlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZl ci5jCj4gQEAgLTI5OTEsMjUgKzI5OTEsMjkgQEAgc3RhdGljIHZvaWQgaW50ZWxfcmluZ19kZWZh dWx0X3ZmdW5jcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJZW5naW5l LT5nZXRfc2Vxbm8gPSByaW5nX2dldF9zZXFubzsKPiAgIAllbmdpbmUtPnNldF9zZXFubyA9IHJp bmdfc2V0X3NlcW5vOwo+Cj4gLQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA4KSB7Cj4gLQkJ ZW5naW5lLT5kaXNwYXRjaF9leGVjYnVmZmVyID0gZ2VuOF9yaW5nX2Rpc3BhdGNoX2V4ZWNidWZm ZXI7Cj4gKwllbmdpbmUtPmFkZF9yZXF1ZXN0ID0gaTl4eF9hZGRfcmVxdWVzdDsKPiArCWlmIChJ TlRFTF9HRU4oZGV2X3ByaXYpID49IDYpCj4gICAJCWVuZ2luZS0+YWRkX3JlcXVlc3QgPSBnZW42 X2FkZF9yZXF1ZXN0Owo+IC0JCWVuZ2luZS0+aXJxX3NlcW5vX2JhcnJpZXIgPSBnZW42X3NlcW5v X2JhcnJpZXI7Cj4gLQl9IGVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gNikgewo+ICsK PiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDgpCj4gKwkJZW5naW5lLT5kaXNwYXRjaF9l eGVjYnVmZmVyID0gZ2VuOF9yaW5nX2Rpc3BhdGNoX2V4ZWNidWZmZXI7Cj4gKwllbHNlIGlmIChJ TlRFTF9HRU4oZGV2X3ByaXYpID49IDYpCj4gICAJCWVuZ2luZS0+ZGlzcGF0Y2hfZXhlY2J1ZmZl ciA9IGdlbjZfcmluZ19kaXNwYXRjaF9leGVjYnVmZmVyOwo+IC0JCWVuZ2luZS0+YWRkX3JlcXVl c3QgPSBnZW42X2FkZF9yZXF1ZXN0Owo+IC0JCWVuZ2luZS0+aXJxX3NlcW5vX2JhcnJpZXIgPSBn ZW42X3NlcW5vX2JhcnJpZXI7Cj4gLQl9IGVsc2Ugewo+ICsJZWxzZSBpZiAoSU5URUxfR0VOKGRl dl9wcml2KSA+PSA0KQo+ICAgCQllbmdpbmUtPmRpc3BhdGNoX2V4ZWNidWZmZXIgPSBpOTY1X2Rp c3BhdGNoX2V4ZWNidWZmZXI7Cj4gLQkJZW5naW5lLT5hZGRfcmVxdWVzdCA9IGk5eHhfYWRkX3Jl cXVlc3Q7Cj4gLQl9Cj4gKwllbHNlIGlmIChJU19JODMwKGRldl9wcml2KSB8fCBJU184NDVHKGRl dl9wcml2KSkKPiArCQllbmdpbmUtPmRpc3BhdGNoX2V4ZWNidWZmZXIgPSBpODMwX2Rpc3BhdGNo X2V4ZWNidWZmZXI7Cj4gKwllbHNlCj4gKwkJZW5naW5lLT5kaXNwYXRjaF9leGVjYnVmZmVyID0g aTkxNV9kaXNwYXRjaF9leGVjYnVmZmVyOwo+Cj4gICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikg Pj0gOCkgewo+ICAgCQllbmdpbmUtPmlycV9nZXQgPSBnZW44X3JpbmdfZ2V0X2lycTsKPiAgIAkJ ZW5naW5lLT5pcnFfcHV0ID0gZ2VuOF9yaW5nX3B1dF9pcnE7Cj4gKwkJZW5naW5lLT5pcnFfc2Vx bm9fYmFycmllciA9IGdlbjZfc2Vxbm9fYmFycmllcjsKPiAgIAl9IGVsc2UgaWYgKElOVEVMX0dF TihkZXZfcHJpdikgPj0gNikgewo+ICAgCQllbmdpbmUtPmlycV9nZXQgPSBnZW42X3JpbmdfZ2V0 X2lycTsKPiAgIAkJZW5naW5lLT5pcnFfcHV0ID0gZ2VuNl9yaW5nX3B1dF9pcnE7Cj4gKwkJZW5n aW5lLT5pcnFfc2Vxbm9fYmFycmllciA9IGdlbjZfc2Vxbm9fYmFycmllcjsKPiAgIAl9IGVsc2Ug aWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gNSkgewo+ICAgCQllbmdpbmUtPmlycV9nZXQgPSBn ZW41X3JpbmdfZ2V0X2lycTsKPiAgIAkJZW5naW5lLT5pcnFfcHV0ID0gZ2VuNV9yaW5nX3B1dF9p cnE7Cj4gQEAgLTMwNjksMTAgKzMwNzMsNyBAQCBpbnQgaW50ZWxfaW5pdF9yZW5kZXJfcmluZ19i dWZmZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPgo+ICAgCWlmIChJU19IQVNXRUxMKGRldl9w cml2KSkKPiAgIAkJZW5naW5lLT5kaXNwYXRjaF9leGVjYnVmZmVyID0gaHN3X3JpbmdfZGlzcGF0 Y2hfZXhlY2J1ZmZlcjsKPiAtCWVsc2UgaWYgKElTX0k4MzAoZGV2X3ByaXYpIHx8IElTXzg0NUco ZGV2X3ByaXYpKQo+IC0JCWVuZ2luZS0+ZGlzcGF0Y2hfZXhlY2J1ZmZlciA9IGk4MzBfZGlzcGF0 Y2hfZXhlY2J1ZmZlcjsKPiAtCWVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPD0gMykKPiAt CQllbmdpbmUtPmRpc3BhdGNoX2V4ZWNidWZmZXIgPSBpOTE1X2Rpc3BhdGNoX2V4ZWNidWZmZXI7 Cj4gKwo+ICAgCWVuZ2luZS0+aW5pdF9odyA9IGluaXRfcmVuZGVyX3Jpbmc7Cj4gICAJZW5naW5l LT5jbGVhbnVwID0gcmVuZGVyX3JpbmdfY2xlYW51cDsKCkkgd2FzIHBsYW5uaW5nIHRvIGRvIHRo aXMgdG9kYXkgYWZ0ZXIgeW91ciBjb21tZW50IGZyb20geWVzdGVyZGF5LCB3aGljaCAKSSB3YXMg YWdyZWVpbmcgd2l0aCwgYnV0IHlvdSBiZWF0IG1lIHRvIGl0LiBObyBjb21wbGFpbnRzIGFib3V0 IHRoYXQuIDopCgpMb29rcyBjb3JyZWN0LgoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0 dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCgoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK