From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/2] drm/i915/ringbuffer: Move all default irq vfuncs init to a separate func Date: Fri, 1 Jul 2016 09:41:16 +0100 Message-ID: <57762CAC.4040501@linux.intel.com> References: <1467361093-20209-1-git-send-email-chris@chris-wilson.co.uk> <1467361093-20209-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 3AB266E9EB for ; Fri, 1 Jul 2016 08:41:18 +0000 (UTC) In-Reply-To: <1467361093-20209-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAxLzA3LzE2IDA5OjE4LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gSnVzdCBwbG9uayBhbGwg dGhlIGRlZmF1bHQgaXJxIHZmdW5jcyB0b2dldGhlciBpbiBvbmUgZnVuY3Rpb24gdG8ga2VlcAo+ IHRoZSBpbml0aWFsaXNlcnMgb2YgcmVhc29uYWJsZSBzaXplLgo+Cj4gU2lnbmVkLW9mZi1ieTog Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFR2cnRrbyBVcnN1 bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgfCA0MyArKysrKysrKysrKysrKysrKystLS0tLS0tLS0t LS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVy LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBpbmRleCBjYWVi ZTgxMmQxMGYuLjI0Y2RjOTIwZjRiNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9yaW5nYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9y aW5nYnVmZmVyLmMKPiBAQCAtMjk4Myw2ICsyOTgzLDI5IEBAIHN0YXRpYyB2b2lkIGludGVsX3Jp bmdfaW5pdF9zZW1hcGhvcmVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAg IAl9Cj4gICB9Cj4KPiArc3RhdGljIHZvaWQgaW50ZWxfcmluZ19pbml0X2lycShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCQlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUpCj4gK3sKPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDgpIHsKPiArCQllbmdp bmUtPmlycV9nZXQgPSBnZW44X3JpbmdfZ2V0X2lycTsKPiArCQllbmdpbmUtPmlycV9wdXQgPSBn ZW44X3JpbmdfcHV0X2lycTsKPiArCQllbmdpbmUtPmlycV9zZXFub19iYXJyaWVyID0gZ2VuNl9z ZXFub19iYXJyaWVyOwo+ICsJfSBlbHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDYpIHsK PiArCQllbmdpbmUtPmlycV9nZXQgPSBnZW42X3JpbmdfZ2V0X2lycTsKPiArCQllbmdpbmUtPmly cV9wdXQgPSBnZW42X3JpbmdfcHV0X2lycTsKPiArCQllbmdpbmUtPmlycV9zZXFub19iYXJyaWVy ID0gZ2VuNl9zZXFub19iYXJyaWVyOwo+ICsJfSBlbHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYp ID49IDUpIHsKPiArCQllbmdpbmUtPmlycV9nZXQgPSBnZW41X3JpbmdfZ2V0X2lycTsKPiArCQll bmdpbmUtPmlycV9wdXQgPSBnZW41X3JpbmdfcHV0X2lycTsKPiArCX0gZWxzZSBpZiAoSU5URUxf R0VOKGRldl9wcml2KSA+PSAzKSB7Cj4gKwkJZW5naW5lLT5pcnFfZ2V0ID0gaTl4eF9yaW5nX2dl dF9pcnE7Cj4gKwkJZW5naW5lLT5pcnFfcHV0ID0gaTl4eF9yaW5nX3B1dF9pcnE7Cj4gKwl9IGVs c2Ugewo+ICsJCWVuZ2luZS0+aXJxX2dldCA9IGk4eHhfcmluZ19nZXRfaXJxOwo+ICsJCWVuZ2lu ZS0+aXJxX3B1dCA9IGk4eHhfcmluZ19wdXRfaXJxOwo+ICsJfQo+ICt9Cj4gKwo+ICAgc3RhdGlj IHZvaWQgaW50ZWxfcmluZ19kZWZhdWx0X3ZmdW5jcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4gICAJCQkJICAgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ ICAgewo+IEBAIC0zMDA2LDI1ICszMDI5LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfcmluZ19kZWZh dWx0X3ZmdW5jcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJZWxzZQo+ ICAgCQllbmdpbmUtPmRpc3BhdGNoX2V4ZWNidWZmZXIgPSBpOTE1X2Rpc3BhdGNoX2V4ZWNidWZm ZXI7Cj4KPiAtCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDgpIHsKPiAtCQllbmdpbmUtPmly cV9nZXQgPSBnZW44X3JpbmdfZ2V0X2lycTsKPiAtCQllbmdpbmUtPmlycV9wdXQgPSBnZW44X3Jp bmdfcHV0X2lycTsKPiAtCQllbmdpbmUtPmlycV9zZXFub19iYXJyaWVyID0gZ2VuNl9zZXFub19i YXJyaWVyOwo+IC0JfSBlbHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDYpIHsKPiAtCQll bmdpbmUtPmlycV9nZXQgPSBnZW42X3JpbmdfZ2V0X2lycTsKPiAtCQllbmdpbmUtPmlycV9wdXQg PSBnZW42X3JpbmdfcHV0X2lycTsKPiAtCQllbmdpbmUtPmlycV9zZXFub19iYXJyaWVyID0gZ2Vu Nl9zZXFub19iYXJyaWVyOwo+IC0JfSBlbHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDUp IHsKPiAtCQllbmdpbmUtPmlycV9nZXQgPSBnZW41X3JpbmdfZ2V0X2lycTsKPiAtCQllbmdpbmUt PmlycV9wdXQgPSBnZW41X3JpbmdfcHV0X2lycTsKPiAtCX0gZWxzZSBpZiAoSU5URUxfR0VOKGRl dl9wcml2KSA+PSAzKSB7Cj4gLQkJZW5naW5lLT5pcnFfZ2V0ID0gaTl4eF9yaW5nX2dldF9pcnE7 Cj4gLQkJZW5naW5lLT5pcnFfcHV0ID0gaTl4eF9yaW5nX3B1dF9pcnE7Cj4gLQl9IGVsc2Ugewo+ IC0JCWVuZ2luZS0+aXJxX2dldCA9IGk4eHhfcmluZ19nZXRfaXJxOwo+IC0JCWVuZ2luZS0+aXJx X3B1dCA9IGk4eHhfcmluZ19wdXRfaXJxOwo+IC0JfQo+IC0KPiArCWludGVsX3JpbmdfaW5pdF9p cnEoZGV2X3ByaXYsIGVuZ2luZSk7Cj4gICAJaW50ZWxfcmluZ19pbml0X3NlbWFwaG9yZXMoZGV2 X3ByaXYsIGVuZ2luZSk7Cj4gICB9Cj4KPgoKWWVzIHRoYXRzIGJldHRlci4KClJldmlld2VkLWJ5 OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2 cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK