Re: [PATCH 10/11] drm/i915: Support to create write combined type vmaps

Chris Wilson
2016-06-28T10:43:02Z

On Tue, Jun 28, 2016 at 03:55:15PM +0530, Goel, Akash wrote:
> >>+ pinned = (obj->pages_pin_count > 1);
> >
> >Too many ()
>
> Sorry is the above condition not correct ?
> If pin count is more than 1 then it implies that pages have been
> pinned elsewhere also, so pages were already pinned before they were
> pinned
> one more time, inside this function.

The definition of pinned is correct, just the () are redundant:
pinned = obj->pages_pin_count > 1;
-Chris

--
Chris Wilson, Intel Open Source Technology Centre