public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/bxt: Export pooled eu info to userspace
@ 2016-07-01  9:57 Arun Siluvery
  2016-07-01 10:07 ` ✗ Ro.CI.BAT: failure for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Arun Siluvery @ 2016-07-01  9:57 UTC (permalink / raw)
  To: intel-gfx

Pooled EU is a bxt only feature and kernel changes are already merged. This
feature is not yet exposed to userspace as the support was not yet
available. Beignet team expressed interest and added patches to use this.

Since we now have a user and patches to use them, expose them from the
kernel side as well.

[1] https://lists.freedesktop.org/archives/beignet/2016-June/007698.html
[2] https://lists.freedesktop.org/archives/beignet/2016-June/007699.html

Cc: Winiarski, Michal <michal.winiarski@intel.com>
Cc: Zou, Nanhai <nanhai.zou@intel.com>
Cc: Yang, Rong R <rong.r.yang@intel.com>
Cc: Tim Gore <tim.gore@intel.com>
Cc: Jeff McGee <jeff.mcgee@intel.com>
Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 6 ++++++
 include/uapi/drm/i915_drm.h     | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index c580e24..8a26740 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -365,6 +365,12 @@ static int i915_getparam(struct drm_device *dev, void *data,
 	case I915_PARAM_HAS_EXEC_SOFTPIN:
 		value = 1;
 		break;
+	case I915_PARAM_HAS_POOLED_EU:
+		value = HAS_POOLED_EU(dev);
+		break;
+	case I915_PARAM_MIN_EU_IN_POOL:
+		value = INTEL_INFO(dev)->min_eu_in_pool;
+		break;
 	default:
 		DRM_DEBUG("Unknown parameter %d\n", param->param);
 		return -EINVAL;
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index c17d63d..905880d 100644
--- a/include/uapi/drm/i915_drm.h
+++ b/include/uapi/drm/i915_drm.h
@@ -361,6 +361,8 @@ typedef struct drm_i915_irq_wait {
 #define I915_PARAM_HAS_GPU_RESET	 35
 #define I915_PARAM_HAS_RESOURCE_STREAMER 36
 #define I915_PARAM_HAS_EXEC_SOFTPIN	 37
+#define I915_PARAM_HAS_POOLED_EU	 38
+#define I915_PARAM_HAS_MIN_EU_IN_POOL	 39
 
 typedef struct drm_i915_getparam {
 	__s32 param;
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* ✗ Ro.CI.BAT: failure for drm/i915/bxt: Export pooled eu info to userspace
  2016-07-01  9:57 [PATCH] drm/i915/bxt: Export pooled eu info to userspace Arun Siluvery
@ 2016-07-01 10:07 ` Patchwork
  2016-07-01 10:43 ` [PATCH] " Arun Siluvery
  2016-07-01 11:16 ` ✓ Ro.CI.BAT: success for drm/i915/bxt: Export pooled eu info to userspace (rev2) Patchwork
  2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2016-07-01 10:07 UTC (permalink / raw)
  To: arun.siluvery; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/bxt: Export pooled eu info to userspace
URL   : https://patchwork.freedesktop.org/series/9367/
State : failure

== Summary ==

  CC      drivers/acpi/acpica/uthex.o
  CC      drivers/acpi/acpica/utids.o
  CC      drivers/acpi/acpica/utinit.o
  CC      drivers/acpi/acpica/utlock.o
  CC      drivers/acpi/acpica/utmath.o
  CC      drivers/acpi/acpica/utmutex.o
  CC      drivers/acpi/acpica/utnonansi.o
  CC      drivers/acpi/acpica/utmisc.o
  CC      drivers/acpi/acpica/utobject.o
  CC      drivers/acpi/acpica/utosi.o
  CC      drivers/acpi/acpica/utownerid.o
  CC      drivers/acpi/acpica/utpredef.o
  CC      drivers/acpi/acpica/utresrc.o
  CC      drivers/acpi/acpica/utstate.o
  CC      drivers/acpi/acpica/utstring.o
  CC      drivers/acpi/acpica/utxface.o
  CC      drivers/acpi/acpica/utxferror.o
  CC      drivers/acpi/acpica/utxfinit.o
  CC      drivers/acpi/acpica/utxfmutex.o
  LD      lib/built-in.o
  LD      net/ipv6/ipv6.o
  AR      lib/lib.a
  LD      drivers/acpi/acpica/acpi.o
  LD      net/ipv6/built-in.o
  LD      drivers/acpi/acpica/built-in.o
  LD      net/built-in.o
  LD      drivers/acpi/built-in.o
Makefile:985: recipe for target 'drivers' failed
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] drm/i915/bxt: Export pooled eu info to userspace
  2016-07-01  9:57 [PATCH] drm/i915/bxt: Export pooled eu info to userspace Arun Siluvery
  2016-07-01 10:07 ` ✗ Ro.CI.BAT: failure for " Patchwork
@ 2016-07-01 10:43 ` Arun Siluvery
  2016-07-01 11:56   ` Chris Wilson
  2016-07-01 11:16 ` ✓ Ro.CI.BAT: success for drm/i915/bxt: Export pooled eu info to userspace (rev2) Patchwork
  2 siblings, 1 reply; 7+ messages in thread
From: Arun Siluvery @ 2016-07-01 10:43 UTC (permalink / raw)
  To: intel-gfx

Pooled EU is a bxt only feature and kernel changes are already merged. This
feature is not yet exposed to userspace as the support was not yet
available. Beignet team expressed interest and added patches to use this.

Since we now have a user and patches to use them, expose them from the
kernel side as well.

v2: fix compile error

[1] https://lists.freedesktop.org/archives/beignet/2016-June/007698.html
[2] https://lists.freedesktop.org/archives/beignet/2016-June/007699.html

Cc: Winiarski, Michal <michal.winiarski@intel.com>
Cc: Zou, Nanhai <nanhai.zou@intel.com>
Cc: Yang, Rong R <rong.r.yang@intel.com>
Cc: Tim Gore <tim.gore@intel.com>
Cc: Jeff McGee <jeff.mcgee@intel.com>
Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 6 ++++++
 include/uapi/drm/i915_drm.h     | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index c580e24..8a26740 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -365,6 +365,12 @@ static int i915_getparam(struct drm_device *dev, void *data,
 	case I915_PARAM_HAS_EXEC_SOFTPIN:
 		value = 1;
 		break;
+	case I915_PARAM_HAS_POOLED_EU:
+		value = HAS_POOLED_EU(dev);
+		break;
+	case I915_PARAM_MIN_EU_IN_POOL:
+		value = INTEL_INFO(dev)->min_eu_in_pool;
+		break;
 	default:
 		DRM_DEBUG("Unknown parameter %d\n", param->param);
 		return -EINVAL;
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index c17d63d..a642bbc 100644
--- a/include/uapi/drm/i915_drm.h
+++ b/include/uapi/drm/i915_drm.h
@@ -361,6 +361,8 @@ typedef struct drm_i915_irq_wait {
 #define I915_PARAM_HAS_GPU_RESET	 35
 #define I915_PARAM_HAS_RESOURCE_STREAMER 36
 #define I915_PARAM_HAS_EXEC_SOFTPIN	 37
+#define I915_PARAM_HAS_POOLED_EU	 38
+#define I915_PARAM_MIN_EU_IN_POOL	 39
 
 typedef struct drm_i915_getparam {
 	__s32 param;
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* ✓ Ro.CI.BAT: success for drm/i915/bxt: Export pooled eu info to userspace (rev2)
  2016-07-01  9:57 [PATCH] drm/i915/bxt: Export pooled eu info to userspace Arun Siluvery
  2016-07-01 10:07 ` ✗ Ro.CI.BAT: failure for " Patchwork
  2016-07-01 10:43 ` [PATCH] " Arun Siluvery
@ 2016-07-01 11:16 ` Patchwork
  2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2016-07-01 11:16 UTC (permalink / raw)
  To: arun.siluvery; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/bxt: Export pooled eu info to userspace (rev2)
URL   : https://patchwork.freedesktop.org/series/9367/
State : success

== Summary ==

Series 9367v2 drm/i915/bxt: Export pooled eu info to userspace
http://patchwork.freedesktop.org/api/1.0/series/9367/revisions/2/mbox

Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-b:
                skip       -> PASS       (fi-skl-i5-6260u)
        Subgroup suspend-read-crc-pipe-c:
                incomplete -> PASS       (fi-hsw-i7-4770k)

fi-hsw-i7-4770k  total:229  pass:196  dwarn:0   dfail:0   fail:0   skip:33 
fi-kbl-qkkr      total:229  pass:160  dwarn:28  dfail:1   fail:0   skip:40 
fi-skl-i5-6260u  total:229  pass:204  dwarn:0   dfail:0   fail:0   skip:25 
fi-skl-i7-6700k  total:229  pass:190  dwarn:0   dfail:0   fail:0   skip:39 
fi-snb-i7-2600   total:229  pass:176  dwarn:0   dfail:0   fail:0   skip:53 
ro-bdw-i7-5557U  total:229  pass:204  dwarn:1   dfail:1   fail:0   skip:23 
ro-bdw-i7-5600u  total:229  pass:190  dwarn:0   dfail:1   fail:0   skip:38 
ro-bsw-n3050     total:229  pass:177  dwarn:0   dfail:1   fail:2   skip:49 
ro-byt-n2820     total:229  pass:180  dwarn:0   dfail:1   fail:3   skip:45 
ro-hsw-i3-4010u  total:229  pass:197  dwarn:0   dfail:1   fail:0   skip:31 
ro-hsw-i7-4770r  total:229  pass:197  dwarn:0   dfail:1   fail:0   skip:31 
ro-ilk-i7-620lm  total:229  pass:157  dwarn:0   dfail:1   fail:1   skip:70 
ro-ilk1-i5-650   total:224  pass:157  dwarn:0   dfail:1   fail:1   skip:65 
ro-ivb-i7-3770   total:229  pass:188  dwarn:0   dfail:1   fail:0   skip:40 
ro-ivb2-i7-3770  total:229  pass:192  dwarn:0   dfail:1   fail:0   skip:36 
ro-skl3-i5-6260u total:229  pass:208  dwarn:1   dfail:1   fail:0   skip:19 
ro-snb-i7-2620M  total:229  pass:179  dwarn:0   dfail:1   fail:1   skip:48 
ro-bdw-i5-5250u failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1357/

ee2057a drm-intel-nightly: 2016y-07m-01d-08h-52m-58s UTC integration manifest
7761c2c drm/i915/bxt: Export pooled eu info to userspace

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] drm/i915/bxt: Export pooled eu info to userspace
  2016-07-01 10:43 ` [PATCH] " Arun Siluvery
@ 2016-07-01 11:56   ` Chris Wilson
  2016-07-01 12:45     ` Arun Siluvery
  0 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2016-07-01 11:56 UTC (permalink / raw)
  To: Arun Siluvery; +Cc: intel-gfx

On Fri, Jul 01, 2016 at 11:43:02AM +0100, Arun Siluvery wrote:
> Pooled EU is a bxt only feature and kernel changes are already merged. This
> feature is not yet exposed to userspace as the support was not yet
> available. Beignet team expressed interest and added patches to use this.
> 
> Since we now have a user and patches to use them, expose them from the
> kernel side as well.
> 
> v2: fix compile error
> 
> [1] https://lists.freedesktop.org/archives/beignet/2016-June/007698.html
> [2] https://lists.freedesktop.org/archives/beignet/2016-June/007699.html
> 
> Cc: Winiarski, Michal <michal.winiarski@intel.com>
> Cc: Zou, Nanhai <nanhai.zou@intel.com>
> Cc: Yang, Rong R <rong.r.yang@intel.com>
> Cc: Tim Gore <tim.gore@intel.com>
> Cc: Jeff McGee <jeff.mcgee@intel.com>
> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] drm/i915/bxt: Export pooled eu info to userspace
  2016-07-01 11:56   ` Chris Wilson
@ 2016-07-01 12:45     ` Arun Siluvery
  2016-07-01 13:56       ` Tvrtko Ursulin
  0 siblings, 1 reply; 7+ messages in thread
From: Arun Siluvery @ 2016-07-01 12:45 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx, Tvrtko Ursulin, Daniel Vetter

On 01/07/2016 12:56, Chris Wilson wrote:
> On Fri, Jul 01, 2016 at 11:43:02AM +0100, Arun Siluvery wrote:
>> Pooled EU is a bxt only feature and kernel changes are already merged. This
>> feature is not yet exposed to userspace as the support was not yet
>> available. Beignet team expressed interest and added patches to use this.
>>
>> Since we now have a user and patches to use them, expose them from the
>> kernel side as well.
>>
>> v2: fix compile error
>>
>> [1] https://lists.freedesktop.org/archives/beignet/2016-June/007698.html
>> [2] https://lists.freedesktop.org/archives/beignet/2016-June/007699.html
>>
>> Cc: Winiarski, Michal <michal.winiarski@intel.com>
>> Cc: Zou, Nanhai <nanhai.zou@intel.com>
>> Cc: Yang, Rong R <rong.r.yang@intel.com>
>> Cc: Tim Gore <tim.gore@intel.com>
>> Cc: Jeff McGee <jeff.mcgee@intel.com>
>> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris

Thanks Chris.

Daniel, Tvrtko,

Could you please check this and merge?

regards
Arun

>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] drm/i915/bxt: Export pooled eu info to userspace
  2016-07-01 12:45     ` Arun Siluvery
@ 2016-07-01 13:56       ` Tvrtko Ursulin
  0 siblings, 0 replies; 7+ messages in thread
From: Tvrtko Ursulin @ 2016-07-01 13:56 UTC (permalink / raw)
  To: Arun Siluvery, Chris Wilson, intel-gfx, Daniel Vetter


On 01/07/16 13:45, Arun Siluvery wrote:
> On 01/07/2016 12:56, Chris Wilson wrote:
>> On Fri, Jul 01, 2016 at 11:43:02AM +0100, Arun Siluvery wrote:
>>> Pooled EU is a bxt only feature and kernel changes are already
>>> merged. This
>>> feature is not yet exposed to userspace as the support was not yet
>>> available. Beignet team expressed interest and added patches to use
>>> this.
>>>
>>> Since we now have a user and patches to use them, expose them from the
>>> kernel side as well.
>>>
>>> v2: fix compile error
>>>
>>> [1] https://lists.freedesktop.org/archives/beignet/2016-June/007698.html
>>> [2] https://lists.freedesktop.org/archives/beignet/2016-June/007699.html
>>>
>>> Cc: Winiarski, Michal <michal.winiarski@intel.com>
>>> Cc: Zou, Nanhai <nanhai.zou@intel.com>
>>> Cc: Yang, Rong R <rong.r.yang@intel.com>
>>> Cc: Tim Gore <tim.gore@intel.com>
>>> Cc: Jeff McGee <jeff.mcgee@intel.com>
>>> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
>> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
>> -Chris
>
> Thanks Chris.
>
> Daniel, Tvrtko,
>
> Could you please check this and merge?

Merged to dinq with Jani's ack.

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-07-01 13:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-01  9:57 [PATCH] drm/i915/bxt: Export pooled eu info to userspace Arun Siluvery
2016-07-01 10:07 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-07-01 10:43 ` [PATCH] " Arun Siluvery
2016-07-01 11:56   ` Chris Wilson
2016-07-01 12:45     ` Arun Siluvery
2016-07-01 13:56       ` Tvrtko Ursulin
2016-07-01 11:16 ` ✓ Ro.CI.BAT: success for drm/i915/bxt: Export pooled eu info to userspace (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox