From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH] drm/i915: tidy up request alloc
Date: Fri, 1 Jul 2016 17:58:18 +0100
Message-ID: <5776A12A.7040103@intel.com>
References: <1467250532-23644-1-git-send-email-hong.liu@intel.com>
 <5774DD4C.6030702@linux.intel.com>
 <20160630102241.GY28577@nuc-i3427.alporthouse.com>
 <5775154A.9070005@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id AAF296EB05
 for <intel-gfx@lists.freedesktop.org>; Fri,  1 Jul 2016 16:59:20 +0000 (UTC)
In-Reply-To: <5775154A.9070005@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, Chris Wilson <chris@chris-wilson.co.uk>, Hong Liu <hong.liu@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMzAvMDYvMTYgMTM6NDksIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMzAvMDYvMTYg
MTE6MjIsIENocmlzIFdpbHNvbiB3cm90ZToKPj4gT24gVGh1LCBKdW4gMzAsIDIwMTYgYXQgMDk6
NTA6MjBBTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Pgo+Pj4gT24gMzAvMDYvMTYg
MDI6MzUsIEhvbmcgTGl1IHdyb3RlOgo+Pj4+IFJldHVybiB0aGUgYWxsb2NhdGVkIHJlcXVlc3Qg
cG9pbnRlciBkaXJlY3RseSB0byByZW1vdmUKPj4+PiB0aGUgZG91YmxlIHBvaW50ZXIgcGFyYW1l
dGVyLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogSG9uZyBMaXUgPGhvbmcubGl1QGludGVsLmNv
bT4KPj4+PiAtLS0KPj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAyNSAr
KysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4+Pj4gICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRp
b25zKCspLCAxOCBkZWxldGlvbnMoLSkKPj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+Pj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl
bS5jCj4+Pj4gaW5kZXggMWQ5ODc4Mi4uOTg4MTQ1NSAxMDA2NDQKPj4+PiAtLS0gYS9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aTkxNV9nZW0uYwo+Pj4+IEBAIC0yOTg4LDMyICsyOTg4LDI2IEBAIHZvaWQgaTkxNV9nZW1fcmVx
dWVzdF9mcmVlKHN0cnVjdCBrcmVmCj4+Pj4gKnJlcV9yZWYpCj4+Pj4gICAgICAga21lbV9jYWNo
ZV9mcmVlKHJlcS0+aTkxNS0+cmVxdWVzdHMsIHJlcSk7Cj4+Pj4gICB9Cj4+Pj4KPj4+PiAtc3Rh
dGljIGlubGluZSBpbnQKPj4+PiArc3RhdGljIGlubGluZSBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3Jl
cXVlc3QgKgo+Pj4+ICAgX19pOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRlbF9lbmdp
bmVfY3MgKmVuZ2luZSwKPj4+PiAtICAgICAgICAgICAgIHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0
ICpjdHgsCj4+Pj4gLSAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKipy
ZXFfb3V0KQo+Pj4+ICsgICAgICAgICAgICAgc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCkK
Pj4+PiAgIHsKPj4+PiAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBl
bmdpbmUtPmk5MTU7Cj4+Pj4gICAgICAgdW5zaWduZWQgcmVzZXRfY291bnRlciA9Cj4+Pj4gaTkx
NV9yZXNldF9jb3VudGVyKCZkZXZfcHJpdi0+Z3B1X2Vycm9yKTsKPj4+PiAgICAgICBzdHJ1Y3Qg
ZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcTsKPj4+PiAgICAgICBpbnQgcmV0Owo+Pj4+Cj4+Pj4g
LSAgICBpZiAoIXJlcV9vdXQpCj4+Pj4gLSAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4+Pj4gLQo+
Pj4+IC0gICAgKnJlcV9vdXQgPSBOVUxMOwo+Pj4+IC0KPj4+PiAgICAgICAvKiBBQkk6IEJlZm9y
ZSB1c2Vyc3BhY2UgYWNjZXNzZXMgdGhlIEdQVSAoZS5nLiBleGVjYnVmZmVyKSwKPj4+PiByZXBv
cnQKPj4+PiAgICAgICAgKiBFSU8gaWYgdGhlIEdQVSBpcyBhbHJlYWR5IHdlZGdlZCwgb3IgRUFH
QUlOIHRvIGRyb3AgdGhlCj4+Pj4gc3RydWN0X211dGV4Cj4+Pj4gICAgICAgICogYW5kIHJlc3Rh
cnQuCj4+Pj4gICAgICAgICovCj4+Pj4gICAgICAgcmV0ID0gaTkxNV9nZW1fY2hlY2tfd2VkZ2Uo
cmVzZXRfY291bnRlciwKPj4+PiBkZXZfcHJpdi0+bW0uaW50ZXJydXB0aWJsZSk7Cj4+Pj4gICAg
ICAgaWYgKHJldCkKPj4+PiAtICAgICAgICByZXR1cm4gcmV0Owo+Pj4+ICsgICAgICAgIHJldHVy
biBFUlJfUFRSKHJldCk7Cj4+Pj4KPj4+PiAgICAgICByZXEgPSBrbWVtX2NhY2hlX3phbGxvYyhk
ZXZfcHJpdi0+cmVxdWVzdHMsIEdGUF9LRVJORUwpOwo+Pj4+ICAgICAgIGlmIChyZXEgPT0gTlVM
TCkKPj4+PiAtICAgICAgICByZXR1cm4gLUVOT01FTTsKPj4+PiArICAgICAgICByZXR1cm4gRVJS
X1BUUigtRU5PTUVNKTsKPj4+Pgo+Pj4+ICAgICAgIHJldCA9IGk5MTVfZ2VtX2dldF9zZXFubyhl
bmdpbmUtPmk5MTUsICZyZXEtPnNlcW5vKTsKPj4+PiAgICAgICBpZiAocmV0KQo+Pj4+IEBAIC0z
MDQxLDE0ICszMDM1LDEzIEBAIF9faTkxNV9nZW1fcmVxdWVzdF9hbGxvYyhzdHJ1Y3QKPj4+PiBp
bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPj4+PiAgICAgICBpZiAocmV0KQo+Pj4+ICAgICAgICAg
ICBnb3RvIGVycl9jdHg7Cj4+Pj4KPj4+PiAtICAgICpyZXFfb3V0ID0gcmVxOwo+Pj4+IC0gICAg
cmV0dXJuIDA7Cj4+Pj4gKyAgICByZXR1cm4gcmVxOwo+Pj4+Cj4+Pj4gICBlcnJfY3R4Ogo+Pj4+
ICAgICAgIGk5MTVfZ2VtX2NvbnRleHRfdW5yZWZlcmVuY2UoY3R4KTsKPj4+PiAgIGVycjoKPj4+
PiAgICAgICBrbWVtX2NhY2hlX2ZyZWUoZGV2X3ByaXYtPnJlcXVlc3RzLCByZXEpOwo+Pj4+IC0g
ICAgcmV0dXJuIHJldDsKPj4+PiArICAgIHJldHVybiBFUlJfUFRSKHJldCk7Cj4+Pj4gICB9Cj4+
Pj4KPj4+PiAgIC8qKgo+Pj4+IEBAIC0zMDY3LDEzICszMDYwLDkgQEAgc3RydWN0IGRybV9pOTE1
X2dlbV9yZXF1ZXN0ICoKPj4+PiAgIGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2Moc3RydWN0IGludGVs
X2VuZ2luZV9jcyAqZW5naW5lLAo+Pj4+ICAgICAgICAgICAgICAgICAgc3RydWN0IGk5MTVfZ2Vt
X2NvbnRleHQgKmN0eCkKPj4+PiAgIHsKPj4+PiAtICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVx
dWVzdCAqcmVxOwo+Pj4+IC0gICAgaW50IGVycjsKPj4+PiAtCj4+Pj4gICAgICAgaWYgKGN0eCA9
PSBOVUxMKQo+Pj4+ICAgICAgICAgICBjdHggPSBlbmdpbmUtPmk5MTUtPmtlcm5lbF9jb250ZXh0
Owo+Pj4+IC0gICAgZXJyID0gX19pOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKGVuZ2luZSwgY3R4LCAm
cmVxKTsKPj4+PiAtICAgIHJldHVybiBlcnIgPyBFUlJfUFRSKGVycikgOiByZXE7Cj4+Pj4gKyAg
ICByZXR1cm4gX19pOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKGVuZ2luZSwgY3R4KTsKPj4+PiAgIH0K
Pj4+Pgo+Pj4+ICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICoKPj4+Pgo+Pj4KPj4+IExv
b2tzIGdvb2QgdG8gbWUuIEFuZCBoYXZlIHRoaXMgZmVlbGluZyBJJ3ZlIHNlZW4gdGhpcyBzb21l
d2hlcmUgYmVmb3JlLgo+Pgo+PiBTZXZlcmFsIHRpbWVzLiBUaGlzIGlzIG5vdCB0aGUgZnVsbCB0
aWR5LCBub3IgZG9lcyBpdCByZWFsaXNlIHRoZQo+PiByYW1pZmFjdGlvbnMgb2YgcmVxdWVzdCBh
bGxvYyB0aHJvdWdoIHRoZSBzdGFjay4KPgo+IEhtIEkgY2FuJ3Qgc3BvdCB0aGF0IGl0IGlzIGRv
aW5nIGFueXRoaW5nIHdyb25nIG9yIG1ha2luZyBhbnl0aGluZwo+IHdvcnNlLiBZb3UgZG9uJ3Qg
d2FudCB0byBsZXQgdGhlIHNtYWxsIGNsZWFudXAgaW4/Cj4KPiBSZWdhcmRzLAo+IFR2cnRrbwoK
SXQgb3VnaHQgdG8gbWFrZSBhbG1vc3Qgbm8gZGlmZmVyZW5jZSwgYmVjYXVzZSB0aGUgKm9ubHkq
IHBsYWNlIHRoZSAKaW5uZXIgZnVuY3Rpb24gaXMgY2FsbGVkIGlzIGZyb20gdGhlIG91dGVyIG9u
ZSwgd2hpY2ggcGFzc2VzIGEgcG9pbnRlciAKdG8gYSBsb2NhbCBmb3IgdGhlIHJldHVybmVkIG9i
amVjdDsgYW5kIHRoZSBpbm5lciBvbmUgaXMgdGhlbiBpbmxpbmVkLCAKc28gdGhlIGNvbXBpbGVy
IGRvZXNuJ3QgYWN0dWFsbHkgcHV0IGl0IG9uIHRoZSBzdGFjayBhbmQgY2FsbCB0byB0aGUgCmlu
bmVyIGFsbG9jYXRvciBhbnl3YXkuCgpTdHJhbmdlbHksIGhvd2V2ZXIsIHdpdGggdGhpcyBjaGFu
Z2UgdGhlIGNvZGUgYmVjb21lcyB+NDAwIGJ5dGVzIGJpZ2dlciEKCkRpc2Fzc2VtYmx5IHJldmVh
bHMgdGhhdCB3aGlsZSB0aGUgY29kZSBmb3IgdGhlIGV4dGVybmFsbHktY2FsbGFibGUgCm91dGVy
IGZ1bmN0aW9uIGlzIGluZGVlZCBhbG1vc3QgaWRlbnRpY2FsLCBhIHNlY29uZCBjb3B5IG9mIGl0
IGhhcyBhbHNvIApiZWVuIGlubGluZWQgYXQgdGhlIG9uZSBjYWxsc2l0ZSBpbiB0aGlzIGZpbGU6
CgpfX2k5MTVfZ2VtX29iamVjdF9zeW5jKCkgLi4uCglyZXEgPSBpOTE1X2dlbV9yZXF1ZXN0X2Fs
bG9jKHRvLCBOVUxMKTsKCkkgZG9uJ3QgdGhpbmsgdGhhdCdzIGEgY3JpdGljYWwgcGF0aCBhbmQg
d291bGQgcmF0aGVyIGhhdmUgNDAwIGJ5dGVzIApzbWFsbGVyIGNvZGVzcGFjZS4gV2UgY2FuIGdl
dCB0aGF0IGJhY2sgYnkgYWRkaW5nIC9ub2lubGluZS8gdG8gdGhlIApvdXRlciBmdW5jdGlvbiBp
OTE1X2dlbV9yZXF1ZXN0X2FsbG9jKCkgKG5vdCwgb2YgY291cnNlLCB0byB0aGUgaW5uZXIgCm9u
ZSwgdGhhdCBkZWZpbml0ZWx5ICpzaG91bGQqIGJlIGlubGluZSkuCgouRGF2ZS4KX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg
bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl
c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==