Re: [PATCH] drm/i915: Mass convert dev->dev_private to to_i915(dev)

[Dave Gordon <david.s.gordon@intel.com>]

On 01/07/16 16:26, Chris Wilson wrote:
> Since we now subclass struct drm_device, we can save pointer dances by
> noting the equivalence of struct drm_device and struct drm_i915_private,
> i.e. by using to_i915().
>
>     text    data     bss     dec     hex filename
> 1073824    4562     416 1078802  107612 drivers/gpu/drm/i915/i915.ko
> 1068976    4562     416 1073954  106322 drivers/gpu/drm/i915/i915.ko
>
> Created by the coccinelle script:
>
> @@
> expression E;
> identifier p;
> @@
> - struct drm_i915_private *p = E->dev_private;
> + struct drm_i915_private *p = to_i915(E);
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/i915_debugfs.c            | 176 +++++++--------
>   drivers/gpu/drm/i915/i915_drv.c                |  36 ++--
>   drivers/gpu/drm/i915/i915_gem.c                |  54 ++---
>   drivers/gpu/drm/i915/i915_gem_context.c        |  10 +-
>   drivers/gpu/drm/i915/i915_gem_execbuffer.c     |   4 +-
>   drivers/gpu/drm/i915/i915_gem_fence.c          |  24 +--
>   drivers/gpu/drm/i915/i915_gem_gtt.c            |  20 +-
>   drivers/gpu/drm/i915/i915_gem_stolen.c         |   6 +-
>   drivers/gpu/drm/i915/i915_gem_tiling.c         |   4 +-
>   drivers/gpu/drm/i915/i915_gpu_error.c          |   6 +-
>   drivers/gpu/drm/i915/i915_guc_submission.c     |   4 +-
>   drivers/gpu/drm/i915/i915_irq.c                |  92 ++++----
>   drivers/gpu/drm/i915/i915_suspend.c            |   8 +-
>   drivers/gpu/drm/i915/i915_sysfs.c              |  22 +-
>   drivers/gpu/drm/i915/intel_audio.c             |  18 +-
>   drivers/gpu/drm/i915/intel_color.c             |  18 +-
>   drivers/gpu/drm/i915/intel_crt.c               |  24 +--
>   drivers/gpu/drm/i915/intel_ddi.c               |  36 ++--
>   drivers/gpu/drm/i915/intel_display.c           | 286 ++++++++++++-------------
>   drivers/gpu/drm/i915/intel_dp.c                | 107 +++++----
>   drivers/gpu/drm/i915/intel_dp_mst.c            |   6 +-
>   drivers/gpu/drm/i915/intel_dpio_phy.c          |  10 +-
>   drivers/gpu/drm/i915/intel_dpll_mgr.c          |  12 +-
>   drivers/gpu/drm/i915/intel_drv.h               |   4 +-
>   drivers/gpu/drm/i915/intel_dsi.c               |  36 ++--
>   drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c |   2 +-
>   drivers/gpu/drm/i915/intel_dsi_panel_vbt.c     |   6 +-
>   drivers/gpu/drm/i915/intel_dsi_pll.c           |  12 +-
>   drivers/gpu/drm/i915/intel_dvo.c               |  18 +-
>   drivers/gpu/drm/i915/intel_fbc.c               |  24 +--
>   drivers/gpu/drm/i915/intel_fbdev.c             |  10 +-
>   drivers/gpu/drm/i915/intel_fifo_underrun.c     |  18 +-
>   drivers/gpu/drm/i915/intel_guc_loader.c        |   6 +-
>   drivers/gpu/drm/i915/intel_hdmi.c              |  48 ++---
>   drivers/gpu/drm/i915/intel_i2c.c               |   6 +-
>   drivers/gpu/drm/i915/intel_lrc.c               |   4 +-
>   drivers/gpu/drm/i915/intel_lvds.c              |  16 +-
>   drivers/gpu/drm/i915/intel_modes.c             |   4 +-
>   drivers/gpu/drm/i915/intel_overlay.c           |   4 +-
>   drivers/gpu/drm/i915/intel_panel.c             |   6 +-
>   drivers/gpu/drm/i915/intel_pm.c                | 110 +++++-----
>   drivers/gpu/drm/i915/intel_psr.c               |  36 ++--
>   drivers/gpu/drm/i915/intel_ringbuffer.c        |  10 +-
>   drivers/gpu/drm/i915/intel_sdvo.c              |  22 +-
>   drivers/gpu/drm/i915/intel_sprite.c            |  18 +-
>   drivers/gpu/drm/i915/intel_tv.c                |  12 +-
>   drivers/gpu/drm/i915/intel_uncore.c            |   2 +-
>   47 files changed, 708 insertions(+), 709 deletions(-)

Looks fine :)
Reviewed-by: Dave Gordon <david.s.gordon@intel.com>

I found three more to convert, plus one place where we can delete
some entirely redundant locals, both 'dev' AND 'dev_priv' :)

.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx