From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915/guc: Protect against HAS_GUC_* returning true values other than one Date: Tue, 5 Jul 2016 12:56:12 +0100 Message-ID: <577BA05C.9030902@linux.intel.com> References: <1467642633-35255-1-git-send-email-tvrtko.ursulin@linux.intel.com> <577B9EEE.8060103@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C3086E0D3 for ; Tue, 5 Jul 2016 11:56:14 +0000 (UTC) In-Reply-To: <577B9EEE.8060103@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA1LzA3LzE2IDEyOjUwLCBEYXZlIEdvcmRvbiB3cm90ZToKPiBPbiAwNC8wNy8xNiAxNToz MCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IEZyb206IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28u dXJzdWxpbkBpbnRlbC5jb20+Cj4+Cj4+IEF0IHRoZSBtb21lbnQgSEFTX0dVQ19VQ09ERSA9PSBI QVNfR1VDID09IElTX0dFTjkgPT0KPj4gKElOVEVMX0lORk8oZGV2KS0+Z2VuX21hc2sgJiBCSVQo OCkpLCB3aGljaCBpcyB0cnVlIGJ1dCBub3Qgb25lLiBBbmQKPj4gbW9kdWxlIHBhcmFtZXRlcnMg YXJlIGludGVnZXJzIGFuZCBub3QgYm9vbGVhbnMgc28gY29tcGlsZXIgd2lsbCBub3QKPj4gbm9y bWFsaXplIHRoZSB2YWx1ZSBmb3IgdXMuCj4+Cj4+IFF1aWNrIGFuZCBlYXN5IGZpeCBmb3IgdGhl IEd1QyBsb2FkaW5nIGNvZGUgYW5kIHRoZSB3aG9sZSBhcmVhIGNhbgo+PiBiZSBldmFsdWF0ZWQg YWZ0ZXJ3YXJkcy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51 cnN1bGluQGludGVsLmNvbT4KPj4gUmVwb3J0ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+PiBDYzogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVs LmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5j IHwgNCArKy0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19s b2FkZXIuYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+PiBp bmRleCBkOTI1ZTJkYWViMjQuLjcyZWE1Yjk3ZTI0MiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+PiBAQCAtNjg3LDkgKzY4Nyw5IEBAIHZvaWQgaW50ZWxf Z3VjX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4KPj4gICAgICAgLyogQSBuZWdhdGl2 ZSB2YWx1ZSBtZWFucyAidXNlIHBsYXRmb3JtIGRlZmF1bHQiICovCj4+ICAgICAgIGlmIChpOTE1 LmVuYWJsZV9ndWNfbG9hZGluZyA8IDApCj4+IC0gICAgICAgIGk5MTUuZW5hYmxlX2d1Y19sb2Fk aW5nID0gSEFTX0dVQ19VQ09ERShkZXYpOwo+PiArICAgICAgICBpOTE1LmVuYWJsZV9ndWNfbG9h ZGluZyA9ICEhSEFTX0dVQ19VQ09ERShkZXYpOwo+PiAgICAgICBpZiAoaTkxNS5lbmFibGVfZ3Vj X3N1Ym1pc3Npb24gPCAwKQo+PiAtICAgICAgICBpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA9 IEhBU19HVUNfU0NIRUQoZGV2KTsKPj4gKyAgICAgICAgaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Np b24gPSAhIUhBU19HVUNfU0NIRUQoZGV2KTsKPj4KPj4gICAgICAgaWYgKCFIQVNfR1VDX1VDT0RF KGRldikpIHsKPj4gICAgICAgICAgIGZ3X3BhdGggPSBOVUxMOwo+Cj4gT3Igd2UgY291bGQganVz dCBmaXggdGhlIElTX0dFTngoKSBtYWNyb3M6CgpZb3UgbWVhbgoKY29tbWl0IGFmMTM0NmEwZjM4 ZmU1Yjc2MjcyOWE5MWVkMTBjN2M3ZjU5Yjc2YzkKQXV0aG9yOiBUdnJ0a28gVXJzdWxpbiA8dHZy dGtvLnVyc3VsaW5AaW50ZWwuY29tPgpEYXRlOiAgIE1vbiBKdWwgNCAxNTo1MDoyMyAyMDE2ICsw MTAwCgogICAgIGRybS9pOTE1OiBFeHBsaWNpdGx5IGNvbnZlcnQgc29tZSBtYWNyb3MgdG8gYm9v bGVhbiB2YWx1ZXMKCjpECgpTdGlsbCwgSSB0aGluayBiZWluZyBleHBsaWNpdCB3aGVuIGFzc2ln bmluZyBib29sZWFuIHR5cGUgbWFjcm9zIHRvIAppbnRlZ2VyIGlzIGEgZ29vZCB0aGluZyB0byBk by4gQmVjYXVzZSBJIHRob3VnaHQgdHJ1ZSBpcyBkZWZpbmVkIGFzIApub24temVybyBpbiBDLiBV bmxlc3MgSSBhbSBiZWhpbmQgdGhlIHRpbWVzLgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK