From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH] drm/i915/guc: Protect against HAS_GUC_*
 returning true values other than one
Date: Tue, 5 Jul 2016 13:32:20 +0100
Message-ID: <577BA8D4.4050602@intel.com>
References: <1467642633-35255-1-git-send-email-tvrtko.ursulin@linux.intel.com>
 <577B9EEE.8060103@intel.com> <577BA05C.9030902@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 6A4616E0A4
 for <Intel-gfx@lists.freedesktop.org>; Tue,  5 Jul 2016 12:32:22 +0000 (UTC)
In-Reply-To: <577BA05C.9030902@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, Intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMDUvMDcvMTYgMTI6NTYsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMDUvMDcvMTYg
MTI6NTAsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBPbiAwNC8wNy8xNiAxNTozMCwgVHZydGtvIFVy
c3VsaW4gd3JvdGU6Cj4+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50
ZWwuY29tPgo+Pj4KPj4+IEF0IHRoZSBtb21lbnQgSEFTX0dVQ19VQ09ERSA9PSBIQVNfR1VDID09
IElTX0dFTjkgPT0KPj4+IChJTlRFTF9JTkZPKGRldiktPmdlbl9tYXNrICYgQklUKDgpKSwgd2hp
Y2ggaXMgdHJ1ZSBidXQgbm90IG9uZS4gQW5kCj4+PiBtb2R1bGUgcGFyYW1ldGVycyBhcmUgaW50
ZWdlcnMgYW5kIG5vdCBib29sZWFucyBzbyBjb21waWxlciB3aWxsIG5vdAo+Pj4gbm9ybWFsaXpl
IHRoZSB2YWx1ZSBmb3IgdXMuCj4+Pgo+Pj4gUXVpY2sgYW5kIGVhc3kgZml4IGZvciB0aGUgR3VD
IGxvYWRpbmcgY29kZSBhbmQgdGhlIHdob2xlIGFyZWEgY2FuCj4+PiBiZSBldmFsdWF0ZWQgYWZ0
ZXJ3YXJkcy4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVy
c3VsaW5AaW50ZWwuY29tPgo+Pj4gUmVwb3J0ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy
aXMtd2lsc29uLmNvLnVrPgo+Pj4gQ2M6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRl
bC5jb20+Cj4+PiAtLS0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRl
ci5jIHwgNCArKy0tCj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVs
ZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2d1Y19sb2FkZXIuYwo+Pj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVy
LmMKPj4+IGluZGV4IGQ5MjVlMmRhZWIyNC4uNzJlYTViOTdlMjQyIDEwMDY0NAo+Pj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4+PiArKysgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPj4+IEBAIC02ODcsOSArNjg3LDkgQEAg
dm9pZCBpbnRlbF9ndWNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+Pj4KPj4+ICAgICAg
IC8qIEEgbmVnYXRpdmUgdmFsdWUgbWVhbnMgInVzZSBwbGF0Zm9ybSBkZWZhdWx0IiAqLwo+Pj4g
ICAgICAgaWYgKGk5MTUuZW5hYmxlX2d1Y19sb2FkaW5nIDwgMCkKPj4+IC0gICAgICAgIGk5MTUu
ZW5hYmxlX2d1Y19sb2FkaW5nID0gSEFTX0dVQ19VQ09ERShkZXYpOwo+Pj4gKyAgICAgICAgaTkx
NS5lbmFibGVfZ3VjX2xvYWRpbmcgPSAhIUhBU19HVUNfVUNPREUoZGV2KTsKPj4+ICAgICAgIGlm
IChpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA8IDApCj4+PiAtICAgICAgICBpOTE1LmVuYWJs
ZV9ndWNfc3VibWlzc2lvbiA9IEhBU19HVUNfU0NIRUQoZGV2KTsKPj4+ICsgICAgICAgIGk5MTUu
ZW5hYmxlX2d1Y19zdWJtaXNzaW9uID0gISFIQVNfR1VDX1NDSEVEKGRldik7Cj4+Pgo+Pj4gICAg
ICAgaWYgKCFIQVNfR1VDX1VDT0RFKGRldikpIHsKPj4+ICAgICAgICAgICBmd19wYXRoID0gTlVM
TDsKPj4KPj4gT3Igd2UgY291bGQganVzdCBmaXggdGhlIElTX0dFTngoKSBtYWNyb3M6Cj4KPiBZ
b3UgbWVhbgo+Cj4gY29tbWl0IGFmMTM0NmEwZjM4ZmU1Yjc2MjcyOWE5MWVkMTBjN2M3ZjU5Yjc2
YzkKPiBBdXRob3I6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4g
RGF0ZTogICBNb24gSnVsIDQgMTU6NTA6MjMgMjAxNiArMDEwMAo+Cj4gICAgICBkcm0vaTkxNTog
RXhwbGljaXRseSBjb252ZXJ0IHNvbWUgbWFjcm9zIHRvIGJvb2xlYW4gdmFsdWVzCj4KPiA6RAoK
WWVhaCwgSSB3YXMgcmVhZGluZyBlbWFpbCBvdXQtb2Ytb3JkZXIuIEJ1dCBJIGxpa2UgbWluZSBi
ZXR0ZXIgYW55d2F5IAoocmVmYWN0b3IgaW50byBhIHNpbmdsZSB1bmRlcmx5aW5nIG1hY3JvLCBh
bmQgbW9yZSBwYXJlbnRoZXNlcykuCgpCVFcgSSB0cmllZAoKI2RlZmluZQlJU19HRU4yKGRldikJ
KElTX0dFTihkZXYsIDIsIDIpKQoKKGJlY2F1c2UgdGhlIElTX0dFTigpIG1hY3JvIGFscmVhZHkg
aGFzIHRoZSAhISBib29sZWFuaXNhdGlvbikgYnV0IGl0IAppbmNyZWFzZWQgdGhlIGNvZGVzaXpl
IGJ5IH40Sy4gSGVuY2UgdGhlIHNlcGFyYXRlIF9JU19HRU4oKS4KCj4gU3RpbGwsIEkgdGhpbmsg
YmVpbmcgZXhwbGljaXQgd2hlbiBhc3NpZ25pbmcgYm9vbGVhbiB0eXBlIG1hY3JvcyB0bwo+IGlu
dGVnZXIgaXMgYSBnb29kIHRoaW5nIHRvIGRvLiBCZWNhdXNlIEkgdGhvdWdodCB0cnVlIGlzIGRl
ZmluZWQgYXMKPiBub24temVybyBpbiBDLiBVbmxlc3MgSSBhbSBiZWhpbmQgdGhlIHRpbWVzLgo+
Cj4gUmVnYXJkcywKPiBUdnJ0a28KClRoZSAqcmVzdWx0KiBvZiBhIGNvbXBhcmlzb24gb3Igb3Ro
ZXIgYm9vbGVhbiBvcGVyYXRpb24gaXMgYW5kIGFsd2F5cyAKaGFzIGJlZW4gMC1vci0xIGluIEMg
KHdoZXJlYXMgaW4gQkNQTCBUUlVFIHdhcyAtMSkuIEl0J3MgdGhlICppbnB1dHMqIHRvIApib29s
ZWFuIG9wZXJhdGlvbnMgdGhhdCBhcmUgdGVzdGVkIGZvciB6ZXJvL25vbnplcm8uCgpPVE9IIG1h
eWJlIEkgd2lsbCBjaGFuZ2UgdGhlIGVuYWJsZV9ndWNfe2xvYWRpbmcsc3VibWlzc2lvbikgdmFs
dWVzIHRvIAphbiBlbnVtIG9yIHNldCBvZiAjZGVmaW5lcywgYW5kIHRoZW4gdGhlIGFzc2lnbm1l
bnQgb2YgdGhlIGRlZmF1bHQgCnZhbHVlcyB3aWxsIHVzZSA/OiB0byBwaWNrIGFwcHJvcHJpYXRl
IHZhbHVlcy4KCi5EYXZlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl
bC1nZngK