public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Dave Gordon <david.s.gordon@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: lawrence.t.li@intel.com, sean.v.kelley@intel.com,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 3/6] drm/i915/huc: Add HuC fw loading support
Date: Tue, 5 Jul 2016 15:41:46 +0100	[thread overview]
Message-ID: <577BC72A.3040902@intel.com> (raw)
In-Reply-To: <CABVU7+u=kuNep7rFKc=3gmtHpLtux7ppnvRUDONoET-e2QWktQ@mail.gmail.com>

On 29/06/16 18:59, Rodrigo Vivi wrote:
>> On Wed, Jun 29, 2016 at 7:31 AM, Dave Gordon <david.s.gordon@intel.com> wrote:
>>> On 29/06/16 00:03, Rodrigo Vivi wrote:
>>>>
>>>> I don't believe we need to be that extreme here.
>>>>
>>>> Daniel asked a cleaner version, but we don't need to block the huc on
>>>> a full rework of an unified fw loader.
>>>
>>>
>>> Oh, I agree, we should take this "mostly" as-is and then reunify them after.
>>>
>>> .Dave.
>
> But the merge on hug/guc loading is just the minor thing Daniel asked.
>
> The major request is to stop using the fetch_status, but errnos
> instead.

That's not going to happen. It's written as a state machine for good 
reason, because the various elements (fetch/load/reload) get called at 
different (and rather arbitrary) points in the driver load sequence, and 
they need to maintain state from one stage to another, not rely on the 
caller(s) to interpret errnos to determine what the next callback should be.

Unless you (or Daniel) just mean change the details of the encoding i.e. 
how that state is represented? We could do that, but I don't think it 
would be useful to reuse unrelated errnos rather than have our own 
precise and specific enumeration of the state of the loading process.

.Dave.

> so, maybe one extra patch that simplifies this right now
> before this series would be the ideal so we could speed up the merge
> and maybe later to the unified firmware loading solution.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-07-05 14:41 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 18:11 [PATCH 0/6] HuC Loading Patches Peter Antoine
2016-06-21 18:11 ` [PATCH 1/6] drm/i915/guc: Make the GuC fw loading helper functions general Peter Antoine
2016-06-28 14:24   ` Dave Gordon
2016-06-21 18:11 ` [PATCH 2/6] drm/i915/huc: Unified css_header struct for GuC and HuC Peter Antoine
2016-06-28 14:32   ` Dave Gordon
2016-06-30 10:39     ` Antoine, Peter
2016-06-21 18:11 ` [PATCH 3/6] drm/i915/huc: Add HuC fw loading support Peter Antoine
2016-06-22  8:31   ` Daniel Vetter
2016-06-23 10:14     ` Dave Gordon
2016-06-23 13:52       ` Peter Antoine
2016-07-13 12:48         ` Daniel Vetter
2016-07-13 14:52           ` Peter Antoine
2016-07-14 14:16             ` Daniel Vetter
2016-07-14 14:39               ` Dave Gordon
2016-07-14 14:43               ` Peter Antoine
2016-07-14 14:08           ` Dave Gordon
2016-07-14 14:26             ` Daniel Vetter
2016-07-15  7:33               ` Dave Gordon
2016-06-28 14:54   ` Dave Gordon
2016-06-28 15:45     ` Dave Gordon
2016-06-28 23:03       ` Rodrigo Vivi
2016-06-29 14:31         ` Dave Gordon
2016-06-29 17:59           ` Rodrigo Vivi
2016-07-05 14:41             ` Dave Gordon [this message]
2016-06-21 18:11 ` [PATCH 4/6] drm/i915/huc: Add debugfs for HuC loading status check Peter Antoine
2016-06-23  8:47   ` Xiang, Haihao
2016-06-23  9:51     ` Peter Antoine
2016-06-23 10:01     ` Peter Antoine
2016-06-23 10:48       ` Michel Thierry
2016-06-23 22:04         ` Kelley, Sean V
2016-07-13  8:13           ` Xiang, Haihao
2016-06-28 14:57   ` Dave Gordon
2016-06-21 18:11 ` [PATCH 5/6] drm/i915/huc: Support HuC authentication Peter Antoine
2016-06-28 15:08   ` Dave Gordon
2016-06-30 10:42     ` Antoine, Peter
2016-06-21 18:11 ` [PATCH 6/6] drm/i915/huc: Add BXT HuC Loading Support Peter Antoine
2016-06-21 18:26   ` Vivi, Rodrigo
2016-06-21 21:28     ` Antoine, Peter
2016-06-28 15:20   ` Dave Gordon
2016-06-22 13:02 ` ✗ Ro.CI.BAT: warning for HuC Loading Patches Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577BC72A.3040902@intel.com \
    --to=david.s.gordon@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lawrence.t.li@intel.com \
    --cc=rodrigo.vivi@gmail.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=sean.v.kelley@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox