From: Mario Kleiner <mario.kleiner.de@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: Pageflipping bugs in drm-next on at least Ironlake and Ivybridge.
Date: Wed, 6 Jul 2016 15:43:04 +0200 [thread overview]
Message-ID: <577D0AE8.1070205@gmail.com> (raw)
In-Reply-To: <20160706130520.GB3438@nuc-i3427.alporthouse.com>
On 07/06/2016 03:05 PM, Chris Wilson wrote:
> On Wed, Jul 06, 2016 at 12:17:55PM +0200, Mario Kleiner wrote:
>> Since i pulled the current drm-next tree i see strong flicker and
>> visual corruption during pageflipping, both in my own app, but also
>> in KDE4 and KDE5 Plasma with desktop composition enabled. This
>> happens on both Intel HD Ironake mobile (Apple MBP 2010) and HD-4000
>> Ivybridge mobile (Apple macMini 2012).
>>
>> It looks like page flips are not waiting properly for rendering to
>> complete, showing partially rendered frames at flip time.
>>
>> If i revert Daniel's commit that switches legacy pageflips from the
>> old code path to the atomic code, all problems disappear, so
>> apparently the atomic code for Intel is not quite ready at least on
>> those parts?
>
> Exactly right, we've reverted the enabling patch for the time being.
> Daniel Stone has spotted the likely problem, but we also want to review
> the handling of state/old_state to see if the same problem has cropped
> up elsewhere.
> -Chris
>
Ah ok, now i see it in drm-intel-next-queued. I'm probably not adding
anything new here, but wrt. your crc based tests not catching it, while
it happens all the time for me under KDE, in my own fullscreen app, it
only obviously happens for some tests, the more graphics heavy ones not
others, so probably (gfx-)load dependent? Maybe the tests don't put
enough work onto the gpu to still keep it rendering at flip time.
-mario
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-07-06 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 10:17 Pageflipping bugs in drm-next on at least Ironlake and Ivybridge Mario Kleiner
2016-07-06 13:05 ` Chris Wilson
2016-07-06 13:43 ` Mario Kleiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577D0AE8.1070205@gmail.com \
--to=mario.kleiner.de@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox