From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 05/17] drm/i915: Support for GuC interrupts Date: Mon, 11 Jul 2016 14:23:03 +0100 Message-ID: <57839DB7.8010007@linux.intel.com> References: <1468158084-22028-1-git-send-email-akash.goel@intel.com> <1468158084-22028-6-git-send-email-akash.goel@intel.com> <5783752D.2020807@linux.intel.com> <122d9b10-3ed9-bbde-06cb-f83f744ccfd3@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id F026C89A60 for ; Mon, 11 Jul 2016 13:23:04 +0000 (UTC) In-Reply-To: <122d9b10-3ed9-bbde-06cb-f83f744ccfd3@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Goel, Akash" , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDExLzA3LzE2IDE0OjE1LCBHb2VsLCBBa2FzaCB3cm90ZToKPiBPbiA3LzExLzIwMTYgNDow MCBQTSwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IE9uIDEwLzA3LzE2IDE0OjQxLCBha2Fz aC5nb2VsQGludGVsLmNvbSB3cm90ZToKPj4+IEZyb206IFNhZ2FyIEFydW4gS2FtYmxlIDxzYWdh ci5hLmthbWJsZUBpbnRlbC5jb20+Cj4+Pgo+Pj4gVGhlcmUgYXJlIGNlcnRhaW4gdHlwZXMgb2Yg aW50ZXJydXB0cyB3aGljaCBIb3N0IGNhbiByZWNpZXZlIGZyb20gR3VDLgo+Pj4gR3VDIHVrZXJu ZWwgc2VuZHMgYW4gaW50ZXJydXB0IHRvIEhvc3QgZm9yIGNlcnRhaW4gZXZlbnRzLCBsaWtlIGZv cgo+Pj4gZXhhbXBsZSByZXRyaWV2ZS9jb25zdW1lIHRoZSBsb2dzIGdlbmVyYXRlZCBieSB1a2Vy bmVsLgo+Pj4gVGhpcyBwYXRjaCBhZGRzIHN1cHBvcnQgdG8gcmVjZWl2ZSBpbnRlcnJ1cHRzIGZy b20gR3VDIGJ1dCBjdXJyZW50bHkKPj4+IGVuYWJsZXMgJiBwYXJ0aWFsbHkgaGFuZGxlcyBvbmx5 IHRoZSBpbnRlcnJ1cHQgc2VudCBieSBHdUMgdWtlcm5lbC4KPj4+IEZ1dHVyZSBwYXRjaGVzIHdp bGwgYWRkIHN1cHBvcnQgZm9yIGhhbmRsaW5nIG90aGVyIGludGVycnVwdCB0eXBlcy4KPj4+Cj4+ PiB2MjoKPj4+IC0gVXNlIGNvbW1vbiBsb3cgbGV2ZWwgcm91dGluZXMgZm9yIFBNIElFUi9JSVIg cHJvZ3JhbW1pbmcgKENocmlzKQo+Pj4gLSBSZW5hbWUgaW50ZXJydXB0IGZ1bmN0aW9ucyB0byBn ZW45X3h4eCBmcm9tIGdlbjhfeHh4IChDaHJpcykKPj4+IC0gUmVwbGFjZSBkaXNhYmxpbmcgb2Yg d2FrZSByZWYgYXNzZXJ0cyB3aXRoIHJwbSBnZXQvcHV0IChDaHJpcykKPj4+Cj4+PiB2MzoKPj4+ IC0gVXBkYXRlIGNvbW1lbnRzIGZvciBtb3JlIGNsYXJpdHkuIChUdnJ0a28pCj4+PiAtIFJlbW92 ZSB0aGUgbWFza2luZyBvZiBHdUMgaW50ZXJydXB0LCB3aGljaCB3YXMga2VwdCBtYXNrZWQgdGls bCB0aGUKPj4+ICAgIHN0YXJ0IG9mIGJvdHRvbSBoYWxmLCBpdHMgbm90IHJlYWxseSBuZWVkZWQg YXMgdGhlcmUgaXMgb25seSBhCj4+PiAgICBzaW5nbGUgaW5zdGFuY2Ugb2Ygd29yayBpdGVtICYg d3EgaXMgb3JkZXJlZC4gKFR2cnRrbykKPj4+Cj4+PiB2NDoKPj4+IC0gUmViYXNlLgo+Pj4gLSBS ZW5hbWUgZ3VjX2V2ZW50cyB0byBwbV9ndWNfZXZlbnRzIHNvIGFzIHRvIGJlIGluZGljYXRpdmUg b2YgdGhlCj4+PiAgICByZWdpc3Rlci9jb250cm9sIGJsb2NrIGl0IGlzIGFzc29jaWF0ZWQgd2l0 aC4gKENocmlzKQo+Pj4gLSBBZGQgaGFuZGxpbmcgZm9yIGJhY2sgdG8gYmFjayBsb2cgYnVmZmVy IGZsdXNoIGludGVycnVwdHMuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogU2FnYXIgQXJ1biBLYW1i bGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4KPj4+IFNpZ25lZC1vZmYtYnk6IEFrYXNoIEdv ZWwgPGFrYXNoLmdvZWxAaW50ZWwuY29tPgo+Pj4gLS0tCj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmggICAgICAgICAgICB8ICAxICsKPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwgIDUgKysKPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9pcnEuYyAgICAgICAgICAgIHwgOTgKPj4+ICsrKysrKysrKysrKysrKysrKysrKysr KysrKystLQo+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICAgICAgICAg fCAxMSArKysrCj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICAgICAg ICB8ICAzICsKPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmggICAgICAgICAg IHwgIDQgKysKPj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jICAg IHwgIDQgKysKPj4+ICAgNyBmaWxlcyBjaGFuZ2VkLCAxMjIgaW5zZXJ0aW9ucygrKSwgNCBkZWxl dGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+Pj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+PiBpbmRleCBjM2E1 NzlmLi42ZTJkZGZhIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+Pj4gQEAgLTE3 OTQsNiArMTc5NCw3IEBAIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlIHsKPj4+ICAgICAgIHUzMiBw bV9pbXI7Cj4+PiAgICAgICB1MzIgcG1faWVyOwo+Pj4gICAgICAgdTMyIHBtX3Jwc19ldmVudHM7 Cj4+PiArICAgIHUzMiBwbV9ndWNfZXZlbnRzOwo+Pj4gICAgICAgdTMyIHBpcGVzdGF0X2lycV9t YXNrW0k5MTVfTUFYX1BJUEVTXTsKPj4+Cj4+PiAgICAgICBzdHJ1Y3QgaTkxNV9ob3RwbHVnIGhv dHBsdWc7Cj4+Pgo+Pj4gKwo+Pj4gICAvKioKPj4+ICAgICogYmR3X3VwZGF0ZV9wb3J0X2lycSAt IHVwZGF0ZSBERSBwb3J0IGludGVycnVwdAo+Pj4gICAgKiBAZGV2X3ByaXY6IGRyaXZlciBwcml2 YXRlCj4+PiBAQCAtMTE3NCw2ICsxMjA4LDIxIEBAIHN0YXRpYyB2b2lkIGdlbjZfcG1fcnBzX3dv cmsoc3RydWN0IHdvcmtfc3RydWN0Cj4+PiAqd29yaykKPj4+ICAgICAgIG11dGV4X3VubG9jaygm ZGV2X3ByaXYtPnJwcy5od19sb2NrKTsKPj4+ICAgfQo+Pj4KPj4+ICtzdGF0aWMgdm9pZCBnZW45 X2d1YzJob3N0X2V2ZW50c193b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPj4+ICt7Cj4+ PiArICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9Cj4+PiArICAgICAgICBj b250YWluZXJfb2Yod29yaywgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUsIGd1Yy5ldmVudHNfd29y ayk7Cj4+PiArCj4+PiArICAgIHNwaW5fbG9ja19pcnEoJmRldl9wcml2LT5pcnFfbG9jayk7Cj4+ PiArICAgIC8qIFNwZWVkIHVwIHdvcmsgY2FuY2VsbGF0aW9uIGR1cmluZyBkaXNhYmxpbmcgZ3Vj IGludGVycnVwdHMuICovCj4+PiArICAgIGlmICghZGV2X3ByaXYtPmd1Yy5pbnRlcnJ1cHRzX2Vu YWJsZWQpIHsKPj4+ICsgICAgICAgIHNwaW5fdW5sb2NrX2lycSgmZGV2X3ByaXYtPmlycV9sb2Nr KTsKPj4+ICsgICAgICAgIHJldHVybjsKPj4+ICsgICAgfQo+Pj4gKyAgICBzcGluX3VubG9ja19p cnEoJmRldl9wcml2LT5pcnFfbG9jayk7Cj4+PiArCj4+PiArICAgIC8qIFRPRE86IEhhbmRsZSB0 aGUgZXZlbnRzIGZvciB3aGljaCBHdUMgaW50ZXJydXB0ZWQgaG9zdCAqLwo+Pj4gK30KPj4+Cj4+ PiAgIC8qKgo+Pj4gICAgKiBpdnlicmlkZ2VfcGFyaXR5X3dvcmsgLSBXb3JrcXVldWUgY2FsbGVk IHdoZW4gYSBwYXJpdHkgZXJyb3IKPj4+IGludGVycnVwdAo+Pj4gQEAgLTEzNDYsMTEgKzEzOTUs MTMgQEAgc3RhdGljIGlycXJldHVybl90IGdlbjhfZ3RfaXJxX2FjayhzdHJ1Y3QKPj4+IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+Pj4gICAgICAgICAgICAgICBEUk1fRVJST1IoIlRoZSBt YXN0ZXIgY29udHJvbCBpbnRlcnJ1cHQgbGllZCAoR1QzKSFcbiIpOwo+Pj4gICAgICAgfQo+Pj4K Pj4+IC0gICAgaWYgKG1hc3Rlcl9jdGwgJiBHRU44X0dUX1BNX0lSUSkgewo+Pj4gKyAgICBpZiAo bWFzdGVyX2N0bCAmIChHRU44X0dUX1BNX0lSUSB8IEdFTjhfR1RfR1VDX0lSUSkpIHsKPj4+ICAg ICAgICAgICBndF9paXJbMl0gPSBJOTE1X1JFQURfRlcoR0VOOF9HVF9JSVIoMikpOwo+Pj4gLSAg ICAgICAgaWYgKGd0X2lpclsyXSAmIGRldl9wcml2LT5wbV9ycHNfZXZlbnRzKSB7Cj4+PiArICAg ICAgICBpZiAoZ3RfaWlyWzJdICYgKGRldl9wcml2LT5wbV9ycHNfZXZlbnRzIHwKPj4+ICsgICAg ICAgICAgICAgICAgIGRldl9wcml2LT5wbV9ndWNfZXZlbnRzKSkgewo+Pj4gICAgICAgICAgICAg ICBJOTE1X1dSSVRFX0ZXKEdFTjhfR1RfSUlSKDIpLAo+Pj4gLSAgICAgICAgICAgICAgICAgICAg ICBndF9paXJbMl0gJiBkZXZfcHJpdi0+cG1fcnBzX2V2ZW50cyk7Cj4+PiArICAgICAgICAgICAg ICAgICAgICAgIGd0X2lpclsyXSAmIChkZXZfcHJpdi0+cG1fcnBzX2V2ZW50cyB8Cj4+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgZGV2X3ByaXYtPnBtX2d1Y19ldmVudHMpKTsKPj4+ICAg ICAgICAgICAgICAgcmV0ID0gSVJRX0hBTkRMRUQ7Cj4+PiAgICAgICAgICAgfSBlbHNlCj4+PiAg ICAgICAgICAgICAgIERSTV9FUlJPUigiVGhlIG1hc3RlciBjb250cm9sIGludGVycnVwdCBsaWVk IChQTSkhXG4iKTsKPj4+IEBAIC0xMzgyLDYgKzE0MzMsOSBAQCBzdGF0aWMgdm9pZCBnZW44X2d0 X2lycV9oYW5kbGVyKHN0cnVjdAo+Pj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+Pgo+ Pj4gICAgICAgaWYgKGd0X2lpclsyXSAmIGRldl9wcml2LT5wbV9ycHNfZXZlbnRzKQo+Pj4gICAg ICAgICAgIGdlbjZfcnBzX2lycV9oYW5kbGVyKGRldl9wcml2LCBndF9paXJbMl0pOwo+Pj4gKwo+ Pj4gKyAgICBpZiAoZ3RfaWlyWzJdICYgZGV2X3ByaXYtPnBtX2d1Y19ldmVudHMpCj4+PiArICAg ICAgICBnZW45X2d1Y19pcnFfaGFuZGxlcihkZXZfcHJpdiwgZ3RfaWlyWzJdKTsKPj4+ICAgfQo+ Pj4KPj4+ICAgc3RhdGljIGJvb2wgYnh0X3BvcnRfaG90cGx1Z19sb25nX2RldGVjdChlbnVtIHBv cnQgcG9ydCwgdTMyIHZhbCkKPj4+IEBAIC0xNjI4LDYgKzE2ODIsMzggQEAgc3RhdGljIHZvaWQg Z2VuNl9ycHNfaXJxX2hhbmRsZXIoc3RydWN0Cj4+PiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwgdTMyIHBtX2lpcikKPj4+ICAgICAgIH0KPj4+ICAgfQo+Pj4KPj4+ICtzdGF0aWMgdm9pZCBn ZW45X2d1Y19pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ PiB1MzIgZ3RfaWlyKQo+Pj4gK3sKPj4+ICsgICAgaWYgKGd0X2lpciAmIEdFTjlfR1VDX1RPX0hP U1RfSU5UX0VWRU5UKSB7Cj4+PiArICAgICAgICBzcGluX2xvY2soJmRldl9wcml2LT5pcnFfbG9j ayk7Cj4+PiArICAgICAgICBpZiAoZGV2X3ByaXYtPmd1Yy5pbnRlcnJ1cHRzX2VuYWJsZWQpIHsK Pj4+ICsgICAgICAgICAgICAvKiBTYW1wbGUgdGhlIGxvZyBidWZmZXIgZmx1c2ggcmVsYXRlZCBi aXRzICYgY2xlYXIgdGhlbQo+Pj4gKyAgICAgICAgICAgICAqIG91dCBub3cgaXRzZWxmIGZyb20g dGhlIG1lc3NhZ2UgaWRlbnRpdHkgcmVnaXN0ZXIgdG8KPj4+ICsgICAgICAgICAgICAgKiBtaW5p bWl6ZSB0aGUgcHJvYmFiaWxpdHkgb2YgbG9zaW5nIGEgZmx1c2ggaW50ZXJydXB0LAo+Pj4gKyAg ICAgICAgICAgICAqIHdoZW4gdGhlcmUgYXJlIGJhY2sgdG8gYmFjayBmbHVzaCBpbnRlcnJ1cHRz Lgo+Pj4gKyAgICAgICAgICAgICAqIFRoZXJlIGNhbiBiZSBhIG5ldyBmbHVzaCBpbnRlcnJ1cHQs IGZvciBkaWZmZXJlbnQgbG9nCj4+PiArICAgICAgICAgICAgICogYnVmZmVyIHR5cGUgKGxpa2Ug Zm9yIElTUiksIHdoaWxzdCBIb3N0IGlzIGhhbmRsaW5nCj4+PiArICAgICAgICAgICAgICogb25l IChmb3IgRFBDKS4gU2luY2Ugc2FtZSBiaXQgaXMgdXNlZCBpbiBtZXNzYWdlCj4+PiArICAgICAg ICAgICAgICogcmVnaXN0ZXIgZm9yIElTUiAmIERQQywgaXQgY291bGQgaGFwcGVuIHRoYXQgR3VD Cj4+PiArICAgICAgICAgICAgICogc2V0cyB0aGUgYml0IGZvciAybmQgaW50ZXJydXB0IGJ1dCBI b3N0IGNsZWFycyBvdXQKPj4+ICsgICAgICAgICAgICAgKiB0aGUgYml0IG9uIGhhbmRsaW5nIHRo ZSAxc3QgaW50ZXJydXB0Lgo+Pj4gKyAgICAgICAgICAgICAqLwo+Pj4gKyAgICAgICAgICAgIHUz MiBtc2cgPSBJOTE1X1JFQUQoU09GVF9TQ1JBVENIKDE1KSkgJgo+Pj4gKyAgICAgICAgICAgICAg ICAgICAgKEdVQzJIT1NUX01TR19DUkFTSF9EVU1QX1BPU1RFRCB8Cj4+PiArICAgICAgICAgICAg ICAgICAgICAgR1VDMkhPU1RfTVNHX0ZMVVNIX0xPR19CVUZGRVIpOwo+Pj4gKyAgICAgICAgICAg IGlmIChtc2cpIHsKPj4+ICsgICAgICAgICAgICAgICAgLyogQ2xlYXIgdGhlIG1lc3NhZ2UgYml0 cyB0aGF0IGFyZSBoYW5kbGVkICovCj4+PiArICAgICAgICAgICAgICAgIEk5MTVfV1JJVEUoU09G VF9TQ1JBVENIKDE1KSwKPj4+ICsgICAgICAgICAgICAgICAgICAgIEk5MTVfUkVBRChTT0ZUX1ND UkFUQ0goMTUpKSAmIH5tc2cpOwo+Pj4gKwo+Pj4gKyAgICAgICAgICAgICAgICAvKiBIYW5kbGUg Zmx1c2ggaW50ZXJydXB0IGV2ZW50IGluIGJvdHRvbSBoYWxmICovCj4+PiArICAgICAgICAgICAg ICAgIHF1ZXVlX3dvcmsoZGV2X3ByaXYtPndxLCAmZGV2X3ByaXYtPmd1Yy5ldmVudHNfd29yayk7 Cj4+Cj4+IFNpbmNlIHRoZSBsYXRlciBwYXRjaCBpcyBjaGFuZ2luZyB0aGlzIHRvIHVzZSBhIHRo cmVhZCwgc2luY2UgeW91IGhhdmUKPj4gZXN0YWJsaXNoZWQgd29ya2VyIGlzIHRvbyBzbG93IC0g ZXNwZWNpYWxseSB0aGUgc2hhcmVkIG9uZSAtIEkgd291bGQKPj4gcmVhbGx5IHJlY29tbWVuZCB5 b3Ugc3RhcnQgd2l0aCB0aGUga3RocmVhZCBzdHJhaWdodCBhd2F5LiBOb3QgaGF2ZSB0aGUKPj4g d29ya2VyIGZvciBhIHdoaWxlIGluIHRoZSBzYW1lIHNlcmllcyBhbmQgdGhlbiBsYXRlciBjaGFu Z2UgaXQgdG8gYQo+PiB0aHJlYWQuCj4+Cj4gQWN0dWFsbHkgaXQgd29uJ3QgYmUgYXBwcm9wcmlh dGUgdG8gc2F5IHRoYXQgc2hhcmVkIHdvcmtlciB0aHJlYWQgaXMgdG9vCj4gc2xvdywgYnV0IGhh dmluZyBhIGRlZGljYXRlZCBrdGhyZWFkIGRlZmluaXRlbHkgaGVscHMuCj4KPiBJIGtlcHQgdGhl IGt0aHJlYWQgcGF0Y2ggYXQgdGhlIGxhc3Qgc28gdGhhdCBhcyBwZXIgdGhlIHJlc3BvbnNlLAo+ IHJldmlldyBjb21tZW50cyBjYW4gZHJvcCBpdCBhbHNvLgoKSSB0aGluayBpdCBzaG91bGQgb25s eSBiZSBvbmUgaW1wbGVtZW50YXRpb24gaW4gdGhlIHBhdGNoIHNlcmllcy4gSWYgd2UgCmFncmVl ZCBvbiBhIGt0aHJlYWQgbWFrZSBpdCBzbyBmcm9tIHRoZSBzdGFydC4KCkFuZCBkZXNjcmliZSBp biB0aGUgY29tbWl0IG1lc3NhZ2Ugd2h5IGl0IHdhcyBzZWxlY3RlZCBldGMuCgo+Pj4gKyAgICAg ICAgICAgIH0KPj4+ICsgICAgICAgIH0KPj4+ICsgICAgICAgIHNwaW5fdW5sb2NrKCZkZXZfcHJp di0+aXJxX2xvY2spOwo+Pgo+PiBXaHkgZG9lcyB0aGUgYWJvdmUgbmVlZHMgdG8gYmUgZG9uZSB1 bmRlciB0aGUgaXJxX2xvY2sgPwo+Pgo+IFVzaW5nIHRoZSBpcnFfbG9jayBmb3IgJ2d1Yy5pbnRl cnJ1cHRzX2VuYWJsZWQnLCBlc3BlY2lhbGx5IHVzZWZ1bAo+IHdoaWxlIGRpc2FibGluZyB0aGUg aW50ZXJydXB0LgoKV2h5PyBJIGRvbid0IHNlZSBob3cgaXQgZ2FpbnMgeW91IGFueXRoaW5nIGFu ZCBzbyBpdCBzZWVtcyBwcmVmZXJhYmxlIApub3QgdG8gaG9sZCBpdCBvdmVyIG1taW8gYWNjZXNz ZXMuCgpSZWdhcmRzLAoKVHZydGtvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==