From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Dave Gordon <david.s.gordon@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915/guc: downgrade some DRM_ERROR() messages to DRM_WARN()
Date: Tue, 12 Jul 2016 10:37:42 +0100 [thread overview]
Message-ID: <5784BA66.5060407@linux.intel.com> (raw)
In-Reply-To: <20160712092714.GO6157@nuc-i3427.alporthouse.com>
On 12/07/16 10:27, Chris Wilson wrote:
> On Tue, Jul 12, 2016 at 10:20:43AM +0100, Tvrtko Ursulin wrote:
>> On 11/07/16 19:01, Dave Gordon wrote:
>>> @@ -553,8 +551,8 @@ static int guc_ring_doorbell(struct i915_guc_client *gc)
>>> if (db_ret.db_status == GUC_DOORBELL_DISABLED)
>>> break;
>>>
>>> - DRM_ERROR("Cookie mismatch. Expected %d, returned %d\n",
>>> - db_cmp.cookie, db_ret.cookie);
>>> + DRM_WARN("Cookie mismatch. Expected %d, found %d\n",
>>> + db_cmp.cookie, db_ret.cookie);
>>
>> This one is interesting, error is propagated out a bit but then
>> ignored in actual command submission.
>>
>> If the above message means command will not be submitted error is
>> probably more appropriate. Or perhaps we cannot tell if the command
>> was submitted or not in this case?
>
> It's insignificant. An actual error would result in a GPU hang, and
> without being recorded in the error state any message here is useless.
I don't agree that it is useless, if it is a very unexpected situation
it deserves to be logged. People do store and look at logs when things
go bad.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-07-12 9:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 18:01 [PATCH 1/3] drm: extra printk() wrapper macros Dave Gordon
2016-07-11 18:01 ` [PATCH 2/3] drm/i915/guc: downgrade some DRM_ERROR() messages to DRM_WARN() Dave Gordon
2016-07-12 9:20 ` Tvrtko Ursulin
2016-07-12 9:27 ` [Intel-gfx] " Chris Wilson
2016-07-12 9:37 ` Tvrtko Ursulin [this message]
2016-07-12 12:29 ` Dave Gordon
2016-07-11 18:01 ` [PATCH 3/3] drm/i915/guc: revisit GuC loader message levels Dave Gordon
2016-07-12 9:26 ` [Intel-gfx] " Tvrtko Ursulin
2016-07-12 15:11 ` Dave Gordon
2016-07-12 9:06 ` [PATCH 1/3] drm: extra printk() wrapper macros Tvrtko Ursulin
2016-07-12 13:28 ` Dave Gordon
2016-07-12 13:51 ` [Intel-gfx] " Tvrtko Ursulin
2016-07-12 11:06 ` Eric Engestrom
2016-07-12 14:25 ` Daniel Vetter
2016-07-12 14:53 ` Dave Gordon
2016-07-12 14:59 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5784BA66.5060407@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=david.s.gordon@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox