From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 2/3] drm/i915/guc: downgrade some DRM_ERROR() messages to DRM_WARN() Date: Tue, 12 Jul 2016 13:29:54 +0100 Message-ID: <5784E2C2.7020506@intel.com> References: <1468260090-2756-1-git-send-email-david.s.gordon@intel.com> <1468260090-2756-2-git-send-email-david.s.gordon@intel.com> <5784B66B.7010502@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 55E9F6E542 for ; Tue, 12 Jul 2016 12:29:56 +0000 (UTC) In-Reply-To: <5784B66B.7010502@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTIvMDcvMTYgMTA6MjAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMTEvMDcvMTYg MTk6MDEsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBXaGVyZSB3ZSdyZSBnb2luZyB0byBjb250aW51 ZSByZWdhcmRsZXNzIG9mIHRoZSBwcm9ibGVtLCByYXRoZXIgdGhhbgo+PiBmYWlsLCB0aGVuIHRo ZSBtZXNzYWdlIHNob3VsZCBiZSBhIFdBUk5pbmcgcmF0aGVyIHRoYW4gYW4gRVJST1IuCj4+Cj4+ IFNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4+ IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDE4 ICsrKysrKystLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyks IDExIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNf c3VibWlzc2lvbi5jCj4+IGluZGV4IDIxMTJlMDIuLmUyOTliNjQgMTAwNjQ0Cj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4gQEAgLTExNCwxMCArMTE0LDgg QEAgc3RhdGljIGludCBob3N0Mmd1Y19hY3Rpb24oc3RydWN0IGludGVsX2d1YyAqZ3VjLAo+PiB1 MzIgKmRhdGEsIHUzMiBsZW4pCj4+ICAgICAgICAgICBpZiAocmV0ICE9IC1FVElNRURPVVQpCj4+ ICAgICAgICAgICAgICAgcmV0ID0gLUVJTzsKPj4KPj4gLSAgICAgICAgRFJNX0VSUk9SKCJHVUM6 IGhvc3QyZ3VjIGFjdGlvbiAweCVYIGZhaWxlZC4gcmV0PSVkICIKPj4gLSAgICAgICAgICAgICAg ICAic3RhdHVzPTB4JTA4WCByZXNwb25zZT0weCUwOFhcbiIsCj4+IC0gICAgICAgICAgICAgICAg ZGF0YVswXSwgcmV0LCBzdGF0dXMsCj4+IC0gICAgICAgICAgICAgICAgSTkxNV9SRUFEKFNPRlRf U0NSQVRDSCgxNSkpKTsKPj4gKyAgICAgICAgRFJNX1dBUk4oIkFjdGlvbiAweCVYIGZhaWxlZDsg cmV0PSVkIHN0YXR1cz0weCUwOFgKPj4gcmVzcG9uc2U9MHglMDhYXG4iLAo+PiArICAgICAgICAg ICAgIGRhdGFbMF0sIHJldCwgc3RhdHVzLCBJOTE1X1JFQUQoU09GVF9TQ1JBVENIKDE1KSkpOwo+ Cj4gSG0sIHRoaXMgZG9lcyBwcm9wYWdhdGUgdGhlIGVycm9yIGNvZGUgdG8gdGhlIGNhbGxlcnMg c29tZSB3aGljaCB3aWxsCj4gYWN0IGFuZCBsb2cgdGhlIGZhaWx1cmUuIE1ham9yaXR5IHdvbid0 IHRob3VnaCAtIGxpa2Ugc3VzcGVuZC9yZXN1bWUKPiBldGMuIEluIHRob3NlIGNhc2VzIGl0IGZl ZWxzIG1vcmUgbGlrZSBhbiBlcnJvciB0aGFuIGEgd2FybmluZy4KCkl0J3MgZGVmaW5pdGVseSBz b21ldGhpbmcgdGhhdCBzaG91bGRuJ3QgaGFwcGVuLCBzbyB3ZSBuZWVkIHRvIGxvZyBpdDsgCmFu ZCBpdCBoYXMgdG8gYmUgZG9uZSBhdCB0aGlzIGxldmVsIGJlY2F1c2Ugd2UgZG9uJ3QgcGFzcyBl bm91Z2ggCmluZm9ybWF0aW9uIGJhY2sgdG8gbGVhdmUgaXQgdG8gdGhlIGNhbGxlci4gQnV0IE9U T0ggdGhpcyBsYXllciBkb2Vzbid0IApoYXZlIGVub3VnaCBpbmZvcm1hdGlvbiB0byBkZXRlcm1p bmUganVzdCBob3cgc2VyaW91cyBhIGZhaWx1cmUgaXMuCgpTbyBhcyBhIGNvbXByb21pc2UgdGhl IGlkZWEgaXMgdG8gbG9nIGEgV0FSTklORyBoZXJlLCBhbmQgdGhlbiB0aGUgCmNhbGxlciBjYW4g Y2hvb3NlIHRvOgoxLiBwYXNzIHRoZSBmYWlsdXJlIHVwICh1bnRpbCB3ZSByZWFjaCBhIGxheWVy IHdpdGggbW9yZSBjb250ZXh0KQoyLiBxdWlldGx5IGRpc3JlZ2FyZCB0aGUgZmFpbHVyZSBhbmQg Y29udGludWUgYW55d2F5CjMuIHJlcG9ydCBhbiBFUlJPUiBhbmQgZmFpbC9hYm9ydCB0aGUgcHJv Y2Vzcy4KClRoYXQgd2F5IHdlIHNob3VsZCBnZXQgYWxsIHRoZSB1c2VmdWwgaW5mb3JtYXRpb24g YWJvdXQgdGhlIHJvb3QgY2F1c2UgCm9mIHNvbWV0aGluZyB0aGF0IGVuZHMgdXAgYXMgYW4gRVJS T1IsIHdoaWxlIG5laXRoZXIgaWdub3Jpbmcgbm9yIGJlaW5nIAp0b28gdmVyYm9zZSBhYm91dCBm YWlsdXJlcyBmcm9tIHdoaWNoIHdlIG1heSB1bHRpbWF0ZWx5IHJlY292ZXIuCgpGb3IgZXhhbXBs ZSwgb25lIG9mIHRoZSBjYWxsZXJzICh0aGUgZG9vcmJlbGwgaC93IGluaXRpYWxpc2F0aW9uIGNv ZGUpIApjb25zaWRlcnMgc29tZSBmYWlsdXJlcyBhcyBpbnRlcmVzdGluZyBidXQgbm90IGNyaXRp Y2FsIChERUJVRyBsZXZlbCkgCmJ1dCBvdGhlciBpbnN0YW5jZXMgb2YgdGhlIGV4YWN0IHNhbWUg b3BlcmF0aW9uIGFyZSBmYXRhbCAoRVJST1IpLgoKPj4gICAgICAgICAgIGRldl9wcml2LT5ndWMu YWN0aW9uX2ZhaWwgKz0gMTsKPj4gICAgICAgICAgIGRldl9wcml2LT5ndWMuYWN0aW9uX2VyciA9 IHJldDsKPj4gQEAgLTU1Myw4ICs1NTEsOCBAQCBzdGF0aWMgaW50IGd1Y19yaW5nX2Rvb3JiZWxs KHN0cnVjdAo+PiBpOTE1X2d1Y19jbGllbnQgKmdjKQo+PiAgICAgICAgICAgaWYgKGRiX3JldC5k Yl9zdGF0dXMgPT0gR1VDX0RPT1JCRUxMX0RJU0FCTEVEKQo+PiAgICAgICAgICAgICAgIGJyZWFr Owo+Pgo+PiAtICAgICAgICBEUk1fRVJST1IoIkNvb2tpZSBtaXNtYXRjaC4gRXhwZWN0ZWQgJWQs IHJldHVybmVkICVkXG4iLAo+PiAtICAgICAgICAgICAgICBkYl9jbXAuY29va2llLCBkYl9yZXQu Y29va2llKTsKPj4gKyAgICAgICAgRFJNX1dBUk4oIkNvb2tpZSBtaXNtYXRjaC4gRXhwZWN0ZWQg JWQsIGZvdW5kICVkXG4iLAo+PiArICAgICAgICAgICAgIGRiX2NtcC5jb29raWUsIGRiX3JldC5j b29raWUpOwo+Cj4gVGhpcyBvbmUgaXMgaW50ZXJlc3RpbmcsIGVycm9yIGlzIHByb3BhZ2F0ZWQg b3V0IGEgYml0IGJ1dCB0aGVuIGlnbm9yZWQKPiBpbiBhY3R1YWwgY29tbWFuZCBzdWJtaXNzaW9u Lgo+Cj4gSWYgdGhlIGFib3ZlIG1lc3NhZ2UgbWVhbnMgY29tbWFuZCB3aWxsIG5vdCBiZSBzdWJt aXR0ZWQgZXJyb3IgaXMKPiBwcm9iYWJseSBtb3JlIGFwcHJvcHJpYXRlLiBPciBwZXJoYXBzIHdl IGNhbm5vdCB0ZWxsIGlmIHRoZSBjb21tYW5kIHdhcwo+IHN1Ym1pdHRlZCBvciBub3QgaW4gdGhp cyBjYXNlPwoKTm90ZSB0aGF0IHRoaXMgaXMgaW5zaWRlIGEgcmV0cnkgbG9vcC4gSXQgc2hvdWxk bid0IGV2ZXIgaGFwcGVuLCBidXQgaWYgCml0IGRvZXMgd2UnbGwgcmVwb3J0IGl0IGFuZCB0cnkg b25lIG1vcmUgdGltZS4gSWYgaXQga2VlcHMgaGFwcGVuaW5nIAood2hpY2ggd291bGQgcmVxdWly ZSBhY3RpdmUgaW50ZXJmZXJlbmNlIGJ5IHNvbWUgb3RoZXIgcGFydHkpIHdlIHdvbid0IApiZSBh YmxlIHRvIHJpbmcgdGhlIGRvb3JiZWxsIGFuZCB0aGUgZmFpbHVyZSB3aWxsIGJlIHByb3BhZ2F0 ZWQgYmFjayBvdXQgCm9mIHRoZSBHdUMgc3VibWlzc2lvbiBjb2RlLiBPVE9IIHRoZSBjYWxsZXIg dGhlbiBpZ25vcmVzIGl0IGJlY2F1c2UgCiJzdWJtaXNzaW9uIGlzIG5vdCBhbGxvd2VkIHRvIGZh aWwiICghKQoKQW5kIHllcywgaXQgaXMgdGhlbiB1bmRlZmluZWQgYXMgdG8gd2hldGhlciB0aGUg Y29tbWFuZCBoYXMgYmVlbiAKc3VibWl0dGVkIG9yIG5vdC4gSWYgaXQgaGFzbid0IHdlJ2xsIGV4 cGVjdCBhIEdQVSBoYW5nIGxhdGVyLgoKLkRhdmUuCgo+PiAgICAgICAgICAgLyogdXBkYXRlIHRo ZSBjb29raWUgdG8gbmV3bHkgcmVhZCBjb29raWUgZnJvbSBHdUMgKi8KPj4gICAgICAgICAgIGRi X2NtcC5jb29raWUgPSBkYl9yZXQuY29va2llOwo+PiBAQCAtNzI2LDggKzcyNCw4IEBAIHN0YXRp YyB2b2lkIGd1Y19pbml0X2Rvb3JiZWxsX2h3KHN0cnVjdCBpbnRlbF9ndWMKPj4gKmd1YykKPj4g ICAgICAgLyogUmVzdG9yZSB0byBvcmlnaW5hbCB2YWx1ZSAqLwo+PiAgICAgICBlcnIgPSBndWNf dXBkYXRlX2Rvb3JiZWxsX2lkKGd1YywgY2xpZW50LCBkYl9pZCk7Cj4+ICAgICAgIGlmIChlcnIp Cj4+IC0gICAgICAgIERSTV9FUlJPUigiRmFpbGVkIHRvIHJlc3RvcmUgZG9vcmJlbGwgdG8gJWQs IGVyciAlZFxuIiwKPj4gLSAgICAgICAgICAgIGRiX2lkLCBlcnIpOwo+PiArICAgICAgICBEUk1f V0FSTigiRmFpbGVkIHRvIHJlc3RvcmUgZG9vcmJlbGwgdG8gJWQsIGVyciAlZFxuIiwKPj4gKyAg ICAgICAgICAgICBkYl9pZCwgZXJyKTsKPj4KPj4gICAgICAgZm9yIChpID0gMDsgaSA8IEdVQ19N QVhfRE9PUkJFTExTOyArK2kpIHsKPj4gICAgICAgICAgIGk5MTVfcmVnX3QgZHJicmVnID0gR0VO OF9EUkJSRUdMKGkpOwo+PiBAQCAtODE5LDggKzgxNyw2IEBAIHN0YXRpYyB2b2lkIGd1Y19pbml0 X2Rvb3JiZWxsX2h3KHN0cnVjdCBpbnRlbF9ndWMKPj4gKmd1YykKPj4gICAgICAgcmV0dXJuIGNs aWVudDsKPj4KPj4gICBlcnI6Cj4+IC0gICAgRFJNX0VSUk9SKCJGQUlMRUQgdG8gY3JlYXRlIHBy aW9yaXR5ICV1IEd1QyBjbGllbnQhXG4iLCBwcmlvcml0eSk7Cj4+IC0KPj4gICAgICAgZ3VjX2Ns aWVudF9mcmVlKGRldl9wcml2LCBjbGllbnQpOwo+PiAgICAgICByZXR1cm4gTlVMTDsKPj4gICB9 Cj4+IEBAIC05OTgsNyArOTk0LDcgQEAgaW50IGk5MTVfZ3VjX3N1Ym1pc3Npb25fZW5hYmxlKHN0 cnVjdAo+PiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gICAgICAgICAgICAgICAgICAg ICBHVUNfQ1RYX1BSSU9SSVRZX0tNRF9OT1JNQUwsCj4+ICAgICAgICAgICAgICAgICAgICAgZGV2 X3ByaXYtPmtlcm5lbF9jb250ZXh0KTsKPj4gICAgICAgaWYgKCFjbGllbnQpIHsKPj4gLSAgICAg ICAgRFJNX0VSUk9SKCJGYWlsZWQgdG8gY3JlYXRlIGV4ZWNidWYgZ3VjX2NsaWVudFxuIik7Cj4+ ICsgICAgICAgIERSTV9FUlJPUigiRmFpbGVkIHRvIGNyZWF0ZSBub3JtYWwgR3VDIGNsaWVudCFc biIpOwo+PiAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07Cj4+ICAgICAgIH0KPj4KPj4KPgo+IFJl Z2FyZHMsCj4gVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK