From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 3/3] drm/i915/guc: revisit GuC loader message levels Date: Tue, 12 Jul 2016 16:11:22 +0100 Message-ID: <5785089A.7020007@intel.com> References: <1468260090-2756-1-git-send-email-david.s.gordon@intel.com> <1468260090-2756-3-git-send-email-david.s.gordon@intel.com> <5784B7CC.5010009@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5784B7CC.5010009@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Cc: David Airlie , dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTIvMDcvMTYgMTA6MjYsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMTEvMDcvMTYg MTk6MDEsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBTb21lIGRvd25ncmFkZWQgZnJvbSBEUk1fRVJS T1IoKSB0byBEUk1fV0FSTigpLCBzb21lIGVsaW1pbmF0ZWQsCj4+IGFuZCBhIGZldyB1cGdyYWRl ZCBmcm9tIERSTV9JTkZPKCkgdG8gRFJNX05PVEUoKSBvciBEUk1fV0FSTigpLgo+Pgo+PiBTaWdu ZWQtb2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+PiAtLS0K Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMgfCAyMCArKysrKysr KysrLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMCBk ZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2d1Y19sb2FkZXIuYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIu Ywo+PiBpbmRleCA2MDVjNjk2Li5mZDAzMmViIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZ3VjX2xvYWRlci5jCj4+IEBAIC0xNDAsMTIgKzE0MCwxNCBAQCBzdGF0aWMgdTMyIGdl dF9ndHR5cGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPj4gKmRldl9wcml2KQo+Pgo+PiAgIHN0 YXRpYyB1MzIgZ2V0X2NvcmVfZmFtaWx5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPj4gICB7Cj4+IC0gICAgc3dpdGNoIChJTlRFTF9JTkZPKGRldl9wcml2KS0+Z2VuKSB7Cj4+ ICsgICAgdTMyIGdlbiA9IElOVEVMX0dFTihkZXZfcHJpdik7Cj4+ICsKPj4gKyAgICBzd2l0Y2gg KGdlbikgewo+PiAgICAgICBjYXNlIDk6Cj4+ICAgICAgICAgICByZXR1cm4gR0ZYQ09SRV9GQU1J TFlfR0VOOTsKPj4KPj4gICAgICAgZGVmYXVsdDoKPj4gLSAgICAgICAgRFJNX0VSUk9SKCJHVUM6 IHVuc3VwcG9ydGVkIGNvcmUgZmFtaWx5XG4iKTsKPj4gKyAgICAgICAgRFJNX1dBUk4oIkdFTiVk IGRvZXMgbm90IHN1cHBvcnQgR3VDIG9wZXJhdGlvblxuIiwgZ2VuKTsKPj4gICAgICAgICAgIHJl dHVybiBHRlhDT1JFX0ZBTUlMWV9VTktOT1dOOwo+PiAgICAgICB9Cj4+ICAgfQo+PiBAQCAtNDMz LDcgKzQzNSw3IEBAIGludCBpbnRlbF9ndWNfc2V0dXAoc3RydWN0IGRybV9kZXZpY2UgKmRldikK Pj4gICAgICAgICAgIGdvdG8gZmFpbDsKPj4gICAgICAgfSBlbHNlIGlmICgqZndfcGF0aCA9PSAn XDAnKSB7Cj4+ICAgICAgICAgICAvKiBEZXZpY2UgaGFzIGEgR3VDIGJ1dCB3ZSBkb24ndCBrbm93 IHdoYXQgZi93IHRvIGxvYWQ/ICovCj4+IC0gICAgICAgIERSTV9JTkZPKCJObyBHdUMgZmlybXdh cmUga25vd24gZm9yIHRoaXMgcGxhdGZvcm1cbiIpOwo+PiArICAgICAgICBEUk1fV0FSTigiTm8g R3VDIGZpcm13YXJlIGtub3duIGZvciB0aGlzIHBsYXRmb3JtXG4iKTsKPj4gICAgICAgICAgIGVy ciA9IC1FTk9ERVY7Cj4+ICAgICAgICAgICBnb3RvIGZhaWw7Cj4+ICAgICAgIH0KPj4gQEAgLTQ3 MSwxMCArNDczLDggQEAgaW50IGludGVsX2d1Y19zZXR1cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KQo+PiAgICAgICAgICAgICogdGhhdCB0aGUgc3RhdGUgYW5kIHRpbWluZyBhcmUgZmFpcmx5IHBy ZWRpY3RhYmxlCj4+ICAgICAgICAgICAgKi8KPj4gICAgICAgICAgIGVyciA9IGk5MTVfcmVzZXRf Z3VjKGRldl9wcml2KTsKPj4gLSAgICAgICAgaWYgKGVycikgewo+PiAtICAgICAgICAgICAgRFJN X0VSUk9SKCJHdUMgcmVzZXQgZmFpbGVkOiAlZFxuIiwgZXJyKTsKPj4gKyAgICAgICAgaWYgKGVy cikKPj4gICAgICAgICAgICAgICBnb3RvIGZhaWw7Cj4+IC0gICAgICAgIH0KPj4KPj4gICAgICAg ICAgIGVyciA9IGd1Y191Y29kZV94ZmVyKGRldl9wcml2KTsKPj4gICAgICAgICAgIGlmICghZXJy KQo+PiBAQCAtNTMyLDE1ICs1MzIsMTUgQEAgaW50IGludGVsX2d1Y19zZXR1cChzdHJ1Y3QgZHJt X2RldmljZSAqZGV2KQo+PiAgICAgICBlbHNlIGlmIChlcnIgPT0gMCkKPj4gICAgICAgICAgIERS TV9JTkZPKCJHdUMgZmlybXdhcmUgbG9hZCBza2lwcGVkXG4iKTsKPj4gICAgICAgZWxzZSBpZiAo cmV0ICE9IC1FSU8pCj4+IC0gICAgICAgIERSTV9JTkZPKCJHdUMgZmlybXdhcmUgbG9hZCBmYWls ZWQ6ICVkXG4iLCBlcnIpOwo+PiArICAgICAgICBEUk1fTk9URSgiR3VDIGZpcm13YXJlIGxvYWQg ZmFpbGVkOiAlZFxuIiwgZXJyKTsKPj4gICAgICAgZWxzZQo+PiAtICAgICAgICBEUk1fRVJST1Io Ikd1QyBmaXJtd2FyZSBsb2FkIGZhaWxlZDogJWRcbiIsIGVycik7Cj4+ICsgICAgICAgIERSTV9X QVJOKCJHdUMgZmlybXdhcmUgbG9hZCBmYWlsZWQ6ICVkXG4iLCBlcnIpOwo+Pgo+PiAgICAgICBp ZiAoaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24pIHsKPj4gICAgICAgICAgIGlmIChmd19wYXRo ID09IE5VTEwpCj4+ICAgICAgICAgICAgICAgRFJNX0lORk8oIkd1QyBzdWJtaXNzaW9uIHdpdGhv dXQgZmlybXdhcmUgbm90Cj4+IHN1cHBvcnRlZFxuIik7Cj4+ICAgICAgICAgICBpZiAocmV0ID09 IDApCj4+IC0gICAgICAgICAgICBEUk1fSU5GTygiRmFsbGluZyBiYWNrIGZyb20gR3VDIHN1Ym1p c3Npb24gdG8gZXhlY2xpc3QKPj4gbW9kZVxuIik7Cj4+ICsgICAgICAgICAgICBEUk1fTk9URSgi RmFsbGluZyBiYWNrIGZyb20gR3VDIHN1Ym1pc3Npb24gdG8gZXhlY2xpc3QKPj4gbW9kZVxuIik7 Cj4+ICAgICAgICAgICBlbHNlCj4+ICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJHdUMgaW5pdCBm YWlsZWQ6ICVkXG4iLCByZXQpOwo+PiAgICAgICB9Cj4+IEBAIC02NTYsNyArNjU2LDcgQEAgc3Rh dGljIHZvaWQgZ3VjX2Z3X2ZldGNoKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+IHN0cnVjdCBp bnRlbF9ndWNfZncgKmd1Y19mdykKPj4gICBmYWlsOgo+PiAgICAgICBEUk1fREVCVUdfRFJJVkVS KCJHdUMgZncgZmV0Y2ggc3RhdHVzIEZBSUw7IGVyciAlZCwgZncgJXAsIG9iago+PiAlcFxuIiwK Pj4gICAgICAgICAgIGVyciwgZncsIGd1Y19mdy0+Z3VjX2Z3X29iaik7Cj4+IC0gICAgRFJNX0VS Uk9SKCJGYWlsZWQgdG8gZmV0Y2ggR3VDIGZpcm13YXJlIGZyb20gJXMgKGVycm9yICVkKVxuIiwK Pj4gKyAgICBEUk1fV0FSTigiRmFpbGVkIHRvIGZldGNoIEd1QyBmaXJtd2FyZSBmcm9tICVzIChl cnJvciAlZClcbiIsCj4+ICAgICAgICAgICAgIGd1Y19mdy0+Z3VjX2Z3X3BhdGgsIGVycik7Cj4+ Cj4+ICAgICAgIG11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPj4KPgo+IFItYiBpZiB5 b3UgYWxzbyBjaGFuZ2UgYWxsIHRoZSBvdGhlciBEUk1fRVJST1JzIGluIGd1Y19md19mZXRjaCB0 bwo+IERSTV9ERUJVR19EUklWRVIgYW5kIG1lcmdlIHRoaXMgbGFzdCB0d28gbG9nIGxpbmVzIChE Uk1fREVCVUdfRFJJVkVSICsKPiBEUk1fV0FSTikgdG8gb25lLiA6KQo+Cj4gUmVnYXJkcywKPiBU dnJ0a28KCk5vLCB0aGF0IHdvdWxkbid0IGJlIGFwcHJvcHJpYXRlLiBXZSB3YW50IHRoZSB1c2Vy IHRvIGJlIGluZm9ybWVkIGlmIGFueSAKb2YgdGhlc2UgZmFpbHVyZXMgb2NjdXJzLCBiZWNhdXNl IGl0IG1lYW5zIHRoZWlyIHN5c3RlbSBpcyBpbiBzb21lIHdheSAKbWlzY29uZmlndXJlZCBlLmcu IGNvcnJ1cHRlZCBmaXJtd2FyZSBmaWxlLiBUaGF0J3MgZGVmaW5pdGVseSBub3QgYSAKREVCVUct b25seSBldmVudCwgYW5kIGl0IG11c3QgYmUgbG9nZ2VkIGV2ZW4gaWYgd2UncmUgZ29pbmcgdG8g dHJ5IHRvIApjb250aW51ZSBpbiBmYWxsYmFjayBtb2RlLgoKSSBjb3VsZCBjaGFuZ2UgYWxsIHRo ZSBlYXJsaWVyIEVSUk9ScyB0byBOT1RFcyBhbmQgbGVhdmUganVzdCB0aGUgbGFzdCAKb25lIGFz IGFuIEVSUk9SIGkuZS4gZXhwbGFuYXRpb24gZmlyc3QsIGNvbnNlcXVlbmNlIGFmdGVyLgoKQXMg Zm9yIHRoZSBERUJVRywgdGhhdCdzIGZvciBhIGRpZmZlcmVudCBwdXJwb3NlLiBXaGVyZWFzIHRo ZSB2YXJpb3VzIApFUlJPUi9OT1RFL0lORk8gbWVzc2FnZXMgcmVsYXRlIHRvIHRoZSBleGlzdGVu Y2UsIGZvcm1hdCwgb3IgY29udGVudCBvZiAKdGhlIHJlcXVpcmVkIGZpcm13YXJlIGZpbGUgaW4g dGhlIGZpbGVzeXN0ZW0gb3IgcmFtZGlzaywgdGhlIERFQlVHIGlzIAphYm91dCBpbnRlcm5hbCBm YWlsdXJlcyBzdWNoIGFzIG5vdCBiZWluZyBhYmxlIHRvIGFsbG9jYXRlIG1lbW9yeSwgb3ZlciAK d2hpY2ggdGhlIHVzZXIvYWRtaW5pc3RyYXRvciBoYXMgbm8gZGlyZWN0IGNvbnRyb2wuCgpJIG1p Z2h0IHN3YXAgdGhlbSByb3VuZCB0aG91Z2ggKGkuZS4gREVCVUcgYWZ0ZXIgdGhlIEVSUk9SLCB0 byBleHBsYWluIApmdXJ0aGVyIHRoYW4gSSB3YW50IHRvIGluIGEgdXNlci1mYWNpbmcgbWVzc2Fn ZSkuCgouRGF2ZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==