From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 3/6] drm/i915/huc: Add HuC fw loading support Date: Thu, 14 Jul 2016 15:08:41 +0100 Message-ID: <57879CE9.6010401@intel.com> References: <1466532685-5101-1-git-send-email-peter.antoine@intel.com> <1466532685-5101-4-git-send-email-peter.antoine@intel.com> <20160622083148.GO23520@phenom.ffwll.local> <576BB679.5090807@intel.com> <20160713124810.GO23520@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D4C16E8B1 for ; Thu, 14 Jul 2016 14:09:02 +0000 (UTC) In-Reply-To: <20160713124810.GO23520@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Peter Antoine Cc: sean.v.kelley@intel.com, intel-gfx@lists.freedesktop.org, lawrence.t.li@intel.com, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gMTMvMDcvMTYgMTM6NDgsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gT24gVGh1LCBKdW4gMjMs IDIwMTYgYXQgMDI6NTI6NDFQTSArMDEwMCwgUGV0ZXIgQW50b2luZSB3cm90ZToKPj4gT24gVGh1 LCAyMyBKdW4gMjAxNiwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4+PiBPbiAyMi8wNi8xNiAwOTozMSwg RGFuaWVsIFZldHRlciB3cm90ZToKPj4+IE5vLCB0aGUgKmNvcnJlY3QqIGZpeCBpcyB0byB1bmlm eSBhbGwgdGhlIGZpcm13YXJlIGxvYWRlcnMgd2UgaGF2ZS4KPj4+IFRoZXJlIHNob3VsZCBqdXN0 IGJlIE9ORSBwaWVjZSBvZiBjb2RlIHRoYXQgY2FuIGJlIHVzZWQgdG8gZmV0Y2ggYW5kCj4+PiBs b2FkIEFOeSBmaXJtd2FyZSBpbnRvIEFOWSBhdXhpbGlhcnkgbWljcm9jb250cm9sbGVyLiBOT1Qg b25lIHBlcgo+Pj4gbWljcm9jb250cm9sbGVyLCBhbGwgZGlmZmVyZW50IC0tIHRoYXQgd2F5IGxp ZXMgbWFkbmVzcy4KPj4+Cj4+PiBXZSBhbHJlYWR5IGhhZCBhIHVuaWZpZWQgbG9hZGVyIGZvciB0 aGUgSHVDIGFuZCBHdUMgYSB5ZWFyIGFnbywgYnV0IElJUkMKPj4+IHRoZSBwYXJ0eSBsaW5lIHRo ZW4gd2FzICJqdXN0IG1ha2UgaXQgKEd1Qykgc3BlY2lmaWMsIHRoZW4gY29weXBhc3RlIGl0Cj4+ PiBmb3IgdGhlIHNlY29uZCB1QywgYW5kIHdoZW4gd2UndmUgZ290IHRocmVlIHZlcnNpb25zIHdl J2xsIGhhdmUgbGVhcm50Cj4+PiBob3cgd2UgcmVhbGx5IHdhbnQgYSB1bmlmaWVkIGxvYWRlciB0 byBiZWhhdmUuIgo+Pj4KPj4+IFdlbGwuIGhlcmUncyB0aGUgY29weXBhc3RlLCBhbmQgd2UgYWxy ZWFkeSBoYXZlIGEgZGlmZmVyZW50IGxvYWRlciBmb3IKPj4+IHRoZSBETUMvQ1NSLCBzbyBpdCBt dXN0IGJlIHRpbWUgZm9yIChyZS0pdW5pZmljYXRpb24uCj4+Pgo+Pj4gLkRhdmUuCj4+Cj4+IEp1 c3QgdG8gYWRkLCBpZiB5b3UgdWNfZndfZmV0Y2goKSBoYXMgYW4gZXJyb3IgY29kZSB5b3Ugd2ls bCBzdGlsbCBoYXZlIHRvCj4+IHJlbWVtYmVyIHRoZSBzdGF0ZSBvZiB0aGUgZmV0Y2ggb3IgYXQg ZWFjaCByZXNldC9yZXN1bWUvZXRjLi4uIG9yIHlvdSB3aWxsCj4+IGhhdmUgdG8gdHJ5IHRoZSBm aXJtd2FyZSBsb2FkIGFnYWluIGFuZCB0aGF0IGNhbiB0YWtlIGEgbG9uZyB0aW1lLiBTbyB0aGUK Pj4gc3RhdGUgd2lsbCBoYXZlIHRvIGJlIHJlLWluc3RhdGVkLgo+Pgo+PiBTZWVpbmcgdGhpcyBj b2RlIHdhcyB3cml0dGVuIHdpdGggdGhlIGdpdmVuIGdvYWxzIGFuZCB3ZXJlIHdyaXR0ZW4gaW4g dGhlCj4+IHNhbWUgdmFuZSBhcyBjb2RlIHRoYXQgd2FzIGRlZW1lZCBhY2NlcHRhYmxlLCBpdCBz ZWVtcyB3ZWlyZCBhdCB0aGlzIGxhdGUKPj4gc3RhZ2UgdG8gY2hhbmdlIHRoZSBkZXNpZ24gZ29h bHMuCj4+Cj4+IE5vdGU6IHRoaXMgaXMgdGhlIHRoaXJkIHRpbWUgdGhhdCB0aGVzZSBwYXRjaGVz IGhhdmUgYmVlbiBwb3N0ZWQgYW5kIHdlcmUKPj4gb25seSByZWplY3RlZCAoYXMgZmFyIGFzIEkg a25vdykgZHVlIHRvIG5vIG9wZW4tc291cmNlIHVzZXIuIFdoaWNoIHRoZXJlIGlzCj4+IG5vdywg YW5kIGlzIHdoeSBJIGhhdmUgcmVwb3N0ZWQgdGhlc2UgcGF0Y2hlcy4KPgo+IEkgbmV2ZXIgbGlr ZWQgdGhlIGd1YyBmaXJtd2FyZSBjb2RlLCBidXQgZmlndXJlIGZvciBvbmUgY29weSBpdCdzIG5v dAo+IHdvcnRoIGZpZ2h0aW5nIG92ZXIuIEFkZGluZyBtb3JlIGNvcGllcyAob3IgcGVycGV0dWF0 aW5nIHRoZSBkZXNpZ24gYnkKPiBtYWtpbmcgaXQgZ2VuZXJpYykgaXNuJ3Qgd2hhdCBJJ20gbG9v a2luZyBmb3IuCgoqWW91KiBhc2tlZCBmb3IgbW9yZSBjb3BpZXMsIGJhY2sgd2hlbiB3ZSBwcm9w b3NlZCBhIHNpbmdsZSB1bmlmaWVkIApzb2x1dGlvbiBsYXN0IHllYXIuIFdlIGFscmVhZHkgaGFk IGEgKnNpbmdsZSogR3VDK0h1QyBsb2FkZXIgd2hpY2ggY291bGQgCmFsc28gaGF2ZSBiZWVuIGV4 dGVuZGVkIHRvIHN1cHBvcnQgdGhlIERNQyBhcyB3ZWxsLCBidXQgYXQgdGhlIHRpbWUgeW91IAp3 YW50ZWQgYSBHdUMtc3BlY2lmaWMgdmVyc2lvbiAtLSBhbmQgYnkgaW1wbGljYXRpb24sIGEgc2Vw YXJhdGUgSHVDIApsb2FkZXIgLS0gKmluIGFkZGl0aW9uIHRvKiB0aGUgRE1DIGxvYWRlci4KCiA+ IEZpcm13YXJlIGxvYWRpbmcgc2hvdWxkbid0IGJlIHRoYXQgY29tcGxpY2F0ZWQsIHJlYWxseS4K Ck1heWJlIGl0IHNob3VsZG4ndCBiZSwgYW5kIG1heWJlIGl0IGlzbid0IC0tIHlvdSBtYXkgbm90 IGJlIHNlZWluZyBob3cgCnNpbXBsZSB0aGlzIGNvZGUgYWN0dWFsbHkgaXMuIEZldGNoIGZpcm13 YXJlLCB2YWxpZGF0ZSBpdCwgc2F2ZSBpdCBpbiBhIApHRU0gb2JqZWN0OyBsYXRlciwgRE1BIGl0 IHRvIHRoZSBoL3c7IGF0IGVhY2ggc3RhZ2Uga2VlcCB0cmFjayBvZiBzdGF0dXMgCnNvIHdlIGtu b3cgd2hhdCBoYXMgYmVlbiBkb25lIGFuZCB3aGF0IGlzIHN0aWxsIHRvIGRvIChvciByZWRvLCBk dXJpbmcgCnJlc2V0KS4KCkFueSBjb21wbGljYXRpb25zIGFyZSBiZWNhdXNlIHRoZSBoL3cgKGUu Zy4gd3JpdGUtb25jZSBtZW1vcnkpIG1ha2VzIAp0aGVtIG5lY2Vzc2FyeSwgb3IgYXJ0ZWZhY3Rz IG9mIHRoZSBHRU0gb2JqZWN0IHN5c3RlbSwgb3IgYmVjYXVzZSBvZiB0aGUgCmRyaXZlcidzIGJ5 emFudGluZSBzZXF1ZW5jZSBvZiBvcGVyYXRpb25zIGR1cmluZyAKbG9hZC9yZXNldC9zdXNwZW5k L3Jlc3VtZS91bmxvYWQuCgo+IFRoZSB1bmlmaWVkIGZpcm13YXJlIGxvYWRlciBpcyBjYWxsZWQg cmVxdWVzdF9maXJtd2FyZS4gSWYgdGhhdCdzIG5vdCBnb29kCj4gZW5vdWdoLCBwbHMgZml4IHRo ZSBjb3JlIGZ1bmN0aW9uLCBub3QgcGFwZXIgY29kZSBvdmVyIGluIGk5MTUuCgpUaGF0J3MgZXhh Y3RseSB0aGUgZnVuY3Rpb24gd2UgY2FsbC4gVGhlbiB3ZSBoYXZlIHRvIHZhbGlkYXRlIGFuZCBz YXZlIAp0aGUgYmxvYi4gQW5kIHJlbWVtYmVyIHRoYXQgd2UndmUgZG9uZSBzby4KCj4gSW4gdGhh dCByZWdhcmQgRE1DL0NTUiBpcyB1bmlmaWVkLCBldmVyeXRoaW5nIGVsc2UgaXNuJ3QgeWV0LgoK VW5pZmllZCB3aXRoIHdoYXQ/IE1heWJlIHRoZSAiRE1DIiBpcyB1bmlmaWVkIHdpdGggdGhlICJD U1IiIC0tIHdoaWNoIApBRkFJSyBhcmUgdGhlIHNhbWUgdGhpbmcgLS0gYW5kIHRoZSBzb2Z0d2Fy ZSBqdXN0IHJhbmRvbWx5IHVzZXMgYm90aCAKbmFtZXMgdG8gbWF4aW1pc2UgY29uZnVzaW9uPwoK CWlmIChIQVNfQ1NSKGRldikpIHsKCQlzdHJ1Y3QgaW50ZWxfY3NyICpjc3IgPSAmZGV2X3ByaXYt PmNzcjsKCgkJZXJyX3ByaW50ZihtLCAiRE1DIGxvYWRlZDogJXNcbiIsCgkJCSAgIHllc25vKGNz ci0+ZG1jX3BheWxvYWQgIT0gTlVMTCkpOwoJCWVycl9wcmludGYobSwgIkRNQyBmdyB2ZXJzaW9u OiAlZC4lZFxuIiwKCQkJICAgQ1NSX1ZFUlNJT05fTUFKT1IoY3NyLT52ZXJzaW9uKSwKCQkJICAg Q1NSX1ZFUlNJT05fTUlOT1IoY3NyLT52ZXJzaW9uKSk7Cgl9Ci4uLgoJaWYgKCFJU19HRU45KGRl dl9wcml2KSkgewoJCURSTV9FUlJPUigiTm8gQ1NSIHN1cHBvcnQgYXZhaWxhYmxlIGZvciB0aGlz IHBsYXRmb3JtXG4iKTsKCQlyZXR1cm47Cgl9CglpZiAoIWRldl9wcml2LT5jc3IuZG1jX3BheWxv YWQpIHsKCQlEUk1fRVJST1IoIlRyaWVkIHRvIHByb2dyYW0gQ1NSIHdpdGggZW1wdHkgcGF5bG9h ZFxuIik7CgkJcmV0dXJuOwoJfQoKQW5kIGFjY29yZGluZyB0byB0aGUgY29tbWVudHMgaW4gaW50 ZWxfY3NyLmMgLS0gYnV0IG5vdCB0aGUgY29kZSAtLQoKLyoKICAqIEZpcm13YXJlIGxvYWRpbmcg c3RhdHVzIHdpbGwgYmUgb25lIG9mIHRoZSBiZWxvdyBzdGF0ZXM6CiAgKiBGV19VTklOSVRJQUxJ WkVELCBGV19MT0FERUQsIEZXX0ZBSUxFRC4KICAqCiAgKiBPbmNlIHRoZSBmaXJtd2FyZSBpcyB3 cml0dGVuIGludG8gdGhlIHJlZ2lzdGVycyBzdGF0dXMgd2lsbAogICogYmUgbW92ZWQgZnJvbSBG V19VTklOSVRJQUxJWkVEIHRvIEZXX0xPQURFRCBhbmQgZm9yIGFueQogICogZXJyb25lb3VzIGNv bmRpdGlvbiBzdGF0dXMgd2lsbCBiZSBtb3ZlZCB0byBGV19GQUlMRUQuCiAgKi8KClNvIEkgZG9u J3QgdGhpbmsgeW91IHNob3VsZCBob2xkIHRoaXMgY29kZSB1cCBhcyBhIG1hc3RlcnBpZWNlIG9m IAoidW5pZmllZCIgZGVzaWduIC0tIHdoaWNoIGluIGFueSBjYXNlIHlvdSBhcmd1ZWQgYWdhaW5z dCBsYXN0IHllYXIsIHdoZW4gCndlIHByZXNlbnRlZCBhIHVuaWZpZWQgbG9hZGVyLiBTcGVjaWZp Y2FsbHksIHlvdSBzYWlkLCAiSW4gbXkgZXhwZXJpZW5jZSAKdHJ5aW5nIHRvIGV4dHJhY3QgY29t bW9uIGNvZGUgYXQgYWxsIGNvc3RzIGlzIGhhcm1mdWwgd2F5IHRvbyBvZnRlbi4iCgpBbHNvLCB0 aGUgYXBwcm9hY2ggdGFrZW4gaW4gdGhlIERNQyBsb2FkZXIgLS0gd2hpY2ggYXBwZWFycyB0byBo YXZlIGJlZW4gCmNvcHlwYXN0ZWQgZnJvbSBhIC92ZXJ5IGVhcmx5LyB2ZXJzaW9uIG9mIHRoZSBH dUMgbG9hZGVyLCBiZWZvcmUgSSBmaXhlZCAKdGhlIGFzeW5jLWxvYWQgcHJvYmxlbXMgLS0ganVz dCB3b3VsZG4ndCB3b3JrIGZvciB0aGUgSHVDL0d1Qywgd2hlcmUgdGhlIAprZXJuZWwgbmVlZHMg dG8ga25vdyB3aGVuIHRoZSBmaXJtd2FyZSBsb2FkIGhhcyBiZWVuIGNvbXBsZXRlZCBzbyB0aGF0 IAppdCBjYW4gc3RhcnQgc2VuZGluZyB3b3JrIHRvIHRoZSBHdUMuIFRoZSBETUMgbG9hZGVyIG9u bHkgd29ya3MgYmVjYXVzZSAKaXQgZG9lc24ndCBhY3R1YWxseSBtYXR0ZXIgd2hlbiAob3IgaWYp IGl0J3MgbG9hZGVkLiBJdCB3b3VsZCBiZSAKKmNvbXBsZXRlbHkgd3JvbmcqIHRvIGxvYWQgdGhl IEh1Qy9HdWMgdGhhdCB3YXkuCgo+IElpcmMgdGhlIGJpZyBpc3N1ZSBpcyBkZWxheWVkIGZpcm13 YXJlIGxvYWRpbmcgZm9yIGJ1aWx0LWluIGk5MTUgYW5kIGZ3Cj4gb25seSBhdmFpbGFibGUgbGF0 ZXIgb24uIFRoaXMgaXMgYW4gb3BlbiBpc3N1ZSBpbiByZXF1ZXN0X2Zpcm13YXJlKCkgc2luY2UK PiB5ZWFycywgYW5kIHRoZXJlJ3MgdmFyaW91cyBwYXRjaGVzIGZsb2F0aW5nIGFyb3VuZC4gSWYg dGhlIHByb2JsZW0gaXMgdGhhdAo+IEdyZWcgS0ggZG9lc24ndCBjb25zaWRlciB0aG9zZSBwYXRj aGVzLCBJIGNhbiBoZWxwIHdpdGggdGhhdC4gQnV0IG5vdAo+IHB1c2hpbmcgdGhlIGNvcmUgZml4 IGZvcndhcmQgaXNuJ3QgYWNjZXB0YWJsZSBpbW8uCgpXZSdyZSBub3QgYWRkcmVzc2luZyB0aGF0 IGlzc3VlIGF0IGFsbCBoZXJlLCBmb3IgTGludXggd2UgZXhwZWN0IHRoZSAKZmlybXdhcmUgd2ls bCBiZSBpbiB0aGUgcmFtZGlzayBzbyBpdCdzIGF2YWlsYWJsZSBpbW1lZGlhdGVseS4gQW5kcm9p ZCAKaGFzIGFuIGlzc3VlIHdpdGggdGhhdCwgYnV0IHdlIGFscmVhZHkgaGF2ZSBzb2x1dGlvbnMg dGhlcmUuCgo+IE9uY2UgdGhhdCBmaXggaXMgbGFuZGVkCj4gd2UgY2FuIHRyZWF0IHJlcXVlc3Rf ZmlybXdhcmUgYXMgcmVsaWFibGUgKGl0IG1pZ2h0IHRha2UgYSB3aGlsZSwgaGVuY2UKPiBtdXN0 IGJlIHJ1biBpbiBhbiBhc3luYyB3b3JrIGxpa2UgRE1DIGxvYWRpbmcpLCB3aXRoIG5vIG5lZWQg dG8gZXZlciByZXRyeQo+IGFueXRoaW5nLgoKTm8sIGl0ICpjYW4ndCogcnVuICJpbiBhbiBhc3lu YyB3b3JrIGxpa2UgRE1DIGxvYWRpbmciIC0tIHRoYXQgd2FzIApleGFjdGx5IHdoYXQgd2FzIHdy b25nIHdpdGggdGhlIG9yaWdpbmFsIEd1QyBsb2FkZXIgYmVmb3JlIEkgZ290IAppbnZvbHZlZC4g VGhlIGZpcm13YXJlIHdhcyBkZWxpdmVyZWQgdG8gdGhlIEd1QyBoL3cgYXN5bmNocm9ub3VzbHks IAoqYWZ0ZXIqIHRoZSBrZXJuZWwgaGFkIGFscmVhZHkgc3RhcnRlZCBzZW5kaW5nIHdvcmsgdG8g dGhlIGVuZ2luZXMuIFRoYXQgCndhcyB1dHRlcmx5IGJvZ3VzIQoKKlRoaXMqIHZlcnNpb24gaXMg ZnVsbHkgc3luY2hyb25vdXM7IHRoZSBrZXJuZWwgY2FsbHMgZm9yIHRoZSBmaXJtd2FyZSAKdXNp bmcgcmVxdWVzdF9maXJtd2FyZSgpIChhbmQgd2FpdHMgdW50aWwgaXQncyBzdWNjZWVkZWQgb3Ig ZmFpbGVkKSwgYW5kIApsYXRlciBhc2tzIGZvciB0aGUgZmlybXdhcmUgdG8gYmUgbG9hZGVkIGlu dG8gdGhlIEd1QyAoYWdhaW4sIHdhaXRpbmcgCnVudGlsIGl0IGhhcyBzdWNjZWVkZWQgb3IgZmFp bGVkKS4KCj4gSWYgZncgbG9hZGluZyBmYWlscyB3ZSBjYW4ganVzdCBtYXJrIHRoZSBlbnRpcmUg cmVuZGVyIHBhcnQgb2YKPiB0aGUgZ3B1IGFzIGRlYWQgYnkgaW5qZWN0aW5nIHRoZSBlcXVpdmFs ZW50IG9mIGEgbm9uLXJlY292ZXJhYmxlIGhhbmcKPiAoYXN5bmMgc2V0dXApIG9yIGZhaWxpbmcg ZW5naW5lIGluaXQgd2l0aCAtRUlPIChpZiB0aGlzIGlzIHN0aWxsCj4gc3luY2hyb25vdXMsIHdo aWNoIEkgZG9uJ3QgZXhwZWN0IHJlYWxseSkuCgpXaGljaCBpcyBqdXN0IHdoYXQgd2UgZG8uIFRo aXMgcGF0Y2hzZXQgaXMgZXNzZW50aWFsbHkganVzdCBhZGRpbmcgSHVDIApsb2FkaW5nIHRvIHRo ZSBleGlzdGluZyBHdUMgbG9hZGluZyBwcm9jZXNzLCByZXVzaW5nIGFzIG11Y2ggYXMgcG9zc2li bGUgCm9mIHRoZSBzYW1lIGNvZGUuCgo+IElmIHRoZXJlJ3MgYW5vdGhlciByZWFzb24gZm9yIHRo aXMgY29tcGxleGl0eSwgcGxlYXNlIGV4cGxhaW4gc2luY2UgSSdkCj4gbGlrZSB0byB1bmRlcnN0 YW5kIHdoeSB3ZSBuZWVkIHRoaXMuCj4gLURhbmllbAoKTGVzcyBjb21wbGV4aXR5IHRoYW4geW91 IHRoaW5rLgoKICAgNTMxICAxNjk4IDE0MjU1IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nz ci5jCiAgIDc1MSAgMjc1NyAyMjg4OSBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9h ZGVyLmMKCk11Y2ggdGhlIHNhbWUgc2l6ZSwgdG8gd2l0aGluIGEgKGJpbmFyeSkgb3JkZXItb2Yt bWFnbml0dWRlLiBPYnZpb3VzbHkgCnRoZSBHdUMgY29kZSAqbmVjZXNzYXJpbHkqIGRvZXMgbW9y ZSBiZWNhdXNlIHRoZSBmL3cgaW50ZXJmYWNlcyBhcmUgbXVjaCAKbW9yZSBjb21wbGV4IChjdHgg cG9vbCwgQURTLCBldGMpOyBidXQgdGhvc2UgYXJlIG5vdCBvcHRpb25hbC4gQW5kIHRoZSAKR3VD IGNvZGUgaGFzIHRvIGRlYWwgd2l0aCByZWxvYWRpbmcgYWZ0ZXIgUkM2IG9yIEdQVSByZXNldCwg d2hpY2ggQUZBSUNUIAp0aGUgRE1DIGRvZXNuJ3QuCgouRGF2ZS4KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==