Re: [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

Dave Gordon
2016-07-05T14:41:50Z

On 29/06/16 18:59, Rodrigo Vivi wrote:
>> On Wed, Jun 29, 2016 at 7:31 AM, Dave Gordon <david.s.gordon@intel.com> wrote:
>>> On 29/06/16 00:03, Rodrigo Vivi wrote:
>>>>
>>>> I don't believe we need to be that extreme here.
>>>>
>>>> Daniel asked a cleaner version, but we don't need to block the huc on
>>>> a full rework of an unified fw loader.
>>>
>>>
>>> Oh, I agree, we should take this "mostly" as-is and then reunify them after.
>>>
>>> .Dave.
>
> But the merge on hug/guc loading is just the minor thing Daniel asked.
>
> The major request is to stop using the fetch_status, but errnos
> instead.

That's not going to happen. It's written as a state machine for good
reason, because the various elements (fetch/load/reload) get called at
different (and rather arbitrary) points in the driver load sequence, and
they need to maintain state from one stage to another, not rely on the
caller(s) to interpret errnos to determine what the next callback should be.

Unless you (or Daniel) just mean change the details of the encoding i.e.
how that state is represented? We could do that, but I don't think it
would be useful to reuse unrelated errnos rather than have our own
precise and specific enumeration of the state of the loading process.

.Dave.

> so, maybe one extra patch that simplifies this right now
> before this series would be the ideal so we could speed up the merge
> and maybe later to the unified firmware loading solution.