From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 09/17] drm/i915: Debugfs support for GuC logging control Date: Tue, 19 Jul 2016 12:24:52 +0100 Message-ID: <578E0E04.9070306@linux.intel.com> References: <1468158084-22028-1-git-send-email-akash.goel@intel.com> <1468158084-22028-10-git-send-email-akash.goel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A52F6E675 for ; Tue, 19 Jul 2016 11:24:54 +0000 (UTC) In-Reply-To: <1468158084-22028-10-git-send-email-akash.goel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: akash.goel@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEwLzA3LzE2IDE0OjQxLCBha2FzaC5nb2VsQGludGVsLmNvbSB3cm90ZToKPiBGcm9tOiBT YWdhciBBcnVuIEthbWJsZSA8c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPgo+Cj4gVGhpcyBwYXRj aCBwcm92aWRlcyBkZWJ1Z2ZzIGludGVyZmFjZSBpOTE1X2d1Y19vdXRwdXRfY29udHJvbCBmb3IK PiBvbiB0aGUgZmx5IGVuYWJsaW5nL2Rpc2FibGluZyBvZiBsb2dnaW5nIGluIEd1QyBmaXJtd2Fy ZSBhbmQgY29udHJvbGxpbmcKPiB0aGUgdmVyYm9zaXR5IGxldmVsIG9mIGxvZ3MuCj4gVGhlIHZh bHVlIHdyaXR0ZW4gdG8gdGhlIGZpbGUsIHNob3VsZCBoYXZlIGJpdCAwIHNldCB0byBlbmFibGUg bG9nZ2luZyBhbmQKPiBiaXRzIDQtNyBzaG91bGQgY29udGFpbiB0aGUgdmVyYm9zaXR5IGluZm8u Cj4KPiB2MjogQWRkIGEgZm9yY2VmdWwgZmx1c2gsIHRvIGNvbGxlY3QgbGVmdCBvdmVyIGxvZ3Ms IG9uIGRpc2FibGluZyBsb2dnaW5nLgo+ICAgICAgVXNlZnVsIGZvciBWYWxpZGF0aW9uLgo+Cj4g U2lnbmVkLW9mZi1ieTogU2FnYXIgQXJ1biBLYW1ibGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNv bT4KPiBTaWduZWQtb2ZmLWJ5OiBBa2FzaCBHb2VsIDxha2FzaC5nb2VsQGludGVsLmNvbT4KPiAt LS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jICAgICAgICB8IDMyICsr KysrKysrKysrKysrKystCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNz aW9uLmMgfCA1NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2d1Yy5oICAgICAgICAgICB8ICAxICsKPiAgIDMgZmlsZXMgY2hhbmdl ZCwgODkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kZWJ1Z2ZzLmMKPiBpbmRleCA1ZTM1NTY1Li4zYzljN2Y3IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBAQCAtMjY0NCw2ICsyNjQ0LDM1IEBAIHN0YXRpYyBpbnQgaTkx NV9ndWNfbG9nX2R1bXAoc3RydWN0IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+ICAgCXJldHVy biAwOwo+ICAgfQo+Cj4gK3N0YXRpYyBpbnQKPiAraTkxNV9ndWNfbG9nX2NvbnRyb2xfc2V0KHZv aWQgKmRhdGEsIHU2NCB2YWwpCj4gK3sKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkYXRh Owo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0 ZTsKCnRvX2k5MTUgc2hvdWxkIGJlIHVzZWQuCgo+ICsJaW50IHJldDsKPiArCj4gKwlyZXQgPSBt dXRleF9sb2NrX2ludGVycnVwdGlibGUoJmRldi0+c3RydWN0X211dGV4KTsKPiArCWlmIChyZXQp Cj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwlpZiAoIWk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9u IHx8ICFkZXZfcHJpdi0+Z3VjLmxvZy5vYmopIHsKCldvdWxkbid0IGd1Yy5sb2cub2JqIGJlIGVu b3VnaD8KCj4gKwkJcmV0ID0gLUVJTlZBTDsKPiArCQlnb3RvIGVuZDsKPiArCX0KPiArCj4gKwlp bnRlbF9ydW50aW1lX3BtX2dldChkZXZfcHJpdik7Cj4gKwlyZXQgPSBpOTE1X2d1Y19sb2dfY29u dHJvbChkZXYsIHZhbCk7Cj4gKwlpbnRlbF9ydW50aW1lX3BtX3B1dChkZXZfcHJpdik7Cj4gKwo+ ICtlbmQ6Cj4gKwltdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiArCXJldHVybiBy ZXQ7Cj4gK30KPiArCj4gK0RFRklORV9TSU1QTEVfQVRUUklCVVRFKGk5MTVfZ3VjX2xvZ19jb250 cm9sX2ZvcHMsCj4gKwkJCU5VTEwsIGk5MTVfZ3VjX2xvZ19jb250cm9sX3NldCwKPiArCQkJIjB4 JTA4bGx4XG4iKTsKCkRvZXMgdGhlIHJlYWRiYWNrIHN0aWxsIHdvcmsgd2l0aCBubyBnZXQgbWV0 aG9kPwoKPiArCj4gICBzdGF0aWMgaW50IGk5MTVfZWRwX3Bzcl9zdGF0dXMoc3RydWN0IHNlcV9m aWxlICptLCB2b2lkICpkYXRhKQo+ICAgewo+ICAgCXN0cnVjdCBkcm1faW5mb19ub2RlICpub2Rl ID0gbS0+cHJpdmF0ZTsKPiBAQCAtNTQ2NCw3ICs1NDkzLDggQEAgc3RhdGljIGNvbnN0IHN0cnVj dCBpOTE1X2RlYnVnZnNfZmlsZXMgewo+ICAgCXsiaTkxNV9mYmNfZmFsc2VfY29sb3IiLCAmaTkx NV9mYmNfZmNfZm9wc30sCj4gICAJeyJpOTE1X2RwX3Rlc3RfZGF0YSIsICZpOTE1X2Rpc3BsYXlw b3J0X3Rlc3RfZGF0YV9mb3BzfSwKPiAgIAl7Imk5MTVfZHBfdGVzdF90eXBlIiwgJmk5MTVfZGlz cGxheXBvcnRfdGVzdF90eXBlX2ZvcHN9LAo+IC0JeyJpOTE1X2RwX3Rlc3RfYWN0aXZlIiwgJmk5 MTVfZGlzcGxheXBvcnRfdGVzdF9hY3RpdmVfZm9wc30KPiArCXsiaTkxNV9kcF90ZXN0X2FjdGl2 ZSIsICZpOTE1X2Rpc3BsYXlwb3J0X3Rlc3RfYWN0aXZlX2ZvcHN9LAo+ICsJeyJpOTE1X2d1Y19s b2dfY29udHJvbCIsICZpOTE1X2d1Y19sb2dfY29udHJvbF9mb3BzfQo+ICAgfTsKPgo+ICAgdm9p ZCBpbnRlbF9kaXNwbGF5X2NyY19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IGluZGV4IDhjYzMxYzYuLjJl M2I3MjMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlz c2lvbi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5j Cj4gQEAgLTE5Myw2ICsxOTMsMTYgQEAgc3RhdGljIGludCBob3N0Mmd1Y19mb3JjZV9sb2didWZm ZXJfZmx1c2goc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ICAgCXJldHVybiBob3N0Mmd1Y19hY3Rp b24oZ3VjLCBkYXRhLCAyKTsKPiAgIH0KPgo+ICtzdGF0aWMgaW50IGhvc3QyZ3VjX2xvZ2dpbmdf Y29udHJvbChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIHUzMiBjb250cm9sX3ZhbCkKPiArewo+ICsJ dTMyIGRhdGFbMl07Cj4gKwo+ICsJZGF0YVswXSA9IEhPU1QyR1VDX0FDVElPTl9VS19MT0dfRU5B QkxFX0xPR0dJTkc7Cj4gKwlkYXRhWzFdID0gY29udHJvbF92YWw7Cj4gKwo+ICsJcmV0dXJuIGhv c3QyZ3VjX2FjdGlvbihndWMsIGRhdGEsIDIpOwo+ICt9Cj4gKwo+ICAgLyoKPiAgICAqIEluaXRp YWxpc2UsIHVwZGF0ZSwgb3IgY2xlYXIgZG9vcmJlbGwgZGF0YSBzaGFyZWQgd2l0aCB0aGUgR3VD Cj4gICAgKgo+IEBAIC0xNDU1LDMgKzE0NjUsNTAgQEAgdm9pZCBpOTE1X2d1Y19yZWdpc3Rlcihz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgCWd1Y19sb2dfbGF0ZV9zZXR1cChkZXYpOwo+ICAg CW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICAgfQo+ICsKPiAraW50IGk5MTVf Z3VjX2xvZ19jb250cm9sKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVpbnQ2NF90IGNvbnRyb2xf dmFsKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRl dl9wcml2YXRlOwoKdG9faTkxNQoKQWN0dWFsbHksIGZ1bmN0aW9uIHNob3VsZCB0YWtlIGRldl9w cml2IGlmIG5vdCBldmVuIGd1YyBkZXBlbmRpbmcgb24gdGhlIAplc3RhYmxpc2hlZCBjb252ZW50 aW9uIGluIHRoZSBmaWxlLgoKPiArCXVuaW9uIGd1Y19sb2dfY29udHJvbCBsb2dfcGFyYW07Cj4g KwlpbnQgcmV0Owo+ICsKPiArCWxvZ19wYXJhbS5sb2dnaW5nX2VuYWJsZWQgPSBjb250cm9sX3Zh bCAmIDB4MTsKPiArCWxvZ19wYXJhbS52ZXJib3NpdHkgPSAoY29udHJvbF92YWwgPj4gNCkgJiAw eEY7Cj4gKwo+ICsJaWYgKGxvZ19wYXJhbS52ZXJib3NpdHkgPCBHVUNfTE9HX1ZFUkJPU0lUWV9N SU4gfHwKPiArCSAgICBsb2dfcGFyYW0udmVyYm9zaXR5ID4gR1VDX0xPR19WRVJCT1NJVFlfTUFY KQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCS8qIFRoaXMgY29tYmluYXRpb24gZG9lc24n dCBtYWtlIHNlbnNlICYgd29uJ3QgaGF2ZSBhbnkgZWZmZWN0ICovCj4gKwlpZiAoIWxvZ19wYXJh bS5sb2dnaW5nX2VuYWJsZWQgJiYgKGk5MTUuZ3VjX2xvZ19sZXZlbCA8IDApKQo+ICsJCXJldHVy biAtRUlOVkFMOwoKSG0sIGRpc2FibGluZyB3aGlsZSBhbHJlYWR5IGRpc2FibGVkIC0gd2h5IHNo b3VsZCB0aGF0IHJldHVybiBhbiBlcnJvcj8gCk1pZ2h0IGJlIGFubm95aW5nIGluIHNjcmlwdHMu Cgo+ICsKPiArCXJldCA9IGhvc3QyZ3VjX2xvZ2dpbmdfY29udHJvbCgmZGV2X3ByaXYtPmd1Yywg bG9nX3BhcmFtLnZhbHVlKTsKPiArCWlmIChyZXQgPCAwKSB7Cj4gKwkJRFJNX0RFQlVHX0RSSVZF UigiaG9zdDJndWMgYWN0aW9uIGZhaWxlZFxuIik7CgpBZGQgcmV0IHRvIHRoZSBsb2cgc2luY2Ug aXQgaXMgZWFzeT8KCj4gKwkJcmV0dXJuIHJldDsKPiArCX0KPiArCj4gKwlpOTE1Lmd1Y19sb2df bGV2ZWwgPSBsb2dfcGFyYW0udmVyYm9zaXR5Owo+ICsKPiArCS8qIElmIGxvZ19sZXZlbCB3YXMg c2V0IGFzIC0xIGF0IGJvb3QgdGltZSwgdGhlbiB0aGUgcmVsYXkgY2hhbm5lbCBmaWxlCj4gKwkg KiB3b3VsZG4ndCBoYXZlIGJlZW4gY3JlYXRlZCBieSBub3cgYW5kIGludGVycnVwdHMgYWxzbyB3 b3VsZCBub3QgaGF2ZQo+ICsJICogYmVlbiBlbmFibGVkLgo+ICsJICovCj4gKwlpZiAoIWRldl9w cml2LT5ndWMubG9nLnJlbGF5X2NoYW4pIHsKPiArCQlyZXQgPSBndWNfbG9nX2xhdGVfc2V0dXAo ZGV2KTsKPiArCQlpZiAoIXJldCkKPiArCQkJZ2VuOV9lbmFibGVfZ3VjX2ludGVycnVwdHMoZGV2 X3ByaXYpOwoKSG0sIGxvb2sgYXQgdGhlIGFib3ZlIGFuZCBiZWxvdywgZG8gd2UgbmVlZCB0byBj cmVhdGUgdGhlIHJlbGF5IGNoYW5uZWwgCmlmIGxvZ2dpbmdfZW5hYmxlZCA9PSBmYWxzZSA/Cgo+ ICsJfSBlbHNlIGlmICghbG9nX3BhcmFtLmxvZ2dpbmdfZW5hYmxlZCkgewo+ICsJCS8qIE9uY2Ug bG9nZ2luZyBpcyBkaXNhYmxlZCwgR3VDIHdvbid0IGdlbmVyYXRlIGxvZ3MgJiBzZW5kIGFuCj4g KwkJICogaW50ZXJydXB0LiBCdXQgdGhlcmUgY291bGQgYmUgc29tZSBkYXRhIGluIHRoZSBsb2cg YnVmZmVyCj4gKwkJICogd2hpY2ggaXMgeWV0IHRvIGJlIGNhcHR1cmVkLiBTbyByZXF1ZXN0IEd1 QyB0byB1cGRhdGUgdGhlIGxvZwo+ICsJCSAqIGJ1ZmZlciBzdGF0ZSBhbmQgc2VuZCB0aGUgZmx1 c2ggaW50ZXJydXB0IHNvIHRoYXQgSG9zdCBjYW4KPiArCQkgKiBjb2xsZWN0IHRoZSBsZWZ0IG92 ZXIgbG9ncyBhbHNvLgo+ICsJCSAqLwo+ICsJCWZsdXNoX3dvcmsoJmRldl9wcml2LT5ndWMuZXZl bnRzX3dvcmspOwo+ICsJCWhvc3QyZ3VjX2ZvcmNlX2xvZ2J1ZmZlcl9mbHVzaCgmZGV2X3ByaXYt Pmd1Yyk7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIHJldDsKPiArfQo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2d1Yy5oCj4gaW5kZXggZWQ3NzNiNS4uZDU2YmRlNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2d1Yy5oCj4gQEAgLTE3OCw1ICsxNzgsNiBAQCB2b2lkIGk5MTVfZ3VjX2NhcHR1cmVfbG9ncyhz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgIHZvaWQgaTkxNV9ndWNfY2FwdHVyZV9sb2dzX29u X3Jlc2V0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICAgdm9pZCBpOTE1X2d1Y19yZWdpc3Rl cihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgIHZvaWQgaTkxNV9ndWNfdW5yZWdpc3Rlcihz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAraW50IGk5MTVfZ3VjX2xvZ19jb250cm9sKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIHVpbnQ2NF90IGNvbnRyb2xfdmFsKTsKPgo+ICAgI2VuZGlmCj4K ClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==