From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 2/5] drm/i915/guc: refactor
 guc_init_doorbell_hw()
Date: Tue, 19 Jul 2016 15:51:58 +0100
Message-ID: <578E3E8E.3090908@linux.intel.com>
References: <1468933157-22412-1-git-send-email-david.s.gordon@intel.com>
 <1468933157-22412-2-git-send-email-david.s.gordon@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 67F8D6E217
 for <intel-gfx@lists.freedesktop.org>; Tue, 19 Jul 2016 14:52:08 +0000 (UTC)
In-Reply-To: <1468933157-22412-2-git-send-email-david.s.gordon@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDE5LzA3LzE2IDEzOjU5LCBEYXZlIEdvcmRvbiB3cm90ZToKCkNvbW1pdCBtZXNzYWdlIG1p
c3NpbmchIDopCgo+IFNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBp
bnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNz
aW9uLmMgfCA1NCArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFu
Z2VkLCAzMCBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiBpbmRleCBkODQwMmU0Li5kYzVmNDg1IDEw
MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+
ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IEBAIC02
OTgsMzIgKzY5OCw0NyBAQCBzdGF0aWMgdm9pZCBnZW1fcmVsZWFzZV9ndWNfb2JqKHN0cnVjdCBk
cm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gICAJa2ZyZWUoY2xpZW50KTsKPiAgIH0KPgo+ICsv
KiBDaGVjayB0aGF0IGEgZG9vcmJlbGwgcmVnaXN0ZXIgaXMgaW4gdGhlIGV4cGVjdGVkIHN0YXRl
ICovCj4gK3N0YXRpYyBib29sIGd1Y19kb29yYmVsbF9jaGVjayhzdHJ1Y3QgaW50ZWxfZ3VjICpn
dWMsIHVpbnQxNl90IGRiX2lkKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2
X3ByaXYgPSBndWNfdG9faTkxNShndWMpOwo+ICsJaTkxNV9yZWdfdCBkcmJyZWcgPSBHRU44X0RS
QlJFR0woZGJfaWQpOwo+ICsJdWludDMyX3QgdmFsdWUgPSBJOTE1X1JFQUQoZHJicmVnKTsKPiAr
CWJvb2wgZW5hYmxlZCA9ICh2YWx1ZSAmIEdVQ19ET09SQkVMTF9FTkFCTEVEKSAhPSAwOwo+ICsJ
Ym9vbCBleHBlY3RlZCA9IHRlc3RfYml0KGRiX2lkLCBndWMtPmRvb3JiZWxsX2JpdG1hcCk7Cj4g
Kwo+ICsJaWYgKGVuYWJsZWQgPT0gZXhwZWN0ZWQpCj4gKwkJcmV0dXJuIHRydWU7Cj4gKwo+ICsJ
RFJNX0RFQlVHX0RSSVZFUigiRG9vcmJlbGwgJWQgKHJlZyAweCV4KSAweCV4LCBzaG91bGQgYmUg
JXNcbiIsCj4gKwkJCSBkYl9pZCwgZHJicmVnLnJlZywgdmFsdWUsCj4gKwkJCSBleHBlY3RlZCA/
ICJhY3RpdmUiIDogImluYWN0aXZlIik7Cj4gKwo+ICsJcmV0dXJuIGZhbHNlOwo+ICt9Cj4gKwo+
ICAgLyoKPiAgICAqIEJvcnJvdyB0aGUgZmlyc3QgY2xpZW50IHRvIHNldCB1cCAmIHRlYXIgZG93
biBlYWNoIHVudXNlZCBkb29yYmVsbAo+ICAgICogaW4gdHVybiwgdG8gZW5zdXJlIHRoYXQgYWxs
IGRvb3JiZWxsIGgvdyBpcyAocmUpaW5pdGlhbGlzZWQuCj4gICAgKi8KPiAgIHN0YXRpYyB2b2lk
IGd1Y19pbml0X2Rvb3JiZWxsX2h3KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIHsKPiAtCXN0
cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGd1Y190b19pOTE1KGd1Yyk7Cj4gICAJ
c3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50ID0gZ3VjLT5leGVjYnVmX2NsaWVudDsKPiAt
CXVpbnQxNl90IGRiX2lkLCBpOwo+IC0JaW50IGVycjsKPiArCXVpbnQxNl90IGRiX2lkOwo+ICsJ
aW50IGksIGVycjsKPgo+ICsJLyogU2F2ZSBjbGllbnQncyBvcmlnaW5hbCBkb29yYmVsbCBzZWxl
Y3Rpb24gKi8KPiAgIAlkYl9pZCA9IGNsaWVudC0+ZG9vcmJlbGxfaWQ7Cj4KPiAgIAlmb3IgKGkg
PSAwOyBpIDwgR1VDX01BWF9ET09SQkVMTFM7ICsraSkgewo+IC0JCWk5MTVfcmVnX3QgZHJicmVn
ID0gR0VOOF9EUkJSRUdMKGkpOwo+IC0JCXUzMiB2YWx1ZSA9IEk5MTVfUkVBRChkcmJyZWcpOwo+
IC0KPiAtCQlpZiAodGVzdF9iaXQoaSwgZ3VjLT5kb29yYmVsbF9iaXRtYXApKQo+ICsJCS8qIFNr
aXAgaWYgZG9vcmJlbGwgaXMgT0sgKi8KPiArCQlpZiAoZ3VjX2Rvb3JiZWxsX2NoZWNrKGd1Yywg
aSkpCj4gICAJCQljb250aW51ZTsKPgo+ICAgCQllcnIgPSBndWNfdXBkYXRlX2Rvb3JiZWxsX2lk
KGd1YywgY2xpZW50LCBpKTsKPiAtCj4gLQkJLyogUmVwb3J0IHVwZGF0ZSBmYWlsdXJlIG9yIHVu
ZXhwZWN0ZWRseSBhY3RpdmUgZG9vcmJlbGwgKi8KPiAtCQlpZiAoZXJyIHx8IChpICE9IGRiX2lk
ICYmICh2YWx1ZSAmIEdVQ19ET09SQkVMTF9FTkFCTEVEKSkpCj4gLQkJCURSTV9ERUJVR19EUklW
RVIoIkRvb3JiZWxsICVkIChyZWcgMHgleCkgd2FzIDB4JXgsIGVyciAlZFxuIiwKPiAtCQkJCQkg
IGksIGRyYnJlZy5yZWcsIHZhbHVlLCBlcnIpOwo+ICsJCWlmIChlcnIpCj4gKwkJCURSTV9ERUJV
R19EUklWRVIoIkRvb3JiZWxsICVkIHVwZGF0ZSBmYWlsZWQsIGVyciAlZFxuIiwKPiArCQkJCQlp
LCBlcnIpOwo+ICAgCX0KPgo+ICAgCS8qIFJlc3RvcmUgdG8gb3JpZ2luYWwgdmFsdWUgKi8KPiBA
QCAtNzMyLDE4ICs3NDcsOSBAQCBzdGF0aWMgdm9pZCBndWNfaW5pdF9kb29yYmVsbF9odyhzdHJ1
Y3QgaW50ZWxfZ3VjICpndWMpCj4gICAJCURSTV9FUlJPUigiRmFpbGVkIHRvIHJlc3RvcmUgZG9v
cmJlbGwgdG8gJWQsIGVyciAlZFxuIiwKPiAgIAkJCWRiX2lkLCBlcnIpOwo+Cj4gLQlmb3IgKGkg
PSAwOyBpIDwgR1VDX01BWF9ET09SQkVMTFM7ICsraSkgewo+IC0JCWk5MTVfcmVnX3QgZHJicmVn
ID0gR0VOOF9EUkJSRUdMKGkpOwo+IC0JCXUzMiB2YWx1ZSA9IEk5MTVfUkVBRChkcmJyZWcpOwo+
IC0KPiAtCQlpZiAodGVzdF9iaXQoaSwgZ3VjLT5kb29yYmVsbF9iaXRtYXApKQo+IC0JCQljb250
aW51ZTsKPiAtCj4gLQkJaWYgKGkgIT0gZGJfaWQgJiYgKHZhbHVlICYgR1VDX0RPT1JCRUxMX0VO
QUJMRUQpKQo+IC0JCQlEUk1fREVCVUdfRFJJVkVSKCJEb29yYmVsbCAlZCAocmVnIDB4JXgpIGZp
bmFsbHkgMHgleFxuIiwKPiAtCQkJCQkgIGksIGRyYnJlZy5yZWcsIHZhbHVlKTsKPiAtCj4gLQl9
Cj4gKwkvKiBSZWFkIGJhY2sgJiB2ZXJpZnkgYWxsIGRvb3JiZWxsIHJlZ2lzdGVycyAqLwo+ICsJ
Zm9yIChpID0gMDsgaSA8IEdVQ19NQVhfRE9PUkJFTExTOyArK2kpCj4gKwkJKHZvaWQpZ3VjX2Rv
b3JiZWxsX2NoZWNrKGd1YywgaSk7Cj4gICB9Cj4KPiAgIC8qKgo+CgpPdGhlcndpc2UgbG9va3Mg
ZmluZS4KClJlZ2FyZHMsCgpUdnJ0a28KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy
ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp
bmZvL2ludGVsLWdmeAo=