From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 3/5] drm/i915/guc: use a separate GuC client for each engine Date: Tue, 19 Jul 2016 16:02:49 +0100 Message-ID: <578E4119.7050409@linux.intel.com> References: <1468933157-22412-1-git-send-email-david.s.gordon@intel.com> <1468933157-22412-3-git-send-email-david.s.gordon@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A32C6E257 for ; Tue, 19 Jul 2016 15:04:00 +0000 (UTC) In-Reply-To: <1468933157-22412-3-git-send-email-david.s.gordon@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzA3LzE2IDEzOjU5LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBXaGVuIHVzaW5nIGEgc2lu Z2xlIEd1QyBjbGllbnQgZm9yIG11bHRpcGxlIGVuZ2luZXMsIHRoZSBpOTE1IGRyaXZlciBoYXMK PiB0byBtZXJnZSBhbGwgd29yayBpdGVtcyBpbnRvIGEgc2luZ2xlIHdvcmsgcXVldWUsIHdoaWNo IHRoZSBHdUMgZmlybXdhcmUKPiB0aGVuIGRlbXVsdGlwbGV4ZXMgaW50byBzZXBhcmF0ZSBzdWJt aXNzaW9uIHF1ZXVlcyBwZXIgZW5naW5lLiBJbgo+IHRoZW9yeSwgdGhpcyBjb3VsZCBsZWFkIHRv IHRoZSBzaW5nbGUgcXVldWUgYmVjb21pbmcgYSBib3R0bGVuZWNrIGluCj4gd2hpY2ggYW4gZXhj ZXNzIG9mIG91dHN0YW5kaW5nIHdvcmsgZm9yIG9uZSBvciBtb3JlIGVuZ2luZXMgbWlnaHQKPiBw cmV2ZW50IHdvcmsgZm9yIGFuIGlkbGUgZW5naW5lIHJlYWNoaW5nIHRoZSBoYXJkd2FyZS4KPgo+ IFRvIHJlZHVjZSB0aGlzIHJpc2ssIHdlIGNhbiBjcmVhdGUgb25lIEd1QyBjbGllbnQgcGVyIGVu Z2luZS4gRWFjaCB3aWxsCj4gaGF2ZSBpdHMgb3duIHdvcmtxdWV1ZSwgdG8gYmUgdXNlZCBvbmx5 IGZvciB3b3JrIHRhcmdldGluZyBhIHNpbmdsZQo+IGVuZ2luZSwgc28gdGhlcmUgd2lsbCBiZSBu byBjcm9zcy1lbmdpbmUgY29udGVudGlvbiBmb3Igd29ya3F1ZXVlIHNsb3RzLgo+Cj4gU2lnbmVk LW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPiAtLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jICAgICAgICB8IDI1ICsrKysrKysr KysrKysrKystLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lv bi5jIHwgMzUgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9ndWMuaCAgICAgICAgICAgfCAgMiArLQo+ICAgMyBmaWxlcyBjaGFuZ2Vk LCA0MiBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZGVidWdmcy5jCj4gaW5kZXggOTBhZWY0NS4uNWNiYjhlZiAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZGVidWdmcy5jCj4gQEAgLTI1NzAsMjAgKzI1NzAsMjYgQEAgc3RhdGljIGludCBp OTE1X2d1Y19pbmZvKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqZGF0YSkKPiAgIAlzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2ID0gbm9kZS0+bWlub3ItPmRldjsKPiAgIAlzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gICAJc3RydWN0IGludGVsX2d1YyBn dWM7Cj4gLQlzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50IGNsaWVudCA9IHt9Owo+ICsJc3RydWN0IGk5 MTVfZ3VjX2NsaWVudCAqY2xpZW50czsKPiAgIAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmU7Cj4gKwllbnVtIGludGVsX2VuZ2luZV9pZCBpZDsKPiAgIAl1NjQgdG90YWwgPSAwOwo+Cj4g ICAJaWYgKCFIQVNfR1VDX1NDSEVEKGRldl9wcml2KSkKPiAgIAkJcmV0dXJuIDA7Cj4KPiArCWNs aWVudHMgPSBrY2FsbG9jKEk5MTVfTlVNX0VOR0lORVMsIHNpemVvZigqY2xpZW50cyksIEdGUF9L RVJORUwpOwo+ICsJaWYgKGNsaWVudHMgPT0gTlVMTCkKPiArCQlyZXR1cm4gLUVOT01FTTsKPiAr Cj4gICAJaWYgKG11dGV4X2xvY2tfaW50ZXJydXB0aWJsZSgmZGV2LT5zdHJ1Y3RfbXV0ZXgpKQo+ IC0JCXJldHVybiAwOwo+ICsJCWdvdG8gZG9uZTsKPgo+ICAgCS8qIFRha2UgYSBsb2NhbCBjb3B5 IG9mIHRoZSBHdUMgZGF0YSwgc28gd2UgY2FuIGR1bXAgaXQgYXQgbGVpc3VyZSAqLwo+ICAgCWd1 YyA9IGRldl9wcml2LT5ndWM7Cj4gLQlpZiAoZ3VjLmV4ZWNidWZfY2xpZW50KQo+IC0JCWNsaWVu dCA9ICpndWMuZXhlY2J1Zl9jbGllbnQ7Cj4gKwlmb3JfZWFjaF9lbmdpbmVfaWQoZW5naW5lLCBk ZXZfcHJpdiwgaWQpCj4gKwkJaWYgKGd1Yy5leGVjX2NsaWVudHNbaWRdKQo+ICsJCQljbGllbnRz W2lkXSA9ICpndWMuZXhlY19jbGllbnRzW2lkXTsKPgo+ICAgCW11dGV4X3VubG9jaygmZGV2LT5z dHJ1Y3RfbXV0ZXgpOwo+Cj4gQEAgLTI2MDYsMTEgKzI2MTIsMTggQEAgc3RhdGljIGludCBpOTE1 X2d1Y19pbmZvKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqZGF0YSkKPiAgIAl9Cj4gICAJc2Vx X3ByaW50ZihtLCAiXHQlczogJWxsdVxuIiwgIlRvdGFsIiwgdG90YWwpOwo+Cj4gLQlzZXFfcHJp bnRmKG0sICJcbkd1QyBleGVjYnVmIGNsaWVudCBAICVwOlxuIiwgZ3VjLmV4ZWNidWZfY2xpZW50 KTsKPiAtCWk5MTVfZ3VjX2NsaWVudF9pbmZvKG0sIGRldl9wcml2LCAmY2xpZW50KTsKPiArCWZv cl9lYWNoX2VuZ2luZV9pZChlbmdpbmUsIGRldl9wcml2LCBpZCkgewo+ICsJCXNlcV9wcmludGYo bSwgIlxuR3VDIGV4ZWNfY2xpZW50WyVkXSBAICVwOlxuIiwKPiArCQkJCWlkLCBndWMuZXhlY19j bGllbnRzW2lkXSk7CgpNaW5vciBhbmQgbm90IGEgYmxvY2tlciBmb3IgdGhpcyBwYXRjaCwgYnV0 IEkgd291bGQgcG90ZW50aWFsbHkgCnJlLWNvbnNpZGVyIGlmIHByaW50aW5nIG91dCB0aGUgY2xp ZW50IHBvaW50ZXIgaXMgdXNlZnVsLgoKPiArCQlpZiAoZ3VjLmV4ZWNfY2xpZW50c1tpZF0pCj4g KwkJCWk5MTVfZ3VjX2NsaWVudF9pbmZvKG0sIGRldl9wcml2LCAmY2xpZW50c1tpZF0pOwo+ICsJ fQo+Cj4gICAJLyogQWRkIG1vcmUgYXMgcmVxdWlyZWQgLi4uICovCj4KPiArZG9uZToKPiArCWtm cmVlKGNsaWVudHMpOwo+ICsKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiBpbmRleCBkYzVmNDg1Li5iMGY5OTQ1IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IEBAIC00 MzQsNyArNDM0LDkgQEAgc3RhdGljIHZvaWQgZ3VjX2ZpbmlfY3R4X2Rlc2Moc3RydWN0IGludGVs X2d1YyAqZ3VjLAo+ICAgaW50IGk5MTVfZ3VjX3dxX2NoZWNrX3NwYWNlKHN0cnVjdCBkcm1faTkx NV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiAgIHsKPiAgIAljb25zdCBzaXplX3Qgd3FpX3NpemUg PSBzaXplb2Yoc3RydWN0IGd1Y193cV9pdGVtKTsKPiAtCXN0cnVjdCBpOTE1X2d1Y19jbGllbnQg KmdjID0gcmVxdWVzdC0+aTkxNS0+Z3VjLmV4ZWNidWZfY2xpZW50Owo+ICsJZW51bSBpbnRlbF9l bmdpbmVfaWQgZW5naW5lX2lkID0gcmVxdWVzdC0+ZW5naW5lLT5pZDsKPiArCXN0cnVjdCBpbnRl bF9ndWMgKmd1YyA9ICZyZXF1ZXN0LT5pOTE1LT5ndWM7Cj4gKwlzdHJ1Y3QgaTkxNV9ndWNfY2xp ZW50ICpnYyA9IGd1Yy0+ZXhlY19jbGllbnRzW2VuZ2luZV9pZF07Cj4gICAJc3RydWN0IGd1Y19w cm9jZXNzX2Rlc2MgKmRlc2M7Cj4gICAJdTMyIGZyZWVzcGFjZTsKPgo+IEBAIC01ODksNyArNTkx LDcgQEAgaW50IGk5MTVfZ3VjX3N1Ym1pdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJx KQo+ICAgewo+ICAgCXVuc2lnbmVkIGludCBlbmdpbmVfaWQgPSBycS0+ZW5naW5lLT5pZDsKPiAg IAlzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmcnEtPmk5MTUtPmd1YzsKPiAtCXN0cnVjdCBpOTE1 X2d1Y19jbGllbnQgKmNsaWVudCA9IGd1Yy0+ZXhlY2J1Zl9jbGllbnQ7Cj4gKwlzdHJ1Y3QgaTkx NV9ndWNfY2xpZW50ICpjbGllbnQgPSBndWMtPmV4ZWNfY2xpZW50c1tlbmdpbmVfaWRdOwo+ICAg CWludCBiX3JldDsKPgo+ICAgCWd1Y19hZGRfd29ya3F1ZXVlX2l0ZW0oY2xpZW50LCBycSk7Cj4g QEAgLTcyMyw3ICs3MjUsNyBAQCBzdGF0aWMgYm9vbCBndWNfZG9vcmJlbGxfY2hlY2soc3RydWN0 IGludGVsX2d1YyAqZ3VjLCB1aW50MTZfdCBkYl9pZCkKPiAgICAqLwo+ICAgc3RhdGljIHZvaWQg Z3VjX2luaXRfZG9vcmJlbGxfaHcoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ICAgewo+IC0Jc3Ry dWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50ID0gZ3VjLT5leGVjYnVmX2NsaWVudDsKPiArCXN0 cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCA9IGd1Yy0+ZXhlY19jbGllbnRzW1JDU107Cj4g ICAJdWludDE2X3QgZGJfaWQ7Cj4gICAJaW50IGksIGVycjsKPgo+IEBAIC0xMDA0LDE3ICsxMDA2 LDIxIEBAIGludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2VuYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gICB7Cj4gICAJc3RydWN0IGludGVsX2d1YyAqZ3VjID0gJmRldl9w cml2LT5ndWM7Cj4gICAJc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50Owo+ICsJc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+Cj4gLQkvKiBjbGllbnQgZm9yIGV4ZWNidWYgc3Vi bWlzc2lvbiAqLwo+IC0JY2xpZW50ID0gZ3VjX2NsaWVudF9hbGxvYyhkZXZfcHJpdiwKPiAtCQkJ CSAgR1VDX0NUWF9QUklPUklUWV9LTURfTk9STUFMLAo+IC0JCQkJICBkZXZfcHJpdi0+a2VybmVs X2NvbnRleHQpOwo+IC0JaWYgKCFjbGllbnQpIHsKPiAtCQlEUk1fRVJST1IoIkZhaWxlZCB0byBj cmVhdGUgZXhlY2J1ZiBndWNfY2xpZW50XG4iKTsKPiAtCQlyZXR1cm4gLUVOT01FTTsKPiArCWZv cl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2KSB7Cj4gKwkJLyogY2xpZW50IGZvciBleGVj YnVmIHN1Ym1pc3Npb24gKi8KPiArCQljbGllbnQgPSBndWNfY2xpZW50X2FsbG9jKGRldl9wcml2 LAo+ICsJCQkJCSAgR1VDX0NUWF9QUklPUklUWV9LTURfTk9STUFMLAo+ICsJCQkJCSAgZGV2X3By aXYtPmtlcm5lbF9jb250ZXh0KTsKPiArCQlpZiAoIWNsaWVudCkgewo+ICsJCQlEUk1fRVJST1Io IkZhaWxlZCB0byBjcmVhdGUgR3VDIGNsaWVudChzKVxuIik7Cj4gKwkJCXJldHVybiAtRU5PTUVN Owo+ICsJCX0KPiArCj4gKwkJZ3VjLT5leGVjX2NsaWVudHNbZW5naW5lLT5pZF0gPSBjbGllbnQ7 Cj4gICAJfQo+Cj4gLQlndWMtPmV4ZWNidWZfY2xpZW50ID0gY2xpZW50Owo+ICAgCWhvc3QyZ3Vj X3NhbXBsZV9mb3JjZXdha2UoZ3VjLCBjbGllbnQpOwo+ICAgCWd1Y19pbml0X2Rvb3JiZWxsX2h3 KGd1Yyk7Cj4KPiBAQCAtMTAyNCw5ICsxMDMwLDEyIEBAIGludCBpOTE1X2d1Y19zdWJtaXNzaW9u X2VuYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICB2b2lkIGk5MTVf Z3VjX3N1Ym1pc3Npb25fZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gICB7Cj4gICAJc3RydWN0IGludGVsX2d1YyAqZ3VjID0gJmRldl9wcml2LT5ndWM7Cj4gKwlz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4KPiAtCWd1Y19jbGllbnRfZnJlZShkZXZf cHJpdiwgZ3VjLT5leGVjYnVmX2NsaWVudCk7Cj4gLQlndWMtPmV4ZWNidWZfY2xpZW50ID0gTlVM TDsKPiArCWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2KSB7Cj4gKwkJZ3VjX2NsaWVu dF9mcmVlKGRldl9wcml2LCBndWMtPmV4ZWNfY2xpZW50c1tlbmdpbmUtPmlkXSk7Cj4gKwkJZ3Vj LT5leGVjX2NsaWVudHNbZW5naW5lLT5pZF0gPSBOVUxMOwo+ICsJfQo+ICAgfQo+Cj4gICB2b2lk IGk5MTVfZ3VjX3N1Ym1pc3Npb25fZmluaShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPiBpbmRleCAzZTNlNzQzLi43YjRjYzRkIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPiBAQCAtMTMyLDcgKzEzMiw3IEBAIHN0cnVj dCBpbnRlbF9ndWMgewo+ICAgCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpjdHhfcG9vbF9v Ymo7Cj4gICAJc3RydWN0IGlkYSBjdHhfaWRzOwo+Cj4gLQlzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50 ICpleGVjYnVmX2NsaWVudDsKPiArCXN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmV4ZWNfY2xpZW50 c1tJOTE1X05VTV9FTkdJTkVTXTsKPgo+ICAgCURFQ0xBUkVfQklUTUFQKGRvb3JiZWxsX2JpdG1h cCwgR1VDX01BWF9ET09SQkVMTFMpOwo+ICAgCXVpbnQzMl90IGRiX2NhY2hlbGluZTsJCS8qIEN5 Y2xpYyBjb3VudGVyIG1vZCBwYWdlc2l6ZQkqLwo+CgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3Vs aW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==