From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 5/5] drm/i915/guc: use for_each_engine_id()
 where appropriate
Date: Tue, 19 Jul 2016 16:09:42 +0100
Message-ID: <578E42B6.6040400@linux.intel.com>
References: <1468933157-22412-1-git-send-email-david.s.gordon@intel.com>
 <1468933157-22412-5-git-send-email-david.s.gordon@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 6B15289C05
 for <intel-gfx@lists.freedesktop.org>; Tue, 19 Jul 2016 15:11:48 +0000 (UTC)
In-Reply-To: <1468933157-22412-5-git-send-email-david.s.gordon@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDE5LzA3LzE2IDEzOjU5LCBEYXZlIEdvcmRvbiB3cm90ZToKPiBOb3cgdGhhdCBob3N0IHN0
cnVjdHVyZXMgYXJlIGluZGV4ZWQgYnkgaG9zdCBlbmdpbmUtaWQgcmF0aGVyIHRoYW4KPiBndWNf
aWQsIHdlIGNhbiB1c2VmdWxseSBjb252ZXJ0IHNvbWUgZm9yX2VhY2hfZW5naW5lKCkgbG9vcHMg
dG8gdXNlCj4gZm9yX2VhY2hfZW5naW5lX2lkKCkgYW5kIGF2b2lkIG11bHRpcGxlIGRlcmVmZXJl
bmNlcyBvZiBlbmdpbmUtPmlkLgo+Cj4gQWxzbyBhIGZldyByZWxhdGVkIHR3ZWFrcyB0byBjYWNo
ZSBzdHJ1Y3R1cmUgbWVtYmVycyBsb2NhbGx5IHdoZXJldmVyCj4gdGhleSdyZSB1c2VkIG1vcmUg
dGhhbiBvbmNlIG9yIHR3aWNlLCBob3BlZnVsbHkgZWxpbWluYXRpbmcgbWVtb3J5Cj4gcmVmZXJl
bmNlcy4KPgo+IFNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRl
bC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyAgICAg
ICAgfCAxNyArKysrKysrKystLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n
dWNfc3VibWlzc2lvbi5jIHwgMjIgKysrKysrKysrKysrKy0tLS0tLS0tLQo+ICAgMiBmaWxlcyBj
aGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg
YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZGVidWdmcy5jCj4gaW5kZXggNWNiYjhlZi4uNzY5MThhYiAxMDA2NDQKPiAtLS0g
YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gQEAgLTI1NDEsNiArMjU0MSw3IEBAIHN0YXRpYyB2
b2lkIGk5MTVfZ3VjX2NsaWVudF9pbmZvKHN0cnVjdCBzZXFfZmlsZSAqbSwKPiAgIAkJCQkgc3Ry
dWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50KQo+ICAgewo+ICAgCXN0cnVjdCBpbnRlbF9lbmdp
bmVfY3MgKmVuZ2luZTsKPiArCWVudW0gaW50ZWxfZW5naW5lX2lkIGlkOwo+ICAgCXVpbnQ2NF90
IHRvdCA9IDA7Cj4KPiAgIAlzZXFfcHJpbnRmKG0sICJcdFByaW9yaXR5ICVkLCBHdUMgY3R4IGlu
ZGV4OiAldSwgUEQgb2Zmc2V0IDB4JXhcbiIsCj4gQEAgLTI1NTUsMTEgKzI1NTYsMTEgQEAgc3Rh
dGljIHZvaWQgaTkxNV9ndWNfY2xpZW50X2luZm8oc3RydWN0IHNlcV9maWxlICptLAo+ICAgCXNl
cV9wcmludGYobSwgIlx0RmFpbGVkIGRvb3JiZWxsOiAldVxuIiwgY2xpZW50LT5iX2ZhaWwpOwo+
ICAgCXNlcV9wcmludGYobSwgIlx0TGFzdCBzdWJtaXNzaW9uIHJlc3VsdDogJWRcbiIsIGNsaWVu
dC0+cmV0Y29kZSk7Cj4KPiAtCWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2KSB7Cj4g
Kwlmb3JfZWFjaF9lbmdpbmVfaWQoZW5naW5lLCBkZXZfcHJpdiwgaWQpIHsKPiArCQl1NjQgc3Vi
bWlzc2lvbnMgPSBjbGllbnQtPnN1Ym1pc3Npb25zW2lkXTsKPiArCQl0b3QgKz0gc3VibWlzc2lv
bnM7Cj4gICAJCXNlcV9wcmludGYobSwgIlx0U3VibWlzc2lvbnM6ICVsbHUgJXNcbiIsCj4gLQkJ
CQljbGllbnQtPnN1Ym1pc3Npb25zW2VuZ2luZS0+aWRdLAo+IC0JCQkJZW5naW5lLT5uYW1lKTsK
PiAtCQl0b3QgKz0gY2xpZW50LT5zdWJtaXNzaW9uc1tlbmdpbmUtPmlkXTsKPiArCQkJCXN1Ym1p
c3Npb25zLCBlbmdpbmUtPm5hbWUpOwo+ICAgCX0KPiAgIAlzZXFfcHJpbnRmKG0sICJcdFRvdGFs
OiAlbGx1XG4iLCB0b3QpOwo+ICAgfQo+IEBAIC0yNjA0LDExICsyNjA1LDExIEBAIHN0YXRpYyBp
bnQgaTkxNV9ndWNfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKmRhdGEpCj4gICAJc2Vx
X3ByaW50ZihtLCAiR3VDIGxhc3QgYWN0aW9uIGVycm9yIGNvZGU6ICVkXG4iLCBndWMuYWN0aW9u
X2Vycik7Cj4KPiAgIAlzZXFfcHJpbnRmKG0sICJcbkd1QyBzdWJtaXNzaW9uczpcbiIpOwo+IC0J
Zm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgZGV2X3ByaXYpIHsKPiArCWZvcl9lYWNoX2VuZ2luZV9p
ZChlbmdpbmUsIGRldl9wcml2LCBpZCkgewo+ICsJCXU2NCBzdWJtaXNzaW9ucyA9IGd1Yy5zdWJt
aXNzaW9uc1tpZF07Cj4gKwkJdG90YWwgKz0gc3VibWlzc2lvbnM7Cj4gICAJCXNlcV9wcmludGYo
bSwgIlx0JS0yNHM6ICUxMGxsdSwgbGFzdCBzZXFubyAweCUwOHhcbiIsCj4gLQkJCWVuZ2luZS0+
bmFtZSwgZ3VjLnN1Ym1pc3Npb25zW2VuZ2luZS0+aWRdLAo+IC0JCQlndWMubGFzdF9zZXFub1tl
bmdpbmUtPmlkXSk7Cj4gLQkJdG90YWwgKz0gZ3VjLnN1Ym1pc3Npb25zW2VuZ2luZS0+aWRdOwo+
ICsJCQllbmdpbmUtPm5hbWUsIHN1Ym1pc3Npb25zLCBndWMubGFzdF9zZXFub1tpZF0pOwo+ICAg
CX0KPiAgIAlzZXFfcHJpbnRmKG0sICJcdCVzOiAlbGx1XG4iLCAiVG90YWwiLCB0b3RhbCk7Cj4K
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5j
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gaW5kZXggNGRh
YmE3Ny4uNWJlZWQxYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1
Y19zdWJtaXNzaW9uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJt
aXNzaW9uLmMKPiBAQCAtMzQyLDcgKzM0Miw4IEBAIHN0YXRpYyB2b2lkIGd1Y19pbml0X2N0eF9k
ZXNjKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywKPgo+ICAgCWZvcl9lYWNoX2VuZ2luZV9tYXNrZWQo
ZW5naW5lLCBkZXZfcHJpdiwgY2xpZW50LT5lbmdpbmVzKSB7Cj4gICAJCXN0cnVjdCBpbnRlbF9j
b250ZXh0ICpjZSA9ICZjdHgtPmVuZ2luZVtlbmdpbmUtPmlkXTsKPiAtCQlzdHJ1Y3QgZ3VjX2V4
ZWNsaXN0X2NvbnRleHQgKmxyYyA9ICZkZXNjLmxyY1tlbmdpbmUtPmd1Y19pZF07Cj4gKwkJdWlu
dDMyX3QgZ3VjX2VuZ2luZV9pZCA9IGVuZ2luZS0+Z3VjX2lkOwo+ICsJCXN0cnVjdCBndWNfZXhl
Y2xpc3RfY29udGV4dCAqbHJjID0gJmRlc2MubHJjW2d1Y19lbmdpbmVfaWRdOwo+ICAgCQlzdHJ1
Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+Cj4gICAJCS8qIFRPRE86IFdlIGhhdmUgYSBk
ZXNpZ24gaXNzdWUgdG8gYmUgc29sdmVkIGhlcmUuIE9ubHkgd2hlbiB3ZQo+IEBAIC0zNjEsNyAr
MzYyLDcgQEAgc3RhdGljIHZvaWQgZ3VjX2luaXRfY3R4X2Rlc2Moc3RydWN0IGludGVsX2d1YyAq
Z3VjLAo+ICAgCQlnZnhfYWRkciA9IGk5MTVfZ2VtX29ial9nZ3R0X29mZnNldChjZS0+c3RhdGUp
Owo+ICAgCQlscmMtPnJpbmdfbGNyYSA9IGdmeF9hZGRyICsgTFJDX1NUQVRFX1BOICogUEFHRV9T
SVpFOwo+ICAgCQlscmMtPmNvbnRleHRfaWQgPSAoY2xpZW50LT5jdHhfaW5kZXggPDwgR1VDX0VM
Q19DVFhJRF9PRkZTRVQpIHwKPiAtCQkJCShlbmdpbmUtPmd1Y19pZCA8PCBHVUNfRUxDX0VOR0lO
RV9PRkZTRVQpOwo+ICsJCQkJKGd1Y19lbmdpbmVfaWQgPDwgR1VDX0VMQ19FTkdJTkVfT0ZGU0VU
KTsKPgo+ICAgCQlvYmogPSBjZS0+cmluZ2J1Zi0+b2JqOwo+ICAgCQlnZnhfYWRkciA9IGk5MTVf
Z2VtX29ial9nZ3R0X29mZnNldChvYmopOwo+IEBAIC0zNzEsNyArMzcyLDcgQEAgc3RhdGljIHZv
aWQgZ3VjX2luaXRfY3R4X2Rlc2Moc3RydWN0IGludGVsX2d1YyAqZ3VjLAo+ICAgCQlscmMtPnJp
bmdfbmV4dF9mcmVlX2xvY2F0aW9uID0gZ2Z4X2FkZHI7Cj4gICAJCWxyYy0+cmluZ19jdXJyZW50
X3RhaWxfcG9pbnRlcl92YWx1ZSA9IDA7Cj4KPiAtCQlkZXNjLmVuZ2luZXNfdXNlZCB8PSAoMSA8
PCBlbmdpbmUtPmd1Y19pZCk7Cj4gKwkJZGVzYy5lbmdpbmVzX3VzZWQgfD0gKDEgPDwgZ3VjX2Vu
Z2luZV9pZCk7Cj4gICAJfQo+Cj4gICAJRFJNX0RFQlVHX0RSSVZFUigiSG9zdCBlbmdpbmVzIDB4
JXggPT4gR3VDIGVuZ2luZXMgdXNlZCAweCV4XG4iLAo+IEBAIC00NjEsNiArNDYyLDcgQEAgc3Rh
dGljIHZvaWQgZ3VjX2FkZF93b3JrcXVldWVfaXRlbShzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpn
YywKPiAgIAkvKiB3cWlfbGVuIGlzIGluIERXb3JkcywgYW5kIGRvZXMgbm90IGluY2x1ZGUgdGhl
IG9uZS13b3JkIGhlYWRlciAqLwo+ICAgCWNvbnN0IHNpemVfdCB3cWlfc2l6ZSA9IHNpemVvZihz
dHJ1Y3QgZ3VjX3dxX2l0ZW0pOwo+ICAgCWNvbnN0IHUzMiB3cWlfbGVuID0gd3FpX3NpemUvc2l6
ZW9mKHUzMikgLSAxOwo+ICsJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lID0gcnEtPmVu
Z2luZTsKPiAgIAlzdHJ1Y3QgZ3VjX3Byb2Nlc3NfZGVzYyAqZGVzYzsKPiAgIAlzdHJ1Y3QgZ3Vj
X3dxX2l0ZW0gKndxaTsKPiAgIAl2b2lkICpiYXNlOwo+IEBAIC01MDIsMTIgKzUwNCwxMSBAQCBz
dGF0aWMgdm9pZCBndWNfYWRkX3dvcmtxdWV1ZV9pdGVtKHN0cnVjdCBpOTE1X2d1Y19jbGllbnQg
KmdjLAo+ICAgCS8qIE5vdyBmaWxsIGluIHRoZSA0LXdvcmQgd29yayBxdWV1ZSBpdGVtICovCj4g
ICAJd3FpLT5oZWFkZXIgPSBXUV9UWVBFX0lOT1JERVIgfAo+ICAgCQkJKHdxaV9sZW4gPDwgV1Ff
TEVOX1NISUZUKSB8Cj4gLQkJCShycS0+ZW5naW5lLT5ndWNfaWQgPDwgV1FfVEFSR0VUX1NISUZU
KSB8Cj4gKwkJCShlbmdpbmUtPmd1Y19pZCA8PCBXUV9UQVJHRVRfU0hJRlQpIHwKPiAgIAkJCVdR
X05PX1dDRkxVU0hfV0FJVDsKPgo+ICAgCS8qIFRoZSBHdUMgd2FudHMgb25seSB0aGUgbG93LW9y
ZGVyIHdvcmQgb2YgdGhlIGNvbnRleHQgZGVzY3JpcHRvciAqLwo+IC0Jd3FpLT5jb250ZXh0X2Rl
c2MgPSAodTMyKWludGVsX2xyX2NvbnRleHRfZGVzY3JpcHRvcihycS0+Y3R4LAo+IC0JCQkJCQkJ
ICAgICBycS0+ZW5naW5lKTsKPiArCXdxaS0+Y29udGV4dF9kZXNjID0gKHUzMilpbnRlbF9scl9j
b250ZXh0X2Rlc2NyaXB0b3IocnEtPmN0eCwgZW5naW5lKTsKPgo+ICAgCXdxaS0+cmluZ190YWls
ID0gdGFpbCA8PCBXUV9SSU5HX1RBSUxfU0hJRlQ7Cj4gICAJd3FpLT5mZW5jZV9pZCA9IHJxLT5z
ZXFubzsKPiBAQCAtMTAzNSwxMSArMTAzNiwxNCBAQCBpbnQgaTkxNV9ndWNfc3VibWlzc2lvbl9l
bmFibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgdm9pZCBpOTE1X2d1
Y19zdWJtaXNzaW9uX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+
ICAgewo+ICAgCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZkZXZfcHJpdi0+Z3VjOwo+ICsJc3Ry
dWN0IGk5MTVfZ3VjX2NsaWVudCAqKmdjX3B0cjsKPiAgIAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz
ICplbmdpbmU7Cj4gKwllbnVtIGludGVsX2VuZ2luZV9pZCBlbmdpbmVfaWQ7Cj4KPiAtCWZvcl9l
YWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2KSB7Cj4gLQkJZ3VjX2NsaWVudF9mcmVlKGRldl9w
cml2LCBndWMtPmV4ZWNfY2xpZW50c1tlbmdpbmUtPmlkXSk7Cj4gLQkJZ3VjLT5leGVjX2NsaWVu
dHNbZW5naW5lLT5pZF0gPSBOVUxMOwo+ICsJZm9yX2VhY2hfZW5naW5lX2lkKGVuZ2luZSwgZGV2
X3ByaXYsIGVuZ2luZV9pZCkgewo+ICsJCWdjX3B0ciA9ICZndWMtPmV4ZWNfY2xpZW50c1tlbmdp
bmVfaWRdOwo+ICsJCWd1Y19jbGllbnRfZnJlZShkZXZfcHJpdiwgKmdjX3B0cik7Cj4gKwkJKmdj
X3B0ciA9IE5VTEw7Cj4gICAJfQo+ICAgfQo+Cj4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxp
biA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs
aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz
a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK