From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 3/5] drm/i915/guc: use a separate GuC client for each engine Date: Tue, 19 Jul 2016 16:13:41 +0100 Message-ID: <578E43A5.9000402@intel.com> References: <1468933157-22412-1-git-send-email-david.s.gordon@intel.com> <1468933157-22412-3-git-send-email-david.s.gordon@intel.com> <578E4119.7050409@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id E01166E382 for ; Tue, 19 Jul 2016 15:13:42 +0000 (UTC) In-Reply-To: <578E4119.7050409@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTkvMDcvMTYgMTY6MDIsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMTkvMDcvMTYg MTM6NTksIERhdmUgR29yZG9uIHdyb3RlOgo+PiBXaGVuIHVzaW5nIGEgc2luZ2xlIEd1QyBjbGll bnQgZm9yIG11bHRpcGxlIGVuZ2luZXMsIHRoZSBpOTE1IGRyaXZlciBoYXMKPj4gdG8gbWVyZ2Ug YWxsIHdvcmsgaXRlbXMgaW50byBhIHNpbmdsZSB3b3JrIHF1ZXVlLCB3aGljaCB0aGUgR3VDIGZp cm13YXJlCj4+IHRoZW4gZGVtdWx0aXBsZXhlcyBpbnRvIHNlcGFyYXRlIHN1Ym1pc3Npb24gcXVl dWVzIHBlciBlbmdpbmUuIEluCj4+IHRoZW9yeSwgdGhpcyBjb3VsZCBsZWFkIHRvIHRoZSBzaW5n bGUgcXVldWUgYmVjb21pbmcgYSBib3R0bGVuZWNrIGluCj4+IHdoaWNoIGFuIGV4Y2VzcyBvZiBv dXRzdGFuZGluZyB3b3JrIGZvciBvbmUgb3IgbW9yZSBlbmdpbmVzIG1pZ2h0Cj4+IHByZXZlbnQg d29yayBmb3IgYW4gaWRsZSBlbmdpbmUgcmVhY2hpbmcgdGhlIGhhcmR3YXJlLgo+Pgo+PiBUbyBy ZWR1Y2UgdGhpcyByaXNrLCB3ZSBjYW4gY3JlYXRlIG9uZSBHdUMgY2xpZW50IHBlciBlbmdpbmUu IEVhY2ggd2lsbAo+PiBoYXZlIGl0cyBvd24gd29ya3F1ZXVlLCB0byBiZSB1c2VkIG9ubHkgZm9y IHdvcmsgdGFyZ2V0aW5nIGEgc2luZ2xlCj4+IGVuZ2luZSwgc28gdGhlcmUgd2lsbCBiZSBubyBj cm9zcy1lbmdpbmUgY29udGVudGlvbiBmb3Igd29ya3F1ZXVlIHNsb3RzLgo+Pgo+PiBTaWduZWQt b2ZmLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+PiAtLS0KPj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyAgICAgICAgfCAyNSArKysrKysr KysrKysrKysrLS0tLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNz aW9uLmMgfCAzNQo+PiArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaCAgICAgICAgICAgfCAgMiArLQo+PiAgIDMgZmlsZXMg Y2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+PiBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4+IGluZGV4IDkwYWVmNDUuLjVjYmI4ZWYgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4+IEBAIC0yNTcwLDIwICsyNTcwLDI2 IEBAIHN0YXRpYyBpbnQgaTkxNV9ndWNfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sCj4+IHZvaWQg KmRhdGEpCj4+ICAgICAgIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBub2RlLT5taW5vci0+ZGV2 Owo+PiAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRl dik7Cj4+ICAgICAgIHN0cnVjdCBpbnRlbF9ndWMgZ3VjOwo+PiAtICAgIHN0cnVjdCBpOTE1X2d1 Y19jbGllbnQgY2xpZW50ID0ge307Cj4+ICsgICAgc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xp ZW50czsKPj4gICAgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+PiArICAgIGVu dW0gaW50ZWxfZW5naW5lX2lkIGlkOwo+PiAgICAgICB1NjQgdG90YWwgPSAwOwo+Pgo+PiAgICAg ICBpZiAoIUhBU19HVUNfU0NIRUQoZGV2X3ByaXYpKQo+PiAgICAgICAgICAgcmV0dXJuIDA7Cj4+ Cj4+ICsgICAgY2xpZW50cyA9IGtjYWxsb2MoSTkxNV9OVU1fRU5HSU5FUywgc2l6ZW9mKCpjbGll bnRzKSwgR0ZQX0tFUk5FTCk7Cj4+ICsgICAgaWYgKGNsaWVudHMgPT0gTlVMTCkKPj4gKyAgICAg ICAgcmV0dXJuIC1FTk9NRU07Cj4+ICsKPj4gICAgICAgaWYgKG11dGV4X2xvY2tfaW50ZXJydXB0 aWJsZSgmZGV2LT5zdHJ1Y3RfbXV0ZXgpKQo+PiAtICAgICAgICByZXR1cm4gMDsKPj4gKyAgICAg ICAgZ290byBkb25lOwo+Pgo+PiAgICAgICAvKiBUYWtlIGEgbG9jYWwgY29weSBvZiB0aGUgR3VD IGRhdGEsIHNvIHdlIGNhbiBkdW1wIGl0IGF0Cj4+IGxlaXN1cmUgKi8KPj4gICAgICAgZ3VjID0g ZGV2X3ByaXYtPmd1YzsKPj4gLSAgICBpZiAoZ3VjLmV4ZWNidWZfY2xpZW50KQo+PiAtICAgICAg ICBjbGllbnQgPSAqZ3VjLmV4ZWNidWZfY2xpZW50Owo+PiArICAgIGZvcl9lYWNoX2VuZ2luZV9p ZChlbmdpbmUsIGRldl9wcml2LCBpZCkKPj4gKyAgICAgICAgaWYgKGd1Yy5leGVjX2NsaWVudHNb aWRdKQo+PiArICAgICAgICAgICAgY2xpZW50c1tpZF0gPSAqZ3VjLmV4ZWNfY2xpZW50c1tpZF07 Cj4+Cj4+ICAgICAgIG11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+Pgo+PiBAQCAt MjYwNiwxMSArMjYxMiwxOCBAQCBzdGF0aWMgaW50IGk5MTVfZ3VjX2luZm8oc3RydWN0IHNlcV9m aWxlICptLAo+PiB2b2lkICpkYXRhKQo+PiAgICAgICB9Cj4+ICAgICAgIHNlcV9wcmludGYobSwg Ilx0JXM6ICVsbHVcbiIsICJUb3RhbCIsIHRvdGFsKTsKPj4KPj4gLSAgICBzZXFfcHJpbnRmKG0s ICJcbkd1QyBleGVjYnVmIGNsaWVudCBAICVwOlxuIiwgZ3VjLmV4ZWNidWZfY2xpZW50KTsKPj4g LSAgICBpOTE1X2d1Y19jbGllbnRfaW5mbyhtLCBkZXZfcHJpdiwgJmNsaWVudCk7Cj4+ICsgICAg Zm9yX2VhY2hfZW5naW5lX2lkKGVuZ2luZSwgZGV2X3ByaXYsIGlkKSB7Cj4+ICsgICAgICAgIHNl cV9wcmludGYobSwgIlxuR3VDIGV4ZWNfY2xpZW50WyVkXSBAICVwOlxuIiwKPj4gKyAgICAgICAg ICAgICAgICBpZCwgZ3VjLmV4ZWNfY2xpZW50c1tpZF0pOwo+Cj4gTWlub3IgYW5kIG5vdCBhIGJs b2NrZXIgZm9yIHRoaXMgcGF0Y2gsIGJ1dCBJIHdvdWxkIHBvdGVudGlhbGx5Cj4gcmUtY29uc2lk ZXIgaWYgcHJpbnRpbmcgb3V0IHRoZSBjbGllbnQgcG9pbnRlciBpcyB1c2VmdWwuCgpJdCdzIHJl YWxseSBvbmx5IHVzZWZ1bCB0byBrbm93IHdoZXRoZXIgaXQncyBOVUxMIG9yIG5vdDsgYnV0IHBy aW50aW5nIAp0aGUgcG9pbnRlciBpdHNlbGYgaXMgc2ltcGxlciB0aGFuIHByaW50aW5nIGEgbWVz c2FnZSBzYXlpbmcgdGhhdC4gVGhpcyAKaXMgYSBkZWJ1Z2ZzIGludGVyZmFjZSwgc28gdGhlIGNv bnRlbnQgaXMgcHJldHR5IG11Y2ggYWQtaG9jLgoKLkRhdmUuCgo+PiArICAgICAgICBpZiAoZ3Vj LmV4ZWNfY2xpZW50c1tpZF0pCj4+ICsgICAgICAgICAgICBpOTE1X2d1Y19jbGllbnRfaW5mbyht LCBkZXZfcHJpdiwgJmNsaWVudHNbaWRdKTsKPj4gKyAgICB9Cj4+Cj4+ICAgICAgIC8qIEFkZCBt b3JlIGFzIHJlcXVpcmVkIC4uLiAqLwo+Pgo+PiArZG9uZToKPj4gKyAgICBrZnJlZShjbGllbnRz KTsKPj4gKwo+PiAgICAgICByZXR1cm4gMDsKPj4gICB9Cj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4gYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4gaW5kZXggZGM1ZjQ4NS4uYjBmOTk0NSAx MDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5j Cj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+PiBA QCAtNDM0LDcgKzQzNCw5IEBAIHN0YXRpYyB2b2lkIGd1Y19maW5pX2N0eF9kZXNjKHN0cnVjdCBp bnRlbF9ndWMgKmd1YywKPj4gICBpbnQgaTkxNV9ndWNfd3FfY2hlY2tfc3BhY2Uoc3RydWN0IGRy bV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+PiAgIHsKPj4gICAgICAgY29uc3Qgc2l6ZV90 IHdxaV9zaXplID0gc2l6ZW9mKHN0cnVjdCBndWNfd3FfaXRlbSk7Cj4+IC0gICAgc3RydWN0IGk5 MTVfZ3VjX2NsaWVudCAqZ2MgPSByZXF1ZXN0LT5pOTE1LT5ndWMuZXhlY2J1Zl9jbGllbnQ7Cj4+ ICsgICAgZW51bSBpbnRlbF9lbmdpbmVfaWQgZW5naW5lX2lkID0gcmVxdWVzdC0+ZW5naW5lLT5p ZDsKPj4gKyAgICBzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmcmVxdWVzdC0+aTkxNS0+Z3VjOwo+ PiArICAgIHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmdjID0gZ3VjLT5leGVjX2NsaWVudHNbZW5n aW5lX2lkXTsKPj4gICAgICAgc3RydWN0IGd1Y19wcm9jZXNzX2Rlc2MgKmRlc2M7Cj4+ICAgICAg IHUzMiBmcmVlc3BhY2U7Cj4+Cj4+IEBAIC01ODksNyArNTkxLDcgQEAgaW50IGk5MTVfZ3VjX3N1 Ym1pdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxKQo+PiAgIHsKPj4gICAgICAgdW5z aWduZWQgaW50IGVuZ2luZV9pZCA9IHJxLT5lbmdpbmUtPmlkOwo+PiAgICAgICBzdHJ1Y3QgaW50 ZWxfZ3VjICpndWMgPSAmcnEtPmk5MTUtPmd1YzsKPj4gLSAgICBzdHJ1Y3QgaTkxNV9ndWNfY2xp ZW50ICpjbGllbnQgPSBndWMtPmV4ZWNidWZfY2xpZW50Owo+PiArICAgIHN0cnVjdCBpOTE1X2d1 Y19jbGllbnQgKmNsaWVudCA9IGd1Yy0+ZXhlY19jbGllbnRzW2VuZ2luZV9pZF07Cj4+ICAgICAg IGludCBiX3JldDsKPj4KPj4gICAgICAgZ3VjX2FkZF93b3JrcXVldWVfaXRlbShjbGllbnQsIHJx KTsKPj4gQEAgLTcyMyw3ICs3MjUsNyBAQCBzdGF0aWMgYm9vbCBndWNfZG9vcmJlbGxfY2hlY2so c3RydWN0IGludGVsX2d1Ywo+PiAqZ3VjLCB1aW50MTZfdCBkYl9pZCkKPj4gICAgKi8KPj4gICBz dGF0aWMgdm9pZCBndWNfaW5pdF9kb29yYmVsbF9odyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4+ ICAgewo+PiAtICAgIHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCA9IGd1Yy0+ZXhlY2J1 Zl9jbGllbnQ7Cj4+ICsgICAgc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50ID0gZ3VjLT5l eGVjX2NsaWVudHNbUkNTXTsKPj4gICAgICAgdWludDE2X3QgZGJfaWQ7Cj4+ICAgICAgIGludCBp LCBlcnI7Cj4+Cj4+IEBAIC0xMDA0LDE3ICsxMDA2LDIxIEBAIGludCBpOTE1X2d1Y19zdWJtaXNz aW9uX2VuYWJsZShzdHJ1Y3QKPj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICAgewo+ PiAgICAgICBzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmZGV2X3ByaXYtPmd1YzsKPj4gICAgICAg c3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50Owo+PiArICAgIHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKmVuZ2luZTsKPj4KPj4gLSAgICAvKiBjbGllbnQgZm9yIGV4ZWNidWYgc3VibWlzc2lv biAqLwo+PiAtICAgIGNsaWVudCA9IGd1Y19jbGllbnRfYWxsb2MoZGV2X3ByaXYsCj4+IC0gICAg ICAgICAgICAgICAgICBHVUNfQ1RYX1BSSU9SSVRZX0tNRF9OT1JNQUwsCj4+IC0gICAgICAgICAg ICAgICAgICBkZXZfcHJpdi0+a2VybmVsX2NvbnRleHQpOwo+PiAtICAgIGlmICghY2xpZW50KSB7 Cj4+IC0gICAgICAgIERSTV9FUlJPUigiRmFpbGVkIHRvIGNyZWF0ZSBleGVjYnVmIGd1Y19jbGll bnRcbiIpOwo+PiAtICAgICAgICByZXR1cm4gLUVOT01FTTsKPj4gKyAgICBmb3JfZWFjaF9lbmdp bmUoZW5naW5lLCBkZXZfcHJpdikgewo+PiArICAgICAgICAvKiBjbGllbnQgZm9yIGV4ZWNidWYg c3VibWlzc2lvbiAqLwo+PiArICAgICAgICBjbGllbnQgPSBndWNfY2xpZW50X2FsbG9jKGRldl9w cml2LAo+PiArICAgICAgICAgICAgICAgICAgICAgIEdVQ19DVFhfUFJJT1JJVFlfS01EX05PUk1B TCwKPj4gKyAgICAgICAgICAgICAgICAgICAgICBkZXZfcHJpdi0+a2VybmVsX2NvbnRleHQpOwo+ PiArICAgICAgICBpZiAoIWNsaWVudCkgewo+PiArICAgICAgICAgICAgRFJNX0VSUk9SKCJGYWls ZWQgdG8gY3JlYXRlIEd1QyBjbGllbnQocylcbiIpOwo+PiArICAgICAgICAgICAgcmV0dXJuIC1F Tk9NRU07Cj4+ICsgICAgICAgIH0KPj4gKwo+PiArICAgICAgICBndWMtPmV4ZWNfY2xpZW50c1tl bmdpbmUtPmlkXSA9IGNsaWVudDsKPj4gICAgICAgfQo+Pgo+PiAtICAgIGd1Yy0+ZXhlY2J1Zl9j bGllbnQgPSBjbGllbnQ7Cj4+ICAgICAgIGhvc3QyZ3VjX3NhbXBsZV9mb3JjZXdha2UoZ3VjLCBj bGllbnQpOwo+PiAgICAgICBndWNfaW5pdF9kb29yYmVsbF9odyhndWMpOwo+Pgo+PiBAQCAtMTAy NCw5ICsxMDMwLDEyIEBAIGludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2VuYWJsZShzdHJ1Y3QKPj4g ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICAgdm9pZCBpOTE1X2d1Y19zdWJtaXNzaW9u X2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiAgIHsKPj4gICAg ICAgc3RydWN0IGludGVsX2d1YyAqZ3VjID0gJmRldl9wcml2LT5ndWM7Cj4+ICsgICAgc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+Pgo+PiAtICAgIGd1Y19jbGllbnRfZnJlZShkZXZf cHJpdiwgZ3VjLT5leGVjYnVmX2NsaWVudCk7Cj4+IC0gICAgZ3VjLT5leGVjYnVmX2NsaWVudCA9 IE5VTEw7Cj4+ICsgICAgZm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgZGV2X3ByaXYpIHsKPj4gKyAg ICAgICAgZ3VjX2NsaWVudF9mcmVlKGRldl9wcml2LCBndWMtPmV4ZWNfY2xpZW50c1tlbmdpbmUt PmlkXSk7Cj4+ICsgICAgICAgIGd1Yy0+ZXhlY19jbGllbnRzW2VuZ2luZS0+aWRdID0gTlVMTDsK Pj4gKyAgICB9Cj4+ICAgfQo+Pgo+PiAgIHZvaWQgaTkxNV9ndWNfc3VibWlzc2lvbl9maW5pKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Z3VjLmgKPj4gaW5kZXggM2UzZTc0My4uN2I0Y2M0ZCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjLmgKPj4gQEAgLTEzMiw3ICsxMzIsNyBAQCBzdHJ1Y3QgaW50ZWxfZ3VjIHsKPj4gICAg ICAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKmN0eF9wb29sX29iajsKPj4gICAgICAgc3Ry dWN0IGlkYSBjdHhfaWRzOwo+Pgo+PiAtICAgIHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmV4ZWNi dWZfY2xpZW50Owo+PiArICAgIHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmV4ZWNfY2xpZW50c1tJ OTE1X05VTV9FTkdJTkVTXTsKPj4KPj4gICAgICAgREVDTEFSRV9CSVRNQVAoZG9vcmJlbGxfYml0 bWFwLCBHVUNfTUFYX0RPT1JCRUxMUyk7Cj4+ICAgICAgIHVpbnQzMl90IGRiX2NhY2hlbGluZTsg ICAgICAgIC8qIEN5Y2xpYyBjb3VudGVyIG1vZCBwYWdlc2l6ZSAgICAqLwo+Pgo+Cj4gUmV2aWV3 ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4KPiBSZWdh cmRzLAo+IFR2cnRrbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==