From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 09/17] drm/i915: Debugfs support for GuC logging control Date: Wed, 20 Jul 2016 10:47:29 +0100 Message-ID: <578F48B1.2070207@linux.intel.com> References: <1468158084-22028-1-git-send-email-akash.goel@intel.com> <1468158084-22028-10-git-send-email-akash.goel@intel.com> <578E0E04.9070306@linux.intel.com> <32eb73ab-f808-a267-e459-29b428f84ec9@intel.com> <578F3F7D.2030101@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 007486E7C4 for ; Wed, 20 Jul 2016 09:47:31 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Goel, Akash" , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIwLzA3LzE2IDEwOjMyLCBHb2VsLCBBa2FzaCB3cm90ZToKPgo+Cj4gT24gNy8yMC8yMDE2 IDI6MzggUE0sIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Pgo+PiBPbiAyMC8wNy8xNiAwNTo0Miwg R29lbCwgQWthc2ggd3JvdGU6Cj4+PiBPbiA3LzE5LzIwMTYgNDo1NCBQTSwgVHZydGtvIFVyc3Vs aW4gd3JvdGU6Cj4+Pj4KPj4+PiBPbiAxMC8wNy8xNiAxNDo0MSwgYWthc2guZ29lbEBpbnRlbC5j b20gd3JvdGU6Cj4+Pj4+IEZyb206IFNhZ2FyIEFydW4gS2FtYmxlIDxzYWdhci5hLmthbWJsZUBp bnRlbC5jb20+Cj4+Pj4+Cj4+Pj4+IFRoaXMgcGF0Y2ggcHJvdmlkZXMgZGVidWdmcyBpbnRlcmZh Y2UgaTkxNV9ndWNfb3V0cHV0X2NvbnRyb2wgZm9yCj4+Pj4+IG9uIHRoZSBmbHkgZW5hYmxpbmcv ZGlzYWJsaW5nIG9mIGxvZ2dpbmcgaW4gR3VDIGZpcm13YXJlIGFuZAo+Pj4+PiBjb250cm9sbGlu Zwo+Pj4+PiB0aGUgdmVyYm9zaXR5IGxldmVsIG9mIGxvZ3MuCj4+Pj4+IFRoZSB2YWx1ZSB3cml0 dGVuIHRvIHRoZSBmaWxlLCBzaG91bGQgaGF2ZSBiaXQgMCBzZXQgdG8gZW5hYmxlIGxvZ2dpbmcK Pj4+Pj4gYW5kCj4+Pj4+IGJpdHMgNC03IHNob3VsZCBjb250YWluIHRoZSB2ZXJib3NpdHkgaW5m by4KPj4+Pj4KPj4+Pj4gdjI6IEFkZCBhIGZvcmNlZnVsIGZsdXNoLCB0byBjb2xsZWN0IGxlZnQg b3ZlciBsb2dzLCBvbiBkaXNhYmxpbmcKPj4+Pj4gbG9nZ2luZy4KPj4+Pj4gICAgICBVc2VmdWwg Zm9yIFZhbGlkYXRpb24uCj4+Pj4+Cj4+Pj4+IFNpZ25lZC1vZmYtYnk6IFNhZ2FyIEFydW4gS2Ft YmxlIDxzYWdhci5hLmthbWJsZUBpbnRlbC5jb20+Cj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEFrYXNo IEdvZWwgPGFrYXNoLmdvZWxAaW50ZWwuY29tPgo+Pj4+PiAtLS0KPj4+Pj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyAgICAgICAgfCAzMiArKysrKysrKysrKysrKysrLQo+ Pj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDU3Cj4+ Pj4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+Pj4+PiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2d1Yy5oICAgICAgICAgICB8ICAxICsKPj4+Pj4gICAzIGZpbGVzIGNoYW5n ZWQsIDg5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4+Pj4KPj4+Pj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4+Pj4+IGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4+Pj4gaW5kZXggNWUzNTU2NS4uM2M5YzdmNyAx MDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4+ Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4+Pj4gQEAgLTI2 NDQsNiArMjY0NCwzNSBAQCBzdGF0aWMgaW50IGk5MTVfZ3VjX2xvZ19kdW1wKHN0cnVjdCBzZXFf ZmlsZQo+Pj4+PiAqbSwgdm9pZCAqZGF0YSkKPj4+Pj4gICAgICAgcmV0dXJuIDA7Cj4+Pj4+ICAg fQo+Pj4+Pgo+Pj4+PiArc3RhdGljIGludAo+Pj4+PiAraTkxNV9ndWNfbG9nX2NvbnRyb2xfc2V0 KHZvaWQgKmRhdGEsIHU2NCB2YWwpCj4+Pj4+ICt7Cj4+Pj4+ICsgICAgc3RydWN0IGRybV9kZXZp Y2UgKmRldiA9IGRhdGE7Cj4+Pj4+ICsgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4+Pgo+Pj4+IHRvX2k5MTUgc2hvdWxkIGJlIHVzZWQu Cj4+PiBTb3JyeSBmb3IgbWlzc2luZyB0aGlzLCBuZWVkIHRvIHVzZSB0aGlzIGF0IG90aGVyIHBs YWNlcyBhbHNvLgo+Pj4KPj4+Pgo+Pj4+PiArICAgIGludCByZXQ7Cj4+Pj4+ICsKPj4+Pj4gKyAg ICByZXQgPSBtdXRleF9sb2NrX2ludGVycnVwdGlibGUoJmRldi0+c3RydWN0X211dGV4KTsKPj4+ Pj4gKyAgICBpZiAocmV0KQo+Pj4+PiArICAgICAgICByZXR1cm4gcmV0Owo+Pj4+PiArCj4+Pj4+ ICsgICAgaWYgKCFpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiB8fCAhZGV2X3ByaXYtPmd1Yy5s b2cub2JqKSB7Cj4+Pj4KPj4+PiBXb3VsZG4ndCBndWMubG9nLm9iaiBiZSBlbm91Z2g/Cj4+Pgo+ Pj4gQWN0dWFsbHkgZmFpbHVyZSBpbiBhbGxvY2F0aW9uIG9mIGxvZyBidWZmZXIsIGF0IGJvb3Qg dGltZSwgaXMgbm90Cj4+PiBjb25zaWRlcmVkIGZhdGFsIGFuZCBzdWJtaXNzaW9uIHRocm91Z2gg R3VDIGlzIHN0aWxsIGRvbmUuCj4+PiBTbyBpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiBjb3Vs ZCBiZSAxIHdpdGggZ3VjLmxvZy5vYmogYXMgTlVMTC4KPj4KPj4gSWYgZ3VjLmxvZy5vYmogaXMg TlVMTCBpdCB3aWxsIHJldHVybiAtRUlOVkFMIHdpdGhvdXQgdHJ5aW5nIHRvIGNyZWF0ZQo+PiBp dCBoZXJlLiBJZiB5b3UgaW50ZW5kZWQgZm9yIHRoaXMgZnVuY3Rpb24gdG8gdHJ5IGFuZCBjcmVh dGUgdGhlIGxvZwo+PiBvYmplY3QgaWYgbm90IGFscmVhZHkgcHJlc2VudCwgdmlhIGk5MTVfZ3Vj X2xvZ19jb250cm9sLCBpbiB0aGF0IGNhc2UKPj4gdGhlIGNvbmRpdGlvbiBhYm92ZSBzaG91bGQg b25seSBiZSBpZiAoIWk5MTUuZW5hYmxlX2d1Y19zdWJtaXNpc29uKSwgbm8/Cj4+Cj4gSWYgZ3Vj LmxvZy5vYmogaXMgZm91bmQgdG8gYmUgTlVMTCwgd2UgY29uc2lkZXIgbG9nZ2luZyBjYW4ndCBi ZSBlbmFibGVkCj4gYXQgcnVuIHRpbWUuIEFsbG9jYXRpb24gb2YgbG9nIGJ1ZmZlciBpcyBzdXBw b3NlZCB0byBkb25lCj4gYXQgYm9vdCB0aW1lIG9ubHksIG90aGVyd2lzZSBHdUMgd291bGQgaGF2 ZSB0byBiZSByZXNldCAmIGZpcm13YXJlIHRvIGJlCj4gcmVsb2FkZWQgdG8gcGFzcyB0aGUgbG9n IGJ1ZmZlciBhZGRyZXNzIGF0IHJ1biB0aW1lLCB3aGljaCBpcyBwcm9iYWJseQo+IG5vdCBkZXNp cmFibGUuIFRoYXQncyB3aHkgaW4gdGhlIGZpcnN0IHBhdGNoIGRlY291cGxlZCB0aGUgYWxsb2Nh dGlvbiBvZgo+IGxvZyBidWZmZXIgZnJvbSBsb2dfbGV2ZWwgdmFsdWUuCgpPa2F5IHNvIHdoeSB0 aGVuIHRoZSBjaGVjayBhYm92ZSBzaG91bGRuJ3QganVzdCBiZTsKCglpZiAoIWRldl9wcml2LT5n dWMubG9nLm9iaikKCmFzIEkgb3JpZ2luYWxseSBzdWdnZXN0ZWQ/Cgo+Cj4+Pj4KPj4+Pj4gKyAg ICAgICAgcmV0ID0gLUVJTlZBTDsKPj4+Pj4gKyAgICAgICAgZ290byBlbmQ7Cj4+Pj4+ICsgICAg fQo+Pj4+PiArCj4+Pj4+ICsgICAgaW50ZWxfcnVudGltZV9wbV9nZXQoZGV2X3ByaXYpOwo+Pj4+ PiArICAgIHJldCA9IGk5MTVfZ3VjX2xvZ19jb250cm9sKGRldiwgdmFsKTsKPj4+Pj4gKyAgICBp bnRlbF9ydW50aW1lX3BtX3B1dChkZXZfcHJpdik7Cj4+Pj4+ICsKPj4+Pj4gK2VuZDoKPj4+Pj4g KyAgICBtdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPj4+Pj4gKyAgICByZXR1cm4g cmV0Owo+Pj4+PiArfQo+Pj4+PiArCj4+Pj4+ICtERUZJTkVfU0lNUExFX0FUVFJJQlVURShpOTE1 X2d1Y19sb2dfY29udHJvbF9mb3BzLAo+Pj4+PiArICAgICAgICAgICAgTlVMTCwgaTkxNV9ndWNf bG9nX2NvbnRyb2xfc2V0LAo+Pj4+PiArICAgICAgICAgICAgIjB4JTA4bGx4XG4iKTsKPj4+Pgo+ Pj4+IERvZXMgdGhlIHJlYWRiYWNrIHN0aWxsIHdvcmsgd2l0aCBubyBnZXQgbWV0aG9kPwo+Pj4K Pj4+IHJlYWRiYWNrIHdpbGwgZ2l2ZSBhICdQZXJtaXNzaW9uIGRlbmllZCcgZXJyb3IKPj4KPj4g SXMgdGhhdCB3aGF0IHdlIHdhbnQ/IEkgdGhpbmsgaXQgd291bGQgYmUgbmljZSB0byBhbGxvdyBy ZWFkLWJhY2sgdW5sZXNzCj4+IHRoZXJlIGlzIGEgc3BlY2lmaWMgcmVhc29uIHdoeSBpdCBzaG91 bGRuJ3QgYmUgYWxsb3dlZC4KPj4KPgo+IE9rIGNhbiBpbXBsZW1lbnQgYSBkdW1teSByZWFkIGJh Y2sgZnVuY3Rpb24gYnV0IHdoYXQgc2hvdWxkIGJlCj4gc2hvd24vcmV0dXJuZWQgb24gcmVhZC4K Pgo+IFNob3VsZCBJIHNob3cvcmV0dXJuIHRoZSBndWNfbG9nX2xldmVsIHZhbHVlICh3aGljaCBp cyBhbHNvIGF2YWlsYWJsZQo+IGZyb20gL3N5cy9tb2R1bGUvaTkxNS9wYXJhbWV0ZXJzLykgPwoK SSB3b3VsZCByZXR1cm4gdGhlIHNhbWUgdmFsdWUgdGhhdCB3YXMgd3JpdHRlbiBpbi4gSXMgdGhl IHByb2JsZW0gdGhhdCAKaXQgaXMgbm90IHN0b3JlZCBhbnl3aGVyZT8gTWF5YmUgcmVjb25zdHJ1 Y3QgaXQgZnJvbQppOTE1Lmd1Y19sb2dfbGV2ZWwgPwoKQWx0aG91Z2ggaXQgaXMgbm90IGlkZWFs IHRoYXQgd2UgZ290IHR3byBmb3JtYXRzIGZvciB0aGUgc2FtZSB0aGluZy4gClRoaW5raW5nIGFi b3V0IHRoYXQsIHdoeSBub3QgdXNlIHRoZSBzYW1lIGZvcm1hdCBpbiBkZWJ1Z2ZzIGFzIGZvciB0 aGUgCm1vZHVsZSBwYXJhbT8KCkFuZCBJIGZvcmdvdCwgaTkxNS5ndWNfbG9nX2xldmVsID09IDAg aXMgbG9nZ2luZyBlbmFibGVkIHdpdGggbWluaW11bSAKdmVyYm9zaXR5PwoKSXMgaXQgdG9vIGxh dGUgdG8gY2hhbmdlIHRoYXQ/IDopCgpSZWdhcmRzLAoKVHZydGtvCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK