From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH 4/9] drm/i915: Wrap drm_gem_object_reference in i915_gem_object_get Date: Wed, 20 Jul 2016 12:38:24 +0100 Message-ID: <578F62B0.3020403@intel.com> References: <1469005202-9659-1-git-send-email-chris@chris-wilson.co.uk> <1469005202-9659-5-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id E36AF6E206 for ; Wed, 20 Jul 2016 11:38:48 +0000 (UTC) In-Reply-To: <1469005202-9659-5-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjAvMDcvMTYgMDk6NTksIENocmlzIFdpbHNvbiB3cm90ZToKPiBTaWduZWQtb2ZmLWJ5OiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICAgICB8IDExICsrKysrKysrKysrCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgICAgICAgfCAgNCArKy0tCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9kbWFidWYuYyAgICAgfCAgMyArLS0KPiAgIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V2aWN0LmMgICAgICB8ICAyICstCj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMgfCAgNCArKy0tCj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zaHJpbmtlci5jICAgfCAgMiArLQo+ICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fdXNlcnB0ci5jICAgIHwgIDMgKy0tCj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgICAgICAgfCAgMyArLS0KPiAgIDggZmlsZXMg Y2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmgKPiBpbmRleCA0N2YyNDRmOWM2NGUuLjE2M2QyOGU4ZTkyYyAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0yMzA2LDYgKzIzMDYsMTcgQEAgX19kZXByZWNhdGVk Cj4gICBleHRlcm4gc3RydWN0IGRybV9nZW1fb2JqZWN0ICoKPiAgIGRybV9nZW1fb2JqZWN0X2xv b2t1cChzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUsIHUzMiBoYW5kbGUpOwo+Cj4gK19fYXR0cmlidXRl X18oKG5vbm51bGwpKQo+ICtzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0 ICoKPiAraTkxNV9nZW1fb2JqZWN0X2dldChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2Jq KQo+ICt7Cj4gKwlkcm1fZ2VtX29iamVjdF9yZWZlcmVuY2UoJm9iai0+YmFzZSk7Cj4gKwlyZXR1 cm4gb2JqOwo+ICt9Cj4gKwo+ICtfX2RlcHJlY2F0ZWQKPiArZXh0ZXJuIHZvaWQgZHJtX2dlbV9v YmplY3RfcmVmZXJlbmNlKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqKTsKPiArCj4gICBzdGF0aWMg aW5saW5lIGJvb2wKPiAgIGk5MTVfZ2VtX29iamVjdF9oYXNfc3RydWN0X3BhZ2UoY29uc3Qgc3Ry dWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPiAgIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPiBpbmRleCA5NzA0OTY0MTkwOTguLmY4ODZjMGJiMjRjYSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW0uYwo+IEBAIC0yODksNyArMjg5LDcgQEAgZHJvcF9wYWdlcyhzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX29iamVjdCAqb2JqKQo+ICAgCXN0cnVjdCBpOTE1X3ZtYSAqdm1hLCAqbmV4dDsKPiAg IAlpbnQgcmV0Owo+Cj4gLQlkcm1fZ2VtX29iamVjdF9yZWZlcmVuY2UoJm9iai0+YmFzZSk7Cj4g KwlpOTE1X2dlbV9vYmplY3RfZ2V0KG9iaik7Cj4gICAJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZl KHZtYSwgbmV4dCwgJm9iai0+dm1hX2xpc3QsIG9ial9saW5rKQo+ICAgCQlpZiAoaTkxNV92bWFf dW5iaW5kKHZtYSkpCj4gICAJCQlicmVhazsKPiBAQCAtMjM2MSw3ICsyMzYxLDcgQEAgdm9pZCBp OTE1X3ZtYV9tb3ZlX3RvX2FjdGl2ZShzdHJ1Y3QgaTkxNV92bWEgKnZtYSwKPgo+ICAgCS8qIEFk ZCBhIHJlZmVyZW5jZSBpZiB3ZSdyZSBuZXdseSBlbnRlcmluZyB0aGUgYWN0aXZlIGxpc3QuICov Cj4gICAJaWYgKG9iai0+YWN0aXZlID09IDApCj4gLQkJZHJtX2dlbV9vYmplY3RfcmVmZXJlbmNl KCZvYmotPmJhc2UpOwo+ICsJCWk5MTVfZ2VtX29iamVjdF9nZXQob2JqKTsKPiAgIAlvYmotPmFj dGl2ZSB8PSBpbnRlbF9lbmdpbmVfZmxhZyhlbmdpbmUpOwo+Cj4gICAJbGlzdF9tb3ZlX3RhaWwo Jm9iai0+ZW5naW5lX2xpc3RbZW5naW5lLT5pZF0sICZlbmdpbmUtPmFjdGl2ZV9saXN0KTsKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZG1hYnVmLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9kbWFidWYuYwo+IGluZGV4IDdkMDhhYzA4YzQwMS4u M2EwMGFiM2FkMDZlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt X2RtYWJ1Zi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZG1hYnVmLmMK PiBAQCAtMjc4LDggKzI3OCw3IEBAIHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqaTkxNV9nZW1fcHJp bWVfaW1wb3J0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gICAJCQkgKiBJbXBvcnRpbmcgZG1h YnVmIGV4cG9ydGVkIGZyb20gb3V0IG93biBnZW0gaW5jcmVhc2VzCj4gICAJCQkgKiByZWZjb3Vu dCBvbiBnZW0gaXRzZWxmIGluc3RlYWQgb2YgZl9jb3VudCBvZiBkbWFidWYuCj4gICAJCQkgKi8K PiAtCQkJZHJtX2dlbV9vYmplY3RfcmVmZXJlbmNlKCZvYmotPmJhc2UpOwo+IC0JCQlyZXR1cm4g Jm9iai0+YmFzZTsKPiArCQkJcmV0dXJuICZpOTE1X2dlbV9vYmplY3RfZ2V0KG9iaiktPmJhc2U7 CgpUaGlzIHdvdWxkIGJlIGEgZ29vZCBwbGFjZSB0byB3cml0ZQoKCXJldHVybiB0b19nZW1fb2Jq ZWN0KGk5MTVfZ2VtX29iamVjdF9nZXQob2JqKSk7CgppZiB5b3UgaGFkIGEgdG9fZ2VtX29iamVj dCgpIGZ1bmN0aW9uIDopCgo+ICAgCQl9Cj4gICAJfQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V2aWN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9ldmljdC5jCj4gaW5kZXggYjExOTRjN2MwYTQ4Li41NjEwMzk0OGVlMTYgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXZpY3QuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V2aWN0LmMKPiBAQCAtMTgzLDcgKzE4Myw3IEBAIGZv dW5kOgo+ICAgCQkJCSAgICAgICBleGVjX2xpc3QpOwo+ICAgCQlpZiAoZHJtX21tX3NjYW5fcmVt b3ZlX2Jsb2NrKCZ2bWEtPm5vZGUpKSB7Cj4gICAJCQlsaXN0X21vdmUoJnZtYS0+ZXhlY19saXN0 LCAmZXZpY3Rpb25fbGlzdCk7Cj4gLQkJCWRybV9nZW1fb2JqZWN0X3JlZmVyZW5jZSgmdm1hLT5v YmotPmJhc2UpOwo+ICsJCQlpOTE1X2dlbV9vYmplY3RfZ2V0KHZtYS0+b2JqKTsKPiAgIAkJCWNv bnRpbnVlOwo+ICAgCQl9Cj4gICAJCWxpc3RfZGVsX2luaXQoJnZtYS0+ZXhlY19saXN0KTsKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gaW5kZXggNTUxZGQ0 ZjU0OWZhLi4yOGJjYzk5YTBjYzEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW1fZXhlY2J1ZmZlci5jCj4gQEAgLTEyMyw3ICsxMjMsNyBAQCBlYl9sb29rdXBfdm1hcyhzdHJ1 Y3QgZWJfdm1hcyAqZWIsCj4gICAJCQlnb3RvIGVycjsKPiAgIAkJfQo+Cj4gLQkJZHJtX2dlbV9v YmplY3RfcmVmZXJlbmNlKCZvYmotPmJhc2UpOwo+ICsJCWk5MTVfZ2VtX29iamVjdF9nZXQob2Jq KTsKPiAgIAkJbGlzdF9hZGRfdGFpbCgmb2JqLT5vYmpfZXhlY19saW5rLCAmb2JqZWN0cyk7Cj4g ICAJfQo+ICAgCXNwaW5fdW5sb2NrKCZmaWxlLT50YWJsZV9sb2NrKTsKPiBAQCAtMTIzNiw3ICsx MjM2LDcgQEAgaTkxNV9nZW1fZXhlY2J1ZmZlcl9wYXJzZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUsCj4gICAJdm1hID0gaTkxNV9nZW1fb2JqX3RvX2dndHQoc2hhZG93X2JhdGNoX29i aik7Cj4gICAJdm1hLT5leGVjX2VudHJ5ID0gc2hhZG93X2V4ZWNfZW50cnk7Cj4gICAJdm1hLT5l eGVjX2VudHJ5LT5mbGFncyA9IF9fRVhFQ19PQkpFQ1RfSEFTX1BJTjsKPiAtCWRybV9nZW1fb2Jq ZWN0X3JlZmVyZW5jZSgmc2hhZG93X2JhdGNoX29iai0+YmFzZSk7Cj4gKwlpOTE1X2dlbV9vYmpl Y3RfZ2V0KHNoYWRvd19iYXRjaF9vYmopOwo+ICAgCWxpc3RfYWRkX3RhaWwoJnZtYS0+ZXhlY19s aXN0LCAmZWItPnZtYXMpOwo+Cj4gICAJc2hhZG93X2JhdGNoX29iai0+YmFzZS5wZW5kaW5nX3Jl YWRfZG9tYWlucyA9IEk5MTVfR0VNX0RPTUFJTl9DT01NQU5EOwo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zaHJpbmtlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW1fc2hyaW5rZXIuYwo+IGluZGV4IDZmMTBiNDIxNDg3Yi4uM2FhNzZkMzYwOGVh IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3Nocmlua2VyLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zaHJpbmtlci5jCj4gQEAgLTE5 MCw3ICsxOTAsNyBAQCBpOTE1X2dlbV9zaHJpbmsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LAo+ICAgCQkJaWYgKCFjYW5fcmVsZWFzZV9wYWdlcyhvYmopKQo+ICAgCQkJCWNvbnRp bnVlOwo+Cj4gLQkJCWRybV9nZW1fb2JqZWN0X3JlZmVyZW5jZSgmb2JqLT5iYXNlKTsKPiArCQkJ aTkxNV9nZW1fb2JqZWN0X2dldChvYmopOwo+Cj4gICAJCQkvKiBGb3IgdGhlIHVuYm91bmQgcGhh c2UsIHRoaXMgc2hvdWxkIGJlIGEgbm8tb3AhICovCj4gICAJCQlsaXN0X2Zvcl9lYWNoX2VudHJ5 X3NhZmUodm1hLCB2LAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV91c2VycHRyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV91c2VycHRyLmMKPiBp bmRleCBiYTE2ZTA0NGZhYzYuLmM0MWJmNzRmOTI2ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbV91c2VycHRyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbV91c2VycHRyLmMKPiBAQCAtNjIyLDggKzYyMiw3IEBAIF9faTkxNV9nZW1fdXNl cnB0cl9nZXRfcGFnZXNfc2NoZWR1bGUoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwK PiAgIAlvYmotPnVzZXJwdHIud29yayA9ICZ3b3JrLT53b3JrOwo+ICAgCW9iai0+dXNlcnB0ci53 b3JrZXJzKys7Cj4KPiAtCXdvcmstPm9iaiA9IG9iajsKPiAtCWRybV9nZW1fb2JqZWN0X3JlZmVy ZW5jZSgmb2JqLT5iYXNlKTsKPiArCXdvcmstPm9iaiA9IGk5MTVfZ2VtX29iamVjdF9nZXQob2Jq KTsKPgo+ICAgCXdvcmstPnRhc2sgPSBjdXJyZW50Owo+ICAgCWdldF90YXNrX3N0cnVjdCh3b3Jr LT50YXNrKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggNzdkMzIw NTg0NDc4Li44NDkwNGEyZDNmY2QgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gQEAgLTExNjQ5LDcgKzExNjQ5LDYgQEAgc3RhdGljIGludCBpbnRlbF9jcnRjX3BhZ2Vf ZmxpcChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4KPiAgIAkvKiBSZWZlcmVuY2UgdGhlIG9iamVj dHMgZm9yIHRoZSBzY2hlZHVsZWQgd29yay4gKi8KPiAgIAlkcm1fZnJhbWVidWZmZXJfcmVmZXJl bmNlKHdvcmstPm9sZF9mYik7Cj4gLQlkcm1fZ2VtX29iamVjdF9yZWZlcmVuY2UoJm9iai0+YmFz ZSk7Cj4KPiAgIAljcnRjLT5wcmltYXJ5LT5mYiA9IGZiOwo+ICAgCXVwZGF0ZV9zdGF0ZV9mYihj cnRjLT5wcmltYXJ5KTsKPiBAQCAtMTE2NTcsNyArMTE2NTYsNyBAQCBzdGF0aWMgaW50IGludGVs X2NydGNfcGFnZV9mbGlwKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgIAlpbnRlbF9mYmNfcHJl X3VwZGF0ZShpbnRlbF9jcnRjLCBpbnRlbF9jcnRjLT5jb25maWcsCj4gICAJCQkgICAgIHRvX2lu dGVsX3BsYW5lX3N0YXRlKHByaW1hcnktPnN0YXRlKSk7Cj4KPiAtCXdvcmstPnBlbmRpbmdfZmxp cF9vYmogPSBvYmo7Cj4gKwl3b3JrLT5wZW5kaW5nX2ZsaXBfb2JqID0gaTkxNV9nZW1fb2JqZWN0 X2dldChvYmopOwo+Cj4gICAJcmV0ID0gaTkxNV9tdXRleF9sb2NrX2ludGVycnVwdGlibGUoZGV2 KTsKPiAgIAlpZiAocmV0KQoKVGhpcyBsYXN0IG9uZSBtb3ZlcyB0aGUgcG9pbnQgYXQgd2hpY2gg dGhlIHJlZmVyZW5jZSBpcyB0YWtlbiBwYXN0IApzZXZlcmFsIGZ1bmN0aW9uIGNhbGxzOyBpcyB0 aGF0IGludGVudGlvbmFsLCBvciBhdCBsZWFzdCBoYXJtbGVzcz8KCldpdGggdGhhdCBhbnN3ZXJl ZCwgdGhlbgoKUmV2aWV3ZWQtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5j b20+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK