public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Dave Gordon <david.s.gordon@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@gmail.com>,
	Carlos Santa <carlos.santa@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 07/23] drm/i915: Move HAS_GUC_UCODE definition to platform definition
Date: Thu, 21 Jul 2016 18:10:10 +0100	[thread overview]
Message-ID: <579101F2.50801@intel.com> (raw)
In-Reply-To: <5790A62B.6080208@linux.intel.com>

On 21/07/16 11:38, Tvrtko Ursulin wrote:
>
> On 20/07/16 22:07, Rodrigo Vivi wrote:
>> please kill this _ucode variation that is just a alias to guc instead....
>
> Not sure, it was added with a particular goal. Cc Dave in case he wants
> to comment.
>
> Regards,
> Tvrtko

The comment is already in the source code, just above the lines that 
this patch changes.

.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-07-21 17:10 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 17:40 [PATCH 00/23] drm/i915: Organize most GPU features by platform Carlos Santa
2016-07-20 17:40 ` [PATCH 01/23] drm/i915: Move HAS_PSR definition to platform struct definition Carlos Santa
2016-07-20 20:16   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 02/23] drm/i915: Introduce GEN6_FEATURES for device info Carlos Santa
2016-07-20 20:17   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 03/23] drm/i915: Move HAS_RUNTIME_PM definition to platform Carlos Santa
2016-07-20 20:25   ` Rodrigo Vivi
2016-07-21 13:34     ` Imre Deak
2016-08-09 13:49       ` Ville Syrjälä
2016-08-11 23:38         ` Carlos Santa
2016-08-01 13:02   ` Jani Nikula
2016-07-20 17:40 ` [PATCH 04/23] drm/i915: Move HAS_CORE_RING_FREQ definition to platform definition Carlos Santa
2016-07-20 20:28   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 05/23] drm/i915: Move HAS_CSR " Carlos Santa
2016-07-20 21:04   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 06/23] drm/i915: Move HAS_GUC " Carlos Santa
2016-07-20 17:40 ` [PATCH 07/23] drm/i915: Move HAS_GUC_UCODE " Carlos Santa
2016-07-20 21:07   ` Rodrigo Vivi
2016-07-21 10:38     ` Tvrtko Ursulin
2016-07-21 17:10       ` Dave Gordon [this message]
2016-08-02 10:10         ` Dave Gordon
2016-08-02 14:16           ` Daniel Vetter
2016-08-04 10:13             ` Dave Gordon
2016-07-20 17:40 ` [PATCH 08/23] drm/i915: Move HAS_GUC_SCHED " Carlos Santa
2016-07-20 21:07   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 09/23] drm/i915: Move HAS_RESOURCE_STREAMER " Carlos Santa
2016-07-20 21:14   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 10/23] drm/i915: Move HAS_RC6 " Carlos Santa
2016-07-20 21:16   ` Rodrigo Vivi
2016-07-21 10:50   ` Tvrtko Ursulin
2016-07-21 16:45     ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 11/23] drm/i915: Move HAS_RC6p " Carlos Santa
2016-07-20 21:18   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 12/23] drm/i915: Move HAS_DP_MST " Carlos Santa
2016-07-20 21:21   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 13/23] drm/i915: Introduce GEN5_FEATURES for device info Carlos Santa
2016-07-20 21:22   ` Rodrigo Vivi
2016-07-20 21:24     ` Rodrigo Vivi
2016-08-01 13:05   ` Jani Nikula
2016-07-20 17:40 ` [PATCH 14/23] drm/i915: Move HAS_AUX_IRQ definition to platform definition Carlos Santa
2016-07-20 21:40   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 15/23] drm/i915: Move HAS_GMBUS_IRQ " Carlos Santa
2016-07-20 21:41   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 16/23] drm/i915: Introduce GEN4_FEATURES for device info Carlos Santa
2016-07-20 21:44   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 17/23] drm/i915: Introduce GEN3_FEATURES " Carlos Santa
2016-07-20 21:45   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 18/23] drm/i915: Introduce GEN2 FEATURES " Carlos Santa
2016-07-20 21:47   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 19/23] drm/915: Move HAS_FW_BLC definition to platform Carlos Santa
2016-07-20 21:48   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 20/23] drm/i915: Move HAS_HW_CONTEXTS " Carlos Santa
2016-07-20 21:49   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 21/23] drm/i915: Move HAS_LOGICAL_RING_CONTEXTS definition to platform definition Carlos Santa
2016-07-20 21:51   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 22/23] drm/i915: Move HAS_L3_DPF " Carlos Santa
2016-07-20 21:52   ` Rodrigo Vivi
2016-07-20 17:40 ` [PATCH 23/23] drm/i915: Move HAS_GMCH_DISPLAY definition to platform Carlos Santa
2016-07-20 21:55   ` Rodrigo Vivi
2016-07-21  6:11 ` ✗ Ro.CI.BAT: failure for drm/i915: Organize most GPU features by platform Patchwork
2016-08-01 13:08 ` [PATCH 00/23] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=579101F2.50801@intel.com \
    --to=david.s.gordon@intel.com \
    --cc=carlos.santa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@gmail.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox