From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH v2 5/6] drm/i915/guc: use
 for_each_engine_id() where appropriate
Date: Fri, 22 Jul 2016 11:45:41 +0100
Message-ID: <5791F955.5050300@intel.com>
References: <1469124942-17943-1-git-send-email-david.s.gordon@intel.com>
 <1469124942-17943-6-git-send-email-david.s.gordon@intel.com>
 <5791EF98.10908@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTP id 218F86EB35
 for <intel-gfx@lists.freedesktop.org>; Fri, 22 Jul 2016 10:45:43 +0000 (UTC)
In-Reply-To: <5791EF98.10908@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMjIvMDcvMTYgMTE6MDQsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMjEvMDcvMTYg
MTk6MTUsIERhdmUgR29yZG9uIHdyb3RlOgo+PiBOb3cgdGhhdCBob3N0IHN0cnVjdHVyZXMgYXJl
IGluZGV4ZWQgYnkgaG9zdCBlbmdpbmUtaWQgcmF0aGVyIHRoYW4KPj4gZ3VjX2lkLCB3ZSBjYW4g
dXNlZnVsbHkgY29udmVydCBzb21lIGZvcl9lYWNoX2VuZ2luZSgpIGxvb3BzIHRvIHVzZQo+PiBm
b3JfZWFjaF9lbmdpbmVfaWQoKSBhbmQgYXZvaWQgbXVsdGlwbGUgZGVyZWZlcmVuY2VzIG9mIGVu
Z2luZS0+aWQuCj4+Cj4+IEFsc28gYSBmZXcgcmVsYXRlZCB0d2Vha3MgdG8gY2FjaGUgc3RydWN0
dXJlIG1lbWJlcnMgbG9jYWxseSB3aGVyZXZlcgo+PiB0aGV5J3JlIHVzZWQgbW9yZSB0aGFuIG9u
Y2Ugb3IgdHdpY2UsIGhvcGVmdWxseSBlbGltaW5hdGluZyBtZW1vcnkKPj4gcmVmZXJlbmNlcy4K
Pj4KPj4gU2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNv
bT4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgICAgICAg
IHwgMTcgKysrKysrKysrLS0tLS0tLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1
Y19zdWJtaXNzaW9uLmMgfCAyMiArKysrKysrKysrKysrLS0tLS0tLS0tCj4+ICAgMiBmaWxlcyBj
aGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4+IGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4gaW5kZXggNzkzYjFkOS4uMjEwNjc2NiAxMDA2NDQK
Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4gQEAgLTI1MzUsNiArMjUzNSw3IEBA
IHN0YXRpYyB2b2lkIGk5MTVfZ3VjX2NsaWVudF9pbmZvKHN0cnVjdCBzZXFfZmlsZQo+PiAqbSwK
Pj4gICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCkKPj4g
ICB7Cj4+ICAgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZTsKPj4gKyAgICBlbnVt
IGludGVsX2VuZ2luZV9pZCBpZDsKPj4gICAgICAgdWludDY0X3QgdG90ID0gMDsKPj4KPj4gICAg
ICAgc2VxX3ByaW50ZihtLCAiXHRQcmlvcml0eSAlZCwgR3VDIGN0eCBpbmRleDogJXUsIFBEIG9m
ZnNldCAweCV4XG4iLAo+PiBAQCAtMjU0OSwxMSArMjU1MCwxMSBAQCBzdGF0aWMgdm9pZCBpOTE1
X2d1Y19jbGllbnRfaW5mbyhzdHJ1Y3QKPj4gc2VxX2ZpbGUgKm0sCj4+ICAgICAgIHNlcV9wcmlu
dGYobSwgIlx0RmFpbGVkIGRvb3JiZWxsOiAldVxuIiwgY2xpZW50LT5iX2ZhaWwpOwo+PiAgICAg
ICBzZXFfcHJpbnRmKG0sICJcdExhc3Qgc3VibWlzc2lvbiByZXN1bHQ6ICVkXG4iLCBjbGllbnQt
PnJldGNvZGUpOwo+Pgo+PiAtICAgIGZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2KSB7
Cj4+ICsgICAgZm9yX2VhY2hfZW5naW5lX2lkKGVuZ2luZSwgZGV2X3ByaXYsIGlkKSB7Cj4+ICsg
ICAgICAgIHU2NCBzdWJtaXNzaW9ucyA9IGNsaWVudC0+c3VibWlzc2lvbnNbaWRdOwo+PiArICAg
ICAgICB0b3QgKz0gc3VibWlzc2lvbnM7Cj4+ICAgICAgICAgICBzZXFfcHJpbnRmKG0sICJcdFN1
Ym1pc3Npb25zOiAlbGx1ICVzXG4iLAo+PiAtICAgICAgICAgICAgICAgIGNsaWVudC0+c3VibWlz
c2lvbnNbZW5naW5lLT5pZF0sCj4+IC0gICAgICAgICAgICAgICAgZW5naW5lLT5uYW1lKTsKPj4g
LSAgICAgICAgdG90ICs9IGNsaWVudC0+c3VibWlzc2lvbnNbZW5naW5lLT5pZF07Cj4+ICsgICAg
ICAgICAgICAgICAgc3VibWlzc2lvbnMsIGVuZ2luZS0+bmFtZSk7Cj4+ICAgICAgIH0KPj4gICAg
ICAgc2VxX3ByaW50ZihtLCAiXHRUb3RhbDogJWxsdVxuIiwgdG90KTsKPj4gICB9Cj4+IEBAIC0y
NTk4LDExICsyNTk5LDExIEBAIHN0YXRpYyBpbnQgaTkxNV9ndWNfaW5mbyhzdHJ1Y3Qgc2VxX2Zp
bGUgKm0sCj4+IHZvaWQgKmRhdGEpCj4+ICAgICAgIHNlcV9wcmludGYobSwgIkd1QyBsYXN0IGFj
dGlvbiBlcnJvciBjb2RlOiAlZFxuIiwgZ3VjLmFjdGlvbl9lcnIpOwo+Pgo+PiAgICAgICBzZXFf
cHJpbnRmKG0sICJcbkd1QyBzdWJtaXNzaW9uczpcbiIpOwo+PiAtICAgIGZvcl9lYWNoX2VuZ2lu
ZShlbmdpbmUsIGRldl9wcml2KSB7Cj4+ICsgICAgZm9yX2VhY2hfZW5naW5lX2lkKGVuZ2luZSwg
ZGV2X3ByaXYsIGlkKSB7Cj4+ICsgICAgICAgIHU2NCBzdWJtaXNzaW9ucyA9IGd1Yy5zdWJtaXNz
aW9uc1tpZF07Cj4+ICsgICAgICAgIHRvdGFsICs9IHN1Ym1pc3Npb25zOwo+PiAgICAgICAgICAg
c2VxX3ByaW50ZihtLCAiXHQlLTI0czogJTEwbGx1LCBsYXN0IHNlcW5vIDB4JTA4eFxuIiwKPj4g
LSAgICAgICAgICAgIGVuZ2luZS0+bmFtZSwgZ3VjLnN1Ym1pc3Npb25zW2VuZ2luZS0+aWRdLAo+
PiAtICAgICAgICAgICAgZ3VjLmxhc3Rfc2Vxbm9bZW5naW5lLT5pZF0pOwo+PiAtICAgICAgICB0
b3RhbCArPSBndWMuc3VibWlzc2lvbnNbZW5naW5lLT5pZF07Cj4+ICsgICAgICAgICAgICBlbmdp
bmUtPm5hbWUsIHN1Ym1pc3Npb25zLCBndWMubGFzdF9zZXFub1tpZF0pOwo+PiAgICAgICB9Cj4+
ICAgICAgIHNlcV9wcmludGYobSwgIlx0JXM6ICVsbHVcbiIsICJUb3RhbCIsIHRvdGFsKTsKPj4K
Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24u
Ywo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+PiBpbmRl
eCA2NzU2ZGIwLi5lY2UzNDc5IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n
dWNfc3VibWlzc2lvbi5jCj4+IEBAIC0zNDIsNyArMzQyLDggQEAgc3RhdGljIHZvaWQgZ3VjX2lu
aXRfY3R4X2Rlc2Moc3RydWN0IGludGVsX2d1YyAqZ3VjLAo+Pgo+PiAgICAgICBmb3JfZWFjaF9l
bmdpbmVfbWFza2VkKGVuZ2luZSwgZGV2X3ByaXYsIGNsaWVudC0+ZW5naW5lcykgewo+PiAgICAg
ICAgICAgc3RydWN0IGludGVsX2NvbnRleHQgKmNlID0gJmN0eC0+ZW5naW5lW2VuZ2luZS0+aWRd
Owo+PiAtICAgICAgICBzdHJ1Y3QgZ3VjX2V4ZWNsaXN0X2NvbnRleHQgKmxyYyA9ICZkZXNjLmxy
Y1tlbmdpbmUtPmd1Y19pZF07Cj4+ICsgICAgICAgIHVpbnQzMl90IGd1Y19lbmdpbmVfaWQgPSBl
bmdpbmUtPmd1Y19pZDsKPj4gKyAgICAgICAgc3RydWN0IGd1Y19leGVjbGlzdF9jb250ZXh0ICps
cmMgPSAmZGVzYy5scmNbZ3VjX2VuZ2luZV9pZF07Cj4+ICAgICAgICAgICBzdHJ1Y3QgZHJtX2k5
MTVfZ2VtX29iamVjdCAqb2JqOwo+Pgo+PiAgICAgICAgICAgLyogVE9ETzogV2UgaGF2ZSBhIGRl
c2lnbiBpc3N1ZSB0byBiZSBzb2x2ZWQgaGVyZS4gT25seSB3aGVuIHdlCj4+IEBAIC0zNjEsNyAr
MzYyLDcgQEAgc3RhdGljIHZvaWQgZ3VjX2luaXRfY3R4X2Rlc2Moc3RydWN0IGludGVsX2d1YyAq
Z3VjLAo+PiAgICAgICAgICAgZ2Z4X2FkZHIgPSBpOTE1X2dlbV9vYmpfZ2d0dF9vZmZzZXQoY2Ut
PnN0YXRlKTsKPj4gICAgICAgICAgIGxyYy0+cmluZ19sY3JhID0gZ2Z4X2FkZHIgKyBMUkNfU1RB
VEVfUE4gKiBQQUdFX1NJWkU7Cj4+ICAgICAgICAgICBscmMtPmNvbnRleHRfaWQgPSAoY2xpZW50
LT5jdHhfaW5kZXggPDwgR1VDX0VMQ19DVFhJRF9PRkZTRVQpIHwKPj4gLSAgICAgICAgICAgICAg
ICAoZW5naW5lLT5ndWNfaWQgPDwgR1VDX0VMQ19FTkdJTkVfT0ZGU0VUKTsKPj4gKyAgICAgICAg
ICAgICAgICAoZ3VjX2VuZ2luZV9pZCA8PCBHVUNfRUxDX0VOR0lORV9PRkZTRVQpOwo+Pgo+PiAg
ICAgICAgICAgb2JqID0gY2UtPnJpbmdidWYtPm9iajsKPj4gICAgICAgICAgIGdmeF9hZGRyID0g
aTkxNV9nZW1fb2JqX2dndHRfb2Zmc2V0KG9iaik7Cj4+IEBAIC0zNzEsNyArMzcyLDcgQEAgc3Rh
dGljIHZvaWQgZ3VjX2luaXRfY3R4X2Rlc2Moc3RydWN0IGludGVsX2d1YyAqZ3VjLAo+PiAgICAg
ICAgICAgbHJjLT5yaW5nX25leHRfZnJlZV9sb2NhdGlvbiA9IGdmeF9hZGRyOwo+PiAgICAgICAg
ICAgbHJjLT5yaW5nX2N1cnJlbnRfdGFpbF9wb2ludGVyX3ZhbHVlID0gMDsKPj4KPj4gLSAgICAg
ICAgZGVzYy5lbmdpbmVzX3VzZWQgfD0gKDEgPDwgZW5naW5lLT5ndWNfaWQpOwo+PiArICAgICAg
ICBkZXNjLmVuZ2luZXNfdXNlZCB8PSAoMSA8PCBndWNfZW5naW5lX2lkKTsKPj4gICAgICAgfQo+
Pgo+PiAgICAgICBEUk1fREVCVUdfRFJJVkVSKCJIb3N0IGVuZ2luZXMgMHgleCA9PiBHdUMgZW5n
aW5lcyB1c2VkIDB4JXhcbiIsCj4+IEBAIC00NjEsNiArNDYyLDcgQEAgc3RhdGljIHZvaWQgZ3Vj
X2FkZF93b3JrcXVldWVfaXRlbShzdHJ1Y3QKPj4gaTkxNV9ndWNfY2xpZW50ICpnYywKPj4gICAg
ICAgLyogd3FpX2xlbiBpcyBpbiBEV29yZHMsIGFuZCBkb2VzIG5vdCBpbmNsdWRlIHRoZSBvbmUt
d29yZAo+PiBoZWFkZXIgKi8KPj4gICAgICAgY29uc3Qgc2l6ZV90IHdxaV9zaXplID0gc2l6ZW9m
KHN0cnVjdCBndWNfd3FfaXRlbSk7Cj4+ICAgICAgIGNvbnN0IHUzMiB3cWlfbGVuID0gd3FpX3Np
emUvc2l6ZW9mKHUzMikgLSAxOwo+PiArICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2lu
ZSA9IHJxLT5lbmdpbmU7Cj4+ICAgICAgIHN0cnVjdCBndWNfcHJvY2Vzc19kZXNjICpkZXNjOwo+
PiAgICAgICBzdHJ1Y3QgZ3VjX3dxX2l0ZW0gKndxaTsKPj4gICAgICAgdm9pZCAqYmFzZTsKPj4g
QEAgLTUwMiwxMiArNTA0LDExIEBAIHN0YXRpYyB2b2lkIGd1Y19hZGRfd29ya3F1ZXVlX2l0ZW0o
c3RydWN0Cj4+IGk5MTVfZ3VjX2NsaWVudCAqZ2MsCj4+ICAgICAgIC8qIE5vdyBmaWxsIGluIHRo
ZSA0LXdvcmQgd29yayBxdWV1ZSBpdGVtICovCj4+ICAgICAgIHdxaS0+aGVhZGVyID0gV1FfVFlQ
RV9JTk9SREVSIHwKPj4gICAgICAgICAgICAgICAod3FpX2xlbiA8PCBXUV9MRU5fU0hJRlQpIHwK
Pj4gLSAgICAgICAgICAgIChycS0+ZW5naW5lLT5ndWNfaWQgPDwgV1FfVEFSR0VUX1NISUZUKSB8
Cj4+ICsgICAgICAgICAgICAoZW5naW5lLT5ndWNfaWQgPDwgV1FfVEFSR0VUX1NISUZUKSB8Cj4+
ICAgICAgICAgICAgICAgV1FfTk9fV0NGTFVTSF9XQUlUOwo+Pgo+PiAgICAgICAvKiBUaGUgR3VD
IHdhbnRzIG9ubHkgdGhlIGxvdy1vcmRlciB3b3JkIG9mIHRoZSBjb250ZXh0Cj4+IGRlc2NyaXB0
b3IgKi8KPj4gLSAgICB3cWktPmNvbnRleHRfZGVzYyA9ICh1MzIpaW50ZWxfbHJfY29udGV4dF9k
ZXNjcmlwdG9yKHJxLT5jdHgsCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBy
cS0+ZW5naW5lKTsKPj4gKyAgICB3cWktPmNvbnRleHRfZGVzYyA9ICh1MzIpaW50ZWxfbHJfY29u
dGV4dF9kZXNjcmlwdG9yKHJxLT5jdHgsCj4+IGVuZ2luZSk7Cj4+Cj4+ICAgICAgIHdxaS0+cmlu
Z190YWlsID0gdGFpbCA8PCBXUV9SSU5HX1RBSUxfU0hJRlQ7Cj4+ICAgICAgIHdxaS0+ZmVuY2Vf
aWQgPSBycS0+ZmVuY2Uuc2Vxbm87Cj4+IEBAIC0xMDM1LDExICsxMDM2LDE0IEBAIGludCBpOTE1
X2d1Y19zdWJtaXNzaW9uX2VuYWJsZShzdHJ1Y3QKPj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By
aXYpCj4+ICAgdm9pZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1
X3ByaXZhdGUgKmRldl9wcml2KQo+PiAgIHsKPj4gICAgICAgc3RydWN0IGludGVsX2d1YyAqZ3Vj
ID0gJmRldl9wcml2LT5ndWM7Cj4+ICsgICAgc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqKmdjX3B0
cjsKPj4gICAgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+PiArICAgIGVudW0g
aW50ZWxfZW5naW5lX2lkIGVuZ2luZV9pZDsKPj4KPj4gLSAgICBmb3JfZWFjaF9lbmdpbmUoZW5n
aW5lLCBkZXZfcHJpdikgewo+PiAtICAgICAgICBndWNfY2xpZW50X2ZyZWUoZGV2X3ByaXYsIGd1
Yy0+ZXhlY19jbGllbnRzW2VuZ2luZS0+aWRdKTsKPj4gLSAgICAgICAgZ3VjLT5leGVjX2NsaWVu
dHNbZW5naW5lLT5pZF0gPSBOVUxMOwo+PiArICAgIGZvcl9lYWNoX2VuZ2luZV9pZChlbmdpbmUs
IGRldl9wcml2LCBlbmdpbmVfaWQpIHsKPj4gKyAgICAgICAgZ2NfcHRyID0gJmd1Yy0+ZXhlY19j
bGllbnRzW2VuZ2luZV9pZF07Cj4+ICsgICAgICAgIGd1Y19jbGllbnRfZnJlZShkZXZfcHJpdiwg
KmdjX3B0cik7Cj4+ICsgICAgICAgICpnY19wdHIgPSBOVUxMOwo+PiAgICAgICB9Cj4+ICAgfQo+
Pgo+Pgo+Cj4gRGlkbid0IHNwb3QgYSBkaWZmZXJlbmNlIGZyb20gdjEgd2hpY2ggSSByZXZpZXdl
ZCBiZWZvcmUuIFdoYXQgaXMgbmV3IGluCj4gdjI/Cj4KPiBSZXZpZXdlZC1ieTogVHZydGtvIFVy
c3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPgo+IFJlZ2FyZHMsCj4gVHZydGtvCgpO
b3RoaW5nIGRpZmZlcmVudCBpbiB0aGlzIHBhdGNoOyBpdCdzIHYyIG9mIHRoZSBzZXQsIG5vdCBv
ZiBlYWNoIHBhdGNoIAp3aXRoaW4gaXQuIE5vdGljZSBpbiBwYXJ0aWN1bGFyIHRoZSBwcmVzZW5j
ZSBvZiBhIGNvdmVyIGxldHRlciAoYXMgaXQncyAKbW9yZSB0aGFuIGEgc2luZ2xlIHBhdGNoKSwg
YXMgYWdyZWVkIGF0IHllc3RlcmRheSdzIFRlY2ggRm9ydW0uCgpCdXQgSSBvbmx5IGZvdW5kIFIt
QidzIGZyb20geW91IGZvciB2MSAzLzUgYW5kIDQvNTsgd2UgZGlzY3Vzc2VkIDEvNSBhbmQgCjIv
NSBvZmZsaW5lIGJ1dCBBRkFJQ1QgeW91IGRpZG4ndCBwb3N0IGFuIFItQiBmb3IgdGhlbT8KCi5E
YXZlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50
ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==