Re: [PATCH v3] drm/i915: Replace gen6 semaphore signal table with code

Chris Wilson
2016-07-21T14:34:32Z

On Thu, Jul 21, 2016 at 02:46:01PM +0100, Tvrtko Ursulin wrote:
>
> On 21/07/16 14:31, Chris Wilson wrote:
> >Hmm. This was in intel_ringbuffer.c, at least I assumed so as this only
> >applies to legacy submission, for gen6-7.
>
> It uses the static intel_engines array since the dev_priv->engines
> are not initialized yet by the time it runs, for an engine.

Hmm, right.

> Could as an alternative make the engine init phase multi-pass.
> Maybe. Not sure what repercussions for the cleanup path that would
> have.

Or expose the intel_engines[] array. Double pass (setup, then init) is
better than exposing the array. I think I am preferring that and trying
to keep the semaphore logic in the intel_ringbuffer.c silo.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre