Re: [PATCH 0/4]: Picture aspect ratio support in DRM layer

Sharma, Shashank
2016-08-03T15:33:48Z

> Patch series seems to have 0 changelogs anywhere, but I'm pretty sure I've seen this before. > > Please try again and state what changed and why you are resubmitting this.
> -Daniel

Hi Daniel,
This is a re-spin of the patch series for aspect ratio support.
The first four patches dint get reviewed for a long time, so I sent it again.
https://patchwork.freedesktop.org/patch/78308/

You gave review comments on the fifth patch, which was In I915, so I kept that patch away from this series, and made this as DRM layer only. So this series contains only 4 patches.
https://patchwork.freedesktop.org/patch/78178/

We can decide for I915, if we want to keep the aspect ratio property or not, internally.
You are more than welcome to review this series :).

Regards
Shashank
-----Original Message-----
From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter
Sent: Wednesday, August 3, 2016 5:18 PM
To: Sharma, Shashank <shashank.sharma@intel.com>
Cc: dri-devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; ville.syrjala@linux.intel.com; rodrigo.vivi@gmail.com; Vetter, Daniel <daniel.vetter@intel.com>
Subject: Re: [PATCH 0/4]: Picture aspect ratio support in DRM layer

On Wed, Aug 03, 2016 at 04:26:24PM +0530, Shashank Sharma wrote:
> This patch series adds 4 patches.
> - The first two patches add aspect ratio support in DRM layes
> - Next two patches add new aspect ratios defined in CEA-861-F
> supported for HDMI 2.0 4k modes.
>
> Adding aspect ratio support in DRM layer:
> - The CEA videmodes contain aspect ratio information, which we
> parse when we read the modes from EDID. But while transforming
> user_mode to kernel_mode or viceversa, DRM layer lose this
> information.
> - HDMI compliance testing for CEA modes, expects the AVI info frames
> to contain exact VIC no for the 'video mode under test'. Now CEA
> modes have different VIC for same modes but different aspect ratio
> for example:
> VIC 2 = 720x480@60 4:3
> VIC 3 = 720x480@60 16:9
> In this way, lack of aspect ratio information, can cause wrong VIC
> no in AVI IF, causing HDMI complaince test to fail.
> - This patch set adds code, which embeds the aspect ratio information
> also in DRM video mode flags, and uses it while comparing two modes.
>
> Adding new aspect ratios for HDMI 2.0
> - CEA-861-F defines two new aspect ratios, to be used for 4k HDMI 2.0
> modes.
> - 64:27
> - 256:135
> Last two patches in the series, adds code to handle these new aspect
> ratios.
>
> Shashank Sharma (4):
> drm: add picture aspect ratio flags
> drm: Add aspect ratio parsing in DRM layer
> video: Add new aspect ratios for HDMI 2.0
> drm: Add and handle new aspect ratios in DRM layer

Patch series seems to have 0 changelogs anywhere, but I'm pretty sure I've seen this before. Please try again and state what changed and why you are resubmitting this.
-Daniel

>
> drivers/gpu/drm/drm_modes.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> drivers/video/hdmi.c | 4 ++++
> include/linux/hdmi.h | 2 ++
> include/uapi/drm/drm_mode.h | 24 +++++++++++++++++++-----
> 4 files changed, 68 insertions(+), 5 deletions(-)
>
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation