Re: [PATCH 1/4] drm: add picture aspect ratio flags

Sharma, Shashank
2016-08-04T09:19:17Z

Thanks for the review, Sean.

My comments, inline.

Regards
Shashank
On 8/3/2016 11:10 PM, Sean Paul wrote:
> On Wed, Aug 3, 2016 at 6:56 AM, Shashank Sharma
> <shashank.sharma@intel.com> wrote:
>> This patch adds drm flag bits for aspect ratio information
>>
>> Currently drm flag bits don't have field for mode's picture
>> aspect ratio. This field will help the driver to pick mode with
>> right aspect ratio, and help in setting right VIC field in avi
>> infoframes.
>>
>> Signed-off-by: Shashank Sharma <shashank.sharma@intel.com>
>> ---
>> include/uapi/drm/drm_mode.h | 18 +++++++++++++-----
>> 1 file changed, 13 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
>> index 49a7265..cd66a95 100644
>> --- a/include/uapi/drm/drm_mode.h
>> +++ b/include/uapi/drm/drm_mode.h
>> @@ -77,6 +77,19 @@ extern "C" {
>> #define DRM_MODE_FLAG_3D_TOP_AND_BOTTOM (7<<14)
>> #define DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF (8<<14)
>>
>> +/* Picture aspect ratio options */
>> +#define DRM_MODE_PICTURE_ASPECT_NONE 0
>> +#define DRM_MODE_PICTURE_ASPECT_4_3 1
>> +#define DRM_MODE_PICTURE_ASPECT_16_9 2
>> +
>> +/* Aspect ratio flag bitmask (4 bits 22:19) */
>> +#define DRM_MODE_FLAG_PARMASK (0x0F<<19)
>> +#define DRM_MODE_FLAG_PARNONE \
>> + (DRM_MODE_PICTURE_ASPECT_NONE << 19)
> While I prefer the spaces in between the << operator, it seems like
> convention in this file is to not have them.
I agree, I will remove the spaces.
>
>> +#define DRM_MODE_FLAG_PAR4_3 \
>> + (DRM_MODE_PICTURE_ASPECT_4_3 << 19)
>> +#define DRM_MODE_FLAG_PAR16_9 \
>> + (DRM_MODE_PICTURE_ASPECT_16_9 << 19)
> Not crazy about "PAR". Perhaps DRM_MODE_FLAG_ASPECT_BLAH would be more
> descriptive?
Ok, let me come up with something which rhymes with BLAH :)

Regards
Shashank
>> /* DPMS flags */
>> /* bit compatible with the xorg definitions. */
>> @@ -92,11 +105,6 @@ extern "C" {
>> #define DRM_MODE_SCALE_CENTER 2 /* Centered, no scaling */
>> #define DRM_MODE_SCALE_ASPECT 3 /* Full screen, preserve aspect */
>>
>> -/* Picture aspect ratio options */
>> -#define DRM_MODE_PICTURE_ASPECT_NONE 0
>> -#define DRM_MODE_PICTURE_ASPECT_4_3 1
>> -#define DRM_MODE_PICTURE_ASPECT_16_9 2
>> -
>> /* Dithering mode options */
>> #define DRM_MODE_DITHERING_OFF 0
>> #define DRM_MODE_DITHERING_ON 1
>> --
>> 1.9.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel