From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 11/18] drm/i915: Optimization to reduce the sampling time of GuC log buffer Date: Mon, 15 Aug 2016 16:36:40 +0100 Message-ID: <57B1E188.40406@linux.intel.com> References: <1471272599-14586-1-git-send-email-akash.goel@intel.com> <1471272599-14586-12-git-send-email-akash.goel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 538E46E067 for ; Mon, 15 Aug 2016 15:36:42 +0000 (UTC) In-Reply-To: <1471272599-14586-12-git-send-email-akash.goel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: akash.goel@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE1LzA4LzE2IDE1OjQ5LCBha2FzaC5nb2VsQGludGVsLmNvbSB3cm90ZToKPiBGcm9tOiBB a2FzaCBHb2VsIDxha2FzaC5nb2VsQGludGVsLmNvbT4KPgo+IEd1QyBmaXJtd2FyZSBzZW5kcyBh biBpbnRlcnJ1cHQgdG8gZmx1c2ggdGhlIGxvZyBidWZmZXIgd2hlbiBpdCBiZWNvbWVzCj4gaGFs ZiBmdWxsLCBzbyBEcml2ZXIgZG9lc24ndCByZWFsbHkgbmVlZCB0byBzYW1wbGUgdGhlIGNvbXBs ZXRlIGJ1ZmZlcgo+IGFuZCBjYW4ganVzdCBjb3B5IG9ubHkgdGhlIG5ld2x5IHdyaXR0ZW4gZGF0 YSBieSBHdUMgaW50byB0aGUgbG9jYWwKPiBidWZmZXIsIGkuZS4gYXMgcGVyIHRoZSByZWFkICYg d3JpdGUgcG9pbnRlciB2YWx1ZXMuCj4gTW9yZW92ZXIgdGhlIGZsdXNoIGludGVycnVwdCB3b3Vs ZCBnZW5lcmFsbHkgY29tZSBmb3Igb25lIHR5cGUgb2YgbG9nCj4gYnVmZmVyLCB3aGVuIGl0IGJl Y29tZXMgaGFsZiBmdWxsLCBzbyBhdCB0aGF0IHRpbWUgdGhlIG90aGVyIDIgdHlwZXMgb2YKPiBs b2cgYnVmZmVyIHdvdWxkIGNvbXBhcmF0aXZlbHkgaGF2ZSBtdWNoIGxlc3NlciB1bnJlYWQgZGF0 YSBpbiB0aGVtLgo+IEluIGNhc2Ugb2Ygb3ZlcmZsb3cgcmVwb3J0ZWQgYnkgR3VDLCBEcml2ZXIg ZG8gbmVlZCB0byBjb3B5IHRoZSBlbnRpcmUKPiBidWZmZXIgYXMgdGhlIHdob2xlIGJ1ZmZlciB3 b3VsZCBjb250YWluIHRoZSB1bnJlYWQgZGF0YS4KPgo+IHYyOiBSZWJhc2UuCj4KPiB2MzogRml4 IHRoZSBibG9vcGVyIG9mIGRvaW5nIHRoZSBjb3B5IHR3aWNlLiAoVHZydGtvKQo+Cj4gU2lnbmVk LW9mZi1ieTogQWthc2ggR29lbCA8YWthc2guZ29lbEBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgfCA0MCArKysrKysrKysrKysr KysrKysrKysrKysrLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCA2 IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z3VjX3N1Ym1pc3Npb24uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Np b24uYwo+IGluZGV4IGM3YjRhNTcuLmI4ZDYzMTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gQEAgLTEwMDMsNiArMTAwMyw4IEBAIHN0YXRpYyB2 b2lkIGd1Y19yZWFkX3VwZGF0ZV9sb2dfYnVmZmVyKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAg IAl2b2lkICpzcmNfZGF0YV9wdHIsICpkc3RfZGF0YV9wdHI7Cj4gICAJdW5zaWduZWQgaW50IGJ1 ZmZlcl9zaXplLCBleHBlY3RlZF9zaXplOwo+ICAgCWVudW0gZ3VjX2xvZ19idWZmZXJfdHlwZSB0 eXBlOwo+ICsJdW5zaWduZWQgaW50IHJlYWRfb2Zmc2V0LCB3cml0ZV9vZmZzZXQsIGJ5dGVzX3Rv X2NvcHk7Cj4gKwlib29sIG5ld19vdmVyZmxvdzsKPgo+ICAgCWlmIChXQVJOX09OKCFndWMtPmxv Zy5idWZfYWRkcikpCj4gICAJCXJldHVybjsKPiBAQCAtMTAyNSwxMSArMTAyNywxNCBAQCBzdGF0 aWMgdm9pZCBndWNfcmVhZF91cGRhdGVfbG9nX2J1ZmZlcihzdHJ1Y3QgaW50ZWxfZ3VjICpndWMp Cj4gICAJCW1lbWNweSgmbG9nX2J1ZmZlcl9zdGF0ZV9sb2NhbCwgbG9nX2J1ZmZlcl9zdGF0ZSwK PiAgIAkJICAgICAgIHNpemVvZihzdHJ1Y3QgZ3VjX2xvZ19idWZmZXJfc3RhdGUpKTsKPiAgIAkJ YnVmZmVyX3NpemUgPSBsb2dfYnVmZmVyX3N0YXRlX2xvY2FsLnNpemU7Cj4gKwkJcmVhZF9vZmZz ZXQgPSBsb2dfYnVmZmVyX3N0YXRlX2xvY2FsLnJlYWRfcHRyOwo+ICsJCXdyaXRlX29mZnNldCA9 IGxvZ19idWZmZXJfc3RhdGVfbG9jYWwuc2FtcGxlZF93cml0ZV9wdHI7Cj4KPiAgIAkJLyogQm9v a2tlZXBpbmcgc3R1ZmYgKi8KPiAgIAkJZ3VjLT5sb2cuZmx1c2hfY291bnRbdHlwZV0gKz0gbG9n X2J1ZmZlcl9zdGF0ZV9sb2NhbC5mbHVzaF90b19maWxlOwo+ICAgCQlpZiAobG9nX2J1ZmZlcl9z dGF0ZV9sb2NhbC5idWZmZXJfZnVsbF9jbnQgIT0KPiAgIAkJICAgIGd1Yy0+bG9nLnByZXZfb3Zl cmZsb3dfY291bnRbdHlwZV0pIHsKPiArCQkJbmV3X292ZXJmbG93ID0gMTsKPiAgIAkJCWd1Yy0+ bG9nLnRvdGFsX292ZXJmbG93X2NvdW50W3R5cGVdICs9Cj4gICAJCQkJKGxvZ19idWZmZXJfc3Rh dGVfbG9jYWwuYnVmZmVyX2Z1bGxfY250IC0KPiAgIAkJCQkgZ3VjLT5sb2cucHJldl9vdmVyZmxv d19jb3VudFt0eXBlXSk7Cj4gQEAgLTEwNDMsNyArMTA0OCw4IEBAIHN0YXRpYyB2b2lkIGd1Y19y ZWFkX3VwZGF0ZV9sb2dfYnVmZmVyKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIAkJCWd1Yy0+ bG9nLnByZXZfb3ZlcmZsb3dfY291bnRbdHlwZV0gPQo+ICAgCQkJCQlsb2dfYnVmZmVyX3N0YXRl X2xvY2FsLmJ1ZmZlcl9mdWxsX2NudDsKPiAgIAkJCURSTV9FUlJPUl9SQVRFTElNSVRFRCgiR3VD IGxvZyBidWZmZXIgb3ZlcmZsb3dcbiIpOwo+IC0JCX0KPiArCQl9IGVsc2UKPiArCQkJbmV3X292 ZXJmbG93ID0gMDsKCk5pdHBpY2s6IG5vcm1hbGx5IHRoZSBydWxlIGlzIGlmIG9uZSBicmFuY2gg aGFzIGN1cmxpZXMgYWxsIG9mIHRoZW0gaGF2ZSAKdG8uIENoZWNrcGF0Y2ggSSB0aGluayB3YXJu cyBhYm91dCB0aGF0LCBvciBtYXliZSBvbmx5IGluIHN0cmljdCBtb2RlLgoKPgo+ICAgCQlpZiAo bG9nX2J1ZmZlcl9zbmFwc2hvdF9zdGF0ZSkgewo+ICAgCQkJLyogRmlyc3QgY29weSB0aGUgc3Rh dGUgc3RydWN0dXJlIGluIHNuYXBzaG90IGJ1ZmZlciAqLwo+IEBAIC0xMDU1LDggKzEwNjEsNyBA QCBzdGF0aWMgdm9pZCBndWNfcmVhZF91cGRhdGVfbG9nX2J1ZmZlcihzdHJ1Y3QgaW50ZWxfZ3Vj ICpndWMpCj4gICAJCQkgKiBmb3IgY29uc2lzdGVuY3kgc2V0IHRoZSB3cml0ZSBwb2ludGVyIHZh bHVlIHRvIHNhbWUKPiAgIAkJCSAqIHZhbHVlIG9mIHNhbXBsZWRfd3JpdGVfcHRyIGluIHRoZSBz bmFwc2hvdCBidWZmZXIuCj4gICAJCQkgKi8KPiAtCQkJbG9nX2J1ZmZlcl9zbmFwc2hvdF9zdGF0 ZS0+d3JpdGVfcHRyID0KPiAtCQkJCWxvZ19idWZmZXJfc25hcHNob3Rfc3RhdGUtPnNhbXBsZWRf d3JpdGVfcHRyOwo+ICsJCQlsb2dfYnVmZmVyX3NuYXBzaG90X3N0YXRlLT53cml0ZV9wdHIgPSB3 cml0ZV9vZmZzZXQ7Cj4KPiAgIAkJCWxvZ19idWZmZXJfc25hcHNob3Rfc3RhdGUrKzsKPgo+IEBA IC0xMDc5LDcgKzEwODQsMzEgQEAgc3RhdGljIHZvaWQgZ3VjX3JlYWRfdXBkYXRlX2xvZ19idWZm ZXIoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ICAgCQkJCWJ1ZmZlcl9zaXplID0gZXhwZWN0ZWRf c2l6ZTsKPiAgIAkJCX0KPgo+IC0JCQltZW1jcHkoZHN0X2RhdGFfcHRyLCBzcmNfZGF0YV9wdHIs IGJ1ZmZlcl9zaXplKTsKPiArCQkJaWYgKHVubGlrZWx5KG5ld19vdmVyZmxvdykpIHsKPiArCQkJ CS8qIGNvcHkgdGhlIHdob2xlIGJ1ZmZlciBpbiBjYXNlIG9mIG92ZXJmbG93ICovCj4gKwkJCQly ZWFkX29mZnNldCA9IDA7Cj4gKwkJCQl3cml0ZV9vZmZzZXQgPSBidWZmZXJfc2l6ZTsKPiArCQkJ fSBlbHNlIGlmICh1bmxpa2VseSgocmVhZF9vZmZzZXQgPiBidWZmZXJfc2l6ZSkgfHwKPiArCQkJ CQkgICAgKHdyaXRlX29mZnNldCA+IGJ1ZmZlcl9zaXplKSkpIHsKCkNvdWxkIGFsc28gY2hlY2sg Zm9yIHJlYWRfb2Zmc2V0ID09IHdyaXRlX29mZnNldCBmb3IgZXZlbiBtb3JlIHNhZmV0eT8KCj4g KwkJCQlEUk1fRVJST1IoImludmFsaWQgbG9nIGJ1ZmZlciBzdGF0ZVxuIik7Cj4gKwkJCQkvKiBj b3B5IHdob2xlIGJ1ZmZlciBhcyBvZmZzZXRzIGFyZSB1bnJlbGlhYmxlICovCj4gKwkJCQlyZWFk X29mZnNldCA9IDA7Cj4gKwkJCQl3cml0ZV9vZmZzZXQgPSBidWZmZXJfc2l6ZTsKPiArCQkJfQo+ ICsKPiArCQkJLyogSnVzdCBjb3B5IHRoZSBuZXdseSB3cml0dGVuIGRhdGEgKi8KPiArCQkJaWYg KHJlYWRfb2Zmc2V0IDw9IHdyaXRlX29mZnNldCkgewo+ICsJCQkJYnl0ZXNfdG9fY29weSA9IHdy aXRlX29mZnNldCAtIHJlYWRfb2Zmc2V0Owo+ICsJCQkJbWVtY3B5KGRzdF9kYXRhX3B0ciArIHJl YWRfb2Zmc2V0LAo+ICsJCQkJICAgICAgIHNyY19kYXRhX3B0ciArIHJlYWRfb2Zmc2V0LCBieXRl c190b19jb3B5KTsKPiArCQkJfSBlbHNlIHsKPiArCQkJCWJ5dGVzX3RvX2NvcHkgPSBidWZmZXJf c2l6ZSAtIHJlYWRfb2Zmc2V0Owo+ICsJCQkJbWVtY3B5KGRzdF9kYXRhX3B0ciArIHJlYWRfb2Zm c2V0LAo+ICsJCQkJICAgICAgIHNyY19kYXRhX3B0ciArIHJlYWRfb2Zmc2V0LCBieXRlc190b19j b3B5KTsKPiArCj4gKwkJCQlieXRlc190b19jb3B5ID0gd3JpdGVfb2Zmc2V0Owo+ICsJCQkJbWVt Y3B5KGRzdF9kYXRhX3B0ciwgc3JjX2RhdGFfcHRyLCBieXRlc190b19jb3B5KTsKPiArCQkJfQo+ Cj4gICAJCQlzcmNfZGF0YV9wdHIgKz0gYnVmZmVyX3NpemU7Cj4gICAJCQlkc3RfZGF0YV9wdHIg Kz0gYnVmZmVyX3NpemU7Cj4gQEAgLTEwODgsOCArMTExNyw3IEBAIHN0YXRpYyB2b2lkIGd1Y19y ZWFkX3VwZGF0ZV9sb2dfYnVmZmVyKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIAkJLyogRklY TUU6IGludmFsaWRhdGUvZmx1c2ggZm9yIGxvZyBidWZmZXIgbmVlZGVkICovCj4KPiAgIAkJLyog VXBkYXRlIHRoZSByZWFkIHBvaW50ZXIgaW4gdGhlIHNoYXJlZCBsb2cgYnVmZmVyICovCj4gLQkJ bG9nX2J1ZmZlcl9zdGF0ZS0+cmVhZF9wdHIgPQo+IC0JCQlsb2dfYnVmZmVyX3N0YXRlX2xvY2Fs LnNhbXBsZWRfd3JpdGVfcHRyOwo+ICsJCWxvZ19idWZmZXJfc3RhdGUtPnJlYWRfcHRyID0gd3Jp dGVfb2Zmc2V0Owo+Cj4gICAJCS8qIENsZWFyIHRoZSAnZmx1c2ggdG8gZmlsZScgZmxhZyAqLwo+ ICAgCQlsb2dfYnVmZmVyX3N0YXRlLT5mbHVzaF90b19maWxlID0gMDsKPgoKTG9va3MgT0sgdG8g bWUuCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNv bT4KClJlZ2FyZHMsCgpUdnJ0a28KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=