From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 15/18] drm/i915: Debugfs support for GuC logging control Date: Mon, 15 Aug 2016 17:03:25 +0100 Message-ID: <57B1E7CD.5000709@linux.intel.com> References: <1471272599-14586-1-git-send-email-akash.goel@intel.com> <1471272599-14586-16-git-send-email-akash.goel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 1384A6E5A8 for ; Mon, 15 Aug 2016 16:03:38 +0000 (UTC) In-Reply-To: <1471272599-14586-16-git-send-email-akash.goel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: akash.goel@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE1LzA4LzE2IDE1OjQ5LCBha2FzaC5nb2VsQGludGVsLmNvbSB3cm90ZToKPiBGcm9tOiBT YWdhciBBcnVuIEthbWJsZSA8c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPgo+Cj4gVGhpcyBwYXRj aCBwcm92aWRlcyBkZWJ1Z2ZzIGludGVyZmFjZSBpOTE1X2d1Y19vdXRwdXRfY29udHJvbCBmb3IK PiBvbiB0aGUgZmx5IGVuYWJsaW5nL2Rpc2FibGluZyBvZiBsb2dnaW5nIGluIEd1QyBmaXJtd2Fy ZSBhbmQgY29udHJvbGxpbmcKPiB0aGUgdmVyYm9zaXR5IGxldmVsIG9mIGxvZ3MuCj4gVGhlIHZh bHVlIHdyaXR0ZW4gdG8gdGhlIGZpbGUsIHNob3VsZCBoYXZlIGJpdCAwIHNldCB0byBlbmFibGUg bG9nZ2luZyBhbmQKPiBiaXRzIDQtNyBzaG91bGQgY29udGFpbiB0aGUgdmVyYm9zaXR5IGluZm8u Cj4KPiB2MjogQWRkIGEgZm9yY2VmdWwgZmx1c2gsIHRvIGNvbGxlY3QgbGVmdCBvdmVyIGxvZ3Ms IG9uIGRpc2FibGluZyBsb2dnaW5nLgo+ICAgICAgVXNlZnVsIGZvciBWYWxpZGF0aW9uLgo+Cj4g djM6IEJlc2lkZXMgbWlub3IgY2xlYW51cCwgaW1wbGVtZW50IHJlYWQgbWV0aG9kIGZvciB0aGUg ZGVidWdmcyBmaWxlIGFuZAo+ICAgICAgc2V0IHRoZSBndWNfbG9nX2xldmVsIHRvIC0xIHdoZW4g bG9nZ2luZyBpcyBkaXNhYmxlZC4gKFR2cnRrbykKPgo+IHY0OiBNaW5vciBjbGVhbnVwICYgcmVi YXNlLiAoVHZydGtvKQo+Cj4gU2lnbmVkLW9mZi1ieTogU2FnYXIgQXJ1biBLYW1ibGUgPHNhZ2Fy LmEua2FtYmxlQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBa2FzaCBHb2VsIDxha2FzaC5n b2VsQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdm cy5jICAgICAgICB8IDQ0ICsrKysrKysrKysrKysrKysrKysrLQo+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwgNjIgKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaCAgICAgICAgICAgfCAg MSArCj4gICAzIGZpbGVzIGNoYW5nZWQsIDEwNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IGluZGV4IGFhYTUxYmMuLmJmYzIy YmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IEBAIC0yNjI2LDYgKzI2 MjYsNDcgQEAgc3RhdGljIGludCBpOTE1X2d1Y19sb2dfZHVtcChzdHJ1Y3Qgc2VxX2ZpbGUgKm0s IHZvaWQgKmRhdGEpCj4gICAJcmV0dXJuIDA7Cj4gICB9Cj4KPiArc3RhdGljIGludCBpOTE1X2d1 Y19sb2dfY29udHJvbF9nZXQodm9pZCAqZGF0YSwgdTY0ICp2YWwpCj4gK3sKPiArCXN0cnVjdCBk cm1fZGV2aWNlICpkZXYgPSBkYXRhOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gdG9faTkxNShkZXYpOwo+ICsKPiArCWlmICghZGV2X3ByaXYtPmd1Yy5sb2cudm1hKQo+ ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCSp2YWwgPSBpOTE1Lmd1Y19sb2dfbGV2ZWw7Cj4g Kwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgaTkxNV9ndWNfbG9nX2NvbnRy b2xfc2V0KHZvaWQgKmRhdGEsIHU2NCB2YWwpCj4gK3sKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpk ZXYgPSBkYXRhOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShkZXYpOwo+ICsJaW50IHJldDsKPiArCj4gKwlyZXQgPSBtdXRleF9sb2NrX2ludGVycnVwdGli bGUoJmRldi0+c3RydWN0X211dGV4KTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiAr Cj4gKwlpZiAoIWRldl9wcml2LT5ndWMubG9nLnZtYSkgewo+ICsJCXJldCA9IC1FSU5WQUw7Cj4g KwkJZ290byBlbmQ7Cj4gKwl9Cj4gKwo+ICsJaW50ZWxfcnVudGltZV9wbV9nZXQoZGV2X3ByaXYp Owo+ICsJcmV0ID0gaTkxNV9ndWNfbG9nX2NvbnRyb2woZGV2X3ByaXYsIHZhbCk7Cj4gKwlpbnRl bF9ydW50aW1lX3BtX3B1dChkZXZfcHJpdik7Cj4gKwo+ICtlbmQ6Cj4gKwltdXRleF91bmxvY2so JmRldi0+c3RydWN0X211dGV4KTsKPiArCXJldHVybiByZXQ7Cj4gK30KPiArCj4gK0RFRklORV9T SU1QTEVfQVRUUklCVVRFKGk5MTVfZ3VjX2xvZ19jb250cm9sX2ZvcHMsCj4gKwkJCWk5MTVfZ3Vj X2xvZ19jb250cm9sX2dldCwgaTkxNV9ndWNfbG9nX2NvbnRyb2xfc2V0LAo+ICsJCQkiJWxsZFxu Iik7Cj4gKwo+ICAgc3RhdGljIGludCBpOTE1X2VkcF9wc3Jfc3RhdHVzKHN0cnVjdCBzZXFfZmls ZSAqbSwgdm9pZCAqZGF0YSkKPiAgIHsKPiAgIAlzdHJ1Y3QgZHJtX2luZm9fbm9kZSAqbm9kZSA9 IG0tPnByaXZhdGU7Cj4gQEAgLTU0MzYsNyArNTQ3Nyw4IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg aTkxNV9kZWJ1Z2ZzX2ZpbGVzIHsKPiAgIAl7Imk5MTVfZmJjX2ZhbHNlX2NvbG9yIiwgJmk5MTVf ZmJjX2ZjX2ZvcHN9LAo+ICAgCXsiaTkxNV9kcF90ZXN0X2RhdGEiLCAmaTkxNV9kaXNwbGF5cG9y dF90ZXN0X2RhdGFfZm9wc30sCj4gICAJeyJpOTE1X2RwX3Rlc3RfdHlwZSIsICZpOTE1X2Rpc3Bs YXlwb3J0X3Rlc3RfdHlwZV9mb3BzfSwKPiAtCXsiaTkxNV9kcF90ZXN0X2FjdGl2ZSIsICZpOTE1 X2Rpc3BsYXlwb3J0X3Rlc3RfYWN0aXZlX2ZvcHN9Cj4gKwl7Imk5MTVfZHBfdGVzdF9hY3RpdmUi LCAmaTkxNV9kaXNwbGF5cG9ydF90ZXN0X2FjdGl2ZV9mb3BzfSwKPiArCXsiaTkxNV9ndWNfbG9n X2NvbnRyb2wiLCAmaTkxNV9ndWNfbG9nX2NvbnRyb2xfZm9wc30KPiAgIH07Cj4KPiAgIHZvaWQg aW50ZWxfZGlzcGxheV9jcmNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiBpbmRleCA4NWRmMmYzLi5iZTZj NzI3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Np b24uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+ IEBAIC0xOTUsNiArMTk1LDE2IEBAIHN0YXRpYyBpbnQgaG9zdDJndWNfZm9yY2VfbG9nYnVmZmVy X2ZsdXNoKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIAlyZXR1cm4gaG9zdDJndWNfYWN0aW9u KGd1YywgZGF0YSwgMik7Cj4gICB9Cj4KPiArc3RhdGljIGludCBob3N0Mmd1Y19sb2dnaW5nX2Nv bnRyb2woc3RydWN0IGludGVsX2d1YyAqZ3VjLCB1MzIgY29udHJvbF92YWwpCj4gK3sKPiArCXUz MiBkYXRhWzJdOwo+ICsKPiArCWRhdGFbMF0gPSBIT1NUMkdVQ19BQ1RJT05fVUtfTE9HX0VOQUJM RV9MT0dHSU5HOwo+ICsJZGF0YVsxXSA9IGNvbnRyb2xfdmFsOwo+ICsKPiArCXJldHVybiBob3N0 Mmd1Y19hY3Rpb24oZ3VjLCBkYXRhLCAyKTsKPiArfQo+ICsKPiAgIC8qCj4gICAgKiBJbml0aWFs aXNlLCB1cGRhdGUsIG9yIGNsZWFyIGRvb3JiZWxsIGRhdGEgc2hhcmVkIHdpdGggdGhlIEd1Qwo+ ICAgICoKPiBAQCAtMTU4NSwzICsxNTk1LDU1IEBAIHZvaWQgaTkxNV9ndWNfcmVnaXN0ZXIoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgCWd1Y19sb2dfbGF0ZV9zZXR1cCgm ZGV2X3ByaXYtPmd1Yyk7Cj4gICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+ZHJtLnN0cnVjdF9t dXRleCk7Cj4gICB9Cj4gKwo+ICtpbnQgaTkxNV9ndWNfbG9nX2NvbnRyb2woc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LCB1NjQgY29udHJvbF92YWwpCj4gK3sKPiArCXVuaW9uIGd1 Y19sb2dfY29udHJvbCBsb2dfcGFyYW07Cj4gKwlpbnQgcmV0Owo+ICsKPiArCWxvZ19wYXJhbS52 YWx1ZSA9IGNvbnRyb2xfdmFsOwo+ICsKPiArCWlmIChsb2dfcGFyYW0udmVyYm9zaXR5IDwgR1VD X0xPR19WRVJCT1NJVFlfTUlOIHx8Cj4gKwkgICAgbG9nX3BhcmFtLnZlcmJvc2l0eSA+IEdVQ19M T0dfVkVSQk9TSVRZX01BWCkKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4gKwkvKiBUaGlzIGNv bWJpbmF0aW9uIGRvZXNuJ3QgbWFrZSBzZW5zZSAmIHdvbid0IGhhdmUgYW55IGVmZmVjdCAqLwo+ ICsJaWYgKCFsb2dfcGFyYW0ubG9nZ2luZ19lbmFibGVkICYmIChpOTE1Lmd1Y19sb2dfbGV2ZWwg PCAwKSkKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlyZXQgPSBob3N0Mmd1Y19sb2dnaW5nX2NvbnRy b2woJmRldl9wcml2LT5ndWMsIGxvZ19wYXJhbS52YWx1ZSk7Cj4gKwlpZiAocmV0IDwgMCkgewo+ ICsJCURSTV9ERUJVR19EUklWRVIoImhvc3QyZ3VjIGFjdGlvbiBmYWlsZWQgJWRcbiIsIHJldCk7 Cj4gKwkJcmV0dXJuIHJldDsKPiArCX0KPiArCj4gKwlpOTE1Lmd1Y19sb2dfbGV2ZWwgPSBsb2df cGFyYW0udmVyYm9zaXR5Owo+ICsKPiArCS8qIElmIGxvZ19sZXZlbCB3YXMgc2V0IGFzIC0xIGF0 IGJvb3QgdGltZSwgdGhlbiB0aGUgcmVsYXkgY2hhbm5lbCBmaWxlCj4gKwkgKiB3b3VsZG4ndCBo YXZlIGJlZW4gY3JlYXRlZCBieSBub3cgYW5kIGludGVycnVwdHMgYWxzbyB3b3VsZCBub3QgaGF2 ZQo+ICsJICogYmVlbiBlbmFibGVkLgo+ICsJICovCj4gKwlpZiAoIWRldl9wcml2LT5ndWMubG9n LnJlbGF5X2NoYW4pIHsKPiArCQlyZXQgPSBndWNfbG9nX2xhdGVfc2V0dXAoJmRldl9wcml2LT5n dWMpOwo+ICsJCWlmICghcmV0KQo+ICsJCQlnZW45X2VuYWJsZV9ndWNfaW50ZXJydXB0cyhkZXZf cHJpdik7Cj4gKwl9IGVsc2UgaWYgKCFsb2dfcGFyYW0ubG9nZ2luZ19lbmFibGVkKSB7Cj4gKwkJ LyogT25jZSBsb2dnaW5nIGlzIGRpc2FibGVkLCBHdUMgd29uJ3QgZ2VuZXJhdGUgbG9ncyAmIHNl bmQgYW4KPiArCQkgKiBpbnRlcnJ1cHQuIEJ1dCB0aGVyZSBjb3VsZCBiZSBzb21lIGRhdGEgaW4g dGhlIGxvZyBidWZmZXIKPiArCQkgKiB3aGljaCBpcyB5ZXQgdG8gYmUgY2FwdHVyZWQuIFNvIHJl cXVlc3QgR3VDIHRvIHVwZGF0ZSB0aGUgbG9nCj4gKwkJICogYnVmZmVyIHN0YXRlIGFuZCB0aGVu IGNvbGxlY3QgdGhlIGxlZnQgb3ZlciBsb2dzLgo+ICsJCSAqLwo+ICsJCWk5MTVfZ3VjX2ZsdXNo X2xvZ3MoZGV2X3ByaXYsIHRydWUpOwo+ICsKPiArCQkvKiBHdUMgd291bGQgaGF2ZSB1cGRhdGVk IGxvZyBidWZmZXIgYnkgbm93LCBzbyBjYXB0dXJlIGl0ICovCj4gKwkJaTkxNV9ndWNfY2FwdHVy ZV9sb2dzKGRldl9wcml2KTsKPiArCj4gKwkJLyogQXMgbG9nZ2luZyBpcyBkaXNhYmxlZCwgdXBk YXRlIGxvZyBsZXZlbCB0byByZWZsZWN0IHRoYXQgKi8KPiArCQlpOTE1Lmd1Y19sb2dfbGV2ZWwg PSAtMTsKPiArCX0gZWxzZSB7Cj4gKwkJLyogSW4gY2FzZSBpbnRlcnJ1cHRzIHdlcmUgZGlzYWJs ZWQsIGVuYWJsZSB0aGVtIG5vdyAqLwo+ICsJCWdlbjlfZW5hYmxlX2d1Y19pbnRlcnJ1cHRzKGRl dl9wcml2KTsKPiArCX0KPiArCj4gKwlyZXR1cm4gcmV0Owo+ICt9Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjLmgKPiBpbmRleCBkN2VkYTQyLi5iNTZmZTI0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjLmgKPiBAQCAtMTg1LDUgKzE4NSw2IEBAIHZvaWQgaTkxNV9ndWNfY2FwdHVyZV9sb2dz KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gICB2b2lkIGk5MTVfZ3VjX2Zs dXNoX2xvZ3Moc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBib29sIGNhbl93YWl0 KTsKPiAgIHZvaWQgaTkxNV9ndWNfcmVnaXN0ZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KTsKPiAgIHZvaWQgaTkxNV9ndWNfdW5yZWdpc3RlcihzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpOwo+ICtpbnQgaTkxNV9ndWNfbG9nX2NvbnRyb2woc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LCB1NjQgY29udHJvbF92YWwpOwo+Cj4gICAjZW5kaWYKPgoK UmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpS ZWdhcmRzLAoKVHZydGtvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==